モテるコードの書き方

Growfit TechLT会の発表資料です。
https://growfit01.connpass.com/event/251492/

Transcript

1. ϞςΔίʔυͷॻ͖ํ 2022/7/30 Grow fi t TechLTձ Ώ͏͖ΌΜ
2. ࣗݾ঺հ • גࣜձࣾROLO • ΤϯδχΞྺ͸13೥ • ૊ΈࠐΈܥ͔Βឯ༨ۂં͋ͬͯWebܥʹస޲ • PHP/Laravel͕޷͖ • झຯ͸HADO
3. ϞςΔίʔυ͔ɺ ϞςΔίʔυҎ֎͔ɻ ੈͷதʹ͸2छྨͷίʔυ͕͋Δ
4. ඇϞςίʔυΛॻ͘ͱ あの⼈のコードちょっと臭う... さわりたくない... ⼀緒に仕事したくない>< 控えめに⾔ってうんコード
5. ඇϞςίʔυͱϞςίʔυ 4બ
6. ඇϞςίʔυᶃ
7. class Hoge { public function foo($arg): string { if ($arg === 'bar') { return 'bar'; } return 'piyo'; } } ඇϞςίʔυ💩
8. ݟͨ໨͕Ԛ͍🙅 • ΠϯσϯτͷཚΕ͸৺ͷཚΕ • Πϯσϯτ่͕Ε͍ͯΔͱݏΘΕΔ
9. class Hoge { public function foo($arg): string { if ($arg === 'bar') { return 'bar'; } return 'piyo'; } } Ϟςίʔυ🏄
10. 1ߦ1ߦ͍ͯͶ͍ʹॻ͘🙆 • ΠϯσϯτɺۭߦɺεϖʔεΛஸೡʹ • ͢΂ͯͷߦͱจࣈʹ੹೚Λ࣋ͭ
11. ඇϞςίʔυᶄ
12. public function isActiveUser(User $user): bool { if ($user !== null) { if ($user->email_verified_at !== null) { if ($user->last_logined_at > new DateTime('-1 year')) { return true; } else { return false; } } else { return false; } } else { return false; } } ඇϞςίʔυ💩
13. ৚͕݅ଟ͍உ͸Ϟςͳ͍🙅 • elseจ͕ͨ͘͞Μ͋ΔͱಡΈʹ͘͘ͳΔ • ͜Ε΋ݟͨ໨͸ྑ͘ͳ͍
14. public function isActiveUser(User $user): bool { if ($user !== null) { return false; } if ($user->email_verified_at === null) { return false; } if ($user->last_logined_at <= new DateTime('-1 year')) { return false; } return true; } Ϟςίʔυ🏄
15. ૣظϦλʔϯΛ࢖͏🙆 • Ψʔυઅͱ΋ݴ͏ • ifจ͸elseΛͳ͘͢ͱಡΈ΍͘͢ͳΔ • ωετΛݮΒͯ͠ɺ೴಺ϝϞϦΛઅ໿
16. ඇϞςίʔυᶅ
17. try { $hogeService->handle(); } catch (Exception $e) { } ඇϞςίʔυ💩
18. ΤϥʔΛӅ͢உ͸Ϟςͳ͍ • ΤϥʔΛແࢹͨ͠ΓӅṭͯ͠͸͍͚ͳ͍ • ίʔυ͕௥͍ʹ͘͘ͳΔ
19. try { $hogeService->handle(); } catch (Exception $e) { $this->logger->error($e->getMesage()); } Ϟςίʔυ🏄
20. ྫ֎͸ѲΓͭͿ͞ͳ͍🙆 • ྫ֎͕ى͖ͨΒॲཧΛதࢭ͢Δͷ͕جຊ • ॲཧΛࢭΊͨ͘ͳ͍৔߹͸ඞͣϩάΛ࢒͢ • ϩά͔Β௥͍΍͘͢͢Δ
21. ඇϞςίʔυᶆ
22. final class HogeService { public function execute() { $slackNotification = new SlackNotification(); if ($isProduction) { $slackNotification->send('Success!'); } } } ඇϞςίʔυ💩
23. ਓʹΑͬͯଶ౓Λม͑Δͷ͸ Ϟςͳ͍🙅 • ਓ(؀ڥ)ʹΑͬͯଶ౓Λม͑Δͷ͸Ϟςͳ͍
24. interface SlackNotificationInterface { public function send(string $message): void; } final class SlackNotification implemetns SlackNotificationInterface { public function send(string $message): void { // Slack通知の実装を書く } } final class MockSlackNotification implemetns SlackNotificationInterface { public function send(string $message): void { // 何もしない } } final class HogeService { public function __construct(private SlackNotificationInterface $slackNotification) { } public function execute() { $this->slackNotification->send('Success!'); } } Ϟςίʔυ🏄
25. NullΦϒδΣΫτύλʔϯ Λ࢖͏🙆 • Slack௨஌༻ͷΠϯλʔϑΣʔεΛ༻ҙ͢Δ • ςετ࣌͸Կ΋͠ͳ͍Mockʹࠩ͠ସ͑Δ
26. ·ͱΊ
27. ·ͱΊ • Πϯσϯτ͸େࣄ • ૣظϦλʔϯΛ࢖ͬͯifจΛγϯϓϧʹ • ྫ֎ΛѲΓͭͿ͞ͳ͍ • nullΦϒδΣΫτύλʔϯΛ࢖͏
28. େ੾ͳ͜ͱ
29. ͜ͷLTΛฉ͍ͯ΋ ࣮ࡍʹϞςΔͱ͸ݶΓ·ͤ Μɻ
30. ͍͞͝ʹ
31. એ఻Ͱ͢
32. એ఻1 ฐࣾ(ROLO)Ͱ͸PHP/Laravelͷ Ҋ݅Λେืूͯ͠·͢🙏
33. એ఻2 • https://github.com/ucan-lab/laravel-dacapo • LaravelͷϚΠάϨʔγϣϯੜ੒αϙʔτ • γϯϓϧͳYAMLදهͰ؅ཧͰ͖Δ • https://github.com/ucan-lab/docker-laravel • LaravelͷDocker؀ڥςϯϓϨʔτ
34. ͓͠·͍👏