Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review with GitHub
Search
Uyi Ehondor
June 18, 2013
Programming
0
150
Code Review with GitHub
Uyi Ehondor
June 18, 2013
Tweet
Share
Other Decks in Programming
See All in Programming
Ktorで簡単AIアプリケーション
tsukakei
0
100
GC25 Recap: The Code You Reviewed is Not the Code You Built / #newt_gophercon_tour
mazrean
0
110
Pythonに漸進的に型をつける
nealle
1
120
AI駆動で0→1をやって見えた光と伸びしろ
passion0102
1
810
NixOS + Kubernetesで構築する自宅サーバーのすべて
ichi_h3
0
1.2k
なぜGoのジェネリクスはこの形なのか? - Featherweight Goが明かす設計の核心
qualiarts
0
240
開発組織の戦略的な役割と 設計スキル向上の効果
masuda220
PRO
8
1.5k
Leading Effective Engineering Teams in the AI Era
addyosmani
7
590
Flutterで分数(Fraction)を表示する方法
koukimiura
0
140
フロントエンド開発のためのブラウザ組み込みAI入門
masashi
7
3.4k
Domain-centric? Why Hexagonal, Onion, and Clean Architecture Are Answers to the Wrong Question
olivergierke
3
960
React Nativeならぬ"Vue Native"が実現するかも?_新世代マルチプラットフォーム開発フレームワークのLynxとLynxのVue.js対応を追ってみよう_Vue Lynx
yut0naga1_fa
2
510
Featured
See All Featured
Automating Front-end Workflow
addyosmani
1371
200k
Statistics for Hackers
jakevdp
799
220k
Embracing the Ebb and Flow
colly
88
4.9k
The Art of Programming - Codeland 2020
erikaheidi
56
14k
Making Projects Easy
brettharned
120
6.4k
Speed Design
sergeychernyshev
32
1.2k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
16
1.7k
The Illustrated Children's Guide to Kubernetes
chrisshort
49
51k
Building Flexible Design Systems
yeseniaperezcruz
329
39k
How To Stay Up To Date on Web Technology
chriscoyier
791
250k
How STYLIGHT went responsive
nonsquared
100
5.8k
ピンチをチャンスに:未来をつくるプロダクトロードマップ #pmconf2020
aki_iinuma
127
54k
Transcript
Sources: https://help.github.com/articles/using-pull-requests https://speakerdeck.com/takai/code-review-in-action Code Review with GitHub
source: http://octodex.github.com/gangnamtocat/
Collaborative Dev. Models • Fork & Pull • Shared Repository
Fork & Pull Model • Popular choice with open source
projects. • Encourages independence almost immediately without upfront coordination.
Shared Repository Model • Prevalent with small teams and organisations
collaborating on private projects.
Pull Requests • Pull requests let you tell others about
changes. • Interested parties will be notified. • Parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary.
How To: Pull Requests See "More Reading"
Why Code Review • Improved code quality • Fewer defects
in code • Improved communication about code content • ...
Good Code Review • What does not meet set standards?
• Why it does not meet standards? • How to improve • ...
More Reading https://help.github.com/articles/using-pull-requests
Clean code depends on... YOU
Q & A