Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review with GitHub
Search
Uyi Ehondor
June 18, 2013
Programming
0
150
Code Review with GitHub
Uyi Ehondor
June 18, 2013
Tweet
Share
Other Decks in Programming
See All in Programming
CSC509 Lecture 02
javiergs
PRO
0
150
Kotlin Multiplatform at Stable and Beyond (Kotlin Vienna, October 2024)
zsmb
2
320
Vue :: Better Testing 2024
up1
1
360
CDKを活用した 大規模コンテナ移行 プロジェクトの紹介
yoyoyopg
0
230
sqlcを利用してsqlに型付けを
kamiyam
0
220
個人開発のおいしさと続け方
3l4l5
1
260
"Swarming" をコンセプトに掲げるアジャイルチームのベストプラクティス
boykush
1
150
ファーストペンギンBot @Qiita Hackathon 2024 予選
dyson_web
0
210
RDBの世界をぬりかえていくモデルグラフDB〜truncus graphによるモデルファースト開発〜
jurabi
0
150
ポケモンで考えるコミュニケーション / Communication Lessons from Pokémon
mackey0225
3
130
CSC509 Lecture 03
javiergs
PRO
0
130
タイミーにおけるデータの利用シーンと データ基盤の挑戦
marufeuille
4
3.1k
Featured
See All Featured
The MySQL Ecosystem @ GitHub 2015
samlambert
250
12k
The Mythical Team-Month
searls
218
43k
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
panda_program
91
16k
Infographics Made Easy
chrislema
239
18k
Testing 201, or: Great Expectations
jmmastey
38
7k
Optimizing for Happiness
mojombo
375
69k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
23
1.7k
Distributed Sagas: A Protocol for Coordinating Microservices
caitiem20
327
21k
Faster Mobile Websites
deanohume
304
30k
Agile that works and the tools we love
rasmusluckow
327
21k
How to Think Like a Performance Engineer
csswizardry
16
1k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
4
94
Transcript
Sources: https://help.github.com/articles/using-pull-requests https://speakerdeck.com/takai/code-review-in-action Code Review with GitHub
source: http://octodex.github.com/gangnamtocat/
Collaborative Dev. Models • Fork & Pull • Shared Repository
Fork & Pull Model • Popular choice with open source
projects. • Encourages independence almost immediately without upfront coordination.
Shared Repository Model • Prevalent with small teams and organisations
collaborating on private projects.
Pull Requests • Pull requests let you tell others about
changes. • Interested parties will be notified. • Parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary.
How To: Pull Requests See "More Reading"
Why Code Review • Improved code quality • Fewer defects
in code • Improved communication about code content • ...
Good Code Review • What does not meet set standards?
• Why it does not meet standards? • How to improve • ...
More Reading https://help.github.com/articles/using-pull-requests
Clean code depends on... YOU
Q & A