Upgrade to Pro — share decks privately, control downloads, hide ads and more …
Sign up for free

Code Review with GitHub

Avatar for Uyi Ehondor Uyi Ehondor
June 18, 2013
Programming
160
0

Code Review with GitHub

Avatar for Uyi Ehondor

Uyi Ehondor

June 18, 2013

Other Decks in Programming

See All in Programming
作れる、でも消せるか？──安全に「枯らして消す」機能削除術 / Drain, Then Delete
Avatar for chobishiba chobishiba
2
640
コードレビューのボトルネックを"する側"と"される側"の両面から解消する
Avatar for yub0n yub0n
2
1.6k
現場と育てるRailsモデリング 〜Spreadsheetから始めたモデル設計〜
Avatar for siroemk siroemk
2
590
Rでドレミ/Do-Re-Mi_with_R
Avatar for florets1 florets1
0
130
TechTown - Creating Composable Callables in Contemporary C++
Avatar for Björn Fahller rollbear
0
130
R8 の設定見直しでアプリサイズ削減
Avatar for ANDPAD inc andpad
0
220
Unity6 URPによる海底をテーマにしたVJシステムの解説 | Unity Shader 完全に理解した 勉強会
Avatar for がむ gam0022
0
370
C#の現在地 進化の歴史と、AI時代の.NET Everywhere
Avatar for Yoshifumi Kawai neuecc
5
5.2k
The Rails Doctrine Decade
Avatar for Koichi ITO koic
2
590
Railsのためのパスキー実践入門 〜マルチテナントSaaSでの意思決定〜
Avatar for utakaha utakaha
2
550
JAWS-UG 東京支部が始める、JAWS-UG支部コラボ / JAWS-UG lunchtime LT Collaboration
Avatar for y-ohgi y0hgi
0
270
iOS 27でニュースアプリはどう変わる！？ 〜日経電子版の新機能対応と、開発事例から〜
Avatar for Kazuki Nakashima lynnswap
7
13k

Featured

See All Featured
We Are The Robots
Avatar for Honza Javorek honzajavorek
0
400
VelocityConf: Rendering Performance Case Studies
Avatar for Addy Osmani addyosmani
331
25k
End of SEO as We Know It (SMX Advanced Version)
Avatar for Michael King ipullrank
3
4.4k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
Avatar for mongodb mongodb
50
10k
Put a Button on it: Removing Barriers to Going Fast.
Avatar for kastner kastner
60
4.6k
GraphQLとの向き合い方2022年版
Avatar for Yosuke Kurami quramy
50
15k
AI in Enterprises - Java and Open Source to the Rescue
Avatar for ivargrimstad ivargrimstad
0
1.5k
世界の人気アプリ100個を分析して見えたペイウォール設計の心得
Avatar for Akihiro Kokubo akihiro_kokubo
PRO
74
43k
Collaborative Software Design: How to facilitate domain modelling decisions
Avatar for Kenny Baas-Schwegler baasie
1
340
Odyssey Design
Avatar for Ryan Kendrick rkendrick25
PRO
2
870
A designer walks into a library…
Avatar for Paul Jervis Heath pauljervisheath
211
25k
Test your architecture with Archunit
Avatar for Yoan thirion
2
2.4k

Transcript

  1. Sources: https://help.github.com/articles/using-pull-requests https://speakerdeck.com/takai/code-review-in-action Code Review with GitHub

  2. source: http://octodex.github.com/gangnamtocat/

  3. Collaborative Dev. Models • Fork & Pull • Shared Repository

  4. Fork & Pull Model • Popular choice with open source

    projects. • Encourages independence almost immediately without upfront coordination.

  5. Shared Repository Model • Prevalent with small teams and organisations

    collaborating on private projects.

  6. Pull Requests • Pull requests let you tell others about

    changes. • Interested parties will be notified. • Parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary.

  7. How To: Pull Requests See "More Reading"

  8. Why Code Review • Improved code quality • Fewer defects

    in code • Improved communication about code content • ...

  9. Good Code Review • What does not meet set standards?

    • Why it does not meet standards? • How to improve • ...

  10. More Reading https://help.github.com/articles/using-pull-requests

  11. Clean code depends on... YOU

  12. Q & A