Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review with GitHub
Search
Uyi Ehondor
June 18, 2013
Programming
0
150
Code Review with GitHub
Uyi Ehondor
June 18, 2013
Tweet
Share
Other Decks in Programming
See All in Programming
速いWebフレームワークを作る
yusukebe
5
1.7k
rage against annotate_predecessor
junk0612
0
170
アルテニア コンサル/ITエンジニア向け 採用ピッチ資料
altenir
0
110
Amazon RDS 向けに提供されている MCP Server と仕組みを調べてみた/jawsug-okayama-2025-aurora-mcp
takahashiikki
1
110
Compose Multiplatform × AI で作る、次世代アプリ開発支援ツールの設計と実装
thagikura
0
170
旅行プランAIエージェント開発の裏側
ippo012
2
920
MCPでVibe Working。そして、結局はContext Eng(略)/ Working with Vibe on MCP And Context Eng
rkaga
5
2.3k
個人軟體時代
ethanhuang13
0
330
2025 年のコーディングエージェントの現在地とエンジニアの仕事の変化について
azukiazusa1
24
12k
@Environment(\.keyPath)那么好我不允许你们不知道! / atEnvironment keyPath is so good and you should know it!
lovee
0
120
The Past, Present, and Future of Enterprise Java with ASF in the Middle
ivargrimstad
0
160
複雑なドメインに挑む.pdf
yukisakai1225
5
1.2k
Featured
See All Featured
Speed Design
sergeychernyshev
32
1.1k
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
12
1.1k
Put a Button on it: Removing Barriers to Going Fast.
kastner
60
4k
Balancing Empowerment & Direction
lara
3
620
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
26
3k
Building an army of robots
kneath
306
46k
Save Time (by Creating Custom Rails Generators)
garrettdimon
PRO
32
1.6k
The MySQL Ecosystem @ GitHub 2015
samlambert
251
13k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
35
3.1k
Side Projects
sachag
455
43k
How to Create Impact in a Changing Tech Landscape [PerfNow 2023]
tammyeverts
53
2.9k
Understanding Cognitive Biases in Performance Measurement
bluesmoon
29
1.9k
Transcript
Sources: https://help.github.com/articles/using-pull-requests https://speakerdeck.com/takai/code-review-in-action Code Review with GitHub
source: http://octodex.github.com/gangnamtocat/
Collaborative Dev. Models • Fork & Pull • Shared Repository
Fork & Pull Model • Popular choice with open source
projects. • Encourages independence almost immediately without upfront coordination.
Shared Repository Model • Prevalent with small teams and organisations
collaborating on private projects.
Pull Requests • Pull requests let you tell others about
changes. • Interested parties will be notified. • Parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary.
How To: Pull Requests See "More Reading"
Why Code Review • Improved code quality • Fewer defects
in code • Improved communication about code content • ...
Good Code Review • What does not meet set standards?
• Why it does not meet standards? • How to improve • ...
More Reading https://help.github.com/articles/using-pull-requests
Clean code depends on... YOU
Q & A