Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review with GitHub
Search
Uyi Ehondor
June 18, 2013
Programming
0
150
Code Review with GitHub
Uyi Ehondor
June 18, 2013
Tweet
Share
Other Decks in Programming
See All in Programming
GitHub Copilot and GitHub Codespaces Hands-on
ymd65536
2
150
なぜ「共通化」を考え、失敗を繰り返すのか
rinchoku
1
650
XP, Testing and ninja testing
m_seki
3
240
Hypervel - A Coroutine Framework for Laravel Artisans
albertcht
1
120
ニーリーにおけるプロダクトエンジニア
nealle
0
830
今ならAmazon ECSのサービス間通信をどう選ぶか / Selection of ECS Interservice Communication 2025
tkikuc
21
4k
Discover Metal 4
rei315
2
130
PHP 8.4の新機能「プロパティフック」から学ぶオブジェクト指向設計とリスコフの置換原則
kentaroutakeda
2
890
WebViewの現在地 - SwiftUI時代のWebKit - / The Current State Of WebView
marcy731
0
120
Rails Frontend Evolution: It Was a Setup All Along
skryukov
0
140
Code as Context 〜 1にコードで 2にリンタ 34がなくて 5にルール? 〜
yodakeisuke
0
130
猫と暮らす Google Nest Cam生活🐈 / WebRTC with Google Nest Cam
yutailang0119
0
120
Featured
See All Featured
Cheating the UX When There Is Nothing More to Optimize - PixelPioneers
stephaniewalter
281
13k
The Illustrated Children's Guide to Kubernetes
chrisshort
48
50k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
34
3.1k
Documentation Writing (for coders)
carmenintech
72
4.9k
Optimizing for Happiness
mojombo
379
70k
Responsive Adventures: Dirty Tricks From The Dark Corners of Front-End
smashingmag
251
21k
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
161
15k
Building a Scalable Design System with Sketch
lauravandoore
462
33k
Typedesign – Prime Four
hannesfritz
42
2.7k
Java REST API Framework Comparison - PWX 2021
mraible
31
8.7k
Mobile First: as difficult as doing things right
swwweet
223
9.7k
The Web Performance Landscape in 2024 [PerfNow 2024]
tammyeverts
8
690
Transcript
Sources: https://help.github.com/articles/using-pull-requests https://speakerdeck.com/takai/code-review-in-action Code Review with GitHub
source: http://octodex.github.com/gangnamtocat/
Collaborative Dev. Models • Fork & Pull • Shared Repository
Fork & Pull Model • Popular choice with open source
projects. • Encourages independence almost immediately without upfront coordination.
Shared Repository Model • Prevalent with small teams and organisations
collaborating on private projects.
Pull Requests • Pull requests let you tell others about
changes. • Interested parties will be notified. • Parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary.
How To: Pull Requests See "More Reading"
Why Code Review • Improved code quality • Fewer defects
in code • Improved communication about code content • ...
Good Code Review • What does not meet set standards?
• Why it does not meet standards? • How to improve • ...
More Reading https://help.github.com/articles/using-pull-requests
Clean code depends on... YOU
Q & A