Upgrade to Pro — share decks privately, control downloads, hide ads and more …
Sign up for free

Code Review with GitHub

Avatar for Uyi Ehondor Uyi Ehondor
June 18, 2013
Programming
160
0

Code Review with GitHub

Avatar for Uyi Ehondor

Uyi Ehondor

June 18, 2013

Other Decks in Programming

See All in Programming
Snowflakeで業務アプリを作ろう。 Snowflakeのアプリ機能解説&実践ガイド
Avatar for Ayumu Yamaguchi ayumu_yamaguchi
1
280
The Rails Doctrine Decade
Avatar for Koichi ITO koic
2
170
スマート反転とウェブアクセシビリティ
Avatar for KAMIHARA Takumi camiha
0
210
AIは賢い。でも実行環境は？ CLIおじさんがAI時代に伝えたいこと ~ CLIおじさんがAI時代に伝えたいこと ~
Avatar for curekoshimizu curekoshimizu
1
250
The Good Stuff, Not the Slop: Engineering High-Quality Android Apps with Modern AI Tooling
Avatar for danybony danybony
1
260
XHTMLが残したもの
Avatar for Yosuke Furukawa yosuke_furukawa
PRO
2
830
『寄り添うラジオ』をAIで作る 体験価値から逆算した、会話しないUXと品質設計
Avatar for テオリア・テクノロジーズ theoriatec2024
3
180
Everything will be SERVERLESS — 信じて運用した10年の経験値 / Everything Will be Serverless — Lessons Learned from 10 Years of Operational Experience
Avatar for shiro seike seike460
PRO
1
340
WebMCP Challenge に星空観察アプリで参加した話
Avatar for dario okazaki okajun35
0
180
AGENTS.md Is Not Enough: Build Skills, Don't Download Them
Avatar for Alex T lx_t
0
120
AHC070解法紹介
Avatar for eijirou eijirou
0
130
FreeBSDでZabbixを動かす
Avatar for kenkino kenkino
0
310

Featured

See All Featured
Done Done
Avatar for chrislema chrislema
186
16k
Design of three-dimensional binary manipulators for pick-and-place task avoiding obstacles (IECON2024)
Avatar for konakalab konakalab
0
600
RailsConf 2023
Avatar for Aaron Patterson tenderlove
30
1.6k
State of Search Keynote: SEO is Dead Long Live SEO
Avatar for Ryan Jones ryanjones
0
280
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
Avatar for soudai sone soudai
PRO
203
76k
The MySQL Ecosystem @ GitHub 2015
Avatar for Sam Lambert samlambert
251
13k
Bridging the Design Gap: How Collaborative Modelling removes blockers to flow between stakeholders and teams @FastFlow conf
Avatar for Kenny Baas-Schwegler baasie
0
700
Navigating the moral maze — ethical principles for Al-driven product design
Avatar for Skipper Chong Warson skipperchong
2
550
Fight the Zombie Pattern Library - RWD Summit 2016
Avatar for Marcelo Somers marcelosomers
234
18k
Neural Spatial Audio Processing for Sound Field Analysis and Control
Avatar for NII S. Koyama's Lab skoyamalab
0
510
How to Build an AI Search Optimization Roadmap - Criteria and Steps to Take #SEOIRL
Avatar for Aleyda Solis aleyda
1
2.2k
How to build a perfect <img>
Avatar for Jono Alderson jonoalderson
1
6k

Transcript

  1. Sources: https://help.github.com/articles/using-pull-requests https://speakerdeck.com/takai/code-review-in-action Code Review with GitHub

  2. source: http://octodex.github.com/gangnamtocat/

  3. Collaborative Dev. Models • Fork & Pull • Shared Repository

  4. Fork & Pull Model • Popular choice with open source

    projects. • Encourages independence almost immediately without upfront coordination.

  5. Shared Repository Model • Prevalent with small teams and organisations

    collaborating on private projects.

  6. Pull Requests • Pull requests let you tell others about

    changes. • Interested parties will be notified. • Parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary.

  7. How To: Pull Requests See "More Reading"

  8. Why Code Review • Improved code quality • Fewer defects

    in code • Improved communication about code content • ...

  9. Good Code Review • What does not meet set standards?

    • Why it does not meet standards? • How to improve • ...

  10. More Reading https://help.github.com/articles/using-pull-requests

  11. Clean code depends on... YOU

  12. Q & A