Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review with GitHub
Search
Uyi Ehondor
June 18, 2013
Programming
0
150
Code Review with GitHub
Uyi Ehondor
June 18, 2013
Tweet
Share
Other Decks in Programming
See All in Programming
設計やレビューに悩んでいるPHPerに贈る、クリーンなオブジェクト設計の指針たち
panda_program
6
2.1k
PHPでWebSocketサーバーを実装しよう2025
kubotak
0
280
Composerが「依存解決」のためにどんな工夫をしているか #phpcon
o0h
PRO
1
250
Azure AI Foundryではじめてのマルチエージェントワークフロー
seosoft
0
170
スタートアップの急成長を支えるプラットフォームエンジニアリングと組織戦略
sutochin26
1
5.5k
Google Agent Development Kit でLINE Botを作ってみた
ymd65536
2
250
PHP 8.4の新機能「プロパティフック」から学ぶオブジェクト指向設計とリスコフの置換原則
kentaroutakeda
2
880
ISUCON研修おかわり会 講義スライド
arfes0e2b3c
1
440
High-Level Programming Languages in AI Era -Human Thought and Mind-
hayat01sh1da
PRO
0
770
ペアプロ × 生成AI 現場での実践と課題について / generative-ai-in-pair-programming
codmoninc
1
17k
Node-RED を(HTTP で)つなげる MCP サーバーを作ってみた
highu
0
120
Result型で“失敗”を型にするPHPコードの書き方
kajitack
5
650
Featured
See All Featured
Mobile First: as difficult as doing things right
swwweet
223
9.7k
RailsConf & Balkan Ruby 2019: The Past, Present, and Future of Rails at GitHub
eileencodes
138
34k
Scaling GitHub
holman
460
140k
Done Done
chrislema
184
16k
ReactJS: Keep Simple. Everything can be a component!
pedronauck
667
120k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
31
2.4k
How to Create Impact in a Changing Tech Landscape [PerfNow 2023]
tammyeverts
53
2.9k
The Psychology of Web Performance [Beyond Tellerrand 2023]
tammyeverts
48
2.9k
Why Our Code Smells
bkeepers
PRO
336
57k
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
panda_program
107
19k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
tammyeverts
6
300
The Illustrated Children's Guide to Kubernetes
chrisshort
48
50k
Transcript
Sources: https://help.github.com/articles/using-pull-requests https://speakerdeck.com/takai/code-review-in-action Code Review with GitHub
source: http://octodex.github.com/gangnamtocat/
Collaborative Dev. Models • Fork & Pull • Shared Repository
Fork & Pull Model • Popular choice with open source
projects. • Encourages independence almost immediately without upfront coordination.
Shared Repository Model • Prevalent with small teams and organisations
collaborating on private projects.
Pull Requests • Pull requests let you tell others about
changes. • Interested parties will be notified. • Parties can review the set of changes, discuss potential modifications, and even push follow-up commits if necessary.
How To: Pull Requests See "More Reading"
Why Code Review • Improved code quality • Fewer defects
in code • Improved communication about code content • ...
Good Code Review • What does not meet set standards?
• Why it does not meet standards? • How to improve • ...
More Reading https://help.github.com/articles/using-pull-requests
Clean code depends on... YOU
Q & A