Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Saddler - HCMC meetup 2015

Avatar for Vinh Nguyen Le Vinh Nguyen Le
November 25, 2015
Technology
300
0

Saddler - HCMC meetup 2015

5 minutes introduce and setup saddler for code review

Avatar for Vinh Nguyen Le

Vinh Nguyen Le

November 25, 2015

More Decks by Vinh Nguyen Le

See All by Vinh Nguyen Le
Rails girls - Part 1
Avatar for Vinh Nguyen Le vinhngl
0
77
Introduction Heroku
Avatar for Vinh Nguyen Le vinhngl
0
150

Other Decks in Technology

See All in Technology
社内の7割が使うデータ基盤を、 データチーム2人で回すためにやったこと
Avatar for KOH koh_yoshi
4
1.5k
なぜ Temporal の大小比較には compare しかないのか / Why Does Temporal Only Have compare() for Comparisons
Avatar for KazukiHayase kazukihayase
1
160
Master Dataグループ紹介資料
Avatar for Sansan, Inc. sansan33
PRO
1
4.8k
What's new in Go 1.27?
Avatar for Koya IWAMURA ciarana
0
260
Reference-Free Image Quality Assessment for Virtual Try-On via Human Feedback
Avatar for ZOZO Developers zozotech
PRO
0
640
現場回帰したデータエンジニアが考える AI 時代のキャリア開発 / Career Development in the Age of AI Perspectives from a Hands-on Data Engineer
Avatar for MEDLEY, INC. medley
0
120
会社紹介資料 / Sansan Company Profile
Avatar for Sansan, Inc. sansan33
PRO
24
430k
Service Connect 上のサービスに ECS Service の外側から到達できなかった話
Avatar for Itaru Ota ota1022
1
270
生成 AI の基礎 〜 サンプル実装で学ぶ基本原理
Avatar for Etsuji Nakai enakai00
7
4.4k
SO-101×VLAによる3色キューブのピック＆プレース
Avatar for ABEJA abeja
0
220
Eight Engineering Unit 紹介資料
Avatar for Sansan, Inc. sansan33
PRO
3
8.2k
35分でわかるEffective Platform Engineering
Avatar for nwiizo nwiizo
5
400

Featured

See All Featured
Everyday Curiosity
Avatar for Cassini Nazir cassininazir
0
290
ReactJS: Keep Simple. Everything can be a component!
Avatar for Pedro Nauck pedronauck
666
130k
Writing Fast Ruby
Avatar for Erik Berlin sferik
630
63k
Darren the Foodie - Storyboard
Avatar for Kevinho.art khoart
PRO
3
3.7k
Marketing Yourself as an Engineer | Alaka | Gurzu
Avatar for Gurzu gurzu
0
280
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
Avatar for Rebecca Miller-Webster rmw
35
3.8k
Technical Leadership for Architectural Decision Making
Avatar for Kenny Baas-Schwegler baasie
3
500
Visualization
Avatar for Eitan Lees eitanlees
152
17k
Designing Powerful Visuals for Engaging Learning
Avatar for Mike Taylor tmiket
1
500
Facilitating Awesome Meetings
Avatar for Lara Hogan lara
57
7.1k
A Modern Web Designer's Workflow
Avatar for Chris Coyier chriscoyier
698
190k
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
Avatar for panda_program panda_program
123
22k

Transcript

  1. Check Style to anywhere Introduce Saddler Presenter: vinhnglx

  2. Code Review

  3. General Practices • Naming Convention • Indentation • Brace style

    • Commenting • Code consistency

  4. Code Metrics • RuboCop • Rails best practices • Reek

    • Hound CI - 12$ / month

  5. RuboCop Rails best practice Reek Saddler Reporters GitHub Pull Requests

    CI Services

  6. • GITHUB_ACCESS_TOKEN • gem ‘saddler’ & ‘saddler-reporter-github’ • metrics gems

    (rubocop - rails_best_practices …)
 Requirements

  7. • https://transfer.sh/EgzcG/circle.yml • https://transfer.sh/Infbv/saddler.sh • https://github.com/vinhnglx/twitter-trends/pull/1 Setup & Result

  8. THANK YOU