Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Zen Code Reviews
Search
Xavier F. Gouchet
PRO
September 04, 2017
Video
Programming
0
4
Zen Code Reviews
Xavier F. Gouchet
PRO
September 04, 2017
Tweet
Share
Video
More Decks by Xavier F. Gouchet
See All by Xavier F. Gouchet
Being an ethical software engineer
xgouchet
PRO
0
260
Libérez votre créativité
xgouchet
PRO
0
110
Unleash your Programming Creativity
xgouchet
PRO
0
170
Demystifying the Test Pyramid
xgouchet
PRO
1
500
Successfully Publishing a Tested, Upgradeable and Documented Open Source Library
xgouchet
PRO
0
110
Property Based Testing in Practice
xgouchet
PRO
0
82
Develop your CI tools
xgouchet
PRO
2
400
How to write a safe and reliable Open Source Library
xgouchet
PRO
1
270
Benchmarking your app's performance
xgouchet
PRO
0
220
Other Decks in Programming
See All in Programming
PicoRuby on Rails
makicamel
2
140
Modern Angular with Signals and Signal Store:New Rules for Your Architecture @enterJS Advanced Angular Day 2025
manfredsteyer
PRO
0
230
Azure AI Foundryではじめてのマルチエージェントワークフロー
seosoft
0
190
AIプログラマーDevinは PHPerの夢を見るか?
shinyasaita
1
230
新メンバーも今日から大活躍!SREが支えるスケールし続ける組織のオンボーディング
honmarkhunt
5
8k
ご注文の差分はこちらですか? 〜 AWS CDK のいろいろな差分検出と安全なデプロイ
konokenj
3
370
Advanced Micro Frontends: Multi Version/ Framework Scenarios @WAD 2025, Berlin
manfredsteyer
PRO
0
330
High-Level Programming Languages in AI Era -Human Thought and Mind-
hayat01sh1da
PRO
0
820
A full stack side project webapp all in Kotlin (KotlinConf 2025)
dankim
0
130
Flutterで備える!Accessibility Nutrition Labels完全ガイド
yuukiw00w
0
170
git worktree × Claude Code × MCP ~生成AI時代の並列開発フロー~
hisuzuya
1
590
なぜ「共通化」を考え、失敗を繰り返すのか
rinchoku
1
660
Featured
See All Featured
The Art of Programming - Codeland 2020
erikaheidi
54
13k
The World Runs on Bad Software
bkeepers
PRO
69
11k
Distributed Sagas: A Protocol for Coordinating Microservices
caitiem20
331
22k
The Psychology of Web Performance [Beyond Tellerrand 2023]
tammyeverts
48
2.9k
XXLCSS - How to scale CSS and keep your sanity
sugarenia
248
1.3M
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
10
970
Principles of Awesome APIs and How to Build Them.
keavy
126
17k
Building Applications with DynamoDB
mza
95
6.5k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
soudai
PRO
181
54k
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
32
2.4k
Designing Dashboards & Data Visualisations in Web Apps
destraynor
231
53k
Building Flexible Design Systems
yeseniaperezcruz
328
39k
Transcript
ZEN CODE REVIEWS THE WAY TOWARDS PAINLESS CODE REVIEWS Droidcon
Berlin 2017 1
ABOUT… XAVIER F. GOUCHET ANDROID ARCHITECT AT ‘MR TOOLS’ /
CI ADMIN / UT ADVOCATE ON ALL SOCIAL NETWORKS @XGOUCHET 2.1
WHO USES CODE REVIEW HERE ? ♫ Put your hands
in the air ♪ — Placebo 3
CODE REVIEWS @ DEEZER 18 Android developers 3 main repositories
Varied experiences and skills 4
WHY ? THE PURPOSES OF CODE REVIEWS 5
FIND DEFECTS EARLY Logic fallacies Typos, spelling Edge cases Potential
technical debt 6
HARMONIZE THE CODE BASE Code style Naming conventions Architecture Libraries
7
GENERATE DISCUSSION AROUND… Choices Algorithm Data Structure Architecture Libraries Features
Best practices 8
TEAM BUILDING Cohesion Trust Lower “Linkedin factor” Asynchronous Pair Programming
9
SHARE KNOWLEDGE Onboard junior / new developers Everyone has something
to teach Everyone has something to learn 10
DOWNSIDES OF CODE REVIEW More time spent per ticket /
less time spent delivering feature Senior developer frustration 11
WHAT ? THE DIFFERENT TYPES OF CODE REVIEWS 12
“AUTOMATIC” CODE REVIEW Static Analysis Android Lints Findbugs, Checkstyle, PMD
Detekt, ktlint Tests (Unit, Integrated, Functionnal) 13
PRE-COMMIT Pro Quality ensured before merge All code must be
reviewed Cons Productivity impact Back & forth Hell ™ 14
POST-COMMIT Pro Continuous development Limit git conflicts Cons Bug can
ship to production Resolution can become non trivial afterwards 15
OPTIONAL CODE REVIEWS by commit author by commit length by
files modified random checks … ? 16
PAIR REVIEW WITH ANOTHER DEVELOPER Provide a single feedack Compare
different viewpoints Tone down negative feedbacks 17
CODE REVIEW MEETING WITH THE AUTHOR 3 to 7 attendees
Only for non trivial reviews Mentor the author Get in depth view Discuss alternatives Immediate feedback 18
HOW ? THE DOS AND DONTS OF CODE REVIEW 19
WRITING REVIEWABLE CODE Keep the commits short git add --patch
/ git add -p Comment the code Use a proper commit message CR Brief for non trivial commits Link to the ticket 20
BEFORE SUBMITTING, REVIEW YOUR OWN CODE Find easy to spot
issues Typos Commented code Duplicates / possible refactoring Copy / Paste errors Take a step back on your code 21
COMMENTING ON ISSUES “If you can't understand that, then yes,
you're crazy. Or just terminally stupid.” — Linus 22
BE PRECISE : WHAT IS THE PROBLEM ? “THIS CODE
IS BAD !” ✗ “THIS LINE COULD CAUSE A MEMORY LEAK…” ✔ 23
ARGUMENT : WHY IS IT A PROBLEM ? “OBVIOUSLY!” ✗
“… BECAUSE THE ACTIVITY REFERENCE IS RETAINED…” ✔ 24
BE HELPFUL : HOW TO FIX THE PROBLEM ? “DEAL
WITH IT!” ✗ “… YOU COULD INSTEAD USE A WEAKREFERENCE.” ✔ 25
DEFINE CRITICITY : HOW IMPORTANT IS THE ISSUE ? “…”
✗ “IT’S NOT CRITICAL, BUT MUST BE FIXED IN A LATER COMMIT BEFORE THE RELEASE CANDIDATE NEXT WEEK.” ✔ 26
EXAMPLES “The name of this variable is ambiguous. You could
rename it as …” “I don’t think this method should be in this class because it’s outside of the class’s responsibility.” “This rule has many edge cases, you should add more unit tests.” 27
VOTING DOWN Avoid blocking commits unnecessarily Always make the reasons
clear Make a full review If an issue has already been raised, don't comment just to say “+1” 28
RECEIVING CRITIQUE Take a step back Stay humble Motivate your
choices Accept the critique (even if it means more work for you) 29
OVERALL BEHAVIOR Stay open minded Make it about the code,
not the people Don't start the flame war Share your knowledge Give as much as you receive 30
GOING FURTHER ? CODEREVIEW.STACKEXCHANGE.COM 31
THANKS FOR YOUR ATTENTION ANY QUESTION ? 32