Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Zen Code Reviews
Search
Xavier F. Gouchet
PRO
September 04, 2017
Video
Programming
0
4
Zen Code Reviews
Xavier F. Gouchet
PRO
September 04, 2017
Tweet
Share
Video
More Decks by Xavier F. Gouchet
See All by Xavier F. Gouchet
Being an ethical software engineer
xgouchet
PRO
0
250
Libérez votre créativité
xgouchet
PRO
0
110
Unleash your Programming Creativity
xgouchet
PRO
0
170
Demystifying the Test Pyramid
xgouchet
PRO
1
490
Successfully Publishing a Tested, Upgradeable and Documented Open Source Library
xgouchet
PRO
0
100
Property Based Testing in Practice
xgouchet
PRO
0
81
Develop your CI tools
xgouchet
PRO
2
400
How to write a safe and reliable Open Source Library
xgouchet
PRO
1
270
Benchmarking your app's performance
xgouchet
PRO
0
220
Other Decks in Programming
See All in Programming
『自分のデータだけ見せたい!』を叶える──Laravel × Casbin で複雑権限をスッキリ解きほぐす 25 分
akitotsukahara
1
580
PHP 8.4の新機能「プロパティフック」から学ぶオブジェクト指向設計とリスコフの置換原則
kentaroutakeda
2
660
Is Xcode slowly dying out in 2025?
uetyo
1
210
Modern Angular with Signals and Signal Store:New Rules for Your Architecture @enterJS Advanced Angular Day 2025
manfredsteyer
PRO
0
140
関数型まつりレポート for JuliaTokai #22
antimon2
0
160
明示と暗黙 ー PHPとGoの インターフェイスの違いを知る
shimabox
2
380
20250628_非エンジニアがバイブコーディングしてみた
ponponmikankan
0
520
技術同人誌をMCP Serverにしてみた
74th
1
440
設計やレビューに悩んでいるPHPerに贈る、クリーンなオブジェクト設計の指針たち
panda_program
6
1.7k
コードの90%をAIが書く世界で何が待っているのか / What awaits us in a world where 90% of the code is written by AI
rkaga
48
31k
#kanrk08 / 公開版 PicoRubyとマイコンでの自作トレーニング計測装置を用いたワークアウトの理想と現実
bash0c7
1
610
datadog dash 2025 LLM observability for reliability and stability
ivry_presentationmaterials
0
190
Featured
See All Featured
The Art of Programming - Codeland 2020
erikaheidi
54
13k
GraphQLとの向き合い方2022年版
quramy
49
14k
The Power of CSS Pseudo Elements
geoffreycrofte
77
5.8k
We Have a Design System, Now What?
morganepeng
53
7.7k
KATA
mclloyd
30
14k
Intergalactic Javascript Robots from Outer Space
tanoku
271
27k
Fantastic passwords and where to find them - at NoRuKo
philnash
51
3.3k
The MySQL Ecosystem @ GitHub 2015
samlambert
251
13k
Rails Girls Zürich Keynote
gr2m
94
14k
Optimising Largest Contentful Paint
csswizardry
37
3.3k
The Invisible Side of Design
smashingmag
300
51k
[RailsConf 2023] Rails as a piece of cake
palkan
55
5.6k
Transcript
ZEN CODE REVIEWS THE WAY TOWARDS PAINLESS CODE REVIEWS Droidcon
Berlin 2017 1
ABOUT… XAVIER F. GOUCHET ANDROID ARCHITECT AT ‘MR TOOLS’ /
CI ADMIN / UT ADVOCATE ON ALL SOCIAL NETWORKS @XGOUCHET 2.1
WHO USES CODE REVIEW HERE ? ♫ Put your hands
in the air ♪ — Placebo 3
CODE REVIEWS @ DEEZER 18 Android developers 3 main repositories
Varied experiences and skills 4
WHY ? THE PURPOSES OF CODE REVIEWS 5
FIND DEFECTS EARLY Logic fallacies Typos, spelling Edge cases Potential
technical debt 6
HARMONIZE THE CODE BASE Code style Naming conventions Architecture Libraries
7
GENERATE DISCUSSION AROUND… Choices Algorithm Data Structure Architecture Libraries Features
Best practices 8
TEAM BUILDING Cohesion Trust Lower “Linkedin factor” Asynchronous Pair Programming
9
SHARE KNOWLEDGE Onboard junior / new developers Everyone has something
to teach Everyone has something to learn 10
DOWNSIDES OF CODE REVIEW More time spent per ticket /
less time spent delivering feature Senior developer frustration 11
WHAT ? THE DIFFERENT TYPES OF CODE REVIEWS 12
“AUTOMATIC” CODE REVIEW Static Analysis Android Lints Findbugs, Checkstyle, PMD
Detekt, ktlint Tests (Unit, Integrated, Functionnal) 13
PRE-COMMIT Pro Quality ensured before merge All code must be
reviewed Cons Productivity impact Back & forth Hell ™ 14
POST-COMMIT Pro Continuous development Limit git conflicts Cons Bug can
ship to production Resolution can become non trivial afterwards 15
OPTIONAL CODE REVIEWS by commit author by commit length by
files modified random checks … ? 16
PAIR REVIEW WITH ANOTHER DEVELOPER Provide a single feedack Compare
different viewpoints Tone down negative feedbacks 17
CODE REVIEW MEETING WITH THE AUTHOR 3 to 7 attendees
Only for non trivial reviews Mentor the author Get in depth view Discuss alternatives Immediate feedback 18
HOW ? THE DOS AND DONTS OF CODE REVIEW 19
WRITING REVIEWABLE CODE Keep the commits short git add --patch
/ git add -p Comment the code Use a proper commit message CR Brief for non trivial commits Link to the ticket 20
BEFORE SUBMITTING, REVIEW YOUR OWN CODE Find easy to spot
issues Typos Commented code Duplicates / possible refactoring Copy / Paste errors Take a step back on your code 21
COMMENTING ON ISSUES “If you can't understand that, then yes,
you're crazy. Or just terminally stupid.” — Linus 22
BE PRECISE : WHAT IS THE PROBLEM ? “THIS CODE
IS BAD !” ✗ “THIS LINE COULD CAUSE A MEMORY LEAK…” ✔ 23
ARGUMENT : WHY IS IT A PROBLEM ? “OBVIOUSLY!” ✗
“… BECAUSE THE ACTIVITY REFERENCE IS RETAINED…” ✔ 24
BE HELPFUL : HOW TO FIX THE PROBLEM ? “DEAL
WITH IT!” ✗ “… YOU COULD INSTEAD USE A WEAKREFERENCE.” ✔ 25
DEFINE CRITICITY : HOW IMPORTANT IS THE ISSUE ? “…”
✗ “IT’S NOT CRITICAL, BUT MUST BE FIXED IN A LATER COMMIT BEFORE THE RELEASE CANDIDATE NEXT WEEK.” ✔ 26
EXAMPLES “The name of this variable is ambiguous. You could
rename it as …” “I don’t think this method should be in this class because it’s outside of the class’s responsibility.” “This rule has many edge cases, you should add more unit tests.” 27
VOTING DOWN Avoid blocking commits unnecessarily Always make the reasons
clear Make a full review If an issue has already been raised, don't comment just to say “+1” 28
RECEIVING CRITIQUE Take a step back Stay humble Motivate your
choices Accept the critique (even if it means more work for you) 29
OVERALL BEHAVIOR Stay open minded Make it about the code,
not the people Don't start the flame war Share your knowledge Give as much as you receive 30
GOING FURTHER ? CODEREVIEW.STACKEXCHANGE.COM 31
THANKS FOR YOUR ATTENTION ANY QUESTION ? 32