MVPのようなものをチームに提案した話

チームに開発効率化のためにMVPっぽいものを提案した話

Transcript

1. MVPͷΑ͏ͳ΋ͷΛ νʔϜʹఏҊͨ͠࿩ shibuya.swift #3 2016/03/01 @amacou
2. ࣗݾ঺հ • ఱ໺ ળ඙(Amano Yoshihiko) • @amacou • GMOϖύϘ minneࣄۀ෦ • ruby Rails Objective-c swift
3. ΍͍ͬͯΔ͜ͱ • ೖ͔ࣾͯ͠ΒminneͷαʔόαΠυ(Rails)ΛҰ ೥ؒ • ͦͷޙiOSΞϓϦҰ೥ؒObjective-c(ͱͪΐͬ ͱ͚ͩSwift) • جຊతʹදʹग़ͯ͜ͳ͍ͱ͜ΖͷվળΛ୲౰
4. ࠓ೔࿩͢͜ͱ • ෳࡶͳը໘ͷΞϓϦͩͱMVCͰ͸ͭΒ͘ͳ͍ Ͱ͔͢ͱ͍͏࿩ • ͦΕͬͯMVP࢖͑͹࠷௿ݶͷมߋͰ͋Δఔ౓ ͏·͍͘Μ͡ΌͶ͍ͬͯ͏࿩
5. ෳࡶͳը໘ͷΞϓϦͰͭΒ͍ ͜ͱ
6. ෳࡶͳը໘ͱ͸ • ୯७Ͱ͸ͳ͍ը໘ • ෳ਺ͷίϯϙʔωϯτ͕഑ஔͯ͋͠Δ • Ұͭͷը໘ʹෳ਺ͷTableView΍ CollectionViewΛ࢖ͬͯͨΓ͢Δ
7. ෳࡶͳը໘ͷΞϓϦͰͳʹ͕ͭ Β͍͔ • ίʔυϨϏϡʔ͕ͭΒ͍ • ςετ͕ͭΒ͍
8. ίʔυϨϏϡʔ͕ͭΒ͍
9. ෳࡶͳը໘ͷϨϏϡʔͷͭΒ͞ • ViewControllerͷߦ਺͕ଟ͘ͳΓ͕ͪ • ϨϏϡʔ࣌ʹ֬ೝ͠ͳ͚Ε͹͍͚ͳ͍ൣғ͕޿͕Δ • मਖ਼ʹ΋͕͔͔࣌ؒΔ • ࠶ϨϏϡʔ࣌͸͔ͬ͢Γ๨Εͯ·ͨ࠷ॳ͔Βݟ௚͠ • ͭΒ͍
10. ςετ͕ͭΒ͍
11. ςετͷͭΒ͞ • ςετ͸ΤϯδχΞͷᅂΈ • ͔͠͠ෳࡶͳViewControllerͷUnitςετ͸ͭ Β͍ • UIςετʹཔΓ͕ͪ
12. ෳࡶͳViewControllerͷUnitς ετͷͭΒ͞ • ViewͱViewController͸བྷΈ߹͍ͬͯΔ͜ͱ͕ଟ͍ • ෳࡶͳ࣮૷ͱෳࡶͳςετ͸ηοτ • ෳࡶͳ࣮૷Λςετ͢Δͱ΋Εͳ͘ෳࡶͳςετʹͳΔ • ෳࡶͳςετ͸อकͰ͖ͳ͍ • UIςετʹཔΓ͕ͪʹͳΔ
13. UIςετͷͭΒ͞ • ςετΛॻ͘ͷʹ͕͔͔࣌ؒΔ • ࣮ߦ͕͔͔࣌ؒ͘͢͝Δ • ࡉ͔͍෼ذͷςετ͕ͩΔ͘ͳΔ • ςετΛ૿΍͠ʹ͍͘ • ςετͷอकʹ͕͔͔࣌ؒΔ • յΕ΍͍͢ • ΍ͬͺΓUnitςετΛްͨ͘͘͠ͳΔ
14. ͳͥ͜ΜͳʹͭΒ͍ͷ͔
15. ͳͥ͜ΜͳʹͭΒ͍ͷ͔ • Unitςετ͕ͭΒ͍ͷ΋ɺϨϏϡʔ͕ͭΒ͍ͷ΋ෳ ࡶͳViewControllerݪҼ • ViewControllerʹ੹຿ɺؔ৺ࣄ͕ूத͍͗ͯ͢͠Δ • γϯϓϧʹ͢Δʹ͸੹຿ɺؔ৺ࣄͰ෼ׂ͢Ε͹͍͍ • => MVPͬΆ͘͢Ε͹͍͍͡ΌΜͯͳͬͨ
16. MVPͬΆ͘͢Δͱ͸
17. MVPͱ͸ • Model-View-Presenterͷུ • Observer SynchronizationํࣜͱPassive View ํࣜͷ2ͭํ͕ࣜ͋Δ
18. MVP
 (Observer Synchronization) • Model • MVCͷModelͱಉ͡ • View • UIΛ୲౰͠ɺModelΛObserverͰ؂ࢹͯ͠ɺModelͷมߋΛ Viewʹ൓өͤ͞Δ • Presenter • View͔ΒͷΠϕϯτΛड͚औͬͯɺModelΛߋ৽͢Δ
19. MVP(Passive View) • Model • MVCͷModelͱಉ͡ • View • MVCͷView • ModelΛ௚઀͞ΘΒͳ͍ • ViewΛߋ৽͢ΔͨΊͷInterfeceΛ࣋ͭ • Presenter • View͔ΒͷΠϕϯτΛड͚औͬͯɺModelΛߋ৽͢Δ • ඞཁʹԠͯ͡ViewΛInterfaceΛ௨ͯ͡ߋ৽͢Δ
20. ࠓճѻ͏MVP • ࠓճѻ͏MVP͸Passive Viewํࣜ • ैདྷͷMVCͱͷ਌࿨ੑ͕ߴ͍ͨΊ • ͳΔ΂͘ViewΛബ͓͖͍ͯͨͨ͘͠Ί • => ࠓճ͸MVPͱݴͬͨΒPassive Viewํ ࣜͩͱࢥ͍ͬͯͩ͘͞
21. MVCͱMVPͷҧ͍
22. MVC 7JFX View ViewController Model
23. MVP View/VC Presenter 7JFX Model
24. ͋Μ·ΓҧΘͳ͍?
25. ͋Μ·ΓҧΘͳ͍ʂ • جຊతͳҧ͍͸2ͭͷখ͞ͳ໿ଋ͚ͩʂ • View͔Β͸ModelΛ௚઀৮Βͳ͍ • View <=> Presenter͸ϝιουΛ༻ҙͯ͠ ૢ࡞͢Δ
26. ͡Ό͋ར఺͸ʁ
27. MVC View ViewController Model
28. MVP 7JFX 7JFX 7JFX$POUSPMMFS 7JFX View/VC Presenter Model
29. େ͖ͳར఺ • MVP͸খ͞ͳView୯ҐͰPresenterΛׂΓ౰ͯΒΕΔ • ؔ৺ࣄΛখ͘͞Ͱ͖Δ = ίʔυΛίϯύΫτ/γϯϓϧʹͰ͖Δ • ςετ΋γϯϓϧʹͰ͖Δ • => Unitςετ͠΍͍͢ʂ • Presenter͸࢖͍·Θ͠΍͍͢ʂʂ • ॏෳ࣮ͨ͠૷͠ͳͯ͘ࡁΉ
30. Ͱ΋ͦΕ͸ࠓྲྀߦΓͷΠέͯ ΔΞʔΩςΫνϟͰ΋ಉͩ͡ ΑͶʁ
31. ͳͥଞͷΞʔΩςΫνϟͰ͸ ͳ͘MVPͳͷ͔
32. ଞͷΞʔΩςΫνϟ • MVVM(Model View ViewModel)ͱ͔DDD(Domain-Driven Design)ͱ͔ • ొ৔ਓ෺͕ଟ͍(Domain Model/Usecase/Input Port/ Output Port/Interface Adapter/Controller/Presenter/ Gateway) • νʔϜશһʹจԽΛਁಁͤ͞Δͷ݁ߏେม • DataBinding͸௒ศར͚ͩͲɺࠓղܾ͍ͨ͜͠ͱ͡Όͳ͍
33. MVPͷར఺ • MVC͔ΒͷୈҰาʹ͸࠷ద • ͦͷޙMVVM΍DDDͳͲ΁ͷൃలͰ͖Δ • ΏΔ;ΘͰ͋Γͳ͕Βͦͦ͜͜γϯϓϧʹͳ Γͦ͏
34. ࣮૷ํ๏
35. ͍͍ͩͨ͜Μͳը໘
37. AMNTopViewController.m #import "AMNTopViewController.h" @interface AMNTopViewController () @end @implementation AMNTopViewController - (void)didReceiveMemoryWarning { [super didReceiveMemoryWarning]; } @end
38. AMNTimelineTableViewPresenter.m @interface AMNTimelineTableViewPresenter() @property (nonatomic) AMNTimeline *timeline; @end @implementation AMNTimelineTableViewPresenter - (instancetype)init { if (self = [super init]) { self.timeline = [AMNTimeline new]; } return self; } - (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView { return 1; } - (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section { return self.timeline.posts.count; } - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath { id post = self.timeline.posts[indexPath.row]; NSString *identifier = [NSString stringWithFormat:@"%@Cell", NSStringFromClass([post class])]; id cell = [tableView dequeueReusableCellWithIdentifier:identifier]; if ([cell respondsToSelector:@selector(presenter)]) { NSObject<AMNPresenterProtocol> *presenter = [cell presenter]; [presenter presentWithModel:post viewController:self.viewController]; } return cell; } - (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath { return 160.f; } - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath { id post = self.timeline.posts[indexPath.row]; if ([post isKindOfClass:[AMNPhoto class]]) { AMNImageViewController *imageViewController = [[self.viewController storyboard] instantiateViewControllerWithIdentifier: NSStringFromClass([AMNImageViewController class])]; imageViewController.presenter.photo = post; [[self.viewController navigationController] pushViewController:imageViewController animated:YES]; } else if ([post isKindOfClass:[AMNText class]]) { AMNTextViewController *textViewController = [[self.viewController storyboard] instantiateViewControllerWithIdentifier: NSStringFromClass([AMNTextViewController class])]; textViewController.presenter.text = post; [[self.viewController navigationController] pushViewController:textViewController animated:YES]; } [tableView deselectRowAtIndexPath:indexPath animated:YES]; } @end
40. AMNPhotoTableViewCell/ AMNPhotoPresenter @interface AMNPhotoTableViewCell() @property (nonatomic) IBOutlet UIImageView *photoImageView; @end @implementation AMNPhotoTableViewCell - (void)awakeFromNib { self.presenter = [[AMNPhotoPresenter alloc] initWithView:self]; } - (void)setImage:(UIImage *)image { self.photoImageView.image = image; } @end @implementation AMNPhotoPresenter - (instancetype)initWithView: (UIView<AMNPhotoPresenterProtocol> *)view { if (self = [self init]) { self.view = view; } return self; } - (void)presentWithModel:(AMNPhoto *)model viewController:(UIViewController *)viewController { self.photo = model; self.viewController = viewController; [self reloadData]; } - (void)reloadData { [self.view setImage:self.photo.image]; } @end
42. AMNTextTableViewCell/ AMNTextPresenter @interface AMNTextTableViewCell() @property (nonatomic) IBOutlet UILabel *label; @end @implementation AMNTextTableViewCell - (void)awakeFromNib { self.presenter = [[AMNTextPresenter alloc] initWithView:self]; } - (void)setText:(NSString *)text { self.label.text = text; } @end @implementation AMNTextPresenter - (instancetype)initWithView: (UIView<AMNTextPresenterProtocol> *)view { if (self = [self init]) { self.view = view; } return self; } - (void)presentWithModel:(AMNText *)model viewController:(UIViewController *)viewController { self.text = model; self.viewController = viewController; [self reloadData]; } - (void)reloadData { [self.view setText:self.text.text]; } @end
44. AMNTextTableViewCell/ AMNTextPresenter @interface AMNPhotoListTableViewCell() @property (nonatomic) IBOutlet UICollectionView *collectionView; @end @implementation AMNPhotoListTableViewCell - (void)awakeFromNib { self.presenter = [[AMNPhotoListCollectionViewPresenter alloc] initWithView:self.collectionView]; } @implementation AMNPhotoListCollectionViewPresenter - (instancetype)initWithView:(UICollectionView *)view { if (self = [super init]) { self.view = view; self.view.delegate = self; self.view.dataSource = self; } return self; } - (void)presentWithModel:(AMNPhotoList *)model viewController:(UIViewController *)viewController { self.photoList = model; self.viewController = viewController; [self reloadData]; } - (void)reloadData { [self.view reloadData]; } - (NSInteger)collectionView:(UICollectionView *)collectionView numberOfItemsInSection:(NSInteger)section { return self.photoList.list.count; } - (UICollectionViewCell *)collectionView:(UICollectionView *)collectionView cellForItemAtIndexPath:(NSIndexPath *)indexPath { AMNPhotoCollectionViewCell *cell = [collectionView dequeueReusableCellWithReuseIdentifier:@"AMNPhotoCollectionViewCell" forIndexPath:indexPath]; cell.presenter.photo = self.photoList.list[indexPath.row]; [cell.presenter reloadData]; return cell; } - (CGSize)collectionView:(UICollectionView *)collectionView layout:(UICollectionViewLayout*)collectionViewLayout sizeForItemAtIndexPath:(NSIndexPath *)indexPath { return CGSizeMake(CGRectGetHeight(self.view.bounds), CGRectGetHeight(self.view.bounds)); } - (void)collectionView:(UICollectionView *)collectionView didSelectItemAtIndexPath:(NSIndexPath *)indexPath { id post = self.photoList.list[indexPath.row]; if ([post isKindOfClass:[AMNPhoto class]]) { AMNImageViewController *imageViewController = [[self.viewController storyboard] instantiateViewControllerWithIdentifier: NSStringFromClass([AMNImageViewController class])]; imageViewController.presenter.photo = post; [[self.viewController navigationController] pushViewController:imageViewController animated:YES]; } [collectionView deselectItemAtIndexPath:indexPath animated:YES]; } @end
46. AMNPhotoCollectionViewCell @interface AMNPhotoCollectionViewCell() @property (nonatomic, weak) IBOutlet UIImageView *imageView; @end @implementation AMNPhotoCollectionViewCell - (void)awakeFromNib { self.presenter = [[AMNPhotoPresenter alloc] initWithView:self]; } - (void)setImage:(UIImage *)image { self.imageView.image = image; } @end
47. ࣮૷ํ๏ • ଓ͖͸GithubͰ • https://github.com/amacou/MVPExample
48. ·ͱΊ • ΋͠ɺViewController͕ෳࡶʹͳͬͯେมʹ ͳ͖ͬͯͨΒ෼ׂͯ͠ΈΔͱΘΓͱ͍͍͔΋ • ͦͷͱ͖࠷௿ݶͷมߋͰՄೳͳΞʔΩςΫνϟ ͱͯ͠MVP͕͋ΔΑ
49. ͋Γ͕ͱ͏͍͟͝·ͨ͠