Teaching Through Code Review

Transcript

1. @DerekB_WI
   Teaching
   Through Code
   Review
   

   View Slide

2. @DerekB_WI
   Why Code Review?
   Prevent Bugs
   Ensure Consistency
   

   View Slide

3. @DerekB_WI
   Importance of
   Consistency
   

   View Slide

4. @DerekB_WI
   Reduce Friction
   Automate Tedious Checks
   Consistency
   

   View Slide

5. @DerekB_WI
   Make Time for Review
   Add Code Review to
   Estimates
   

   View Slide

6. @DerekB_WI
   Teaching through
   Review
   

   View Slide

7. @DerekB_WI
   Code Review is Not
   a Final Exam
   for a user story
   

   View Slide

8. @DerekB_WI
   Knowledge Sharing
   This is probably one of the
   most valuable reasons to do
   code review.” – Trisha Gee of
   JetBrains
   

   View Slide

9. @DerekB_WI
   Reviews by Juniors
   Yes, with solid procedure
   

   View Slide

10. @DerekB_WI
    Readable Code
    

    View Slide

11. @DerekB_WI
    Unreadable code
    

    View Slide

12. @DerekB_WI
    Readable Code
    

    View Slide

13. @DerekB_WI
    Negative Feedback
    Code Review should not
    be like grading a
    final exam.
    

    View Slide

14. @DerekB_WI
    Turn it around
    

    View Slide

15. @DerekB_WI
    Excellent Coaching Opportunity
    Insightful feedback accelerates learning and growth.
    Quality code strengthens readability and system understanding. This is a force
    multiplier for the team’s long term feature velocity.
    Curtis Einsmann – AWS Engineer
    

    View Slide

16. @DerekB_WI
    

    View Slide

17. @DerekB_WI
    I comment with kindness
    I comment on the code, not the person. I avoid using “you” or “your.” I prefix nitpicks
    with ”nit.” I phrase most comments as questions or suggestions.
    I leave at least one positive comment.
    Curtis Einsmann – AWS Engineer
    

    View Slide

18. @DerekB_WI
    

    View Slide

19. @DerekB_WI
    

    View Slide

20. @DerekB_WI
    learning from others.
    Remember that code reviews are not just for looking at what’s wrong, but for
    Camila Lenis – Truora, Inc.
    

    View Slide

21. @DerekB_WI
    The Accidental Code
    Review
    

    View Slide

22. @DerekB_WI
    

    View Slide

23. @DerekB_WI
    Ask for Help
    Managers should create an environment where collaboration is encouraged.
    

    View Slide

24. @DerekB_WI
    Resources
    ● How to Review Someone Else’s Code - https://youtu.be/TlXy_i27N3w
    ● Code Review Best Practice - https://youtu.be/a9_0UUUNt-Y
    ● What to Look For in a Code Review - https://leanpub.com/whattolookforinacodereview\
    ● Blackillustrations.com
    ● https://twitter.com/curtiseinsmann
    ● https://dev.to/camilaleniss/the-code-review-guide-4gfo
    ● https://hbr.org/2018/01/negative-feedback-rarely-leads-to-improvement
    

    View Slide

25. @DerekB_WI
    Thanks
    Keep in touch:
    binkleyd@yahoo.com
    

    View Slide