Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Teaching Through Code Review

D12eaf3ef46e4f0fc6b714fd2b7ffe3b?s=47 derek-b
April 28, 2021

Teaching Through Code Review

D12eaf3ef46e4f0fc6b714fd2b7ffe3b?s=128

derek-b

April 28, 2021
Tweet

Transcript

  1. @DerekB_WI Teaching Through Code Review

  2. @DerekB_WI Why Code Review? Prevent Bugs Ensure Consistency

  3. @DerekB_WI Importance of Consistency

  4. @DerekB_WI Reduce Friction Automate Tedious Checks Consistency

  5. @DerekB_WI Make Time for Review Add Code Review to Estimates

  6. @DerekB_WI Teaching through Review

  7. @DerekB_WI Code Review is Not a Final Exam for a

    user story
  8. @DerekB_WI Knowledge Sharing This is probably one of the most

    valuable reasons to do code review.” – Trisha Gee of JetBrains
  9. @DerekB_WI Reviews by Juniors Yes, with solid procedure

  10. @DerekB_WI Readable Code

  11. @DerekB_WI Unreadable code

  12. @DerekB_WI Readable Code

  13. @DerekB_WI Negative Feedback Code Review should not be like grading

    a final exam.
  14. @DerekB_WI Turn it around

  15. @DerekB_WI Excellent Coaching Opportunity Insightful feedback accelerates learning and growth.

    Quality code strengthens readability and system understanding. This is a force multiplier for the team’s long term feature velocity. Curtis Einsmann – AWS Engineer
  16. @DerekB_WI

  17. @DerekB_WI I comment with kindness I comment on the code,

    not the person. I avoid using “you” or “your.” I prefix nitpicks with ”nit.” I phrase most comments as questions or suggestions. I leave at least one positive comment. Curtis Einsmann – AWS Engineer
  18. @DerekB_WI

  19. @DerekB_WI

  20. @DerekB_WI learning from others. Remember that code reviews are not

    just for looking at what’s wrong, but for Camila Lenis – Truora, Inc.
  21. @DerekB_WI The Accidental Code Review

  22. @DerekB_WI

  23. @DerekB_WI Ask for Help Managers should create an environment where

    collaboration is encouraged.
  24. @DerekB_WI Resources • How to Review Someone Else’s Code -

    https://youtu.be/TlXy_i27N3w • Code Review Best Practice - https://youtu.be/a9_0UUUNt-Y • What to Look For in a Code Review - https://leanpub.com/whattolookforinacodereview\ • Blackillustrations.com • https://twitter.com/curtiseinsmann • https://dev.to/camilaleniss/the-code-review-guide-4gfo • https://hbr.org/2018/01/negative-feedback-rarely-leads-to-improvement
  25. @DerekB_WI Thanks Keep in touch: binkleyd@yahoo.com