Code Review for Teams

Transcript

1. Code Review
2. Josh Betz Engineer, Automattic
3. Why Code Review?
4. • More than 2.6 billion monthly page views • More than 9.5 million lines of code • 100% uptime last 30 days
5. Another set of eyes on your code.
6. Be proactive • Fix issues before they make it to production • Limit downtime • Don’t get hacked
7. Save $$ • Downed, broken, hacked sites are expensive. • Expensive to debug • Expensive to fix
8. Become a better programmer • Part of the WordPress culture is learning by example. • All code that goes into core starts as a patch on a trac ticket. • You can learn just as much by giving feedback as you can by receiving feedback.
9. You wouldn't publish a book without sending it to an editor first, don't publish software without code review.
10. What is Code Review?
11. What do we look for?
12. Security • XSS • SQL Injection • …
13. Performance • Slow Queries • Self DoS • Uncached functions
14. Functionality “Does this do what it’s supposed to do?”
15. When do you Code Review?
16. Always before production.
17. Before staging, if possible.
18. Methods of Code Review
19. Line-by-line • Important: Feedback references the code, not the developer. • Have a Checklist • Github Pull Requests • Feature Branch Workflow • Gitflow Workflow
20. Pair Programming
21. Automated
22. Unit Tests
23. Static Analysis • VIP Scanner • PHP Codesniffer • Services like Code Climate
24. Mix
25. What do you do?
26. Come work with me! http://automattic.com/work-with-us/