Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review for Teams
Search
Josh Betz
July 26, 2015
Technology
0
48
Code Review for Teams
Josh Betz
July 26, 2015
Tweet
Share
More Decks by Josh Betz
See All by Josh Betz
WP REST API
joshbetz
0
65
Automate All the Things
joshbetz
1
1.4k
Hypersonic
joshbetz
1
3.6k
Other Decks in Technology
See All in Technology
Semantic Machine Intelligence for Vision, Language, and Actions
keio_smilab
PRO
2
410
エンジニアリングマネージャー“お悩み相談”パネルセッション
ar_tama
1
740
Expertise as a Service via MCP
yodakeisuke
1
160
激動の時代、新卒エンジニアはAIツールにどう向き合うか。 [LayerX Bet AI Day Countdown LT Day1 ツールの選択]
tak848
0
600
興味の胞子を育て 業務と技術に広がる”きのこ力”
fumiyasac0921
0
260
Webの技術とガジェットで那須の子ども達にワクワクを! / IoTLT_20250720
you
PRO
0
130
2025/07/22_家族アルバム みてねのCRE における生成AI活用事例
masartz
2
130
完璧を目指さない小さく始める信頼性向上
kakehashi
PRO
0
110
ecspressoの設計思想に至る道 / sekkeinight2025
fujiwara3
12
2k
【CEDEC2025】大規模言語モデルを活用したゲーム内会話パートのスクリプト作成支援への取り組み
cygames
PRO
1
150
少人数でも回る! DevinとPlaybookで支える運用改善
ishikawa_pro
4
1.5k
増え続ける脆弱性に立ち向かう: 事前対策と優先度づけによる 持続可能な脆弱性管理 / Confronting the Rise of Vulnerabilities: Sustainable Management Through Proactive Measures and Prioritization
nttcom
1
210
Featured
See All Featured
Visualization
eitanlees
146
16k
What's in a price? How to price your products and services
michaelherold
246
12k
Product Roadmaps are Hard
iamctodd
PRO
54
11k
How to Ace a Technical Interview
jacobian
278
23k
Reflections from 52 weeks, 52 projects
jeffersonlam
351
21k
Keith and Marios Guide to Fast Websites
keithpitt
411
22k
Mobile First: as difficult as doing things right
swwweet
223
9.7k
The Cost Of JavaScript in 2023
addyosmani
51
8.6k
Balancing Empowerment & Direction
lara
1
500
4 Signs Your Business is Dying
shpigford
184
22k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
30
2.2k
Unsuck your backbone
ammeep
671
58k
Transcript
Code Review
Josh Betz Engineer, Automattic
Why Code Review?
• More than 2.6 billion monthly page views • More
than 9.5 million lines of code • 100% uptime last 30 days
Another set of eyes on your code.
Be proactive • Fix issues before they make it to
production • Limit downtime • Don’t get hacked
Save $$ • Downed, broken, hacked sites are expensive. •
Expensive to debug • Expensive to fix
Become a better programmer • Part of the WordPress culture
is learning by example. • All code that goes into core starts as a patch on a trac ticket. • You can learn just as much by giving feedback as you can by receiving feedback.
You wouldn't publish a book without sending it to an
editor first, don't publish software without code review.
What is Code Review?
What do we look for?
Security • XSS • SQL Injection • …
Performance • Slow Queries • Self DoS • Uncached functions
Functionality “Does this do what it’s supposed to do?”
When do you Code Review?
Always before production.
Before staging, if possible.
Methods of Code Review
Line-by-line • Important: Feedback references the code, not the developer.
• Have a Checklist • Github Pull Requests • Feature Branch Workflow • Gitflow Workflow
Pair Programming
Automated
Unit Tests
Static Analysis • VIP Scanner • PHP Codesniffer • Services
like Code Climate
Mix
What do you do?
Come work with me! http://automattic.com/work-with-us/