Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review for Teams
Search
Josh Betz
July 26, 2015
Technology
0
47
Code Review for Teams
Josh Betz
July 26, 2015
Tweet
Share
More Decks by Josh Betz
See All by Josh Betz
WP REST API
joshbetz
0
62
Automate All the Things
joshbetz
1
1.4k
Hypersonic
joshbetz
1
3.6k
Other Decks in Technology
See All in Technology
本が全く読めなかった過去の自分へ
genshun9
0
290
“社内”だけで完結していた私が、AWS Community Builder になるまで
nagisa53
1
390
生成AIで小説を書くためにプロンプトの制約や原則について学ぶ / prompt-engineering-for-ai-fiction
nwiizo
4
1.6k
解析の定理証明実践@Lean 4
dec9ue
0
180
TechLION vol.41~MySQLユーザ会のほうから来ました / techlion41_mysql
sakaik
0
180
PHP開発者のためのSOLID原則再入門 #phpcon / PHP Conference Japan 2025
shogogg
4
730
【5分でわかる】セーフィー エンジニア向け会社紹介
safie_recruit
0
26k
急成長を支える基盤作り〜地道な改善からコツコツと〜 #cre_meetup
stefafafan
0
120
Абьюзим random_bytes(). Фёдор Кулаков, разработчик Lamoda Tech
lamodatech
0
340
Clineを含めたAIエージェントを 大規模組織に導入し、投資対効果を考える / Introducing AI agents into your organization
i35_267
4
1.6k
Node-RED × MCP 勉強会 vol.1
1ftseabass
PRO
0
140
AWS Summit Japan 2025 Community Stage - App workflow automation by AWS Step Functions
matsuihidetoshi
1
260
Featured
See All Featured
Put a Button on it: Removing Barriers to Going Fast.
kastner
60
3.9k
Six Lessons from altMBA
skipperchong
28
3.8k
Intergalactic Javascript Robots from Outer Space
tanoku
271
27k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.3k
"I'm Feeling Lucky" - Building Great Search Experiences for Today's Users (#IAC19)
danielanewman
229
22k
The Pragmatic Product Professional
lauravandoore
35
6.7k
Adopting Sorbet at Scale
ufuk
77
9.4k
ReactJS: Keep Simple. Everything can be a component!
pedronauck
667
120k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
34
3k
Navigating Team Friction
lara
187
15k
YesSQL, Process and Tooling at Scale
rocio
173
14k
How to Think Like a Performance Engineer
csswizardry
24
1.7k
Transcript
Code Review
Josh Betz Engineer, Automattic
Why Code Review?
• More than 2.6 billion monthly page views • More
than 9.5 million lines of code • 100% uptime last 30 days
Another set of eyes on your code.
Be proactive • Fix issues before they make it to
production • Limit downtime • Don’t get hacked
Save $$ • Downed, broken, hacked sites are expensive. •
Expensive to debug • Expensive to fix
Become a better programmer • Part of the WordPress culture
is learning by example. • All code that goes into core starts as a patch on a trac ticket. • You can learn just as much by giving feedback as you can by receiving feedback.
You wouldn't publish a book without sending it to an
editor first, don't publish software without code review.
What is Code Review?
What do we look for?
Security • XSS • SQL Injection • …
Performance • Slow Queries • Self DoS • Uncached functions
Functionality “Does this do what it’s supposed to do?”
When do you Code Review?
Always before production.
Before staging, if possible.
Methods of Code Review
Line-by-line • Important: Feedback references the code, not the developer.
• Have a Checklist • Github Pull Requests • Feature Branch Workflow • Gitflow Workflow
Pair Programming
Automated
Unit Tests
Static Analysis • VIP Scanner • PHP Codesniffer • Services
like Code Climate
Mix
What do you do?
Come work with me! http://automattic.com/work-with-us/