Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review for Teams
Search
Josh Betz
July 26, 2015
Technology
0
44
Code Review for Teams
Josh Betz
July 26, 2015
Tweet
Share
More Decks by Josh Betz
See All by Josh Betz
WP REST API
joshbetz
0
49
Automate All the Things
joshbetz
1
1.3k
Hypersonic
joshbetz
1
3.4k
Other Decks in Technology
See All in Technology
競技としてのKaggle、役に立つKaggle
yu4u
5
2k
Janus
bkuhlmann
1
490
地理空間データ可視化・解析・活用ソリューション Pacific Spatial Solutions (PSS)
pacificspatialsolutions
0
300
アクセシビリティを考慮したUI/CSSフレームワーク・ライブラリ選定
yajihum
2
1k
KubeConにproposalを送りたい人へのアドバイス
sat
PRO
3
260
R3のコードから見る実践LINQ実装最適化・コンカレントプログラミング実例
neuecc
2
620
Cypress or Playwright?
rainerhahnekamp
0
140
TechFeed Experts Night#27 〜 フロントエンドフレームワーク最前線 (Svelte)
baseballyama
1
550
本当のAWS基礎
toru_kubota
0
540
DMM.com アルファ室採用案内資料
hsugita
1
170
EM完全に理解した と思ったけど、 やっぱり何も分からなかった話 / EM Night Fukuoka #1
hirutas
0
110
One engineer company with Ruby on Rails
rstankov
2
250
Featured
See All Featured
"I'm Feeling Lucky" - Building Great Search Experiences for Today's Users (#IAC19)
danielanewman
221
21k
Put a Button on it: Removing Barriers to Going Fast.
kastner
58
3.1k
Easily Structure & Communicate Ideas using Wireframe
afnizarnur
187
16k
ピンチをチャンスに:未来をつくるプロダクトロードマップ #pmconf2020
aki_iinuma
79
43k
What's new in Ruby 2.0
geeforr
337
31k
Large-scale JavaScript Application Architecture
addyosmani
504
110k
What the flash - Photography Introduction
edds
64
11k
Navigating Team Friction
lara
178
13k
The Mythical Team-Month
searls
216
42k
GitHub's CSS Performance
jonrohan
1025
450k
Git: the NoSQL Database
bkeepers
PRO
422
63k
Fireside Chat
paigeccino
21
2.6k
Transcript
Code Review
Josh Betz Engineer, Automattic
Why Code Review?
• More than 2.6 billion monthly page views • More
than 9.5 million lines of code • 100% uptime last 30 days
Another set of eyes on your code.
Be proactive • Fix issues before they make it to
production • Limit downtime • Don’t get hacked
Save $$ • Downed, broken, hacked sites are expensive. •
Expensive to debug • Expensive to fix
Become a better programmer • Part of the WordPress culture
is learning by example. • All code that goes into core starts as a patch on a trac ticket. • You can learn just as much by giving feedback as you can by receiving feedback.
You wouldn't publish a book without sending it to an
editor first, don't publish software without code review.
What is Code Review?
What do we look for?
Security • XSS • SQL Injection • …
Performance • Slow Queries • Self DoS • Uncached functions
Functionality “Does this do what it’s supposed to do?”
When do you Code Review?
Always before production.
Before staging, if possible.
Methods of Code Review
Line-by-line • Important: Feedback references the code, not the developer.
• Have a Checklist • Github Pull Requests • Feature Branch Workflow • Gitflow Workflow
Pair Programming
Automated
Unit Tests
Static Analysis • VIP Scanner • PHP Codesniffer • Services
like Code Climate
Mix
What do you do?
Come work with me! http://automattic.com/work-with-us/