Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review for Teams
Search
Josh Betz
July 26, 2015
Technology
0
49
Code Review for Teams
Josh Betz
July 26, 2015
Tweet
Share
More Decks by Josh Betz
See All by Josh Betz
WP REST API
joshbetz
0
65
Automate All the Things
joshbetz
1
1.4k
Hypersonic
joshbetz
1
3.6k
Other Decks in Technology
See All in Technology
Goでマークダウンの独自記法を実装する
lag129
0
220
新卒(ほぼ)専業Kagglerという選択肢
nocchi1
1
2.4k
Backboneとしてのtimm2025
yu4u
4
1.6k
JavaScript 研修
recruitengineers
PRO
3
190
AIエージェントの開発に必須な「コンテキスト・エンジニアリング」とは何か──プロンプト・エンジニアリングとの違いを手がかりに考える
masayamoriofficial
0
400
広島銀行におけるAWS活用の取り組みについて
masakimori
0
140
KiroでGameDay開催してみよう(準備編)
yuuuuuuu168
1
130
Yahoo!ニュースにおけるソフトウェア開発
lycorptech_jp
PRO
0
370
我々は雰囲気で仕事をしている / How can we do vibe coding as well
naospon
2
220
RAID6 を楔形文字で組んで現代人を怖がらせましょう(実装編)
mimifuwa
1
310
LLMエージェント時代に適応した開発フロー
hiragram
1
410
アジャイルテストで高品質のスプリントレビューを
takesection
0
120
Featured
See All Featured
Stop Working from a Prison Cell
hatefulcrawdad
271
21k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
31
2.2k
Automating Front-end Workflow
addyosmani
1370
200k
RailsConf 2023
tenderlove
30
1.2k
How GitHub (no longer) Works
holman
315
140k
Visualization
eitanlees
147
16k
Music & Morning Musume
bryan
46
6.7k
Testing 201, or: Great Expectations
jmmastey
45
7.6k
Keith and Marios Guide to Fast Websites
keithpitt
411
22k
Building Applications with DynamoDB
mza
96
6.6k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
15
1.6k
The Pragmatic Product Professional
lauravandoore
36
6.8k
Transcript
Code Review
Josh Betz Engineer, Automattic
Why Code Review?
• More than 2.6 billion monthly page views • More
than 9.5 million lines of code • 100% uptime last 30 days
Another set of eyes on your code.
Be proactive • Fix issues before they make it to
production • Limit downtime • Don’t get hacked
Save $$ • Downed, broken, hacked sites are expensive. •
Expensive to debug • Expensive to fix
Become a better programmer • Part of the WordPress culture
is learning by example. • All code that goes into core starts as a patch on a trac ticket. • You can learn just as much by giving feedback as you can by receiving feedback.
You wouldn't publish a book without sending it to an
editor first, don't publish software without code review.
What is Code Review?
What do we look for?
Security • XSS • SQL Injection • …
Performance • Slow Queries • Self DoS • Uncached functions
Functionality “Does this do what it’s supposed to do?”
When do you Code Review?
Always before production.
Before staging, if possible.
Methods of Code Review
Line-by-line • Important: Feedback references the code, not the developer.
• Have a Checklist • Github Pull Requests • Feature Branch Workflow • Gitflow Workflow
Pair Programming
Automated
Unit Tests
Static Analysis • VIP Scanner • PHP Codesniffer • Services
like Code Climate
Mix
What do you do?
Come work with me! http://automattic.com/work-with-us/