Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code Review for Teams
Search
Josh Betz
July 26, 2015
Technology
0
48
Code Review for Teams
Josh Betz
July 26, 2015
Tweet
Share
More Decks by Josh Betz
See All by Josh Betz
WP REST API
joshbetz
0
65
Automate All the Things
joshbetz
1
1.4k
Hypersonic
joshbetz
1
3.6k
Other Decks in Technology
See All in Technology
AI コードレビューが面倒すぎるのでテスト駆動開発で解決しようとして読んだら、根本的に俺の勘違いだった
mutsumix
0
140
alecthomas/kong はいいぞ
fujiwara3
6
1.3k
Datasets for Critical Operations by Dataform
kimujun
0
150
Perlアプリケーションで トレースを実装するまでの 工夫と苦労話
masayoshi
1
350
帳票構造化タスクにおけるLLMファインチューニングの性能評価
yosukeyoshida
1
220
少人数でも回る! DevinとPlaybookで支える運用改善
ishikawa_pro
5
2.1k
Power Automate のパフォーマンス改善レシピ / Power Automate Performance Improvement Recipes
karamem0
0
280
LLMをツールからプラットフォームへ〜Ai Workforceの戦略〜 #BetAIDay
layerx
PRO
1
640
Unson OS|48時間で「売れるか」を判定する AI 市場検証プラットフォーム
unson
0
160
反脆弱性(アンチフラジャイル)とデータ基盤構築
cuebic9bic
2
140
2025新卒研修・HTML/CSS #弁護士ドットコム
bengo4com
3
4.6k
Rubyの国のPerlMonger
anatofuz
2
690
Featured
See All Featured
Building a Scalable Design System with Sketch
lauravandoore
462
33k
Scaling GitHub
holman
461
140k
Build The Right Thing And Hit Your Dates
maggiecrowley
37
2.8k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
30
2.2k
Rails Girls Zürich Keynote
gr2m
95
14k
The MySQL Ecosystem @ GitHub 2015
samlambert
251
13k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
26
3k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
soudai
PRO
182
54k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
15
1.6k
GitHub's CSS Performance
jonrohan
1031
460k
KATA
mclloyd
31
14k
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
10
1k
Transcript
Code Review
Josh Betz Engineer, Automattic
Why Code Review?
• More than 2.6 billion monthly page views • More
than 9.5 million lines of code • 100% uptime last 30 days
Another set of eyes on your code.
Be proactive • Fix issues before they make it to
production • Limit downtime • Don’t get hacked
Save $$ • Downed, broken, hacked sites are expensive. •
Expensive to debug • Expensive to fix
Become a better programmer • Part of the WordPress culture
is learning by example. • All code that goes into core starts as a patch on a trac ticket. • You can learn just as much by giving feedback as you can by receiving feedback.
You wouldn't publish a book without sending it to an
editor first, don't publish software without code review.
What is Code Review?
What do we look for?
Security • XSS • SQL Injection • …
Performance • Slow Queries • Self DoS • Uncached functions
Functionality “Does this do what it’s supposed to do?”
When do you Code Review?
Always before production.
Before staging, if possible.
Methods of Code Review
Line-by-line • Important: Feedback references the code, not the developer.
• Have a Checklist • Github Pull Requests • Feature Branch Workflow • Gitflow Workflow
Pair Programming
Automated
Unit Tests
Static Analysis • VIP Scanner • PHP Codesniffer • Services
like Code Climate
Mix
What do you do?
Come work with me! http://automattic.com/work-with-us/