Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Get Your Patch Accepted
Search
Lorna Mitchell
August 22, 2015
Technology
1
910
Get Your Patch Accepted
Code reviews and how to survive them (from Froscon 2015)
Lorna Mitchell
August 22, 2015
Tweet
Share
More Decks by Lorna Mitchell
See All by Lorna Mitchell
Introduction to OpenAPI Specification
lornajane
1
580
Create PDFs from markup with rst2pdf
lornajane
2
670
Serverless Microservices are the New Black
lornajane
3
92
Serverless Computing with Apache OpenWhisk
lornajane
0
82
Build A Serverless Data Pipeline
lornajane
1
690
SQL, NoSQL and Beyond
lornajane
0
920
Build a Serverless Data Pipeline
lornajane
1
970
Road Trip Through Database Country
lornajane
1
900
Serverless Microservices Are The New Black
lornajane
1
99
Other Decks in Technology
See All in Technology
現代CSSフレームワークの内部実装とその仕組み
poteboy
0
170
元インフラエンジニアに成る / Human Resources to Human Relations
bobtani
3
780
最近たまに見かけるTiDBってなんだ? - Findy
pingcap0315
2
580
AIQ株式会社 エンジニア向け会社紹介資料
aiqlab
0
370
なぜ NOT A HOTEL が Web3 に取り組むのか - NOT A HOTEL TECH TALK
ynunokawa
0
160
SIEMを用いて、セキュリティログ分析の可視化と分析を実現し、PDCAサイクルを回してみた
coconala_engineer
0
220
LLM とプロンプトエンジニアリング/チューターをビルドする / LLM and Prompt Engineering and Building Tutors
ks91
PRO
0
220
Tableau事例紹介 / Tableau Case Study of Eureka
kazuya_araki_tokyo
1
170
「共通基盤」を超えよ! 今、Platform Engineeringに取り組むべき理由
jacopen
25
5.8k
シン・Kafka / shin-kafka
oracle4engineer
PRO
7
2.7k
"好き"との生活/Regularly update profile with GitHub Actions
judeeeee
0
150
スタートアップの技術顧問を3年間続けて発生した事と気付き
biwakonbu
0
160
Featured
See All Featured
Java REST API Framework Comparison - PWX 2021
mraible
PRO
18
6.9k
Building Flexible Design Systems
yeseniaperezcruz
318
37k
Gamification - CAS2011
davidbonilla
76
4.6k
Optimizing for Happiness
mojombo
370
69k
[RailsConf 2023] Rails as a piece of cake
palkan
22
3.9k
Creatively Recalculating Your Daily Design Routine
revolveconf
209
11k
Stop Working from a Prison Cell
hatefulcrawdad
266
19k
Helping Users Find Their Own Way: Creating Modern Search Experiences
danielanewman
19
1.9k
Producing Creativity
orderedlist
PRO
336
39k
What's new in Ruby 2.0
geeforr
337
31k
Optimising Largest Contentful Paint
csswizardry
7
2.3k
XXLCSS - How to scale CSS and keep your sanity
sugarenia
240
1.2M
Transcript
How to get your patch accepted Lorna Mitchell, August 2015
maintainer and team lead
unsolicited advice
stories
3 ingredients
code
words
perspective
what does it do?
feature/bug
ticket(s)?
If there aren't any acceptance criteria for your patch, invent
some
all the code
git diff master
git diff master...HEAD
tools
TOO BIG
common code mistakes
exotic code, no comments
Leaving commented code in your codebase is like leaving litter
on a campsite
variable named $x
contributing.md
can you break your code?
I can
missing data
permissions
user is an idiot
tests
coding standards
syntax check
The commit history in your branch will be part of
my project until the end of time
git reset --soft $(git merge-base master HEAD)
more info than diff
accurate
sane format
http://chris.beams.io/posts/git-commit/
SFW
apologies
will it merge?
git merge --no-commit --no-ff feature git merge --abort
fix it
rebase
A pull request is the opening line in a conversation
about a feature
source/target
diff
title
description
what does it do?
what will I observe?
why do I care?
code review
"review" vs "merge"
anyone
peer review vs gatekeepers
key skills
Being able to see what you're NOT looking at is
a reviewer's superpower
documentation
tests
database patch
deployability
template
email
report
monitoring
cron job
and if not ...
reject
automated build
constructive feedback
colleagues vs contributors
too much feedback
sandwich technique
harsh feedback
Pull requests have a lifecycle, be prepared to champion them
to the end
3 ingredients
code
words
perspective
Thankyou http://lornajane.net (also speaking about PHP7 tomorrow)