Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Get Your Patch Accepted
Search
Lorna Mitchell
August 22, 2015
Technology
1
1k
Get Your Patch Accepted
Code reviews and how to survive them (from Froscon 2015)
Lorna Mitchell
August 22, 2015
Tweet
Share
More Decks by Lorna Mitchell
See All by Lorna Mitchell
Introduction to OpenAPI Specification
lornajane
1
770
Create PDFs from markup with rst2pdf
lornajane
3
810
Serverless Microservices are the New Black
lornajane
3
130
Serverless Computing with Apache OpenWhisk
lornajane
0
110
Build A Serverless Data Pipeline
lornajane
1
770
SQL, NoSQL and Beyond
lornajane
0
1.1k
Build a Serverless Data Pipeline
lornajane
1
1.1k
Road Trip Through Database Country
lornajane
1
980
Serverless Microservices Are The New Black
lornajane
1
140
Other Decks in Technology
See All in Technology
5分でカオスエンジニアリングを分かった気になろう
pandayumi
0
260
Claude Code でアプリ開発をオートパイロットにするためのTips集 Zennの場合 / Claude Code Tips in Zenn
wadayusuke
5
1.3k
LLMを搭載したプロダクトの品質保証の模索と学び
qa
0
1.1k
「Linux」という言葉が指すもの
sat
PRO
4
140
職種の壁を溶かして開発サイクルを高速に回す~情報透明性と職種越境から考えるAIフレンドリーな職種間連携~
daitasu
0
170
AIエージェントで90秒の広告動画を制作!台本・音声・映像・編集をつなぐAWS最新アーキテクチャの実践
nasuvitz
3
350
20250913_JAWS_sysad_kobe
takuyay0ne
2
250
会社紹介資料 / Sansan Company Profile
sansan33
PRO
6
380k
複数サービスを支えるマルチテナント型Batch MLプラットフォーム
lycorptech_jp
PRO
1
940
「全員プロダクトマネージャー」を実現する、Cursorによる仕様検討の自動運転
applism118
22
12k
バイブスに「型」を!Kent Beckに学ぶ、AI時代のテスト駆動開発
amixedcolor
2
580
react-callを使ってダイヤログをいろんなとこで再利用しよう!
shinaps
2
260
Featured
See All Featured
How STYLIGHT went responsive
nonsquared
100
5.8k
Gamification - CAS2011
davidbonilla
81
5.4k
A better future with KSS
kneath
239
17k
Build your cross-platform service in a week with App Engine
jlugia
231
18k
Bootstrapping a Software Product
garrettdimon
PRO
307
110k
Scaling GitHub
holman
463
140k
Responsive Adventures: Dirty Tricks From The Dark Corners of Front-End
smashingmag
252
21k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
48
9.7k
How GitHub (no longer) Works
holman
315
140k
StorybookのUI Testing Handbookを読んだ
zakiyama
31
6.1k
Embracing the Ebb and Flow
colly
87
4.8k
Six Lessons from altMBA
skipperchong
28
4k
Transcript
How to get your patch accepted Lorna Mitchell, August 2015
maintainer and team lead
unsolicited advice
stories
3 ingredients
code
words
perspective
what does it do?
feature/bug
ticket(s)?
If there aren't any acceptance criteria for your patch, invent
some
all the code
git diff master
git diff master...HEAD
tools
TOO BIG
common code mistakes
exotic code, no comments
Leaving commented code in your codebase is like leaving litter
on a campsite
variable named $x
contributing.md
can you break your code?
I can
missing data
permissions
user is an idiot
tests
coding standards
syntax check
The commit history in your branch will be part of
my project until the end of time
git reset --soft $(git merge-base master HEAD)
more info than diff
accurate
sane format
http://chris.beams.io/posts/git-commit/
SFW
apologies
will it merge?
git merge --no-commit --no-ff feature git merge --abort
fix it
rebase
A pull request is the opening line in a conversation
about a feature
source/target
diff
title
description
what does it do?
what will I observe?
why do I care?
code review
"review" vs "merge"
anyone
peer review vs gatekeepers
key skills
Being able to see what you're NOT looking at is
a reviewer's superpower
documentation
tests
database patch
deployability
template
email
report
monitoring
cron job
and if not ...
reject
automated build
constructive feedback
colleagues vs contributors
too much feedback
sandwich technique
harsh feedback
Pull requests have a lifecycle, be prepared to champion them
to the end
3 ingredients
code
words
perspective
Thankyou http://lornajane.net (also speaking about PHP7 tomorrow)