How Sigmund Freud would perform a code review?

Knowing how to fix the code you review is just half of the work - the second one is giving this feedback so it'll be taken into consideration.

This will be a story of soft skills for engineers, and how I learned, the hard way, that even people you think you know, can't handle negative review. No matter how long you work together – it takes only one bad day for personality defense mechanisms to kick in.

I won't tell you how to trick your friends and coworkers into believing everything you say - it's not a NLP course, instead you'll learn how to fix yourself - so others will consider your feedback.

Transcript

1. HOW SIGMUND FREUD WOULD PERFORM A CODE REVIEW? Because knowing how to fix code is just half of the work.
3. I’M HERE TO CHANGE THE WAY YOU THINK ABOUT CODE REVIEW
4. KNOWING HOW TO FIX CODE IS JUST HALF OF THE WORK
5. ROUGHHOUSING
6. WHY DO WE FAIL?
7. HOME OFFICE
8. NOT DOING REVIEW FACE TO FACE
9. ALL IT TAKES IS ONE BAD DAY TO REDUCE THE SANEST MAN ALIVE TO LUNACY. Alan Moore , Batman: The Killing Joke
10. LEARNING IT THE HARD WAY
11. BE THE CHANGE THAT YOU WISH TO SEE IN THE WORLD. Mahatma Ghandi
12. IT IS THERE IN ANCIENT GREECE WHERE OUR STORY BEGINS It's a warm summer evening in ancient Greece
13. PLATO 428/427 or 424/423 – 348/347 BC
14. THE CHARIOT ALLEGORY
15. DANIEL KAHNEMAN 1934 -
16. FAST THINKING Emotional & Instinctive
17. ONLY A SITH DEALS IN ABSOLUTES Obi-wan Kenobi, Star Wars: Episode III – Revenge of the Sith
18. AN INDIVIDUAL HAS BEEN DESCRIBED BY A NEIGHBOR AS FOLLOWS: “Steve is very shy and withdrawn, invariably helpful but with very little interest in people or in the world of reality. A meek and tidy soul, he has a need for order and structure, and a passion for detail.”
19. IS STEVE MORE LIKELY TO BE A LIBRARIAN OR A FARMER?
20. SLOW THINKING Logical & Deliberative
21. WHO IS STEVE? • Farmers to Librarlians ratio 5:1 •Male farmers to male librarians ratio is even higher
22. WE WANT TO FEEL IN CONTROL
23. YOU ARE BAD IN CODE REVIEW!
24. COGNITIVE DISSONANCE
25. SIGMUND FREUD 1856 - 1939
26. PERSONALITY DEFENCE MECHANISMS
27. KNURD OR BEING COMPLETELY AWARE „Knurdness strips away all illusion, all the comforting pink fog in which people normally spend their lives (…)” Sir Terry Pratchett
28. GEORGE EMAN VAILLANT 1934 -
29. LEVEL 1: PATHOLOGICAL • Denial
30. LEVEL 2: IMMATURE • Acting out • Passive-aggressiveness • Projection
31. LEVEL 3: NEUROTIC • Repression • Intelectualization
32. LEVEL 4: MATURE • Anticipation • Humor • Sublimation
33. WHAT TO DO?
34. AVOID USING THE WORD - „YOU”
35. DON’T ARGUE BY APPEALING TO AUTHORITY
36. ARTHUR SCHOPENHAUER 1788 - 1860
37. AND OTHER „DIRTY” ERISTIC STRATEGIES • Existential fallacies • Argument from silence • Argumentum ad populum • …
38. DON’T TRY TO USE NLP ON YOUR COLLEGUES
39. BE SCEPTIC TO „CARGO CULT”AND „MAGPIE” PROGRAMMING
40. DON’T CRITICISE FOR THE SAKE OF CRITICISM
41. SHOW AND TELL
42. START A CONVERSATION
43. SAY SOMETHING NICE FOR A CHANGE
44. HOW SIGMUND FREUD WOULD PERFORM A CODE REVIEW?
45. KEY TAKEOUTS Dos • Show that the code is a shared responsibility. • Start a conversation. • Say something nice for a change. Don’ts • Don’t use „you”. • Don’t practice NLP & eristic. • Don’t faultfinding.
46. HONEST OPEN MINDFUL
48. BIBLIOGRAPHY • Sigmund Freud, Anna Freud - The Ego and the Mechanisms of Defence • George Eman Valillant - An empirically validated hierarchy of defence mechanisms. Archives of General Psychiatry, 73, 786–794. • Phebe Cramer - Protecting the Self: Defense Mechanisms in Action • Daniel Khaneman - Thinking, Fast and Slow • Arthur Schopenhauer - The Art of Being Right @medwith