Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Speaker Deck
PRO
Sign in
Sign up
for free
みんなで育てるprecheck
Kohei Tabata
August 22, 2017
Programming
1
330
みんなで育てるprecheck
Kohei Tabata
August 22, 2017
Tweet
Share
More Decks by Kohei Tabata
See All by Kohei Tabata
nerd0geek1
2
590
nerd0geek1
1
52
nerd0geek1
3
2.7k
nerd0geek1
2
3k
nerd0geek1
1
640
nerd0geek1
4
280
nerd0geek1
3
740
nerd0geek1
0
370
nerd0geek1
0
1.2k
Other Decks in Programming
See All in Programming
maito1201
0
160
mizotake
2
330
abeta
1
210
keeeeen
0
110
takapy
0
170
ryosukes
0
1.4k
sters
2
140
alperhankendi
1
150
grapecity_dev
1
200
oracle4engineer
0
120
lovee
9
2.9k
korosuke613
2
260
Featured
See All Featured
caitiem20
308
17k
productmarketing
6
720
maltzj
502
36k
holman
288
130k
malarkey
119
16k
jakevdp
775
200k
keathley
20
710
lauravandoore
10
1.6k
maggiecrowley
10
500
shlominoach
176
7.5k
zenorocha
296
40k
dotmariusz
94
5.5k
Transcript
ΈΜͳͰҭͯΔ precheck 2017/08/22 fastlaneษڧձ@Origami
ࣗݾհ ɾKohei Tabata(@nerd0geek1) ɾSaib Studio LLC ɾiOS/macOS app Developer ɾfastlane
contributor Said Studio LLC Kohei Tabata Next! Remote quick-zip plus
Agenda ɾprecheckͱ ɾprecheckͷ͍ํ ɾprecheckͱRule ɾprecheckͷΧελϚΠζ ɾContributionνϟϯε ɾ·ͱΊ
precheckͱʁ ɾfastlane v2.40.0Ͱ৽͘͠fastlaneʹՃ͞Εͨrubygems ɾcommunity driven metadata checker ɾiTunes Connect্ͷmetadataʹmetadata rejectΛҾ͖ى͜͢Α͏ͳҎԼͷจݴ͕
ɹؚ·Ε͍ͯͳ͍͔֬ೝ͠ɺඞཁʹԠͯ͡ܯࠂͯ͘͠ΕΔɻ ɹɾଞࣾͷඪ ɹɾiOSͷόάͷݴٴ ɹɾଞͷplatformͷݴٴ(Android) ɹɾetc…
͍ํ ɾfastlane precheck ɾfastlane deliver run(→defaultͰprecheckΛݺͿ)
precheckͱRule ɾprecheckͰɺRuleͱ͍͏ΫϥεΛجఈΫϥεͱ͢Δ༷ʑͳ۩ΫϥεΛ࡞Γɺ ɹͦͷ۩ΫϥεΛmetadataʹద༻͢Δ͜ͱͰνΣοΫΛߦ͍ͬͯΔɻ ɾҎԼͷΑ͏ͳ۩Ϋϥε͕ར༻͞Ε͍ͯΔɻ ɹɾNegativeAppleSentimentRule ɹɾPlaceholderWordsRule ɹɾOtherPlatformsRule(ଞplatformͷݴٴ) ɹɾFutureFunctionalityRule(ʮcoming soonʯͳͲͷະ࣮Λࣔ͢දݱؚ͕·Ε͍ͯΔ͔) ɹɾTestWordsRule(testingͳͲɺςετΞϓϦͬΆ͍จݴؚ͕·Ε͍ͯΔ͔)
ɹɾCurseWordsRule ɹɾCustomTextRule ɹɾCopyrightDateRule ɹɾUnreachableURLRule
precheckͷΧελϚΠζ ɾଞͷfastlaneͷgemಉ༷ʹઃఆϑΝΠϧͱͯ͠PrecheckFileΛ࡞͢Δ͜ͱ͕Ͱ͖Δ ɾPrecheckFileͰɺ֤ϧʔϧΛͲͷఔݫ͘͠νΣοΫ͢Δ͔ΛઃఆՄೳ ɹɾskip(νΣοΫ͠ͳ͍) ɹɾwarn(νΣοΫ͠ɺϧʔϧʹҾ͔͔ͬΕදࣔ͢Δ) ɹɾerror(νΣοΫ͠ɺϧʔϧʹҾ͔͔ͬΕͦ͜ͰॲཧΛऴྃͤ͞Δ)
Contributionνϟϯε ɾprecheckɺ֤Rule͝ͱʹStringͷArrayΛ࡞͠ɺͦͷArrayʹؚ·Ε͍ͯΔจݴ͕ ɹmetadataʹؚ·Ε͍ͯΔ͔ɺͱ͍͏νΣοΫΛ͍ͯ͠Δ͚ͩɻ ɾͳͷͰɺmetadata reject͞ΕͨࡍʹɺRuleͷlowercased_words_to_look_forʹ ɹϦδΣΫτ࣌ʹࢦఠ͞ΕͨจݴΛՃ͠ɺPRΛૹΔ͚ͩͰ؆୯ʹfastlaneͷ ɹContributorʹͳΕΔ͔ʁ
·ͱΊ ɾprecheckίϛϡχςΟͷݟΛ׆͔ͯ͠metadata rejectΛආ͚ΔͨΊͷgem ɾΈΜͳ͕metadata reject࣌ʹprecheckʹPRૹΕू߹Λ׆͔ͤΔΑ͏ʹ ɾreject͞ΕͨจݴΛ֤Ruleͷlowercased_words_to_look_forʹՃ͢Δ͚ͩͳͷͰɺ ɹ؆୯ʹContributeͰ͖Δ͔⭐⭐⭐
ࢀߟ * fastlane release 2.40.0 Introducing fastlane precheck (https://github.com/fastlane/fastlane/releases/tag/2.40.0) *
precheck (https://github.com/fastlane/fastlane/tree/master/precheck)