Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
CircleCIからPull requestできるといろいろ捗る
Search
rvillage
July 29, 2018
Technology
0
440
CircleCIからPull requestできるといろいろ捗る
rvillage
July 29, 2018
Tweet
Share
Other Decks in Technology
See All in Technology
生産性向上チームの紹介
cybozuinsideout
PRO
1
860
開発生産性大幅アップ!Postman VS Code拡張機能
nagix
2
370
長期間TiDBを使ってきた話 @ 私たちはなぜNewSQLを使うのかTiDB選定5社が語る選定理由と活用LT / Experiences with TiDB Over Time
chibiegg
2
870
SPI原点回帰論:事業課題とFour Keysの結節点を見出す実践的ソフトウェアプロセス改善 / DevOpsDays Tokyo 2024
visional_engineering_and_design
4
1.9k
MLOpsの「壁」を乗り越える、LINEヤフーの Data Quality as Code
lycorptech_jp
PRO
5
440
MySQL の SQL クエリチューニングの要所を掴む勉強会
andpad
2
6.1k
Delivering Millions of Messages within seconds @ Duolingo
pelelgrino
0
350
推しは推せるときに推せ! プロダクトにフィードバックしていこう
nakasho
0
290
コンテナセキュリティの基本と脅威への対策
kyohmizu
3
750
エンジニアのキャリアをちょっと楽しくする3本の軸/Three Pillars to Make an Engineer's Career More Enjoyable
kwappa
0
2.6k
サーバー間 GraphQL と webmock-graphql の話 / server-to-server graphql and webmock-graphql
qsona
2
180
JSON攻略法.pdf
miyakemito
8
4.9k
Featured
See All Featured
The Illustrated Children's Guide to Kubernetes
chrisshort
31
46k
In The Pink: A Labor of Love
frogandcode
138
21k
Design by the Numbers
sachag
274
18k
RailsConf & Balkan Ruby 2019: The Past, Present, and Future of Rails at GitHub
eileencodes
125
32k
How STYLIGHT went responsive
nonsquared
92
4.8k
Robots, Beer and Maslow
schacon
PRO
155
7.9k
ParisWeb 2013: Learning to Love: Crash Course in Emotional UX Design
dotmariusz
104
6.6k
Into the Great Unknown - MozCon
thekraken
10
990
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
17
1.4k
[RailsConf 2023 Opening Keynote] The Magic of Rails
eileencodes
9
8.3k
YesSQL, Process and Tooling at Scale
rocio
164
13k
Designing the Hi-DPI Web
ddemaree
276
33k
Transcript
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
None
CI͔Β؆୯ʹPull requestͰ͖Δ
None
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ ਆΛࣗಈԽ͍ͨ͠ʂʂ
ͳͥpr-daikouͳͷ͔ʁ • Sider (࣌SideCI)͋Δ͚Ͳɺ privateϦϙδτϦͷΈ • Ͱ͖Δ͚ͩ҆͘(λμͰ)࣮ݱ͍ͨ͠ • circleci-bundle-update-prͰCI͔Β PRͰ͖ΔݟΛಘͨ
None
ͳΜͰࣗಈԽ͍ͨ͠ CommitΕ • db/schema.rb • annotate_models Lint • rubocop —auto-correct
• eslint —fix Library update • bundle update • yarn upgrade
None
ຊʹ΄͔ͬͨ͠ͷ PRΛ࡞ͬͯ͘ΕΔػೳ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
ৼΓฦΓͰؾΛ͚ͭΑ͏ͱ ͯ͠खಈ͡ΌΕΔ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch CIΕͣඞͣͬͯ͘Εͯ PRΛϚʔδ͢Δ͚ͩʹͳΔ
·ͱΊ • LinterͷAutocorrectΦϓγϣϯਆػೳ • ਓΕΔੜ͖ͳͷͰcommit͢Δલʹ ࣮ߦ͍ͯͩ͘͠͞φϯηϯε • PRΛϚʔδ͢Δ͚ͩͱ͍͏ମݧʹམͱ ͠ࠐΉͷ͕େ
͍͞͝ʹ
Enjoy pr-daikou!