Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
CircleCIからPull requestできるといろいろ捗る
Search
rvillage
July 29, 2018
Technology
0
470
CircleCIからPull requestできるといろいろ捗る
rvillage
July 29, 2018
Tweet
Share
Other Decks in Technology
See All in Technology
AIプロダクトのプロンプト実践テクニック / Practical Techniques for AI Product Prompts
saka2jp
0
110
Building a cloud native business on open source
lizrice
0
170
JSConf JPのwebsiteをGatsbyからNext.jsに移行した話 - Next.jsの多言語静的サイトと課題
leko
2
180
オブザーバビリティと育てた ID管理・認証認可基盤の歩み / The Journey of an ID Management, Authentication, and Authorization Platform Nurtured with Observability
kaminashi
1
570
だいたい分かった気になる 『SREの知識地図』 / introduction-to-sre-knowledge-map-book
katsuhisa91
PRO
3
1.4k
オブザーバビリティが育むシステム理解と好奇心
maruloop
1
960
AI時代、“平均値”ではいられない
uhyo
8
2.5k
Implementing and Evaluating a High-Level Language with WasmGC and the Wasm Component Model: Scala’s Case
tanishiking
0
180
Okta Identity Governanceで実現する最小権限の原則 / Implementing the Principle of Least Privilege with Okta Identity Governance
tatsumin39
0
170
Azureコストと向き合った、4年半のリアル / Four and a half years of dealing with Azure costs
aeonpeople
1
280
クラウドとリアルの融合により、製造業はどう変わるのか?〜クラスメソッドの製造業への取組と共に〜
hamadakoji
0
410
入院医療費算定業務をAIで支援する:包括医療費支払い制度とDPCコーディング (公開版)
hagino3000
0
110
Featured
See All Featured
The Cult of Friendly URLs
andyhume
79
6.6k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
48
9.7k
Scaling GitHub
holman
463
140k
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
12
1.2k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
16
1.7k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
52
5.7k
The Success of Rails: Ensuring Growth for the Next 100 Years
eileencodes
46
7.7k
How GitHub (no longer) Works
holman
315
140k
jQuery: Nuts, Bolts and Bling
dougneiner
65
7.9k
Fireside Chat
paigeccino
41
3.7k
Optimising Largest Contentful Paint
csswizardry
37
3.5k
Build The Right Thing And Hit Your Dates
maggiecrowley
38
2.9k
Transcript
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
None
CI͔Β؆୯ʹPull requestͰ͖Δ
None
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ ਆΛࣗಈԽ͍ͨ͠ʂʂ
ͳͥpr-daikouͳͷ͔ʁ • Sider (࣌SideCI)͋Δ͚Ͳɺ privateϦϙδτϦͷΈ • Ͱ͖Δ͚ͩ҆͘(λμͰ)࣮ݱ͍ͨ͠ • circleci-bundle-update-prͰCI͔Β PRͰ͖ΔݟΛಘͨ
None
ͳΜͰࣗಈԽ͍ͨ͠ CommitΕ • db/schema.rb • annotate_models Lint • rubocop —auto-correct
• eslint —fix Library update • bundle update • yarn upgrade
None
ຊʹ΄͔ͬͨ͠ͷ PRΛ࡞ͬͯ͘ΕΔػೳ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
ৼΓฦΓͰؾΛ͚ͭΑ͏ͱ ͯ͠खಈ͡ΌΕΔ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch CIΕͣඞͣͬͯ͘Εͯ PRΛϚʔδ͢Δ͚ͩʹͳΔ
·ͱΊ • LinterͷAutocorrectΦϓγϣϯਆػೳ • ਓΕΔੜ͖ͳͷͰcommit͢Δલʹ ࣮ߦ͍ͯͩ͘͠͞φϯηϯε • PRΛϚʔδ͢Δ͚ͩͱ͍͏ମݧʹམͱ ͠ࠐΉͷ͕େ
͍͞͝ʹ
Enjoy pr-daikou!