Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
CircleCIからPull requestできるといろいろ捗る
Search
rvillage
July 29, 2018
Technology
0
450
CircleCIからPull requestできるといろいろ捗る
rvillage
July 29, 2018
Tweet
Share
Other Decks in Technology
See All in Technology
サービスの持続的な成長と技術負債について
siva_official
PRO
10
4.4k
Android研修【MIXI 24新卒技術研修】
mixi_engineers
PRO
0
100
フルリモートワークはエンジニアの夢を叶えたか? #cm_odyssey
mamohacy
2
600
[I/O Extended Android 2024] What`s new in Android 2024
kyeongwan
0
220
Azure OpenAI Service Dev Day / LLMでできる!使える!生成AIエージェント
masahiro_nishimi
3
810
GoとアクターモデルでES+CQRSを実践! / proto_actor_es_cqrs
ytake
1
160
目標設定は好きですか? アジャイルとともに目標と向き合い続ける方法 / Do you like target Management?
kakehashi
10
3k
簡単に始めるSnowflakeの機械学習
nayuts
1
190
サービス開発を前に進めるために 新米リードエンジニアが 取り組んだこと / Steps Taken by a Novice Lead Engineer to Advance Service Development
nologyance
0
180
[NIKKEI Tech Talk]Bias for Action!! 実践から学ぶための仕組とコミュニティ / Community for Practice and Learning
kanamasa
0
280
ゆめみのアクセシビリティの現在地と今後
ryokatsuse
3
290
E2Eテスト自動化プラットフォームにおけるAIの活用
shift_evolve
0
190
Featured
See All Featured
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
soudai
149
45k
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
26
1.8k
A Philosophy of Restraint
colly
200
16k
YesSQL, Process and Tooling at Scale
rocio
166
14k
Scaling GitHub
holman
458
140k
Why Our Code Smells
bkeepers
PRO
332
56k
ReactJS: Keep Simple. Everything can be a component!
pedronauck
662
120k
Music & Morning Musume
bryan
43
5.9k
Become a Pro
speakerdeck
PRO
15
4.8k
The Pragmatic Product Professional
lauravandoore
29
6.1k
Keith and Marios Guide to Fast Websites
keithpitt
408
22k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
29
2.5k
Transcript
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
None
CI͔Β؆୯ʹPull requestͰ͖Δ
None
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ ਆΛࣗಈԽ͍ͨ͠ʂʂ
ͳͥpr-daikouͳͷ͔ʁ • Sider (࣌SideCI)͋Δ͚Ͳɺ privateϦϙδτϦͷΈ • Ͱ͖Δ͚ͩ҆͘(λμͰ)࣮ݱ͍ͨ͠ • circleci-bundle-update-prͰCI͔Β PRͰ͖ΔݟΛಘͨ
None
ͳΜͰࣗಈԽ͍ͨ͠ CommitΕ • db/schema.rb • annotate_models Lint • rubocop —auto-correct
• eslint —fix Library update • bundle update • yarn upgrade
None
ຊʹ΄͔ͬͨ͠ͷ PRΛ࡞ͬͯ͘ΕΔػೳ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
ৼΓฦΓͰؾΛ͚ͭΑ͏ͱ ͯ͠खಈ͡ΌΕΔ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch CIΕͣඞͣͬͯ͘Εͯ PRΛϚʔδ͢Δ͚ͩʹͳΔ
·ͱΊ • LinterͷAutocorrectΦϓγϣϯਆػೳ • ਓΕΔੜ͖ͳͷͰcommit͢Δલʹ ࣮ߦ͍ͯͩ͘͠͞φϯηϯε • PRΛϚʔδ͢Δ͚ͩͱ͍͏ମݧʹམͱ ͠ࠐΉͷ͕େ
͍͞͝ʹ
Enjoy pr-daikou!