Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
CircleCIからPull requestできるといろいろ捗る
Search
rvillage
July 29, 2018
Technology
0
470
CircleCIからPull requestできるといろいろ捗る
rvillage
July 29, 2018
Tweet
Share
Other Decks in Technology
See All in Technology
敢えて生成AIを使わないマネジメント業務
kzkmaeda
2
450
CRE Camp #1 エンジニアリングを民主化するCREチームでありたい話
mntsq
1
130
Enhancing SaaS Product Reliability and Release Velocity through Optimized Testing Approach
ropqa
1
230
Glacierだからってコストあきらめてない? / JAWS Meet Glacier Cost
taishin
1
160
United Airlines Customer Service– Call 1-833-341-3142 Now!
airhelp
0
170
開発生産性を測る前にやるべきこと - 組織改善の実践 / Before Measuring Dev Productivity
kaonavi
10
4.7k
第4回Snowflake 金融ユーザー会 Snowflake summit recap
tamaoki
1
290
スタートアップに選択肢を 〜生成AIを活用したセカンダリー事業への挑戦〜
nstock
0
210
american aa airlines®️ USA Contact Numbers: Complete 2025 Support Guide
aaguide
0
210
Beyond Kaniko: Navigating Unprivileged Container Image Creation
f30
0
130
Geminiとv0による高速プロトタイピング
shinya337
1
270
Delta airlines®️ USA Contact Numbers: Complete 2025 Support Guide
airtravelguide
0
340
Featured
See All Featured
Adopting Sorbet at Scale
ufuk
77
9.5k
Keith and Marios Guide to Fast Websites
keithpitt
411
22k
Making the Leap to Tech Lead
cromwellryan
134
9.4k
Embracing the Ebb and Flow
colly
86
4.7k
RailsConf 2023
tenderlove
30
1.1k
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
eileencodes
35
2.4k
Java REST API Framework Comparison - PWX 2021
mraible
31
8.7k
The Power of CSS Pseudo Elements
geoffreycrofte
77
5.9k
Reflections from 52 weeks, 52 projects
jeffersonlam
351
20k
Gamification - CAS2011
davidbonilla
81
5.4k
Rebuilding a faster, lazier Slack
samanthasiow
82
9.1k
Facilitating Awesome Meetings
lara
54
6.4k
Transcript
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
None
CI͔Β؆୯ʹPull requestͰ͖Δ
None
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ ਆΛࣗಈԽ͍ͨ͠ʂʂ
ͳͥpr-daikouͳͷ͔ʁ • Sider (࣌SideCI)͋Δ͚Ͳɺ privateϦϙδτϦͷΈ • Ͱ͖Δ͚ͩ҆͘(λμͰ)࣮ݱ͍ͨ͠ • circleci-bundle-update-prͰCI͔Β PRͰ͖ΔݟΛಘͨ
None
ͳΜͰࣗಈԽ͍ͨ͠ CommitΕ • db/schema.rb • annotate_models Lint • rubocop —auto-correct
• eslint —fix Library update • bundle update • yarn upgrade
None
ຊʹ΄͔ͬͨ͠ͷ PRΛ࡞ͬͯ͘ΕΔػೳ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
ৼΓฦΓͰؾΛ͚ͭΑ͏ͱ ͯ͠खಈ͡ΌΕΔ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch CIΕͣඞͣͬͯ͘Εͯ PRΛϚʔδ͢Δ͚ͩʹͳΔ
·ͱΊ • LinterͷAutocorrectΦϓγϣϯਆػೳ • ਓΕΔੜ͖ͳͷͰcommit͢Δલʹ ࣮ߦ͍ͯͩ͘͠͞φϯηϯε • PRΛϚʔδ͢Δ͚ͩͱ͍͏ମݧʹམͱ ͠ࠐΉͷ͕େ
͍͞͝ʹ
Enjoy pr-daikou!