Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
CircleCIからPull requestできるといろいろ捗る
Search
rvillage
July 29, 2018
Technology
0
460
CircleCIからPull requestできるといろいろ捗る
rvillage
July 29, 2018
Tweet
Share
Other Decks in Technology
See All in Technology
Amazon SageMaker Unified Studio(Preview)、Lakehouse と Amazon S3 Tables
ishikawa_satoru
0
150
Postman と API セキュリティ / Postman and API Security
yokawasa
0
200
継続的にアウトカムを生み出し ビジネスにつなげる、 戦略と運営に対するタイミーのQUEST(探求)
zigorou
0
520
権威ドキュメントで振り返る2024 #年忘れセキュリティ2024
hirotomotaguchi
2
730
プロダクト開発を加速させるためのQA文化の築き方 / How to build QA culture to accelerate product development
mii3king
1
260
AI時代のデータセンターネットワーク
lycorptech_jp
PRO
1
280
Snykで始めるセキュリティ担当者とSREと開発者が楽になる脆弱性対応 / Getting started with Snyk Vulnerability Response
yamaguchitk333
2
180
サーバレスアプリ開発者向けアップデートをキャッチアップしてきた #AWSreInvent #regrowth_fuk
drumnistnakano
0
190
統計データで2024年の クラウド・インフラ動向を眺める
ysknsid25
2
840
10個のフィルタをAXI4-Streamでつなげてみた
marsee101
0
160
CustomCopを使ってMongoidのコーディングルールを整えてみた
jinoketani
0
220
第3回Snowflake女子会_LT登壇資料(合成データ)_Taro_CCCMK
tarotaro0129
0
180
Featured
See All Featured
Building a Modern Day E-commerce SEO Strategy
aleyda
38
7k
Music & Morning Musume
bryan
46
6.2k
Why Our Code Smells
bkeepers
PRO
335
57k
Statistics for Hackers
jakevdp
796
220k
XXLCSS - How to scale CSS and keep your sanity
sugarenia
247
1.3M
Fantastic passwords and where to find them - at NoRuKo
philnash
50
2.9k
Six Lessons from altMBA
skipperchong
27
3.5k
Keith and Marios Guide to Fast Websites
keithpitt
410
22k
Code Review Best Practice
trishagee
65
17k
It's Worth the Effort
3n
183
28k
Being A Developer After 40
akosma
87
590k
Into the Great Unknown - MozCon
thekraken
33
1.5k
Transcript
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
None
CI͔Β؆୯ʹPull requestͰ͖Δ
None
CircleCI͔Β Pull requestͰ͖Δͱ ͍Ζ͍ΖḿΔ TokyuRubyձٞ12 2018-07-29 () Masayuki Kawamura |
@rvillage
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ
ͳͥpr-daikouͳͷ͔ʁ • RuboCop͕͖͚ͩͲࢦఠ ͢ͷ͍ͨΜ • RuboCopʹAutocorrectΦ ϓγϣϯͰࣗಈमਖ਼ͯ͘͠Ε Δਆػೳ͕͋Δ ਆΛࣗಈԽ͍ͨ͠ʂʂ
ͳͥpr-daikouͳͷ͔ʁ • Sider (࣌SideCI)͋Δ͚Ͳɺ privateϦϙδτϦͷΈ • Ͱ͖Δ͚ͩ҆͘(λμͰ)࣮ݱ͍ͨ͠ • circleci-bundle-update-prͰCI͔Β PRͰ͖ΔݟΛಘͨ
None
ͳΜͰࣗಈԽ͍ͨ͠ CommitΕ • db/schema.rb • annotate_models Lint • rubocop —auto-correct
• eslint —fix Library update • bundle update • yarn upgrade
None
ຊʹ΄͔ͬͨ͠ͷ PRΛ࡞ͬͯ͘ΕΔػೳ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ rubocop —auto-correct͔ͯ͠Β commit͢ΔΑ͏ʹ͠·͠ΐ͏ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢ schema.rbΕͣ commit͍ͯͩ͘͠͞ Ε͍ͯͨͷͰɺՃͰ commit͓͖ͯ͠·͢
ৼΓฦΓͰؾΛ͚ͭΑ͏ͱ ͯ͠खಈ͡ΌΕΔ
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch
None
ͳʹ͕ͦΜͳʹḿΔͷ͔ʁ git push origin branch git commit -m “rubocop —auto-correct”
git push origin ci/branch bin/rails db:create db:migrate git commit -m “Update schema.rb” git push origin ci/branch CIΕͣඞͣͬͯ͘Εͯ PRΛϚʔδ͢Δ͚ͩʹͳΔ
·ͱΊ • LinterͷAutocorrectΦϓγϣϯਆػೳ • ਓΕΔੜ͖ͳͷͰcommit͢Δલʹ ࣮ߦ͍ͯͩ͘͠͞φϯηϯε • PRΛϚʔδ͢Δ͚ͩͱ͍͏ମݧʹམͱ ͠ࠐΉͷ͕େ
͍͞͝ʹ
Enjoy pr-daikou!