Androidアプリの 安全なリファクタリングを行うパターン集

Transcript

1. גࣜձࣾϊϋφɹ੉ށ༏೭ "OESPJEΞϓϦͷ
   ҆શͳϦϑΝΫλϦϯάΛߦ͏ύλʔϯू

2. )JSP:6,*
   4FUP גࣜձࣾϊϋφ
   .PCJMF
   5FDI
   -FBE
   "OESPJE
   &OHJOFFS !
   TFUP@IJ !
   IJSPZVLJTFUP 

3. None

4. w ίʔυϕʔεͷ࡮৽ํ๏ൺֱ
   w ϑϧεΫϥον
   ͱ
   ϦϑΝΫλϦϯά
   w ϦϑΝΫλϦϯάͰى͜Γ͕ͪͳ໰୊ͱରࡦ
   w ҆શͳϦϑΝΫλϦϯάͱ͸
   w .7$ΞϓϦͷ҆શͳϦϑΝΫλϦϯά

   ΞδΣϯμ 

5. ͸͡Ίʹ 

6. w ඞͣϦϑΝΫλϦϯάͰίʔυΛ௚ͤʂͱ͸ࢥ͍ͬͯͳ͍
   w ϝϦοτσϝϦοτΛߟ͑Δ΂͖
   w ؀ڥɾ৔໘ʹΑͬͯҟͳΔ
   w εΫϥονͱϦϑΝΫλϦϯάͷ૊Έ߹Θͤ΋˕
   w ࠓճ͸ϦϑΝΫλϦϯάͷࣦഊΛݮΒ͢ϙΠϯτͷ঺հ
   

   w ઈରʹࣦഊ͠ͳ͘ͳΔํ๏͸ͳ͍ ͸͡Ίʹ 

7. w ςετΛॻ͜͏
   w ഁյతมߋͨ͠Βͦͷ෦෼Λݕূ͠Α͏ ൃදͷཁ໿ 

8. ίʔυϕʔεͷ࡮৽ํ๏ൺֱ 

9. w طଘίʔυΛࣺ͔ͯͯΒཧ૝ܕʹॻ͖௚͢
   w ˓
   ͕͠ΒΈ͕ͳ͘։ൃ଎౓΋ग़΍͍͢
   w ˚
   ৽نόάΛ࢓ࠐΉՄೳੑ
   w ˚
   ݱߦ࢓༷͕೺ѲͰ͖͍ͯͳ͍ͱ೉͍͠
   w ࢓༷Λ֬ೝ͢Δ͕࣌ؒඞཁ
   

   w ҙਤ͠ͳ͍σάϨͷՄೳੑ ϑϧεΫϥον 

10. w طଘίʔυΛॻ͖׵͑ͯཧ૝ܕʹ͍࣋ͬͯ͘
    w ˓
    ࢓༷Λ೺Ѳ͍ͯ͠ͳͯ͘΋Ͱ͖Δ
    w ϦϑΝΫλͯ͠ίʔυ͔Β࢓༷ΛಡΈղ͘
    w ˚
    ৽نόά طଘόάʹۤ͠ΉՄೳੑ
    w

    ˚
    طଘ࣮૷ʹҾͬுΒΕͯ։ൃ଎౓͕ग़ͳ͍Մೳੑ ϦϑΝΫλϦϯά 

11. ൺֱද  ϑϧεΫϥον ϦϑΝΫλϦϯά ޻਺ɾ։ൃ଎౓ ޻਺
    গ
    ։ൃ଎౓
    ˓ ޻਺
    ଟ
    ։ൃ଎౓
    ˚ ࢓༷ҡ࣋

    ˚ 
 ҙਤ͠ͳ͍σάϨΛ͢ΔՄೳੑ ˓ όά ΤϯόάͷՄೳੑ Τϯόά 
 طଘόάΛܧଓͷՄೳੑ ͦͷଞ ݱঢ়࢓༷Λ೺Ѳ͍ͯ͠ͳ͍ͱ೉ ࣮૷͠ͳ͕Β࢓༷೺Ѳ͔Մ

12. ϦϑΝΫλϦϯάͰ
    ى͜Γ͕ͪͳ໰୊ͱରࡦ 

13. w ֎෦ಈ࡞࢓༷
    
    Ϣʔβʔʹݟ͑Δಈ࡞
    w ඇഁյతมߋ
    w ಺෦ಈ࡞ʹ΋Өڹ͕ͳ͍ϝιου΍Ϋϥεͷ੔ཧ
    w ഁյతมߋ
    w ಺෦ಈ࡞͸มΘ͕ͬͨ֎෦ಈ࡞࢓༷͸มΘ͍ͬͯͳ͍৔߹
    

    w ྫɿΞϧΰϦζϜมߋɺ+TPO
    1BSTFSมߋ
    w ಺෦ಈ࡞΋֎෦ಈ࡞࢓༷΋มΘΔ৔߹
    w ྫɿ࢓༷มߋɺϥΠϑαΠΫϧมߋɺϝϞϦϦʔΫमਖ਼ ඇഁյతมߋ
    
    ഁյతมߋ 

14. w ͱʹ͔͘طଘಈ࡞͕յΕΔ
    w ͪΐͬͱม͚͑ͨͩͳͷʹյΕͨ
    w յΕͳ͍͸ͣͷमਖ਼ͰյΕͨ
    w ૝ఆ֎ͷ෦෼͕ಈ͔ͳ͘ͳͬͨ ى͜Γ͕ͪͳ໰୊ 

15. w ૝ఆ͍ͯ͠ͳ͍ഁյతมߋ
    w ϦϑϨΫγϣϯɺੜ੒ίʔυͷࢀর
    w ϥΠϒϥϦͷΞοϓσʔτ
    w $IBOHF
    MPHʹͳ͍मਖ਼
    w ଞΞϓϦ΍'SBNFXPSLͱͷ࿈ܞ
    

    w ݕূ͕೉͍͠໰୊
    w ϥΠϑαΠΫϧɺඇಉظॲཧ
    w ෳ߹తͳཁҼ ૝ఆ֎ͷݪҼ  ରࡦ͸೉͍͠

16. w ݕূΛखް͘΍Ε͹໰୊͸ग़ʹ͘͘ͳΔ
    w 㱻
    ݕূϦιʔε͕ඞཁʹͳΔ
    w ഁյతมߋʹΑͬͯಈ࡞͕յΕ͍ͯΔ
    w ඇഁյతมߋͰ͸ಈ࡞͸มΘΒͳ͍
    w ݕূΛബͯ͘͠΋໰୊͸ग़ʹ͍͘͸ͣ
    

    w ഁյతมߋΛݕূ͢Ε͹໰୊͕ݟ͔ͭΓ΍͍͢͸ͣ
    w ಺෦ಈ࡞͕ҙਤͨ͠௨Γ
    w ֎෦ಈ࡞࢓༷͕ҙਤͨ͠௨Γ ݪҼ෼ੳͱରࡦ 

17. w ഁյతมߋ
    
    ඇഁյతมߋΛ໌֬ʹ͢Δ
    w मਖ਼ޙͷಈ࡞ΛݕূͰ͖Δঢ়ଶʹ͢Δ
    w ՄೳͳݶΓࣗಈςετͰݕূ͢Δ
    w ഁյతมߋΛͨ͠఺Λݕূ͢Δ
    w ಺෦ಈ࡞͕ҙਤͨ͠΋ͷͰ͋Δ͜ͱ
    

    w ಺෦ಈ࡞Λม͑ͯ΋֎෦ಈ࡞࢓༷͕ಉҰͰ͋Δ͜ͱ
    w ֎෦ಈ࡞࢓༷͕ҙਤͨ͠΋ͷͰ͋Δ͜ͱ ҆શͳϦϑΝΫλϦϯά 

18. w ҆શͳϦϑΝΫλϦϯάͷͨΊʹܭըΛཱͯΔ
    w ணखલʹΰʔϧ·ͰͷεςοϓΛ෼ׂ͢Δ
    w ΰʔϧ΁ͷํ޲ੑ͕ͳ͍ঢ়ଶͰ͸໎૸͕ͪ͠
    w ഁյతมߋ
    
    ඇഁյతมߋΛࠞͥͳ͍
    w εςοϓͷഁյతมߋΛগͳ͘͢Δ
    

    w ݕূΛ؆୯ʹ͢ΔͨΊ εςοϓ෼ׂ 

19. w ✅
    ͦͷεςοϓʹΑͬͯݕূ͕Ͱ͖ΔΑ͏ʹͳΔ͔
    w ✅
    ഁյతมߋ͔
    w ✅
    Ͳ͕͜ഁյతมߋ͔
    w ✅
    ഁյతมߋʹݕূํ๏͕͋Δ͔ εςοϓ෼ׂνΣοΫϙΠϯτ 

20. w 㲈
    ςετ͕ॻ͚ΔΑ͏ʹͳΔ͔
    w ϦϑΝΫλϦϯά͢ΔͳΒ͹໨ࢦ͢΂͖ΰʔϧ
    w ࣗಈςετͰಈ࡞อূͰ͖Ε͹खಈͷݕূίετ͕ݮΔ
    w मਖ਼ͨ͠ίʔυ͕ҙਤͨ͠ಈ࡞Λ͍ͯ͠Δ͔ͷݕূ
    w ඇഁյతมߋͳΒ͹ಈ࡞ʹมߋ͸ͳ͍͸ͣ
    

    w ݕূΛ௥Ճͤͣ໨ઌͷ։ൃ଎౓ΛٻΊΔ͜ͱ΋Մ ✅
    ݕূ͕Ͱ͖ΔΑ͏ʹͳΔ͔ 

21. w ಈ࡞͕มΘͬͨ఺͕͋Δ͔
    w ಺෦ಈ࡞͸มΘ͕ͬͨ֎෦ಈ࡞࢓༷͸มΘ͍ͬͯͳ͍৔߹
    w ಺෦ಈ࡞΋֎෦ಈ࡞࢓༷΋มΘΔ৔߹ ✅
    ഁյతมߋ͔ 

22. w ಺෦࣮૷
    w εΫϥον։ൃ
    w ΞϧΰϦζϜมߋ
    w ґଘϥΠϒϥϦมߋ
    w +BWB
    ˠ
    ,PUMJO
    ͷOVMMBCJMJUZ
    

    w ֎෦ಈ࡞࢓༷
    w "OESPJEͷϥΠϑαΠΫϧมߋ
    w ΞϓϦͷ࢓༷ ✅
    Ͳ͕͜ഁյతมߋ͔ 

23. w ಺෦ಈ࡞͸มΘ͕ͬͨ֎෦ಈ࡞࢓༷͸มΘ͍ͬͯͳ͍৔߹
    w มߋલͱมߋޙͷಈ࡞͕ಉҰͰ͋Δ͜ͱͷݕূ
    w ಺෦ಈ࡞΋֎෦ಈ࡞࢓༷΋มΘΔ৔߹
    w ҙਤ௨Γಈ͘͜ͱͷݕূ
    w ݕূํ๏
    

    w ࣗಈςετ
    6OJU
    5FTUɺ6*
    5FTUɺ7JTVBM
    3FHSFTTJPO
    5FTU
    w खಈςετͰͷݕূɺ2"Ͱͷݕূ
    w શͯͷมߋΛݕূ͢Δͷ͸ෆՄ ✅
    ഁյతมߋʹݕূํ๏͕͋Δ͔ 

24. w ૝ఆ͍ͯ͠ͳ͍ഁյతมߋ
    w ϦϑϨΫγϣϯɺੜ੒ίʔυͷࢀর
    w ϥΠϒϥϦͷΞοϓσʔτ
    w $IBOHF
    MPHʹͳ͍मਖ਼
    w ଞΞϓϦ΍'SBNFXPSLͱͷ࿈ܞ
    

    w ݕূ͕೉͍͠໰୊
    w ϥΠϑαΠΫϧ
    w ෳ߹తͳཁҼ ૝ఆ֎ͷݪҼ  ରࡦ͸೉͍͠

25. w ϦΞʔΩςΫνϟͷࡍ 
 "OESPJEͰ͸σʔλ૚͔Βணख͢Δͱྑ͍ εςοϓ෼ׂ
    UJQT  ݹ͍%BUB૚ ৽͍͠6*૚ ݺͼग़͠ ෆ҆ఆͳ݁Ռ
    

    ѻ͍ʹ͍͘ܕ ෆ҆ఆͳ݁Ռ
    Λߟྀ࣮ͨ͠૷

26. w ϦΞʔΩςΫνϟͷࡍ 
 "OESPJEͰ͸σʔλ૚͔Βணख͢Δͱྑ͍ εςοϓ෼ׂ
    UJQT  ৽͍͠%BUB૚ ݹ͍6*૚ ݺͼग़͠ ҆ఆͨ݁͠Ռ

    6*૚࡮৽ͷࡍ
    ҆ఆ࣮ͨ͠૷

27. .7$ΞϓϦͷϦϑΝΫλϦϯά 

28. w IUUQTHJUIVCDPNIJSPZVLJTFUPESPJELBJHJTBNQMF
    w NBJO͕ݩͷίʔυ
    w ϦϑΝΫλϦϯάͨ͠΋ͷͰ13
    w ϘλϯΛԡ͢ͱ௨৴ͯ͠ 
 3FTQPOTF$PEFΛදࣔ

    αϯϓϧϦϙδτϦ 

29. αϯϓϧίʔυ  ελʔτ ΰʔϧ ΞʔΩςΫνϟ .7$ .77.
    
 3FDPNNFOEFE
    "QQ
    "SDI 7JFXૢ࡞

    "DUJWJUZͰૢ࡞ %BUB
    #JOEJOH
    ""$
    7JFX.PEFM
    
    -JWF%BUB ௨৴ॲཧ "DUJWJUZʹ΂ͨॻ͖ 3FNPUF
    %BUB
    TPVSDF ඇಉظॲཧ "TZOD5BTL %FQSFDBUFE $PSPVUJOF

30. w IUUQTEFWFMPQFSBOESPJEDPNKFUQBDLHVJEFSFDPNNFOEFEBQQBSDI 3FDPNNFOEFE
    "QQ
    "SDIJUFDUVSF 

31. αϯϓϧίʔυ  'SBHNFOU "TZOD5BTL 8FCTFSWJDF 'SBHNFOU 7JFX.PEFM 3FQPTJUPSZ 3FNPUF%BUB4PVSDF 8FCTFSWJDF

    -JWF%BUB ελʔτ ΰʔϧ

32. αϯϓϧίʔυ ελʔτ 'SBHNFOU

33.  3FNPUF
    %BUB
    TPVSDFͷ࡞੒
     3FQPTJUPSZͷ࡞੒
     7JFX.PEFMͷಋೖ
     -JWF%BUBͷಋೖ
     .77.Խ
    

     $PSPVUJOFԽ εςοϓ෼ׂ 

34. 4UFQ
    3FNPUF%BUB4PVSDFͷ࡞੒  'SBHNFOU "TZOD5BTL 8FCTFSWJDF 3FNPUF%BUB4PVSDF 8FCTFSWJDF #FGPSF "GUFS 'SBHNFOU

    "TZOD5BTL

35. 4UFQ
    3FNPUF%BUB4PVSDFͷ࡞੒ 

36. w ඇഁյతมߋ
    w ॲཧͷΫϥε੾Γग़͠ͷΈ
    w 0L)UUQ$MJFOUΛΫϥεม਺ʹ͕ͨ͠ɺ4UFQͷ࣮૷ͳΒඇഁյత
    w 3FNPUF%BUB4PVSDFͷΠϯελϯεΛ࢖͍ճ͢ͱഁյత 4UFQ
    3FNPUF%BUB4PVSDFͷ࡞੒ 

37. w ௨৴෦෼ͷ࣮૷͕ෛ࠴ͳ͜ͱ΋ଟʑ
    w ϦϑΝΫλ͢Δʹ͸
    w ςετΛॻ͍ͯϦΫΤετ΍ϨεϙϯεͷQBSTF݁ՌΛอূ͢Δ
    w ෛ࠴ΫϥεΛॻ͖׵͍͑ͯ͘
    w NPDLLͷTMPUΛ࢖ͬͯ௨৴पΓͷෛ࠴ղফͷϦϑΝΫλϦϯάΛ͢Δ
    

    w IUUQTRJJUBDPNIJSPZVLJTFUPJUFNTFFCGFG ༨ஊ
    ௨৴෦෼΋ॻ͖׵͍͑ͨ 

38. ϒϥοΫϘοΫεͷ௚͠ํ  ϒϥοΫϘοΫε ݺͼग़͠ ݁Ռ 8SBQQFSΫϥε ݺͼग़͠ ݺͼग़͠ ݁Ռ ݁Ռ

    ςετͰอূ ςετ ݺͼग़͠ ݁Ռ ྑ͍࣮૷ ݺͼग़͠ ݁Ռ "OESPJE
    ςετશॻ
    1
    /FUXPSL6UJMTͷྫ

39. 4UFQ
    3FQPTJUPSZͷ࡞੒  3FQPTJUPSZ 8FCTFSWJDF #FGPSF "GUFS 'SBHNFOU "TZOD5BTL 3FNPUF%BUB4PVSDF 3FNPUF%BUB4PVSDF

    8FCTFSWJDF 'SBHNFOU "TZOD5BTL

40. 4UFQ
    3FQPTJUPSZͷ࡞੒ 

41. w ඇഁյతมߋ
    w Ϋϥε੾Γग़͠ͷΈ
    w ݕূͷ௥Ճ
    w 6OJU
    5FTU͕ॻ͚ΔΑ͏ʹͳΔ 4UFQ
    3FQPTJUPSZͷ࡞੒ 

42. 6OJU
    5FTU 

43. 4UFQ
    7JFX.PEFMͷಋೖ  3FQPTJUPSZ 8FCTFSWJDF #FGPSF "GUFS 'SBHNFOU "TZOD5BTL 3FNPUF%BUB4PVSDF 3FQPTJUPSZ

    8FCTFSWJDF 'SBHNFOU "TZOD5BTL 3FNPUF%BUB4PVSDF 7JFX.PEFM

44. 4UFQ
    7JFX.PEFMͷಋೖ  'SBHNFOU

45. 4UFQ
    7JFX.PEFMͷಋೖ  w ֎෦ಈ࡞࢓༷͸ಉҰͳഁյతมߋ
    w ճ໨ͷ࣮ߦ࣌ʹ3FQPTJUPSZ͕࢖͍ճ͞ΕΔ
    w ഁյతมߋͷݕূ
    w ճ໨ͷ࣮ߦ΋֎෦ಈ࡞࢓༷͕ಉҰͰ͋Δ͜ͱ
    

    w 6*
    5FTUɺखಈςετͳͲ
    w ʮճ໨ͷ࣮ߦͰ΋ҙਤͨ͠ಈ࡞ʯͷ6*
    5FTU͸ෆໟͳͷͰखಈ͕Α͍

46. w ϦϑΝΫλϦϯάͷ్தͰઃܭͱͯ͠ඍົʹͳΔ͜ͱ΋
    w ʮݕূ͢ΔͨΊʯʮ࠷ऴతʹ៉ྷʹͳΔʯͱׂΓ੾Δ
    w தؒঢ়ଶͷ··Ͱ์ஔ͸ઈରʹආ͚Δ
    w ࠷ॳʹνʔϜϝϯόʔʹमਖ਼ํ਑Λڞ༗͢Δ ϙΠϯτ
    தؒঢ়ଶΛݏ͕Βͳ͍ 

47. 4UFQ
    -JWF%BUBͷಋೖ  'SBHNFOU 7JFX.PEFM 3FQPTJUPSZ 3FNPUF%BUB4PVSDF 8FCTFSWJDF -JWF%BUB #FGPSF "GUFS

    3FQPTJUPSZ 8FCTFSWJDF 'SBHNFOU "TZOD5BTL 3FNPUF%BUB4PVSDF 7JFX.PEFM "TZOD5BTL

48. 4UFQ
    -JWF%BUBͷಋೖ  'SBHNFOU "TZOD5BTL 7JFX.PEFM

49. w ֎෦ಈ࡞࢓༷΋มΘΔഁյతมߋ
    w PO4UBSUͱPO4UPQͷ͔ؒ͠6*͕൓ө͞Εͳ͍
    w ݕূͷ௥Ճ
    w 6OJUςετ
    w -JWF%BUBʹ஋͕ೖ͍ͬͯΔ͜ͱͷ֬ೝ
    

    w ഁյతมߋͷݕূ
    w खಈ֬ೝ
    w ࣗಈςετ͕೉͍͠ϥΠϑαΠΫϧؔ࿈ 4UFQ
    -JWF%BUBͷಋೖ 

50. w ֎෦࢓༷͸ಉҰͳഁյతมߋ
    w 7JFXͱͷ΍ΓͱΓ͕%BUB#JOEJOHܦ༝ʹ
    w ഁյతมߋͷݕূ
    w 6*
    5FTUJOH
    w .77.ԽલޙͰಉ͡6*ςετ͕ಈ࡞͢Δ͜ͱ
    

    w खಈςετ
    w 6*
    5FTUͰΧόʔ͖͠Εͳ͍෦෼ 4UFQ
    .77.Խ 

51. w
    6*
    5FTU 

52. 4UFQ
    $PSPVUJOFԽ  #FGPSF "GUFS 'SBHNFOU 7JFX.PEFM 3FQPTJUPSZ 3FNPUF%BUB4PVSDF 8FCTFSWJDF -JWF%BUB

    'SBHNFOU 7JFX.PEFM 3FQPTJUPSZ 3FNPUF%BUB4PVSDF 8FCTFSWJDF -JWF%BUB "TZOD5BTL

53. 4UFQ
    $PSPVUJOFԽ  7JFX.PEFM

54. w ֎෦࢓༷΋มΘΔഁյతมߋ
    w "TZOD5BTLˠ$PSPVUJOFͰඇಉظॲཧ͕ࠜຊ͔ΒมΘΔ
    w 7JFX.PEFMPO$MFBS 'SBHNFOUPO%FTUSPZ Ͱඇಉظॲཧऴྃ
    w "TZOD5BTL࣌୅ͷϝϞϦϦʔΫमਖ਼
    

    w ഁյతมߋͷݕূ
    w "TZOD5BTLΛ$PSPVUJOFʹஔ͖׵͑ͯ6OJU
    5FTU͕௨Δ͜ͱ
    w खಈςετ
    ϥΠϑαΠΫϧ PO%FTUSPZ 4UFQ
    $PSPVUJOFԽ 

55. αϯϓϧίʔυ  'SBHNFOU "TZOD5BTL 8FCTFSWJDF 'SBHNFOU 7JFX.PEFM 3FQPTJUPSZ 3FNPUF%BUB4PVSDF 8FCTFSWJDF

    -JWF%BUB #FGPSF "GUFS

56. w 'SBNFXPSL΍ϥΠϒϥϦͷಈ࡞Λ஌Δ
    w ഁյతมߋΛݟམͱ͢Մೳੑ͕ݮΔ
    w "OESPJEͰ͸ಛʹϥΠϑαΠΫϧΛҙࣝ͢Δ
    w ಺෦࣮૷ΛಡΉͷ͕Φεεϝ ϙΠϯτ
    ಈ࡞Λ஌Δ 

57. w ΤϥʔΛચ͍ग़ͯ͠ॲཧํ๏ΛܾΊΔ
    w ϦΞʔΩςΫνϟͷࡍ͸ॲཧ͢Δ૚ΛܾΊΔ
    w IUUQTTQFBLFSEFDLDPNLHNZTIJOBOESPJEBQQFSSPSIBOEMJOH ϙΠϯτΤϥʔॲཧ 

58. ·ͱΊ 

59. w ܭըΛཱͯͯϦϑΝΫλϦϯάΛ͠Α͏
    w ςετΛॻ͜͏
    w ഁյతมߋͨ͠Βͦͷ෦෼Λݕূ͠Α͏ ൃදͷཁ໿ 

60. ׬