Getting the most out of code review

Code reviews are one of the best ways to improve code quality - however, they can be even more complex than writing the code itself. This talk will help you understand how to conduct effective code reviews and benefit from a strong peer review culture.

Transcript

1. Getting the most out of code review Stephanie Wagner, Software Developer at Namely Twitter: @stephwagner Email: stephanie.wagner@namely.com
3. Why code reviews? • Find bugs • Better quality code • Better developers • Mentoring • Transparency
4. How to perform a code review well • Read the issue before reviewing code • Asking questions encourages discussion • Be supportive and helpful.
5. What to look for • Test coverage • Duplicate code • Security • Anything else!
6. How can the author make code reviews better? • Each set of changes should be one coherent thought • Good version control comments • Self-documenting code • Be a “team lead” in your own task
7. Coding Standards • Developers know what to expect • Keeps code reviews efficient • Improved development speed
8. How teams perform code reviews
9. Volunteer-basis/Pull Requests
11. Volunteer-basis/Pull Requests • Efficient, does not interrupt developer • Everyone can participate • Fits neatly into existing workflows
12. Group Code Reviews
13. Group Code Reviews • Require meetings • Can take up a lot of time
17. Group Code Reviews • Requires meetings • Can take up a lot of time • Can drift into problem-solving • Not necessarily more effective than previous method
18. Pair Reviews • Allows interaction • Can be used for mentoring new developers • Author can skip a change • Review is driven by the developer
19. Pair Programming Pair Programming != Code Review
20. Any code review is better than nothing
21. Thank you! Stephanie Wagner @stephwagner stephanie.wagner@namely.com