Crowdsourcing code reviews

Pitching the use of gerrit as a code review tool for the LibreOffice project
LibreOffice conference, Paris, October 2011

Transcript

1. 1 Crowdsourcing code review Crowdsourcing code reviews Bjoern Michaelsen, Canonical Ltd. bjoern.michaelsen@canonical.com
2. 2 Crowdsourcing code review Patch Workflow
3. 3 Crowdsourcing code review Patches Lost in Space A patch is intended to: Be mailed to the dev@-mailinglist Being picked up by a developer with commit rights and be Checked for a valid license Reviewed for Goodness Applied, Build, Tested and Pushed Reported back to the mailing list that this is in now Reality: fdo#40946
4. 4 Crowdsourcing code review http://upload.wikimedia.org/wikipedia/commons/7/71/US_Navy_100627-N-5319A-218_Sailors_and_Marines_leap_from_the_well_deck_of_the_amphibious_transport_dock_ship_USS_New_Orleans_%28LPD_18%29_after_participating_in_the_Crossing ine_ceremony.jpg By US Navy and thus public domain
5. 5 Crowdsourcing code review Broken Windows
6. 6 Crowdsourcing code review http://upload.wikimedia.org/wikipedia/commons/d/d3/Broken_window_large.jpg CC-BY-SA3 by Tomas Castelazo
7. 7 Crowdsourcing code review Does it hurt? Duplication of work Frustration Scaring away newcomers Makes some kinds of work very hard or painful for everyone
8. 8 Crowdsourcing code review Tinderboxes
9. 9 Crowdsourcing code review Tinderboxes are useless Tinderboxes are useless … … when the master has been already broken and still receives commits.
10. 10 Crowdsourcing code review http://upload.wikimedia.org/wikipedia/commons/1/18/US_Navy_091212-N-3404S-106_Navy_defensive_end_Jabaree_Tuani_%28%5E98%29_and_nose_guard_Chase_Burge_%28%5E93%29_stop_Army_slot_back_Patrick_Mealy_%28%5E5%29_dur
11. 11 Crowdsourcing code review Tinderboxes are Annoying and Scary Tinderboxes are annoying. Tinderboxes are scary. Tinderboxes are ugly.
12. 12 Crowdsourcing code review Tinderboxes are Lemmings Tinderboxes have different speeds. Tinderboxes know nothing of each other. Tinderboxes cant communicate or coordinate. The slowest and rarest tinderboxes (Windows) are the most valueable.
13. 13 Crowdsourcing code review Tinderboxes are Lemmings
14. 14 Crowdsourcing code review Gerrit
15. 15 Crowdsourcing code review Live Demo (if you are not seeing a demo, you are not at the conference)
16. 16 Crowdsourcing code review How does Gerrit help? Possibilities with Gerrit: Automatic Patch Uploads Automatic Contribution License Checks Human Review Tinderbox Review Testsuite Review Thus: Find errors early and before they cause too much pain.
17. 17 Crowdsourcing code review Gerrit Status Test instance on gerrit-test.libreoffice.org Local test instances Tested workflows Indentified required hardware specifications Rent a matching machine Create all the scripting and magic to let it play together.
18. 18 Crowdsourcing code review All text and image content in this document is licensed under the Creative Commons Attribution-Share Alike 3.0 License (unless otherwise specified). "LibreOffice" and "The Document Foundation" are registered trademarks. Their respective logos and icons are subject to international copyright laws. The use of these therefore is subject to the trademark policy. Thank you!