Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Zen Code Reviews

Avatar for Xavier F. Gouchet Xavier F. Gouchet
April 20, 2017
Video
Programming
27
0

Zen Code Reviews

A lightning talk on how to do code reviews without getting into a conflict with coworkers…

Avatar for Xavier F. Gouchet

Xavier F. Gouchet

April 20, 2017

Video

More Decks by Xavier F. Gouchet

See All by Xavier F. Gouchet
Writing a Kotlin Compiler Plugin
Avatar for Xavier F. Gouchet xgouchet
0
80
Being an ethical software engineer
Avatar for Xavier F. Gouchet xgouchet
0
350
Libérez votre créativité
Avatar for Xavier F. Gouchet xgouchet
0
180
Unleash your Programming Creativity
Avatar for Xavier F. Gouchet xgouchet
0
230
Demystifying the Test Pyramid
Avatar for Xavier F. Gouchet xgouchet
1
760
Successfully Publishing a Tested, Upgradeable and Documented Open Source Library
Avatar for Xavier F. Gouchet xgouchet
0
150
Property Based Testing in Practice
Avatar for Xavier F. Gouchet xgouchet
0
130
Develop your CI tools
Avatar for Xavier F. Gouchet xgouchet
2
510
How to write a safe and reliable Open Source Library
Avatar for Xavier F. Gouchet xgouchet
1
360

Other Decks in Programming

See All in Programming
属人化した知識を、 AIが辿れる地図にする
Avatar for PKSHA Technology（パークシャテクノロジー） pkshadeck
PRO
1
190
わからない話を追いかけたら、プログラミング言語を作る側にいた
Avatar for ydah ydah
3
520
AIを紡ぐPMのお話
Avatar for swdtkuy swdtkuy
0
120
Terraform標準の組織で AWS CDKをどう使うか
Avatar for mu7889yoon / Yuta Nakamura mu7889yoon
1
530
言葉の格闘技のススメ～紙とペンと言葉から始める、キャリアの描き方～
Avatar for 進捗ゼミ progresscicada
2
160
VibeCodingからAgenticWorkflowへ
Avatar for starfish719 starfish719
0
650
関東Kaggler会_NVIDIA_Nemotron_コンペ_振り返り
Avatar for rick rick_ds
0
660
php-fpmのプロセスが枯渇した日-調査・対処・そして本当にやるべきだったこと-
Avatar for にわ shibuchaaaan
0
320
torikago - Ruby::Boxで照らすモジュラモノリスの実行境界
Avatar for nori se4weed
1
390
リアルな遅延を測る仕様
Avatar for kota-yata kota_yata
1
120
夏だ！祭りだ！祭りとはドメインモデリングでは？
Avatar for ryugen04 ryugen04
0
320
5分で問診！Composer セキュリティ健康診断
Avatar for コドモン開発チーム codmoninc
0
1.1k

Featured

See All Featured
For a Future-Friendly Web
Avatar for Brad Frost brad_frost
183
10k
The Pragmatic Product Professional
Avatar for Laura Van Doore lauravandoore
37
7.4k
Building a Modern Day 
E-commerce SEO Strategy
Avatar for Aleyda Solis aleyda
45
9.2k
Balancing Empowerment & Direction
Avatar for Lara Hogan lara
6
1.2k
RailsConf 2023
Avatar for Aaron Patterson tenderlove
30
1.5k
Everyday Curiosity
Avatar for Cassini Nazir cassininazir
0
290
Code Reviewing Like a Champion
Avatar for maltzj maltzj
528
40k
The Web Performance Landscape in 2024 [PerfNow 2024]
Avatar for Tammy Everts tammyeverts
12
1.3k
Into the Great Unknown - MozCon
Avatar for Noah Learner thekraken
41
2.7k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
Avatar for Tammy Everts tammyeverts
11
990
Statistics for Hackers
Avatar for Jake VanderPlas jakevdp
799
230k
What does AI have to do with Human Rights?
Avatar for Per Axbom axbom
PRO
1
2.3k

Transcript

  1. Zen Code Reviews The (fast) way towards painless code reviews

    CodeMobile UK 2017 - Chester

  2. Why ◎ Find defects early ◎ Harmonize code base ◎

    Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet

  3. ◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎

    Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet

  4. Reviewable Code ◎ Keep the commits short ◎ git add

    --patch ◎ Use a proper commit message ◦ CR Brief ◎ Review your own code @xgouchet

  5. Commenting on issues ◎ Be precise ◦ “This uses too

    much memory…” ◎ Argument ◦ “… because this object is not retained when …” ◎ Help fix it ◦ “You could instead use …” ◎ Define criticity ◦ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad

  6. Best behavior ◎ Stay open minded ◎ Make it about

    the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet