Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Zen Code Reviews
Search
Xavier F. Gouchet
PRO
April 20, 2017
Video
Programming
0
4
Zen Code Reviews
A lightning talk on how to do code reviews without getting into a conflict with coworkers…
Xavier F. Gouchet
PRO
April 20, 2017
Tweet
Share
Video
More Decks by Xavier F. Gouchet
See All by Xavier F. Gouchet
Being an ethical software engineer
xgouchet
PRO
0
260
Libérez votre créativité
xgouchet
PRO
0
110
Unleash your Programming Creativity
xgouchet
PRO
0
170
Demystifying the Test Pyramid
xgouchet
PRO
1
500
Successfully Publishing a Tested, Upgradeable and Documented Open Source Library
xgouchet
PRO
0
110
Property Based Testing in Practice
xgouchet
PRO
0
82
Develop your CI tools
xgouchet
PRO
2
400
How to write a safe and reliable Open Source Library
xgouchet
PRO
1
270
Benchmarking your app's performance
xgouchet
PRO
0
220
Other Decks in Programming
See All in Programming
Rubyでやりたい駆動開発 / Ruby driven development
chobishiba
1
740
設計やレビューに悩んでいるPHPerに贈る、クリーンなオブジェクト設計の指針たち
panda_program
6
2.2k
AI時代の『改訂新版 良いコード/悪いコードで学ぶ設計入門』 / ai-good-code-bad-code
minodriven
20
7.9k
Is Xcode slowly dying out in 2025?
uetyo
1
280
Azure AI Foundryではじめてのマルチエージェントワークフロー
seosoft
0
190
Blazing Fast UI Development with Compose Hot Reload (droidcon New York 2025)
zsmb
1
300
ペアプロ × 生成AI 現場での実践と課題について / generative-ai-in-pair-programming
codmoninc
2
19k
状態遷移図を書こう / Sequence Chart vs State Diagram
orgachem
PRO
1
130
AIエージェントはこう育てる - GitHub Copilot Agentとチームの共進化サイクル
koboriakira
0
600
生成AI時代のコンポーネントライブラリの作り方
touyou
1
240
Composerが「依存解決」のためにどんな工夫をしているか #phpcon
o0h
PRO
1
270
Modern Angular with Signals and Signal Store:New Rules for Your Architecture @enterJS Advanced Angular Day 2025
manfredsteyer
PRO
0
230
Featured
See All Featured
Let's Do A Bunch of Simple Stuff to Make Websites Faster
chriscoyier
507
140k
The Language of Interfaces
destraynor
158
25k
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
44
2.4k
GitHub's CSS Performance
jonrohan
1031
460k
The Cult of Friendly URLs
andyhume
79
6.5k
A Tale of Four Properties
chriscoyier
160
23k
Stop Working from a Prison Cell
hatefulcrawdad
271
21k
Building Applications with DynamoDB
mza
95
6.5k
Making the Leap to Tech Lead
cromwellryan
134
9.4k
KATA
mclloyd
30
14k
Learning to Love Humans: Emotional Interface Design
aarron
273
40k
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
46
9.6k
Transcript
Zen Code Reviews The (fast) way towards painless code reviews
CodeMobile UK 2017 - Chester
Why ◎ Find defects early ◎ Harmonize code base ◎
Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet
◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎
Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet
Reviewable Code ◎ Keep the commits short ◎ git add
--patch ◎ Use a proper commit message ◦ CR Brief ◎ Review your own code @xgouchet
Commenting on issues ◎ Be precise ◦ “This uses too
much memory…” ◎ Argument ◦ “… because this object is not retained when …” ◎ Help fix it ◦ “You could instead use …” ◎ Define criticity ◦ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad
Best behavior ◎ Stay open minded ◎ Make it about
the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet