Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Zen Code Reviews
Search
Xavier F. Gouchet
PRO
April 20, 2017
Video
Programming
0
1
Zen Code Reviews
A lightning talk on how to do code reviews without getting into a conflict with coworkers…
Xavier F. Gouchet
PRO
April 20, 2017
Tweet
Share
Video
More Decks by Xavier F. Gouchet
See All by Xavier F. Gouchet
Being an ethical software engineer
xgouchet
PRO
0
210
Libérez votre créativité
xgouchet
PRO
0
94
Unleash your Programming Creativity
xgouchet
PRO
0
140
Demystifying the Test Pyramid
xgouchet
PRO
1
450
Successfully Publishing a Tested, Upgradeable and Documented Open Source Library
xgouchet
PRO
0
82
Property Based Testing in Practice
xgouchet
PRO
0
63
Develop your CI tools
xgouchet
PRO
2
380
How to write a safe and reliable Open Source Library
xgouchet
PRO
1
260
Benchmarking your app's performance
xgouchet
PRO
0
200
Other Decks in Programming
See All in Programming
Building a macOS screen saver with Kotlin (Android Makers 2025)
zsmb
1
150
国漢文混用体からHolloまで
minhee
1
180
AWSで雰囲気でつくる! VRChatの写真変換ピタゴラスイッチ
anatofuz
0
150
Agentic Applications with Symfony
el_stoffel
2
280
Devinのメモリ活用の学びを自社サービスにどう組み込むか?
itarutomy
0
2.1k
State of Namespace
tagomoris
4
1k
リアクティブシステムの変遷から理解するalien-signals / Learning alien-signals from the evolution of reactive systems
yamanoku
3
1.2k
Code smarter, not harder - How AI Coding Tools Boost Your Productivity | Webinar 2025
danielsogl
0
120
SQL Server ベクトル検索
odashinsuke
0
170
List とは何か? / PHPerKaigi 2025
meihei3
0
810
Do Dumb Things
mitsuhiko
0
430
タイムゾーンの奥地は思ったよりも闇深いかもしれない
suguruooki
1
610
Featured
See All Featured
Product Roadmaps are Hard
iamctodd
PRO
52
11k
Building a Modern Day E-commerce SEO Strategy
aleyda
40
7.2k
Into the Great Unknown - MozCon
thekraken
37
1.7k
Rails Girls Zürich Keynote
gr2m
94
13k
Fireside Chat
paigeccino
37
3.4k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
30
2k
Why Our Code Smells
bkeepers
PRO
336
57k
A better future with KSS
kneath
239
17k
Writing Fast Ruby
sferik
628
61k
GitHub's CSS Performance
jonrohan
1030
460k
"I'm Feeling Lucky" - Building Great Search Experiences for Today's Users (#IAC19)
danielanewman
227
22k
Designing Experiences People Love
moore
141
24k
Transcript
Zen Code Reviews The (fast) way towards painless code reviews
CodeMobile UK 2017 - Chester
Why ◎ Find defects early ◎ Harmonize code base ◎
Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet
◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎
Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet
Reviewable Code ◎ Keep the commits short ◎ git add
--patch ◎ Use a proper commit message ◦ CR Brief ◎ Review your own code @xgouchet
Commenting on issues ◎ Be precise ◦ “This uses too
much memory…” ◎ Argument ◦ “… because this object is not retained when …” ◎ Help fix it ◦ “You could instead use …” ◎ Define criticity ◦ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad
Best behavior ◎ Stay open minded ◎ Make it about
the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet