Zen Code Reviews

A lightning talk on how to do code reviews without getting into a conflict with coworkers…

Transcript

1. Zen Code Reviews The (fast) way towards painless code reviews CodeMobile UK 2017 - Chester
2. Why ◎ Find defects early ◎ Harmonize code base ◎ Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet
3. ◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎ Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet
4. Reviewable Code ◎ Keep the commits short ◎ git add --patch ◎ Use a proper commit message ◦ CR Brief ◎ Review your own code @xgouchet
5. Commenting on issues ◎ Be precise ◦ “This uses too much memory…” ◎ Argument ◦ “… because this object is not retained when …” ◎ Help fix it ◦ “You could instead use …” ◎ Define criticity ◦ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad
6. Best behavior ◎ Stay open minded ◎ Make it about the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet