Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Zen Code Reviews
Search
Xavier F. Gouchet
PRO
April 20, 2017
Video
Programming
0
6
Zen Code Reviews
A lightning talk on how to do code reviews without getting into a conflict with coworkers…
Xavier F. Gouchet
PRO
April 20, 2017
Tweet
Share
Video
More Decks by Xavier F. Gouchet
See All by Xavier F. Gouchet
Being an ethical software engineer
xgouchet
PRO
0
280
Libérez votre créativité
xgouchet
PRO
0
120
Unleash your Programming Creativity
xgouchet
PRO
0
180
Demystifying the Test Pyramid
xgouchet
PRO
1
540
Successfully Publishing a Tested, Upgradeable and Documented Open Source Library
xgouchet
PRO
0
110
Property Based Testing in Practice
xgouchet
PRO
0
84
Develop your CI tools
xgouchet
PRO
2
420
How to write a safe and reliable Open Source Library
xgouchet
PRO
1
280
Benchmarking your app's performance
xgouchet
PRO
0
230
Other Decks in Programming
See All in Programming
@Environment(\.keyPath)那么好我不允许你们不知道! / atEnvironment keyPath is so good and you should know it!
lovee
0
120
FindyにおけるTakumi活用と脆弱性管理のこれから
rvirus0817
0
530
AWS発のAIエディタKiroを使ってみた
iriikeita
1
190
How Android Uses Data Structures Behind The Scenes
l2hyunwoo
0
480
Compose Multiplatform × AI で作る、次世代アプリ開発支援ツールの設計と実装
thagikura
0
170
Amazon RDS 向けに提供されている MCP Server と仕組みを調べてみた/jawsug-okayama-2025-aurora-mcp
takahashiikki
1
110
パッケージ設計の黒魔術/Kyoto.go#63
lufia
3
440
The Past, Present, and Future of Enterprise Java
ivargrimstad
0
410
Introducing ReActionView: A new ActionView-compatible ERB Engine @ Rails World 2025, Amsterdam
marcoroth
0
710
Improving my own Ruby thereafter
sisshiki1969
1
160
Ruby Parser progress report 2025
yui_knk
1
450
ファインディ株式会社におけるMCP活用とサービス開発
starfish719
0
2k
Featured
See All Featured
Agile that works and the tools we love
rasmusluckow
330
21k
Chrome DevTools: State of the Union 2024 - Debugging React & Beyond
addyosmani
7
850
KATA
mclloyd
32
14k
A designer walks into a library…
pauljervisheath
207
24k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
26
3k
GraphQLの誤解/rethinking-graphql
sonatard
72
11k
Measuring & Analyzing Core Web Vitals
bluesmoon
9
580
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
162
15k
Principles of Awesome APIs and How to Build Them.
keavy
126
17k
GitHub's CSS Performance
jonrohan
1032
460k
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
eileencodes
36
2.5k
Mobile First: as difficult as doing things right
swwweet
224
9.9k
Transcript
Zen Code Reviews The (fast) way towards painless code reviews
CodeMobile UK 2017 - Chester
Why ◎ Find defects early ◎ Harmonize code base ◎
Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet
◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎
Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet
Reviewable Code ◎ Keep the commits short ◎ git add
--patch ◎ Use a proper commit message ◦ CR Brief ◎ Review your own code @xgouchet
Commenting on issues ◎ Be precise ◦ “This uses too
much memory…” ◎ Argument ◦ “… because this object is not retained when …” ◎ Help fix it ◦ “You could instead use …” ◎ Define criticity ◦ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad
Best behavior ◎ Stay open minded ◎ Make it about
the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet