Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Zen Code Reviews
Search
Xavier F. Gouchet
PRO
April 20, 2017
Video
Programming
0
6
Zen Code Reviews
A lightning talk on how to do code reviews without getting into a conflict with coworkers…
Xavier F. Gouchet
PRO
April 20, 2017
Tweet
Share
Video
More Decks by Xavier F. Gouchet
See All by Xavier F. Gouchet
Being an ethical software engineer
xgouchet
PRO
0
280
Libérez votre créativité
xgouchet
PRO
0
120
Unleash your Programming Creativity
xgouchet
PRO
0
180
Demystifying the Test Pyramid
xgouchet
PRO
1
540
Successfully Publishing a Tested, Upgradeable and Documented Open Source Library
xgouchet
PRO
0
110
Property Based Testing in Practice
xgouchet
PRO
0
84
Develop your CI tools
xgouchet
PRO
2
420
How to write a safe and reliable Open Source Library
xgouchet
PRO
1
280
Benchmarking your app's performance
xgouchet
PRO
0
230
Other Decks in Programming
See All in Programming
AIを活用し、今後に備えるための技術知識 / Basic Knowledge to Utilize AI
kishida
22
5.9k
より安全で効率的な Go コードへ: Protocol Buffers Opaque API の導入
shwatanap
2
720
さようなら Date。 ようこそTemporal! 3年間先行利用して得られた知見の共有
8beeeaaat
3
1.5k
AIコーディングAgentとの向き合い方
eycjur
0
280
アプリの "かわいい" を支えるアニメーションツールRiveについて
uetyo
0
280
個人開発で徳島大学生60%以上の心を掴んだアプリ、そして手放した話
akidon0000
1
140
AI Coding Agentのセキュリティリスク:PRの自己承認とメルカリの対策
s3h
0
230
機能追加とリーダー業務の類似性
rinchoku
2
1.3k
Design Foundational Data Engineering Observability
sucitw
3
200
AI時代のUIはどこへ行く?
yusukebe
18
9k
Introducing ReActionView: A new ActionView-compatible ERB Engine @ Rails World 2025, Amsterdam
marcoroth
0
710
アセットのコンパイルについて
ojun9
0
130
Featured
See All Featured
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
162
15k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
31
2.2k
Building Better People: How to give real-time feedback that sticks.
wjessup
368
19k
Measuring & Analyzing Core Web Vitals
bluesmoon
9
580
Agile that works and the tools we love
rasmusluckow
330
21k
Code Review Best Practice
trishagee
71
19k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
35
3.1k
Fantastic passwords and where to find them - at NoRuKo
philnash
52
3.4k
How to train your dragon (web standard)
notwaldorf
96
6.2k
ピンチをチャンスに:未来をつくるプロダクトロードマップ #pmconf2020
aki_iinuma
127
53k
Speed Design
sergeychernyshev
32
1.1k
Build The Right Thing And Hit Your Dates
maggiecrowley
37
2.9k
Transcript
Zen Code Reviews The (fast) way towards painless code reviews
CodeMobile UK 2017 - Chester
Why ◎ Find defects early ◎ Harmonize code base ◎
Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet
◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎
Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet
Reviewable Code ◎ Keep the commits short ◎ git add
--patch ◎ Use a proper commit message ◦ CR Brief ◎ Review your own code @xgouchet
Commenting on issues ◎ Be precise ◦ “This uses too
much memory…” ◎ Argument ◦ “… because this object is not retained when …” ◎ Help fix it ◦ “You could instead use …” ◎ Define criticity ◦ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad
Best behavior ◎ Stay open minded ◎ Make it about
the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet