Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Zen Code Reviews

Zen Code Reviews

A lightning talk on how to do code reviews without getting into a conflict with coworkers…

Xavier F. Gouchet

April 20, 2017
Tweet

Video

More Decks by Xavier F. Gouchet

Other Decks in Programming

Transcript

  1. Why ◎ Find defects early ◎ Harmonize code base ◎

    Generate discussion ◎ Share knowledge ◎ Team Building @xgouchet
  2. ◎ Pre vs Post Commit ◎ Mandatory vs Optional ◎

    Remote vs Pair Review ◎ Static Analysis Workflows @xgouchet
  3. Reviewable Code ◎ Keep the commits short ◎ git add

    --patch ◎ Use a proper commit message ◦ CR Brief ◎ Review your own code @xgouchet
  4. Commenting on issues ◎ Be precise ◦ “This uses too

    much memory…” ◎ Argument ◦ “… because this object is not retained when …” ◎ Help fix it ◦ “You could instead use …” ◎ Define criticity ◦ “Itʼs not critical and can be done in a later commit” @xgouchet This is bad This is bad
  5. Best behavior ◎ Stay open minded ◎ Make it about

    the code ◎ Share knowledge ◎ Give as much as you receive @xgouchet