Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
How to get your pull requests merged
Search
Yasuo Honda
May 30, 2019
Technology
9
830
How to get your pull requests merged
Yasuo Honda
May 30, 2019
Tweet
Share
More Decks by Yasuo Honda
See All by Yasuo Honda
RailsのPostgreSQL 18対応
yahonda
0
1.4k
Contributing to Rails? Start with the Gems You Already Use
yahonda
2
180
PostgreSQL 18 cancel request key長の変更とRailsへの関連
yahonda
0
220
extensionとschema
yahonda
1
270
NOT VALIDな検査制約 / check constraint that is not valid
yahonda
1
210
今、始める、第一歩。 / Your first step
yahonda
3
1.3k
RailsのPull requestsのレビューの時に私が考えていること
yahonda
11
7.3k
pg_stat_statementsで inの数が違うSQLをまとめて ほしい
yahonda
0
250
遅延可能な一意性制約
yahonda
0
1.1k
Other Decks in Technology
See All in Technology
「AI駆動PO」を考えてみる - 作る速さから価値のスループットへ:検査・適応で未来を開発 / AI-driven product owner. scrummat2025
yosuke_nagai
1
490
Goのビルドシステムの変遷 / The history of Go's build system
ymotongpoo
12
3.8k
“2件同時配達”の開発舞台裏 〜出前館PMが挑んだダブルピック実現に向けた体験設計〜
demaecan
0
180
PythonとLLMで挑む、 4コマ漫画の構造化データ化
esuji5
1
130
From Prompt to Product @ How to Web 2025, Bucharest, Romania
janwerner
0
110
ACA でMAGI システムを社内で展開しようとした話
mappie_kochi
0
160
Geospatialの世界最前線を探る [2025年版]
dayjournal
3
470
BirdCLEF+2025 Noir 5位解法紹介
myso
0
180
Green Tea Garbage Collector の今
zchee
PRO
2
380
PLaMo2シリーズのvLLM実装 / PFN LLM セミナー
pfn
PRO
2
910
about #74462 go/token#FileSet
tomtwinkle
1
270
Trust as Infrastructure
bcantrill
0
290
Featured
See All Featured
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
45
2.5k
ピンチをチャンスに:未来をつくるプロダクトロードマップ #pmconf2020
aki_iinuma
127
53k
The Cost Of JavaScript in 2023
addyosmani
53
9k
Making Projects Easy
brettharned
118
6.4k
Statistics for Hackers
jakevdp
799
220k
No one is an island. Learnings from fostering a developers community.
thoeni
21
3.5k
How STYLIGHT went responsive
nonsquared
100
5.8k
StorybookのUI Testing Handbookを読んだ
zakiyama
31
6.2k
The World Runs on Bad Software
bkeepers
PRO
71
11k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
52
5.6k
Navigating Team Friction
lara
189
15k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
tammyeverts
9
570
Transcript
How to get your pull requests merged ۜ࠲Rails#9 2019/05/30 @yahonda
ࣗݾհͱ2ͭͷࢹ • Rails contributor • Maintainer of Active Record Oracle
enhanced adapter • Pull requestΛૹΔཱͱड͚औΔཱ
͢͜ͱɺ͞ͳ͍͜ͱ • ͢͜ͱ • RailsϑϨʔϜϫʔΫͷ։ൃମ੍ • Railsʹpull requestΛૹΔͱ͖ʹ͢Δ͜ͱɺ͠ͳ͍͜ͱ • ͞ͳ͍͜ͱ
• ίʔυ • https://railsguides.jp/contributing_to_ruby_on_rails.html
͋ͳͨͳͥRailsʹpull requestΛ͓͘Δͷ͔
͋ͳͨͷ՝Λղܾ͢ΔͨΊ
ͦͷͨΊʹඞཁͳ͜ͱ
ͦͷpull request͕Railsʹऔ Γࠐ·ΕΔ͖ཧ༝Λίϛο λʔʹೲಘͯ͠Β͏͜ͱ
RailsϑϨʔϜϫʔΫ։ൃମ੍ • ϦϦʔεεέδϡʔϧ • ίϛϡχςΟ • Pull requestΛϚʔδͰ͖Δͷ୭͔ • ݴޠ
• ࣌ࠩ
͋ͳͨͷRailsΞϓϦέʔγϣ ϯ։ൃମ੍ͱಉ͡ͱ͜Ζ͋ Δ͠ɺҧ͏ͱ͜Ζ͋Δ
ϦϦʔεεέδϡʔϧ • RailsͷϦϦʔεαΠΫϧ • Major, Minor: ୯ҐɺTeeny: ݄୯Ґ • Ծʹࠓɺpull
requestϚʔδ͞Εͯೖͬͨ৽ػೳ͕Ϧ Ϧʔε͞ΕΔͷRails 6.1(͓ͦΒ͘2020Ҏ߱) • ͋ͳͨͷRailsΞϓϦέʔγϣϯͷϦϦʔεαΠΫϧ ɺ͓ͦΒͦ͘ΕΑΓ͍ͣ
ίϛϡχςΟ • DHH / Rails core / Rails committer •
Rails contributors • ಉ͡ձࣾ/৫ͰຖҰॹʹ͍ΔΘ͚Ͱͳ͍ • ίϛϡχςΟϝϯόʔ͕RailsʹٻΊΔͷͦΕͧΕҟ ͳΔ • ͋ͳ͕ͨRailsʹٻΊΔͷΛΘ͔ͬͯΒ͏ඞཁ͕͋Δ
Pull requestΛϚʔδ͢Δͷ • ࠷େ18ਓͷRailsίϛολʔ • ΞΫςΟϒͳίϛολʔͬͱগͳ͍ • 700Ҏ্ͷopen pull requests
• 39 pull requests / ίϛολʔ • ͋ͳͨͷRailsΞϓϦέʔγϣϯͷϨϏϡʔମ੍ͱൺͯΈ ·͠ΐ͏
ݴޠ • Ruby • ίʔυ • ӳޠ • ίϛοτϝοηʔδ •
Pull requestͰͷΓͱΓ
࣌ࠩ • Rails ίϛολʔੈքதʹ͍Δ • ͋ͳͨͷ৸͍ͯΔؒʹpull request͕ϨϏϡʔ ͞ΕΔ͔͠Εͳ͍
Railsʹpull requestΛૹΔ ࣌ɺͦͯ͠ૹͬͨޙʹͳʹΛ ͢Δ͔ɺ͠ͳ͍͔
Pull requestΦʔϓϯ͢Δ࣌ʹ • Pull requestΛϚʔδ͢Δཧ༝Λઆ໌͍ͯ͠Δ͔ • ͋ͳͨͷ՝͔ͩΒཧ༝આ໌Ͱ͖Δͣ • Ͱ͖Δ͜ͱΛΔɺͰ͖Δ͜ͱΔ •
ʮ͍ͭͷ͔ૹΔʯͬͯ͜ͳ͍͔͠Εͳ͍ • ʮ͜͏ͩͬͨΒ͍͍ͷʹʯͱ͍͏ίϝϯτΛॻ͘ͳ Βɺগ͠Ͱͦͷʮ͜͏ʯΛίʔυʹ͢Δ
Pull requestΛΦʔϓϯͨ͠ޙ • ͋ͤΒͳ͍ͰԠΛͭ • Ϛʔδͯ͠Β͏ͨΊʹඞཁͳใΛॻ͖ ͍ͬͯΕɺޙ͢Δ͜ͱͳ͍ͣ
ϨϏϡʔ࣭͕དྷͨΒ • Pull requestͰίʔυ͔ӳޠͰճ͢Δ • ڵຯΛ࣋ͨΕ͍ͯΔؒʹճ͢Δ • ϨϏϡʔ࣭Λແࢹ͠ͳ͍
ෳਓ͔Βίϝϯτ͕དྷͨΒ • ίϛολʔʹೲಘͯ͠Β͏͜ͱʹྗ͢Δ • Ϛʔδ͢Δݖݶͷͳ͍ਓΛઆಘͯ͠ํ͕ ͳ͍ɺͱ͍͏ݱ࣮͋Δ • ͘ͳΕͳΔ΄Ͳऩर͕͚ͭʹ͍͘
ϨϏϡʔ͕Θ͔Βͳ͔ͬͨΒ • Θ͔͍ͬͯΔ෦ΛαϚϦʔͯ͠ฦࣄ͢Δ • Βͳ͔ͬͨ͜ͱʹରͯ͠Sorryͱ͍Θͳ͍ • Βͳ͔ͬͨ͜ͱΛڭ͑ͯ͘Εͨ͜ͱʹײँ Λ͠ɺͦΕΛ;·͑ͨίʔυมߋΛ͢Δ
ϨϏϡʔʹࢍͰ͖ͳ͔ͬͨΒ • ࢍͰ͖ͳ͍ཧ༝Λॻ͘ • ʮϨϏϡʔ͋Γ͕ͱ͏ɺͰࢲ͜Ε͕ ΈʯͰΑ͍ • ୯७ʹແࢹ͠ͳ͍
୭͔ΒԿͷԠͳ͔ͬͨΒ • ΈΜͳ͕͏Ձ͕͋Δͷͩͱpull request ୯ಠͰઆ໌͍ͯ͠Δ͔ɺ͏͍ͪͲಡΜͰΈ ·͠ΐ͏ • ͋ͳͨͷϢʔεέʔεઆ໌͞Ε͍ͯ·͔͢ • ڵຯΛҾ͘pull
requestͰ͋ΕɺԿ͔͠Βͷ Ԡ͕͋Δͣ
Pull requestͷϝϯςφϯε • ίϯϑϦΫτΛղফ͓ͯ͘͠ • CIgreenʹ͓ͯ͘͠
Pull request͕ෆཁʹͳͬͨΒ • Ϋϩʔζ͢Δ • ʮࢲ͏ཁΒͳ͍͚Ͳɺଞͷ୭͔͕ඞཁ͔ ͠Εͳ͍ʯͱ͍͏ͷߟ͑ͳͯ͘Α͍
Pull requestΛΦʔϓϯͨ͠ޙ ʹΒͳ͍͜ͱ • ping͠ͳ͍ / any updates? ͱ͔͍Θͳ͍ •
ʮϚʔδ͖͢ཧ༝ʯΛҰͭઆ໌͍ͯ͠ͳ ͍͔Β
Ϛʔδ͞ΕͣΫϩʔζ͞ΕͨΒ • Ϋϩʔζ͞Εͨissuepull requestʹίϝϯτ ͠ͳ͍ • ʮࣺͯࢺʯ͔͔ͳ͍
Ϋϩʔζ͞Εͨpull requestΛ ࠶νϟϨϯδͨ͘͠ͳͬͨΒ • ͍ͬͨΜΫϩʔζ͞Εͨpull requestͱಉ͡ࡐ Λ෮׆ͤ͞ΔͷࠔͰ͋Δ • ͕࣌ؒܦͭͷΛͭ •
ൣғΛখ͘͢͞ΔɺΞϓϩʔνΛม͑Δ • அ͕มΘΔ͔͠Εͳ͍ɺલఏ͕มΘΔ͔ ͠Εͳ͍ɺϝϯςφʔ͕ସΘΔ͔͠Εͳ͍
Pull request͕Ϛʔδ͞ΕͨΒ • https://contributors.rubyonrails.org • https://y-yagi.hatenablog.com • ࣍ͷRails͕ϦϦʔε͞ΕΔͷΛͪ·͠ΐ͏ • ͋ͳͨͷcommitͷੵΈॏͶͰɺ͋ͳͨRails
ίϛϡχςΟʹΒΕ͍ͯ͘Α͏ʹͳΓ·͢
OSSύονձͲ͏ͧ ࣍ճ6݄6