The Labyrinth of How to Write RSpec Pending Reasons

MNTSQの！RubyKaigi 2023 AfterParty！「The Labyrinth of How to Write RSpec Pending Reasons」のスライド
https://techplay.jp/event/907561 #rubykaigiafterparty

Transcript

1. Yudai Takada RubyKaigi 2023 After Party 2023.06.22 (Thu) The Labyrinth of How to Write RSpec Pending Reasons
2. ɾ Name: Yudai Takada ɾ GitHub: @ydah ɾ Twitter: @ydah_ ɾ Member of RuboCop RSpec team ɾ Software Engineer at ANDPAD, Inc. self.inspect
3. ݐஙɾݐઃۀʹಛԽͨ͠Ϋϥ΢υαʔϏε ఏڙ
4. ⼤阪Ruby会議03 "Rubyで笑おう" 2023-09-09 (Sat) 2023-06-23 23:55 CFP締切
5. Today’s Talk
6. Today, I talk about another proposal
7. RSpec
8. About RSpec pending and skip
9. RSpec/PendingWithoutReason
10. About RSpec/ PendingWithoutReason 34QFD1FOEJOH8JUIPVU3FBTPO
    JT
    B
    DPQ
    GPS
    3VCP$PQ
    34QFD 
 
 5IJT
    DPQ
    DIFDLT
    GPS
    QFOEJOH
    PS
    TLJQQFE
    FYBNQMFT
    XJUIPVU
    SFBTPO
11. About RSpec/ PendingWithoutReason # bad it 'does something' do skip end # good it 'does something' do skip 'reason' end
12. Result Foo does something (PENDING : No reason given) does something (PENDING : reason)
13. Is it surprisingly easy?
14. 🙅
15. Case 1 RSpec.describe Foo do it 'does something' do skip 'xxx' end it 'does something' do pending 'xxx' raise 'should not get here' end end RSpec.describe Foo do pending 'xxx' do # ... end skip 'xxx' do # ... end end
16. Case 1 RSpec.describe Foo do it 'does something' do skip 'xxx' end it 'does something' do pending 'xxx' raise 'should not get here' end end RSpec.describe Foo do pending 'xxx' do # ... end skip 'xxx' do # ... end end 🙆 🙅
17. Case 2 RSpec.describe Foo do it 'does something' do skip 'xxx' do # . .. end end end
18. Case 2 🙆 Foo does something (PENDING: xxx)
19. Case 3 RSpec.describe Foo do it 'does something' do pending 'xxx' do # . .. end end end
20. Case 3 🥺 ArgumentError: The semantics of `RSpec::Core::Pending#pending` have changed in RSpec 3. In RSpec 2.x, it caused the example to be skipped. In RSpec 3, the rest of the example is still run but is expected to fail, and will be marked as a failure (rather than as pending) if the example passes. Passing a block within an example is now deprecated. Marking the example as pending provides the same behavior in RSpec 3 which was provided only by the block in RSpec 2.x. Move the code in the block provided to `pending` into the rest of the example body.
21. Various ways to skip/pending still exist
22. Temporarily skipping by prefixing example with an x RSpec.describe "an example" do xit "is skipped using xit" do end xspecify "is skipped using xspecify" do end xexample "is skipped using xexample" do end end
23. Skipping using metadata RSpec.describe "an example" do example "is skipped", :skip => true do end end
24. When implementing a RuboCop’s cop, there are additional considerations to take into account 😇
25. Cases to ignore in RuboCop FactoryBot.def i ne do factory :task do pending skip { true } end end
26. Cases to ignore in RuboCop RSpec.describe Foo do it 'does something' do Foo.pending Foo.skip end end
27. Cases to ignore in RuboCop RSpec.describe Foo do it 'does something' do expect('foo').to eq(pending) foo(bar, pending, skip) foo(bar, pending: pending, skip: skip) is_expected.to match_array([foo, pending, skip]) list = [skip, pending] end end
28. Writing reasons for pending or skip in RSpec was a labyrinth…
29. end