Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review in JavaScript
Search
Adam Conrad
October 03, 2019
Programming
0
620
Code review in JavaScript
How to be a great code reviewer with JavaScript code as an example pull request.
Adam Conrad
October 03, 2019
Tweet
Share
More Decks by Adam Conrad
See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
150
The Dos and Don'ts of CBRA
acconrad
0
70
A-Frame and You
acconrad
0
40
UX and Performance
acconrad
0
57
SX - Startup Experience
acconrad
0
64
Other Decks in Programming
See All in Programming
CSC307 Lecture 17
javiergs
PRO
0
110
エラーって何種類あるの?
kajitack
5
120
GoのGenericsによるslice操作との付き合い方
syumai
2
390
KotlinConf 2025 現地で感じたServer-Side Kotlin
n_takehata
1
180
FormFlow - Build Stunning Multistep Forms
yceruto
1
150
Cursor Meetup Tokyo ゲノミクスとCursor: 進化と制約のあいだ
koido
2
960
実践ArchUnit ~実例による検証パターンの紹介~
ogiwarat
2
240
技術懸念に立ち向かい 法改正を穏便に乗り切った話
pop_cashew
0
1.3k
Your Architecture as a Crime Scene:Forensic Analysis
manfredsteyer
PRO
0
100
PT AI без купюр
v0lka
0
230
セキュリティマネジャー廃止とクラウドネイティブ型サンドボックス活用
kazumura
1
160
型付きアクターモデルがもたらす分散シミュレーションの未来
piyo7
0
740
Featured
See All Featured
The Straight Up "How To Draw Better" Workshop
denniskardys
233
140k
The Web Performance Landscape in 2024 [PerfNow 2024]
tammyeverts
8
650
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
161
15k
The Power of CSS Pseudo Elements
geoffreycrofte
77
5.8k
Large-scale JavaScript Application Architecture
addyosmani
512
110k
It's Worth the Effort
3n
184
28k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
48
5.4k
We Have a Design System, Now What?
morganepeng
52
7.6k
Designing for Performance
lara
609
69k
What's in a price? How to price your products and services
michaelherold
245
12k
GraphQLとの向き合い方2022年版
quramy
46
14k
YesSQL, Process and Tooling at Scale
rocio
172
14k
Transcript
Code review in JavaScript
Who made this cool slide deck??? • Director @ indigo
(hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t
Do u know how to code review?
Do u know how to code review? • It’s not
Do u know how to code review? • It’s not
→ ✅ looks good
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it
An example is probably best https://github.com/indigo-ag/api-interview/pull/1