Code review in JavaScript

Transcript

1. Code review in JavaScript

2. Who made this cool slide deck??? • Director @ indigo

   (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

3. Do u know how to code review?

4. Do u know how to code review? • It’s not

5. Do u know how to code review? • It’s not

   → ✅ looks good

6. Do u know how to code review? • It’s not

   → ✅ looks good • It’s probably more like

7. Do u know how to code review? • It’s not

   → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1