Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
640

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
70
A-Frame and You
Avatar for Adam Conrad acconrad
0
40
UX and Performance
Avatar for Adam Conrad acconrad
0
58
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
67

Other Decks in Programming

See All in Programming
TROCCO×dbtで実現する人にもAIにもやさしいデータ基盤
Avatar for Nealle nealle
0
350
WebAssemblyインタプリタを書く ～Component Modelを添えて～
Avatar for ruccho ruccho
1
930
TanStack DB ~状態管理の新しい考え方~
Avatar for じょうげん bmthd
2
360
フロントエンドのmonorepo化と責務分離のリアーキテクト
Avatar for Takuma Kajikawa kajitack
2
150
Portapad紹介プレゼンテーション
Avatar for KAKERU gotoumakakeru
1
130
サーバーサイドのビルド時間87倍高速化
Avatar for PLAID Tech plaidtech
PRO
0
670
RDoc meets YARD
Avatar for Masafumi Okura okuramasafumi
3
150
🔨 小さなビルドシステムを作る
Avatar for Mutsuha Asada momeemt
2
610
MLH State of the League: 2026 Season
Avatar for Swift theycallmeswift
0
180
AIコーディングAgentとの向き合い方
Avatar for kmuto eycjur
0
240
パスタの技術
Avatar for Yusuke Wada yusukebe
1
540
詳解！defer panic recover のしくみ / Understanding defer, panic, and recover
Avatar for convto convto
0
190

Featured

See All Featured
Into the Great Unknown - MozCon
Avatar for Noah Learner thekraken
40
2k
Producing Creativity
Avatar for Steve Smith orderedlist
PRO
347
40k
4 Signs Your Business is Dying
Avatar for Josh Pigford shpigford
184
22k
How to train your dragon (web standard)
Avatar for Monica Dinculescu notwaldorf
96
6.2k
Speed Design
Avatar for Sergey Chernyshev sergeychernyshev
32
1.1k
How STYLIGHT went responsive
Avatar for nonsquared nonsquared
100
5.8k
A designer walks into a library…
Avatar for Paul Jervis Heath pauljervisheath
207
24k
The Power of CSS Pseudo Elements
Avatar for Geoffrey Crofte geoffreycrofte
77
5.9k
Music & Morning Musume
Avatar for Bryan Veloso bryan
46
6.8k
The Illustrated Children's Guide to Kubernetes
Avatar for Chris Short chrisshort
48
50k
Balancing Empowerment & Direction
Avatar for Lara Hogan lara
3
600
Distributed Sagas: A Protocol for Coordinating Microservices
Avatar for Caitie McCaffrey caitiem20
333
22k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1