Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review in JavaScript
Search
Adam Conrad
October 03, 2019
Programming
0
610
Code review in JavaScript
How to be a great code reviewer with JavaScript code as an example pull request.
Adam Conrad
October 03, 2019
Tweet
Share
More Decks by Adam Conrad
See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
150
The Dos and Don'ts of CBRA
acconrad
0
69
A-Frame and You
acconrad
0
37
UX and Performance
acconrad
0
54
SX - Startup Experience
acconrad
0
61
Other Decks in Programming
See All in Programming
Day0 初心者向けワークショップ実践!ソフトウェアテストの第一歩
satohiroyuki
0
830
Do Dumb Things
mitsuhiko
0
420
SwiftUI API Design Lessons
niw
1
260
[NG India] Event-Based State Management with NgRx SignalStore
markostanimirovic
0
110
Java 24まとめ / Java 24 summary
kishida
3
440
DomainException と Result 型で作る型安全なエラーハンドリング
karszawa
0
880
小田原でみんなで一句詠みたいな #phpcon_odawara
stefafafan
0
320
List とは何か? / PHPerKaigi 2025
meihei3
0
660
サービスレベルを管理してアジャイルを加速しよう!! / slm-accelerate-agility
tomoyakitaura
1
160
Ruby's Line Breaks
yui_knk
2
460
スモールスタートで始めるためのLambda×モノリス
akihisaikeda
2
120
プロダクト横断分析に役立つ、事前集計しないサマリーテーブル設計
hanon52_
2
350
Featured
See All Featured
BBQ
matthewcrist
88
9.6k
What’s in a name? Adding method to the madness
productmarketing
PRO
22
3.4k
Agile that works and the tools we love
rasmusluckow
328
21k
Stop Working from a Prison Cell
hatefulcrawdad
268
20k
Code Reviewing Like a Champion
maltzj
522
39k
Optimising Largest Contentful Paint
csswizardry
36
3.2k
RailsConf & Balkan Ruby 2019: The Past, Present, and Future of Rails at GitHub
eileencodes
135
33k
The Illustrated Children's Guide to Kubernetes
chrisshort
48
49k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
30
2.3k
Being A Developer After 40
akosma
91
590k
The Pragmatic Product Professional
lauravandoore
33
6.5k
Designing Dashboards & Data Visualisations in Web Apps
destraynor
231
53k
Transcript
Code review in JavaScript
Who made this cool slide deck??? • Director @ indigo
(hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t
Do u know how to code review?
Do u know how to code review? • It’s not
Do u know how to code review? • It’s not
→ ✅ looks good
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it
An example is probably best https://github.com/indigo-ag/api-interview/pull/1