Pro Yearly is on sale from $80 to $50! »

Code review in JavaScript

43e0fc25bbcc4a1bcf1e6139e424ee35?s=47 Adam Conrad
October 03, 2019
Programming
0
52

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

43e0fc25bbcc4a1bcf1e6139e424ee35?s=128

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
120
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
32
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
22
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
27
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
31

Other Decks in Programming

See All in Programming
52711e2157a6fed933b0361cc06a6953?s=48 marcelgsantos
1
240
D02d96057c4cd905d60d14549b00db0d?s=48 stvansolano
0
250
4ab3fec3e82ddb19bcadd93ef909a443?s=48 syucream
0
1k
73b0a25ed03f649ec63ded82ce4ac7cb?s=48 nunulk
0
140
52cc8a838bf44a589d2572833b2dd1b9?s=48 palkan
2
290
15934fa2aa7b2ce21f091e9b7cffa856?s=48 manfredsteyer
0
190
0063efb4c7066273b877fdabcdcd15b3?s=48 dora1998
0
130
35761e3936deba2f8189c2d20982c771?s=48 getify
1
550
A3db1cdacad2a1b5de5af000a1c94fda?s=48 xrxoxcxox
2
300
9987516c273a7874b12b742e7aef828f?s=48 smellman
1
710
7edddae207b212e5e035133d9eb10b82?s=48 russhwolf
1
180
D331d219bbb80155f3687db8009984f0?s=48 kinkinkon1009
0
660

Featured

See All Featured
9952dfcd5d338f8a8e7175c8a8f65fb5?s=48 wjessup
337
16k
245cee81a9c424266e5e401d844ea881?s=48 lara
590
60k
B6a8f005f39d23ffc930508ac9da68b9?s=48 vanstee
116
4.8k
C35e01544a0dd94a2cf1619ee8a42ebb?s=48 clairelew
14
1.4k
D67fff74178013024d833b3eec6cf27f?s=48 lynnandtonic
268
16k
5f2da528927a2ec9ba4fec2069cbc958?s=48 kneath
295
39k
B83d5b590577969ee79a5ad845411a7d?s=48 ammeep
654
54k
C1daf20e5c49ff910745198ef9869ac2?s=48 hatefulcrawdad
258
16k
B3ace07412a5178ea778e7eec161fc0a?s=48 jcasabona
7
480
812e1705ff0f8bc1bcf18587bde687d5?s=48 62gerente
585
200k
Fde6c3a50ca518a909ef35c22c0ee0e4?s=48 destraynor
223
47k
A16eb159db895e3b01d3dc95767ad595?s=48 jonyablonski
10
930

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1