Upgrade to PRO for Only $50/Year—Limited-Time Offer! 🔥

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
660

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
72
A-Frame and You
Avatar for Adam Conrad acconrad
0
44
UX and Performance
Avatar for Adam Conrad acconrad
0
59
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
71

Other Decks in Programming

See All in Programming
React Native New Architecture 移行実践報告
Avatar for taminif taminif
1
130
Microservices rules: What good looks like
Avatar for Chris Richardson cer
PRO
0
630
Full-Cycle Reactivity in Angular: SignalStore mit Signal Forms und Resources
Avatar for Manfred Steyer manfredsteyer
PRO
0
180
令和最新版Android Studioで化石デバイス向けアプリを作る
Avatar for Sora Arakawa arkw
0
260
All(?) About Point Sets
Avatar for hole hole
0
280
[SF Ruby Conf 2025] Rails X
Avatar for Vladimir Dementyev palkan
0
450
tsgolintはいかにしてtypescript-goの非公開APIを呼び出しているのか
Avatar for syumai syumai
5
1.5k
20 years of Symfony, what's next?

Avatar for Fabien Potencier fabpot
2
310
手が足りない！兼業データエンジニアに必要だったアーキテクチャと立ち回り
Avatar for zinkosuke zinkosuke
0
420
DSPy Meetup Tokyo #1 - はじめてのDSPy
Avatar for Masahiro Nishimi masahiro_nishimi
1
150
Navigation 3: 적응형 UI를 위한 앱 탐색
Avatar for Sungyong An fornewid
1
160
S3 VectorsとStrands Agentsを利用したAgentic RAGシステムの構築
Avatar for とすり tosuri13
6
270

Featured

See All Featured
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
Avatar for Eileen M. Uchitelle eileencodes
26
3.2k
Documentation Writing (for coders)
Avatar for Carmen Chung carmenintech
76
5.2k
Why Our Code Smells
Avatar for Brandon Keepers bkeepers
PRO
340
57k
Building a Modern Day 
E-commerce SEO Strategy
Avatar for Aleyda Solis aleyda
45
8.3k
Faster Mobile Websites
Avatar for Dean Hume deanohume
310
31k
Testing 201, or: Great Expectations
Avatar for Joseph Mastey jmmastey
46
7.8k
VelocityConf: Rendering Performance Case Studies
Avatar for Addy Osmani addyosmani
333
24k
Done Done
Avatar for chrislema chrislema
186
16k
RailsConf 2023
Avatar for Aaron Patterson tenderlove
30
1.3k
Docker and Python
Avatar for Tania Allard trallard
46
3.7k
Building Flexible Design Systems
Avatar for Yesenia Perez-Cruz yeseniaperezcruz
329
39k
Design and Strategy: How to Deal with People Who Don’t "Get" Design
Avatar for Morgane Peng morganepeng
132
19k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1