Lock in $30 Savings on PRO—Offer Ends Soon! ⏳

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
660

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
72
A-Frame and You
Avatar for Adam Conrad acconrad
0
44
UX and Performance
Avatar for Adam Conrad acconrad
0
59
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
72

Other Decks in Programming

See All in Programming
AIコーディングエージェント（Gemini）
Avatar for kondai kondai24
0
210
251126 TestState APIってなんだっけ?Step Functionsテストどう変わる?
Avatar for Takumi Abe east_takumi
0
320
Go コードベースの構成と AI コンテキスト定義
Avatar for ANDPAD inc andpad
0
120
AIエンジニアリングのご紹介 / Introduction to AI Engineering
Avatar for r-kagaya rkaga
6
2.1k
【CA.ai #3】Google ADKを活用したAI Agent開発と運用知見
Avatar for Kazuki Hara harappa80
0
300
20251212 AI 時代的 Legacy Code 營救術 2025 WebConf
Avatar for mouson(墨嗓) mouson
0
130
ID管理機能開発の裏側 高速にSaaS連携を実現したチームのAI活用編
Avatar for Atsushi Kawamura (atzz/a2c) atzzcokek
0
220
愛される翻訳の秘訣
Avatar for Kishikawa Katsumi kishikawakatsumi
3
320
AIコーディングエージェント（skywork）
Avatar for kondai kondai24
0
160
【Streamlit x Snowflake】データ基盤からアプリ開発・AI活用まで、すべてをSnowflake内で実現
Avatar for Ayumu Yamaguchi ayumu_yamaguchi
1
120
認証・認可の基本を学ぼう後編
Avatar for kaza kouyuume
0
190
DSPy Meetup Tokyo #1 - はじめてのDSPy
Avatar for Masahiro Nishimi masahiro_nishimi
1
160

Featured

See All Featured
A Tale of Four Properties
Avatar for Chris Coyier chriscoyier
162
23k
Statistics for Hackers
Avatar for Jake VanderPlas jakevdp
799
230k
The World Runs on Bad Software
Avatar for Brandon Keepers bkeepers
PRO
72
12k
Docker and Python
Avatar for Tania Allard trallard
47
3.7k
The Invisible Side of Design
Avatar for Vitaly Friedman smashingmag
302
51k
How to Ace a Technical Interview
Avatar for Jacob Kaplan-Moss jacobian
280
24k
Why You Should Never Use an ORM
Avatar for John Nunemaker jnunemaker
PRO
61
9.6k
4 Signs Your Business is Dying
Avatar for Josh Pigford shpigford
186
22k
Building Applications with DynamoDB
Avatar for Matt Wood mza
96
6.8k
Facilitating Awesome Meetings
Avatar for Lara Hogan lara
57
6.7k
The Web Performance Landscape in 2024 [PerfNow 2024]
Avatar for Tammy Everts tammyeverts
12
970
Optimizing for Happiness
Avatar for Tom Preston-Werner mojombo
379
70k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1