Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Adam Conrad
October 03, 2019
Programming
0
590

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
150
The Dos and Don'ts of CBRA
acconrad
0
67
A-Frame and You
acconrad
0
36
UX and Performance
acconrad
0
52
SX - Startup Experience
acconrad
0
53

Other Decks in Programming

See All in Programming
AWS Lambda functions with C# 用の Dev Container Template を作ってみた件
mappie_kochi
0
140
Amazon Nova Reelの可能性
hideg
0
210
為你自己學 Python
eddie
0
520
Package Traits
ikesyo
1
210
どうして手を動かすよりもチーム内のコードレビューを優先するべきなのか
okashoi
3
890
令和7年版 あなたが使ってよいフロントエンド機能とは
mugi_uno
11
5.3k
DevinとCursorから学ぶAIエージェントメモリーの設計とMoatの考え方
itarutomy
0
160
Rubyでつくるパケットキャプチャツール
ydah
0
180
知られざるDMMデータエンジニアの生態 〜かつてツチノコと呼ばれし者〜
takaha4k
1
510
テストコード書いてみませんか？
onopon
2
340
Итераторы в Go 1.23: зачем они нужны, как использовать, и насколько они быстрые?
lamodatech
0
1.4k
ドメインイベント増えすぎ問題
h0r15h0
2
570

Featured

See All Featured
The Web Performance Landscape in 2024 [PerfNow 2024]
tammyeverts
3
360
For a Future-Friendly Web
brad_frost
176
9.5k
YesSQL, Process and Tooling at Scale
rocio
170
14k
Build your cross-platform service in a week with App Engine
jlugia
229
18k
Fontdeck: Realign not Redesign
paulrobertlloyd
82
5.3k
Cheating the UX When There Is Nothing More to Optimize - PixelPioneers
stephaniewalter
280
13k
Designing for Performance
lara
604
68k
Adopting Sorbet at Scale
ufuk
74
9.2k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
marcduiker
26
1.9k
The Art of Programming - Codeland 2020
erikaheidi
53
13k
KATA
mclloyd
29
14k
Put a Button on it: Removing Barriers to Going Fast.
kastner
60
3.6k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1