Pro Yearly is on sale from $80 to $50! »

Code review in JavaScript

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

43e0fc25bbcc4a1bcf1e6139e424ee35?s=128

Adam Conrad

October 03, 2019
Tweet

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t
  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good
  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like
  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it
  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1