Upgrade to Pro — share decks privately, control downloads, hide ads and more …
Sign up for free

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
710
0

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
160
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
100
A-Frame and You
Avatar for Adam Conrad acconrad
0
56
UX and Performance
Avatar for Adam Conrad acconrad
0
74
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
79

Other Decks in Programming

See All in Programming
気持ちぃ〜角丸 Squircle
Avatar for ryu ryu1013
0
120
phperだってパンチカードでコーディングしたい
Avatar for hideki kinjyo o0h
PRO
0
230
wkhtmltopdfの次どうするか問題2026
Avatar for Shinichi Maeshima willnet
2
1.9k
Augmenting AI with the Power of Jakarta EE
Avatar for ivargrimstad ivargrimstad
0
500
Vue Fes Japan 2026 タイムテーブル徹底解説
Avatar for 448jp | OKI Yoshiya 448jp
1
640
半永久的に提供し続けられるプライベートクラウドを目指して ― 利用者の認知負荷を抑えるAPI抽象化とハードウェア世代交代の基盤設計
Avatar for Tomofumi Kondo tomokon
0
460
ジョジョの世界をXRで再現する
Avatar for mofurune mofurune
0
140
モデルのリファクタリングが難しいと思ったら、そもそも複雑だったのはビジネス仕様だった ? / is-the-business-domain-the-real-complexity
Avatar for hatsu hatsu38
0
450
Rでドレミ/Do-Re-Mi_with_R
Avatar for florets1 florets1
0
130
IBM Bob Dojo #1 仕様駆動開発入門
Avatar for Akira Onishi (IBM) oniak3ibm
PRO
0
350
UnityでSystem.Net.WebSocketsなWebSocketサーバが動かないのでUnity Monoのコードを覗いてみた / about implementing websocket server with unity mono
Avatar for にー兄さん drumath2237
1
560
Augmenting AI with the Power of Jakarta EE
Avatar for ivargrimstad ivargrimstad
0
500

Featured

See All Featured
Music & Morning Musume
Avatar for Bryan Veloso bryan
48
7.4k
Information Architects: The Missing Link in Design Systems
Avatar for Michelle Chin soysaucechin
1
1.2k
How Fast Is Fast Enough? [PerfNow 2025]
Avatar for Tammy Everts tammyeverts
3
920
VelocityConf: Rendering Performance Case Studies
Avatar for Addy Osmani addyosmani
331
25k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
Avatar for Tammy Everts tammyeverts
11
1.1k
SEO for Brand Visibility & Recognition
Avatar for Aleyda Solis aleyda
0
4.8k
Impact Scores and Hybrid Strategies: The future of link building
Avatar for Tamara Novitovic tamaranovitovic
0
450
Mozcon NYC 2025: Stop Losing SEO Traffic
Avatar for Sam Torres samtorres
1
570
Helping Users Find Their Own Way: Creating Modern Search Experiences
Avatar for Dan Newman danielanewman
31
3.4k
svc-hook: hooking system calls on ARM64 by binary rewriting
Avatar for Akira Moroo retrage
2
610
Winning Ecommerce Organic Search in an AI Era - #searchnstuff2025
Avatar for Aleyda Solis aleyda
2
2.2k
Performance Is Good for Brains [We Love Speed 2024]
Avatar for Tammy Everts tammyeverts
12
1.9k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1