Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review in JavaScript
Search
Adam Conrad
October 03, 2019
Programming
0
650
Code review in JavaScript
How to be a great code reviewer with JavaScript code as an example pull request.
Adam Conrad
October 03, 2019
Tweet
Share
More Decks by Adam Conrad
See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
150
The Dos and Don'ts of CBRA
acconrad
0
70
A-Frame and You
acconrad
0
41
UX and Performance
acconrad
0
58
SX - Startup Experience
acconrad
0
69
Other Decks in Programming
See All in Programming
組込みだけじゃない!TinyGo で始める無料クラウド開発入門
otakakot
0
210
私達はmodernize packageに夢を見るか feat. go/analysis, go/ast / Go Conference 2025
kaorumuta
2
520
10年もののAPIサーバーにおけるCI/CDの改善の奮闘
mbook
0
810
Things You Thought You Didn’t Need To Care About That Have a Big Impact On Your Job
hollycummins
0
210
Software Architecture
hschwentner
6
2.3k
クラシルを支える技術と組織
rakutek
0
200
『毎日の移動』を支えるGoバックエンド内製開発
yutautsugi
2
230
NetworkXとGNNで学ぶグラフデータ分析入門〜複雑な関係性を解き明かすPythonの力〜
mhrtech
3
1.2k
GitHub Actions × AWS OIDC連携の仕組みと経緯を理解する
ota1022
0
250
アメ車でサンノゼを走ってきたよ!
s_shimotori
0
220
Cursorハンズオン実践!
eltociear
2
920
iOSエンジニア向けの英語学習アプリを作る!
yukawashouhei
0
190
Featured
See All Featured
Six Lessons from altMBA
skipperchong
28
4k
Java REST API Framework Comparison - PWX 2021
mraible
33
8.9k
Side Projects
sachag
455
43k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
eileencodes
26
3.1k
How to train your dragon (web standard)
notwaldorf
96
6.3k
Building an army of robots
kneath
306
46k
GraphQLとの向き合い方2022年版
quramy
49
14k
Writing Fast Ruby
sferik
629
62k
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
358
30k
jQuery: Nuts, Bolts and Bling
dougneiner
64
7.9k
Agile that works and the tools we love
rasmusluckow
331
21k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
35
3.2k
Transcript
Code review in JavaScript
Who made this cool slide deck??? • Director @ indigo
(hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t
Do u know how to code review?
Do u know how to code review? • It’s not
Do u know how to code review? • It’s not
→ ✅ looks good
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it
An example is probably best https://github.com/indigo-ag/api-interview/pull/1