Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Adam Conrad
October 03, 2019
Programming
0
310

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
130
The Dos and Don'ts of CBRA
acconrad
0
44
A-Frame and You
acconrad
0
25
UX and Performance
acconrad
0
34
SX - Startup Experience
acconrad
0
39

Other Decks in Programming

See All in Programming
Sidekiq on the surface and under the hood
paweldabrowski
0
160
設計初心者のための「伝わる」フロー図 / How to draw a communicative flow diagram for beginners
rs_tukki
1
420
実践！ユニットテスト入門（PHPカンファレンス2022）
panda_program
9
3.7k
Laravel を低速化する技術 / how to slow laravel
hanhan1978
PRO
0
1.2k
Nature Remo SDKアップデートの軌跡
tomoyuki
1
460
なるべくJavaScriptを書かないで
SymfonyのUIをリッチにする Symfony UX
ippey
1
760
XP頻出英単語 / XP vocabulary
fkino
0
380
可觀測性(Observability)的實踐
marcustung
0
1.6k
20年ものの巨大レガシープロダクトを PHP 8.0にアップデートした際の対策と得られた知見
akamah
5
2.5k
話を聞き出す技術
murabayashi
30
26k
Rethinking Auth for SPAs and Micro Frontends: Easy and Secure With Gateways
manfredsteyer
PRO
0
120
MPA化するSPAとSPA化するMPA
yosuke_furukawa
PRO
12
5.2k

Featured

See All Featured
Building Adaptive Systems
keathley
25
1.2k
KATA
mclloyd
7
9k
We Have a Design System, Now What?
morganepeng
37
5.7k
Adopting Sorbet at Scale
ufuk
65
7.7k
Support Driven Design
roundedbygravity
87
8.7k
Put a Button on it: Removing Barriers to Going Fast.
kastner
56
2.4k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
15
1k
The Cult of Friendly URLs
andyhume
68
4.9k
Creatively Recalculating Your Daily Design Routine
revolveconf
207
10k
Three Pipe Problems
jasonvnalue
89
8.8k
RailsConf & Balkan Ruby 2019: The Past, Present, and Future of Rails at GitHub
eileencodes
120
28k
VelocityConf: Rendering Performance Case Studies
addyosmani
316
22k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1