Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Adam Conrad
October 03, 2019
Programming
0
570

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
140
The Dos and Don'ts of CBRA
acconrad
0
64
A-Frame and You
acconrad
0
35
UX and Performance
acconrad
0
49
SX - Startup Experience
acconrad
0
51

Other Decks in Programming

See All in Programming
Android 15 でアクションバー表示時にステータスバーが白くなってしまう問題
tonionagauzzi
0
110
EventSourcingの理想と現実
wenas
5
2k
Server Driven Compose With Firebase
skydoves
0
350
ピラミッド、アイスクリームコーン、SMURF: 自動テストの最適バランスを求めて / Pyramid Ice-Cream-Cone and SMURF
twada
PRO
8
730
Honoの来た道とこれから
yusukebe
19
3k
JaSST 24 九州：ワークショップ(は除く) 実践！マインドマップを活用したソフトウェアテスト＋活用事例
satohiroyuki
0
170
Vaporモードを大規模サービスに最速導入して学びを共有する
kazukishimamoto
4
4.2k
役立つログに取り組もう
irof
24
7.7k
go.mod、DockerfileやCI設定に分散しがちなGoのバージョンをまとめて管理する / Go Connect #3
arthur1
10
2.3k
Piniaの現状と今後
waka292
5
1.4k
『ドメイン駆動設計をはじめよう』のモデリングアプローチ
masuda220
PRO
4
150
【Kaigi on Rails 2024】YOUTRUST スポンサーLT
krpk1900
0
210

Featured

See All Featured
A better future with KSS
kneath
238
17k
A Tale of Four Properties
chriscoyier
156
23k
Large-scale JavaScript Application Architecture
addyosmani
510
110k
Statistics for Hackers
jakevdp
796
220k
Being A Developer After 40
akosma
86
590k
Performance Is Good for Brains [We Love Speed 2024]
tammyeverts
3
360
The Invisible Side of Design
smashingmag
297
50k
Reflections from 52 weeks, 52 projects
jeffersonlam
346
20k
A Modern Web Designer's Workflow
chriscoyier
692
190k
Designing Experiences People Love
moore
138
23k
The World Runs on Bad Software
bkeepers
PRO
65
11k
Principles of Awesome APIs and How to Build Them.
keavy
126
17k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1