Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Sponsored · Ship Features Fearlessly Turn features on and off without deploys. Used by thousands of Ruby developers. →
Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
660

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
73
A-Frame and You
Avatar for Adam Conrad acconrad
0
44
UX and Performance
Avatar for Adam Conrad acconrad
0
59
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
72

Other Decks in Programming

See All in Programming
カスタマーサクセス業務を変革したヘルススコアの実現と学び
Avatar for Tomoyuki Hamaguchi _hummer0724
0
120
HTTPプロトコル正しく理解していますか？ 〜かわいい猫と共に学ぼう。ฅ^•ω•^ฅ ﾆｬ〜
Avatar for ♛Heitor Hirose hekuchan
2
660
KIKI_MBSD Cybersecurity Challenges 2025
Avatar for ikema ikema
0
1.2k
Fragmented Architectures
Avatar for Denys Poltorak denyspoltorak
0
120
Fluid Templating in TYPO3 14
Avatar for Simon Praetorius s2b
0
110
クラウドに依存しないS3を使った開発術
Avatar for しめさば simesaba80
0
230
Python札幌 LT資料
Avatar for t3tra t3tra
7
1.1k
DevFest Android in Korea 2025 - 개발자 커뮤니티를 통해 얻는 가치
Avatar for Suhyeon Kim wisemuji
0
190
Deno Tunnel を使ってみた話
Avatar for すずとも kamekyame
0
340
re:Invent 2025 のイケてるサービスを紹介する
Avatar for maroon1st maroon1st
0
170
OSSとなったswift-buildで Xcodeのビルドを差し替えられるため 自分でXcodeを直せる時代になっている ダイアモンド問題編
Avatar for yimajo yimajo
3
430
CSC307 Lecture 04
Avatar for Javier Gonzalez-Sanchez javiergs
PRO
0
650

Featured

See All Featured
Abbi's Birthday
Avatar for Violet Bock coloredviolet
1
4.5k
The SEO identity crisis: Don't let AI make you average
Avatar for Varn varn
0
55
Producing Creativity
Avatar for Steve Smith orderedlist
PRO
348
40k
Scaling GitHub
Avatar for Zach Holman holman
464
140k
Odyssey Design
Avatar for Ryan Kendrick rkendrick25
PRO
0
470
RailsConf 2023
Avatar for Aaron Patterson tenderlove
30
1.3k
ピンチをチャンスに：未来をつくるプロダクトロードマップ #pmconf2020
Avatar for Aki / @LoveIdahoBurger aki_iinuma
128
55k
Dealing with People You Can't Stand - Big Design 2015
Avatar for Cassini Nazir cassininazir
367
27k
How To Stay Up To Date on Web Technology
Avatar for Chris Coyier chriscoyier
791
250k
Dominate Local Search Results - an insider guide to GBP, reviews, and Local SEO
Avatar for Greg Gifford greggifford
PRO
0
46
Into the Great Unknown - MozCon
Avatar for Noah Learner thekraken
40
2.2k
Paper Plane (Part 1)
Avatar for Katie Cordina Lindsey katiecoart
PRO
0
3.4k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1