Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
640

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
70
A-Frame and You
Avatar for Adam Conrad acconrad
0
40
UX and Performance
Avatar for Adam Conrad acconrad
0
58
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
69

Other Decks in Programming

See All in Programming
Reading Rails 1.0 Source Code
Avatar for Masafumi Okura okuramasafumi
0
250
2025 年のコーディングエージェントの現在地とエンジニアの仕事の変化について
Avatar for azukiazusa azukiazusa1
24
12k
Kiroで始めるAI-DLC
Avatar for kaonash kaonash
2
630
250830 IaCの選定~AWS SAMのLambdaをECSに乗り換えたときの備忘録~
Avatar for Takumi Abe east_takumi
0
400
AI時代のUIはどこへ行く？
Avatar for Yusuke Wada yusukebe
18
9.1k
Namespace and Its Future
Avatar for Satoshi Tagomori tagomoris
6
710
Android 16 × Jetpack Composeで縦書きテキストエディタを作ろう / Vertical Text Editor with Compose on Android 16
Avatar for cc4966 cc4966
2
270
奥深くて厄介な「改行」と仲良くなる20分
Avatar for おぐえもん oguemon
1
570
CJK and Unicode From a PHP Committer
Avatar for てきめん tekimen youkidearitai
PRO
0
110
チームのテスト力を鍛える
Avatar for Hiroki Iseri goyoki
3
940
RDoc meets YARD
Avatar for Masafumi Okura okuramasafumi
4
170
Platformに“ちょうどいい”責務ってどこ？ 関心の熱さにあわせて考える、責務分担のプラクティス
Avatar for estie | エスティ estie
1
150

Featured

See All Featured
Building a Modern Day 
E-commerce SEO Strategy
Avatar for Aleyda Solis aleyda
43
7.6k
Thoughts on Productivity
Avatar for Jon Yablonski jonyablonski
70
4.8k
YesSQL, Process and Tooling at Scale
Avatar for Rocio Delgado rocio
173
14k
The Psychology of Web Performance [Beyond Tellerrand 2023]
Avatar for Tammy Everts tammyeverts
49
3k
Building Flexible Design Systems
Avatar for Yesenia Perez-Cruz yeseniaperezcruz
329
39k
No one is an island. Learnings from fostering a developers community.
Avatar for Antonio thoeni
21
3.4k
[RailsConf 2023 Opening Keynote] The Magic of Rails
Avatar for Eileen M. Uchitelle eileencodes
30
9.7k
Reflections from 52 weeks, 52 projects
Avatar for Jefferson Lam jeffersonlam
352
21k
Imperfection Machines: The Place of Print at Facebook
Avatar for Scott Boms scottboms
268
13k
How STYLIGHT went responsive
Avatar for nonsquared nonsquared
100
5.8k
A Tale of Four Properties
Avatar for Chris Coyier chriscoyier
160
23k
実際に使うSQLの書き方 徹底解説 / pgcon21j-tutorial
Avatar for soudai sone soudai
PRO
188
55k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1