$30 off During Our Annual Pro Sale. View Details »

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
660

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
72
A-Frame and You
Avatar for Adam Conrad acconrad
0
44
UX and Performance
Avatar for Adam Conrad acconrad
0
59
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
72

Other Decks in Programming

See All in Programming
AIコーディングエージェント（Manus）
Avatar for kondai kondai24
0
210
perlをWebAssembly上で動かすと何が嬉しいの？？？ / Where does Perl-on-Wasm actually make sense?
Avatar for mackee mackee
0
120
Giselleで作るAI QAアシスタント 〜 Pull Requestレビューに継続的QAを
Avatar for Tadashi Shigeoka codenote
0
280
The Art of Re-Architecture - Droidcon India 2025
Avatar for Sid Patil siddroid
0
120
Cap'n Webについて
Avatar for Yusuke Wada yusukebe
0
150
20251212 AI 時代的 Legacy Code 營救術 2025 WebConf
Avatar for mouson(墨嗓) mouson
0
210
ZJIT: The Ruby 4 JIT Compiler / Ruby Release 30th Anniversary Party
Avatar for Takashi Kokubun k0kubun
0
260
Navigating Dependency Injection with Metro
Avatar for HyunWoo Lee l2hyunwoo
1
170
公共交通オープンデータ × モバイルUX 複雑な運行情報を 『直感』に変換する技術
Avatar for Tsubasa SEKIGUCHI tinykitten
PRO
0
160
AI Agent Tool のためのバックエンドアーキテクチャを考える #encraft
Avatar for izumin5210 izumin5210
3
1k
Full-Cycle Reactivity in Angular: SignalStore mit Signal Forms und Resources
Avatar for Manfred Steyer manfredsteyer
PRO
0
170
Cell-Based Architecture
Avatar for Luram Archanjo larchanjo
0
140

Featured

See All Featured
KATA
Avatar for Megan Lloyd mclloyd
PRO
33
15k
Performance Is Good for Brains [We Love Speed 2024]
Avatar for Tammy Everts tammyeverts
12
1.4k
How to train your dragon (web standard)
Avatar for Monica Dinculescu notwaldorf
97
6.4k
More Than Pixels: Becoming A User Experience Designer
Avatar for Michelle Schulp Hunt marktimemedia
2
250
The Language of Interfaces
Avatar for Des Traynor destraynor
162
25k
Applied NLP in the Age of Generative AI
Avatar for Ines Montani inesmontani
PRO
3
2k
The Cult of Friendly URLs
Avatar for Andy Hume andyhume
79
6.7k
Practical Orchestrator
Avatar for Shlomi Noach shlominoach
190
11k
Claude Code のすすめ
Avatar for schroneko schroneko
65
200k
The SEO Collaboration Effect
Avatar for Kristina Bergwall kristinabergwall1
0
300
The browser strikes back
Avatar for Jono Alderson jonoalderson
0
120
Embracing the Ebb and Flow
Avatar for Simon Collison colly
88
4.9k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1