Code review in JavaScript

43e0fc25bbcc4a1bcf1e6139e424ee35?s=47 Adam Conrad
October 03, 2019
Programming
0
51

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

43e0fc25bbcc4a1bcf1e6139e424ee35?s=128

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
120
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
30
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
22
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
27
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
31

Other Decks in Programming

See All in Programming
Ffc500baeba9a1024e2c8273203c9f90?s=48 raulh82vlc
3
1.3k
C6296f654b1cc6886aabe5b9703cbe67?s=48 ishiitetsuji
1
590
E76754f592fecf0116c53b2bc39ff135?s=48 kthoms
0
200
29fafe10f8a2fefb98671421260aaa65?s=48 steinkel
1
150
F6baf93a0833a98bdc8184c214f4c468?s=48 rgoswami
0
120
B471eb2445c405a8d33f5777816550e3?s=48 lukle
2
190
3cfad86677c5966ecfe9b81955fa3489?s=48 youkan2002
0
270
948c23c57a850629ff283f2a83088173?s=48 yotuba088
2
170
Fc59401781a26b10f5d4fc5b758fb3b7?s=48 andrewradev
0
170
15934fa2aa7b2ce21f091e9b7cffa856?s=48 manfredsteyer
1
230
8fb8810e5e06a997bc13831b9b51007f?s=48 keinuma
0
690
9f33218af7ae5c04e102fcc3076f2f5c?s=48 yhkaplan
1
310

Featured

See All Featured
7653c7c449918ff6542880a8c284f5e7?s=48 jponch
101
4.8k
5f50f94346fbcb23706f0707169317a4?s=48 aarron
254
36k
5f83ef806155b403c3393160ce51f955?s=48 jlugia
216
16k
719435d98d452de7ac367c828266cf01?s=48 erikaheidi
11
3.9k
C44e1f7e22c3f23cff7bc130871047ef?s=48 eileencodes
112
24k
1b75d89772b7eea1f6c89fbf362607d9?s=48 moore
125
21k
016edace78ffe826f2348d1e0c504afd?s=48 maggiecrowley
5
300
B3d6434763caa0ef5dc4b792662c49f7?s=48 smashingmag
227
17k
96270e4c3e5e9806cf7245475c00b275?s=48 addyosmani
1348
190k
433acaea1012b25d97ae66da9b998dad?s=48 malarkey
118
15k
3d4519fd34b76fb265fc0237f3792bd4?s=48 danielanewman
1
340
D8fc2580cfaca035f666d9e4ee79a7f7?s=48 mongodb
23
3.7k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1