$30 off During Our Annual Pro Sale. View Details »

Code review in JavaScript

Adam Conrad
October 03, 2019
Programming
0
580

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
140
The Dos and Don'ts of CBRA
acconrad
0
66
A-Frame and You
acconrad
0
36
UX and Performance
acconrad
0
50
SX - Startup Experience
acconrad
0
51

Other Decks in Programming

See All in Programming
ペアーズにおけるAmazon Bedrockを⽤いた障害対応⽀援 ⽣成AIツールの導⼊事例 @ 20241115配信AWSウェビナー登壇
fukubaka0825
6
2.3k
聞き手から登壇者へ： RubyKaigi2024 LTでの初挑戦が 教えてくれた、可能性の星
mikik0
1
150
WebAssembly Unleashed: Powering Server-Side Applications
chrisft25
0
2.1k
Develop iOS apps with Neovim / vimconf_2024
uhooi
1
260
イマのCSSでできる
インタラクション最前線 + CSS最新情報
clockmaker
5
3.8k
tidymodelsによるtidyな生存時間解析 / Japan.R2024
dropout009
0
230
Serverless苦闘史
mosh_inc
0
140
[KR] Open-Source Ecosystems
skydoves
0
110
Criando Commits Incríveis no Git
marcelgsantos
1
120
物流システムにおけるリファクタリングとアーキテクチャの再構築 〜依存関係とモジュール分割の重要性〜
deeprain
1
290
CSC509 Lecture 12
javiergs
PRO
0
200
Symfony Mapper Component
soyuka
2
350

Featured

See All Featured
Git: the NoSQL Database
bkeepers
PRO
427
64k
Design and Strategy: How to Deal with People Who Don’t "Get" Design
morganepeng
126
18k
Adopting Sorbet at Scale
ufuk
73
9.1k
Put a Button on it: Removing Barriers to Going Fast.
kastner
59
3.6k
5 minutes of I Can Smell Your CMS
philhawksworth
202
19k
Practical Orchestrator
shlominoach
186
10k
Embracing the Ebb and Flow
colly
84
4.5k
Designing Experiences People Love
moore
138
23k
Documentation Writing (for coders)
carmenintech
65
4.5k
Side Projects
sachag
452
42k
Distributed Sagas: A Protocol for Coordinating Microservices
caitiem20
330
21k
Measuring & Analyzing Core Web Vitals
bluesmoon
4
150

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1