Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review in JavaScript
Search
Adam Conrad
October 03, 2019
Programming
0
530
Code review in JavaScript
How to be a great code reviewer with JavaScript code as an example pull request.
Adam Conrad
October 03, 2019
Tweet
Share
More Decks by Adam Conrad
See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
140
The Dos and Don'ts of CBRA
acconrad
0
61
A-Frame and You
acconrad
0
32
UX and Performance
acconrad
0
47
SX - Startup Experience
acconrad
0
49
Other Decks in Programming
See All in Programming
大規模マルチテナントを解決するYugabyteDBという選択肢
nnaka2992
1
250
AWSでゲームサーバーを運用! Amazon GameLiftのお話
iriikeita
0
200
Webエディタライブラリ 「CodeMirror」から学ぶ Webアプリ開発のテクニック
ryosukeigarashi
0
250
The rollercoaster of releasing an Android, iOS, and macOS app with Kotlin Multiplatform | droidcon Berlin
prof18
0
110
Trial
cairolibrary720
1
130
今こそ始める、CDKコンストラクトライブラリ開発 ― 入門から実践まで
tmokmss
1
930
CSC307 Lecture 09
javiergs
PRO
1
500
20240706_CDKConf
takuyay0ne
0
1.2k
企業向け生成AIアプリの 開発から得られた知見
takaakikakei
0
310
Rubyのパフォーマンスプロファイリングの改善 / Enhancing performance profiling for Ruby
osyoyu
1
410
Rustのweb開発を助ける 便利なツール紹介
yuki0418
1
190
CSC307 Lecture 14
javiergs
PRO
0
220
Featured
See All Featured
Web Components: a chance to create the future
zenorocha
307
41k
jQuery: Nuts, Bolts and Bling
dougneiner
61
7.4k
Art, The Web, and Tiny UX
lynnandtonic
291
20k
Making the Leap to Tech Lead
cromwellryan
127
8.7k
Making Projects Easy
brettharned
111
5.7k
[RailsConf 2023] Rails as a piece of cake
palkan
35
4.4k
Testing 201, or: Great Expectations
jmmastey
33
6.9k
Refactoring Trust on Your Teams (GOTO; Chicago 2020)
rmw
29
2.5k
Speed Design
sergeychernyshev
9
270
Building Your Own Lightsaber
phodgson
101
5.9k
Debugging Ruby Performance
tmm1
71
11k
What's new in Ruby 2.0
geeforr
338
31k
Transcript
Code review in JavaScript
Who made this cool slide deck??? • Director @ indigo
(hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t
Do u know how to code review?
Do u know how to code review? • It’s not
Do u know how to code review? • It’s not
→ ✅ looks good
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it
An example is probably best https://github.com/indigo-ag/api-interview/pull/1