Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Speaker Deck
PRO
Sign in
Sign up for free
Code review in JavaScript
Adam Conrad
October 03, 2019
Programming
0
270
Code review in JavaScript
How to be a great code reviewer with JavaScript code as an example pull request.
Adam Conrad
October 03, 2019
Tweet
Share
More Decks by Adam Conrad
See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
130
The Dos and Don'ts of CBRA
acconrad
0
40
A-Frame and You
acconrad
0
25
UX and Performance
acconrad
0
33
SX - Startup Experience
acconrad
0
37
Other Decks in Programming
See All in Programming
Learning DDD輪読会#4 / Learning DDD Book Club #4
suzushin54
1
150
Better Reliability through Observability (and Experimentation)
ksatirli
PRO
1
350
iOSアプリの技術選択2022
tattn
6
2.5k
Jetpack Compose 頑張らないPreviewParameterProvider
horie23
0
110
もしも、 上司に鬼退治を命じられたら~プロジェクト計画編~
higuuu
0
290
実録mruby組み込み体験
coe401_
0
110
職場にPythonistaを増やす方法
soogie
0
320
プログラミングを勉強したいと言われたら
yuba_4
0
420
A technique to implement DSL in Ruby
okuramasafumi
0
790
LOWYAの信頼性向上とNew Relic
kazumax55
4
360
Kotlin KSP - Intro
taehwandev
1
490
「新卒だけ」じゃない!学び直しを支えるミクシィの技術研修を紹介
mixi_engineers
PRO
0
130
Featured
See All Featured
Bootstrapping a Software Product
garrettdimon
295
110k
Web development in the modern age
philhawksworth
197
9.3k
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
151
12k
Rails Girls Zürich Keynote
gr2m
86
12k
GitHub's CSS Performance
jonrohan
1020
410k
Keith and Marios Guide to Fast Websites
keithpitt
404
21k
10 Git Anti Patterns You Should be Aware of
lemiorhan
638
52k
Atom: Resistance is Futile
akmur
255
20k
Designing Dashboards & Data Visualisations in Web Apps
destraynor
224
49k
5 minutes of I Can Smell Your CMS
philhawksworth
196
18k
It's Worth the Effort
3n
172
25k
How GitHub (no longer) Works
holman
296
140k
Transcript
Code review in JavaScript
Who made this cool slide deck??? • Director @ indigo
(hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t
Do u know how to code review?
Do u know how to code review? • It’s not
Do u know how to code review? • It’s not
→ ✅ looks good
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it
An example is probably best https://github.com/indigo-ag/api-interview/pull/1