Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
630

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
70
A-Frame and You
Avatar for Adam Conrad acconrad
0
40
UX and Performance
Avatar for Adam Conrad acconrad
0
58
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
65

Other Decks in Programming

See All in Programming
대규모 트래픽을 처리하는 프론트 개발자의 전략
Avatar for Seungmin 마량 maryang
0
120
物語を動かす行動"量" #エンジニアニメ
Avatar for konifar konifar
9
2.4k
バイブコーディングの正体——AIエージェントはソフトウェア開発を変えるか？
Avatar for Shinichi Takayanagi stakaya
5
780
MySQL9でベクトルカラム登場！PHP×AWSでのAI/類似検索はこう変わる
Avatar for Suguru Ohki suguruooki
1
280
新世界の理解
Avatar for Akihito Koriyama koriym
0
130
React 使いじゃなくても知っておきたい教養としての React
Avatar for Yuka O’oka oukayuka
18
5.3k
PHPUnitの限界をPlaywrightで補完するテストアプローチ
Avatar for yuzneri yuzneri
0
380
実践！App Intents対応
Avatar for 野瀬田　裕樹 yuukiw00w
1
210
GUI操作LLMの最新動向: UI-TARSと関連論文紹介
Avatar for Kazuki Fujikawa kfujikawa
0
540
Infer入門
Avatar for r1ru riru
4
680
それ CLI フレームワークがなくてもできるよ / Building CLI Tools Without Frameworks
Avatar for Kuniwak orgachem
PRO
17
3.7k
202507_ADKで始めるエージェント開発の基本 〜デモを通じて紹介〜（奥田りさ）The Basics of Agent Development with ADK — A Demo-Focused Introduction
Avatar for RisaTube risatube
PRO
6
1.4k

Featured

See All Featured
Exploring the Power of Turbo Streams & Action Cable | RailsConf2023
Avatar for Kevin Liebholz kevinliebholz
34
6k
RailsConf 2023
Avatar for Aaron Patterson tenderlove
30
1.2k
The World Runs on Bad Software
Avatar for Brandon Keepers bkeepers
PRO
70
11k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
Avatar for Marc Duiker marcduiker
30
2.2k
ピンチをチャンスに：未来をつくるプロダクトロードマップ #pmconf2020
Avatar for Aki / @LoveIdahoBurger aki_iinuma
126
53k
Building an army of robots
Avatar for Kyle Neath kneath
306
45k
The Myth of the Modular Monolith - Day 2 Keynote - Rails World 2024
Avatar for Eileen M. Uchitelle eileencodes
26
3k
Imperfection Machines: The Place of Print at Facebook
Avatar for Scott Boms scottboms
267
13k
Documentation Writing (for coders)
Avatar for Carmen Chung carmenintech
73
5k
The Art of Delivering Value - GDevCon NA Keynote
Avatar for David Neal reverentgeek
15
1.6k
Adopting Sorbet at Scale
Avatar for Ufuk Kayserilioglu ufuk
77
9.5k
RailsConf & Balkan Ruby 2019: The Past, Present, and Future of Rails at GitHub
Avatar for Eileen M. Uchitelle eileencodes
139
34k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1