$30 off During Our Annual Pro Sale. View Details »

Code review in JavaScript

Adam Conrad
October 03, 2019
Programming
0
440

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
140
The Dos and Don'ts of CBRA
acconrad
0
53
A-Frame and You
acconrad
0
30
UX and Performance
acconrad
0
43
SX - Startup Experience
acconrad
0
44

Other Decks in Programming

See All in Programming
Introducing Kotlin Multiplatform in an existing mobile app - Workshop Edition | DevFest Berlin 23
prof18
0
230
ユーザー登録とログインフォームにautocomplete属性を使いましょう
ivanova1991
2
1.7k
車両情報のリアルタイム特徴量基盤の構築
mot_techtalk
0
130
DRIVE CHARTのMLOpsを体感しよう
mot_techtalk
0
120
Findy - エンジニア向け会社紹介 / Findy Letter for Engineers
findyinc
2
59k
ゆめみの Flutter エンジニア育成方法
morikann
0
260
C++20からC++23までの変化
faithandbrave
5
5.9k
インターフェースのラッパーを作る際の落とし穴 / Go Conference mini 2023
mazrean
0
250
GoにおけるCall Graphを用いた 大規模コードベースの影響調査
ffjlabo
0
310
Postman CLI で Integration Test
codemountains
1
300
文系出身・開発未経験エンジニアが 入社から5年間で実践した学習法 〜エンジニアの世界で圧倒的に成長するために〜 (LT) - NIFTY Tech Day 2023
niftycorp
1
140
非同期ツールキット「Vert.x」のご紹介
masatoshiitoh
0
120

Featured

See All Featured
Art, The Web, and Tiny UX
lynnandtonic
286
19k
From Idea to $5000 a Month in 5 Months
shpigford
376
45k
Designing on Purpose - Digital PM Summit 2013
jponch
108
6.2k
YesSQL, Process and Tooling at Scale
rocio
160
13k
XXLCSS - How to scale CSS and keep your sanity
sugarenia
239
1.2M
How To Stay Up To Date on Web Technology
chriscoyier
780
250k
For a Future-Friendly Web
brad_frost
168
8.5k
The Psychology of Web Performance [Beyond Tellerrand 2023]
tammyeverts
1
1.1k
Embracing the Ebb and Flow
colly
77
3.9k
Exploring the Power of Turbo Streams & Action Cable | RailsConf2023
kevinliebholz
0
2.7k
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
12
1.1k
個人開発の失敗を避けるイケてる考え方 / tips for indie hackers
panda_program
44
12k

Transcript

  1. Code review in JavaScript


    View Slide

  2. Who made this cool slide deck???
    ● Director @ indigo (hiring JS devs)
    ● @theadamconrad on Twitter
    ● Contributor to deno
    ● Boston JS co-organizer
    ● Writer for SEDaily and host for
    Software Engineering Radio
    ● ???
    ● P r o f i t

    View Slide

  3. Do u know how to code review?

    View Slide

  4. Do u know how to code review?
    ● It’s not

    View Slide

  5. Do u know how to code review?
    ● It’s not
    → ✅ looks good

    View Slide

  6. Do u know how to code review?
    ● It’s not
    → ✅ looks good
    ● It’s probably more like

    View Slide

  7. Do u know how to code review?
    ● It’s not
    → ✅ looks good
    ● It’s probably more like
    → ⁉ could we split this code up and test it

    View Slide

  8. An example is probably best
    https://github.com/indigo-ag/api-interview/pull/1

    View Slide