Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Adam Conrad
October 03, 2019
Programming
0
610

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
150
The Dos and Don'ts of CBRA
acconrad
0
68
A-Frame and You
acconrad
0
37
UX and Performance
acconrad
0
53
SX - Startup Experience
acconrad
0
57

Other Decks in Programming

See All in Programming
requirements with math
moony
0
500
AI Agentを利用したAndroid開発について
yuchan2215
0
190
Functional APIから再考するLangGraphを使う理由
os1ma
4
630
ローコードサービスの進化のためのモノレポ移行
taro28
1
320
Windows版PHPのビルド手順とPHP 8.4における変更点
matsuo_atsushi
0
360
バックエンドNode.js × フロントエンドDeno で開発して得られた知見
ayame113
4
1.2k
php-fpm がリクエスト処理する仕組みを追う / Tracing-How-php-fpm-Handles-Requests
shin1x1
4
750
SLI/SLOの設定を進めるその前に アラート品質の改善に取り組んだ話
tanden
2
610
WordPress Playground for Developers
iambherulal
0
120
RailsでCQRS/ESをやってみたきづき
suzukimar
2
1.4k
アーキテクトと美学 / Architecture and Aesthetics
nrslib
11
2.8k
Node.js, Deno, Bun 最新動向とその所感について
yosuke_furukawa
PRO
6
3k

Featured

See All Featured
10 Git Anti Patterns You Should be Aware of
lemiorhan
PRO
656
60k
Designing for Performance
lara
605
69k
The Art of Programming - Codeland 2020
erikaheidi
53
13k
Adopting Sorbet at Scale
ufuk
75
9.3k
Writing Fast Ruby
sferik
628
61k
Java REST API Framework Comparison - PWX 2021
mraible
29
8.5k
For a Future-Friendly Web
brad_frost
176
9.6k
Docker and Python
trallard
44
3.3k
Save Time (by Creating Custom Rails Generators)
garrettdimon
PRO
30
1.1k
The Psychology of Web Performance [Beyond Tellerrand 2023]
tammyeverts
46
2.4k
Bootstrapping a Software Product
garrettdimon
PRO
307
110k
ピンチをチャンスに：未来をつくるプロダクトロードマップ #pmconf2020
aki_iinuma
117
51k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1