Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

43e0fc25bbcc4a1bcf1e6139e424ee35?s=47 Adam Conrad
October 03, 2019
Programming
0
76

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

43e0fc25bbcc4a1bcf1e6139e424ee35?s=128

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
120
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
33
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
23
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
28
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
32

Other Decks in Programming

See All in Programming
B7bf4e80841a44f921665e88d874f2c3?s=48 treby
0
130
5c588fdfe782f92fa6b081903edd82bb?s=48 hr01
1
4.3k
Df065863f38c6268cb70ed44b2e2f5b4?s=48 chatii
2
290
5155c9bc5b30d9e2a8fd677695887861?s=48 kaonash
2
1.9k
744a38d972036c3bd0bcdaddafdd5f26?s=48 mathetake
7
2.2k
D76231a2114896dfcc7b79ac69558b79?s=48 yosuke_furukawa
PRO
1
320
8847086af047cbf895ab3277b59529fe?s=48 andpad
0
350
3138f3848e96b7dfc3dba2113bcb43e7?s=48 tmyk110
1
170
3179e6bb62dc91d29bb906ffef4fa2d4?s=48 marcoow
0
160
52cc8a838bf44a589d2572833b2dd1b9?s=48 palkan
2
330
15934fa2aa7b2ce21f091e9b7cffa856?s=48 manfredsteyer
PRO
1
100
091c8449decb2f3549c695b5f903865a?s=48 sh_akira
3
120

Featured

See All Featured
465724d73fe3a92c0879fdfb43a3a6f3?s=48 philhawksworth
192
17k
5b6a2bd86ef643786a381a212e0ef2f1?s=48 geoffreycrofte
25
1k
Be9caeb9d4ef9944d151af909063ed6e?s=48 samlambert
237
10k
78b475797a14c84799063c7cd073962f?s=48 holman
448
140k
A16eb159db895e3b01d3dc95767ad595?s=48 jonyablonski
21
1.3k
Aebc2d07a50011e2a30d38435fde564a?s=48 jrom
116
7.2k
F68cb25ae3e5c2106997454b13b7737d?s=48 brad_frost
157
6.5k
78b475797a14c84799063c7cd073962f?s=48 holman
462
280k
9375a9529679f1b42b567a640d775e7d?s=48 schacon
147
6.7k
D09fad3e36ae6841f54820be0e907f7a?s=48 rocio
155
11k
E6c6e133e74c3b83f04d2861deaa1c20?s=48 searls
204
37k
E190023b66e2b8aa73a842b106920c93?s=48 zenorocha
296
40k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1