Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
610

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.
Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
69
A-Frame and You
Avatar for Adam Conrad acconrad
0
37
UX and Performance
Avatar for Adam Conrad acconrad
0
54
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
61

Other Decks in Programming

See All in Programming
個人開発の学生アプリが企業譲渡されるまで
Avatar for akidon0000 akidon0000
2
1.1k
一緒に働きたくなるプログラマの思想 #QiitaConference
Avatar for mu_zaru mu_zaru
78
20k
七輪ライブラリー: Claude AI で作る Next.js アプリ
Avatar for suneo3476 suneo3476
1
170
複雑なフォームの jotai 設計 / Designing jotai(state) for Complex Forms #layerx_frontend
Avatar for Masayuki Izumi izumin5210
6
1.5k
ComposeでのPicture in Picture
Avatar for takathemax takathemax
0
130
RuboCop: Modularity and AST Insights
Avatar for Koichi ITO koic
2
2.4k
大LLM時代にこの先生きのこるには-ITエンジニア編
Avatar for Kuu fumiyakume
8
3.3k
カオスに立ち向かう小規模チームの装備の選択〜フルスタックTSという装備の強み _ 弱み〜/Choosing equipment for a small team facing chaos ~ Strengths and weaknesses of full-stack TS~
Avatar for 株式会社ビットキー / Bitkey Inc. bitkey
1
130
プロダクト横断分析に役立つ、事前集計しないサマリーテーブル設計
Avatar for Uchide Hiroki(ucchi-) hanon52_
3
530
Road to RubyKaigi: Making Tinny Chiptunes with Ruby
Avatar for makicamel makicamel
4
540
Instrumentsを使用した アプリのパフォーマンス向上方法
Avatar for hinakko hinakko
0
230
Making TCPSocket.new "Happy"!
Avatar for Misaki Shioi(塩井美咲/しおい) coe401_
1
3k

Featured

See All Featured
Practical Orchestrator
Avatar for Shlomi Noach shlominoach
187
11k
Java REST API Framework Comparison - PWX 2021
Avatar for Matt Raible mraible
31
8.5k
Understanding Cognitive Biases in Performance Measurement
Avatar for Philip Tellis bluesmoon
29
1.7k
How to train your dragon (web standard)
Avatar for Monica Dinculescu notwaldorf
91
6k
4 Signs Your Business is Dying
Avatar for Josh Pigford shpigford
183
22k
Facilitating Awesome Meetings
Avatar for Lara Hogan lara
54
6.3k
Why You Should Never Use an ORM
Avatar for John Nunemaker jnunemaker
PRO
56
9.3k
GitHub's CSS Performance
Avatar for Jon Rohan jonrohan
1031
460k
Building Flexible Design Systems
Avatar for Yesenia Perez-Cruz yeseniaperezcruz
329
39k
Music & Morning Musume
Avatar for Bryan Veloso bryan
47
6.5k
How to Ace a Technical Interview
Avatar for Jacob Kaplan-Moss jacobian
276
23k
Building Applications with DynamoDB
Avatar for Matt Wood mza
94
6.4k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1