Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
630

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.
Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
70
A-Frame and You
Avatar for Adam Conrad acconrad
0
40
UX and Performance
Avatar for Adam Conrad acconrad
0
58
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
65

Other Decks in Programming

See All in Programming
The Modern View Layer Rails Deserves: A Vision For 2025 And Beyond @ RailsConf 2025, Philadelphia, PA
Avatar for Marco Roth marcoroth
2
680
イベントストーミング図からコードへの変換手順 / Procedure for Converting Event Storming Diagrams to Code
Avatar for nrs nrslib
2
1.1k
ペアプロ × 生成AI 現場での実践と課題について / generative-ai-in-pair-programming
Avatar for コドモン開発チーム codmoninc
2
21k
PHP 8.4の新機能「プロパティフック」から学ぶオブジェクト指向設計とリスコフの置換原則
Avatar for 武田 憲太郎 kentaroutakeda
2
1k
MCPを使ってイベントソーシングのAIコーディングを効率化する / Streamlining Event Sourcing AI Coding with MCP
Avatar for Tomohisa Takaoka tomohisa
0
160
Result型で“失敗”を型にするPHPコードの書き方
Avatar for Takuma Kajikawa kajitack
5
1k
生成AI時代のコンポーネントライブラリの作り方
Avatar for touyou touyou
1
260
Google Agent Development Kit でLINE Botを作ってみた
Avatar for Kento.Yamada ymd65536
2
260
スタートアップの急成長を支えるプラットフォームエンジニアリングと組織戦略
Avatar for Yusuke Suto sutochin26
1
6.9k
テスト駆動Kaggle
Avatar for ねぼすけAI isax1015
1
520
新メンバーも今日から大活躍！SREが支えるスケールし続ける組織のオンボーディング
Avatar for HonMarkHunt honmarkhunt
5
8.4k
AI時代のソフトウェア開発を考える（2025/07版） / Agentic Software Engineering Findy 2025-07 Edition
Avatar for Takuto Wada twada
PRO
97
35k

Featured

See All Featured
Side Projects
Avatar for Sacha Greif sachag
455
42k
Optimising Largest Contentful Paint
Avatar for Harry Roberts csswizardry
37
3.3k
Creating an realtime collaboration tool: Agile Flush - .NET Oxford
Avatar for Marc Duiker marcduiker
30
2.1k
jQuery: Nuts, Bolts and Bling
Avatar for Doug Neiner dougneiner
63
7.8k
Let's Do A Bunch of Simple Stuff to Make Websites Faster
Avatar for Chris Coyier chriscoyier
507
140k
Dealing with People You Can't Stand - Big Design 2015
Avatar for Cassini Nazir cassininazir
367
26k
RailsConf 2023
Avatar for Aaron Patterson tenderlove
30
1.1k
GraphQLとの向き合い方2022年版
Avatar for Yosuke Kurami quramy
49
14k
The MySQL Ecosystem @ GitHub 2015
Avatar for Sam Lambert samlambert
251
13k
Java REST API Framework Comparison - PWX 2021
Avatar for Matt Raible mraible
31
8.7k
Designing for humans not robots
Avatar for Tammie Lister tammielis
253
25k
ピンチをチャンスに：未来をつくるプロダクトロードマップ #pmconf2020
Avatar for Aki / @LoveIdahoBurger aki_iinuma
126
53k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1