Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review in JavaScript
Search
Adam Conrad
October 03, 2019
Programming
0
480
Code review in JavaScript
How to be a great code reviewer with JavaScript code as an example pull request.
Adam Conrad
October 03, 2019
Tweet
Share
More Decks by Adam Conrad
See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
acconrad
0
140
The Dos and Don'ts of CBRA
acconrad
0
54
A-Frame and You
acconrad
0
31
UX and Performance
acconrad
0
45
SX - Startup Experience
acconrad
0
46
Other Decks in Programming
See All in Programming
ONE WEDGE_Company_Information
1wedge
0
160
プロンプトエンジニアリング入門
tomokusaba
2
960
クソコード動画『カプセル化 Mk-II』 で考える 上手くカプセル化できない理由 / encapsulation2
minodriven
11
7.1k
両面どころかインフラもTSでできるよ ~ 全方位TypeScriptによるプロダクト開発 ~
myfinder
7
2.1k
Deno に Web 標準 API を実装する / Implementing Web Standard API to Deno
petamoriken
0
350
SwiftUI, Jetpack Composeの導入で変化した「家族アルバム みてね」のアプリ開発体験
hicka04
6
390
孤独のCTOグルメという やや奇抜な企画をやった目的と効果
shoheimitani
3
1k
BuefyのMaintainerを引き継いだ件
kikuomax
0
510
Material 3で Material 2ぽい見た目にする
numeroanddev
2
250
自作ソフト(VMagicMirror)がVRMA対応してる話+実装のTips
bakudreameater
0
110
Deep Dive 大規模システムアーキテクチャ/開発組織エンジニアリング / Deep Dive Large-Scale System Architecture, Development Organization Engineering
nrslib
15
2.9k
Compiling Python to WebAssembly with py2wasm
syrusakbary
0
130
Featured
See All Featured
Unsuck your backbone
ammeep
660
56k
The Cult of Friendly URLs
andyhume
72
5.6k
Fashionably flexible responsive web design (full day workshop)
malarkey
397
65k
Dealing with People You Can't Stand - Big Design 2015
cassininazir
355
22k
Cheating the UX When There Is Nothing More to Optimize - PixelPioneers
stephaniewalter
272
12k
The Power of CSS Pseudo Elements
geoffreycrofte
58
4.9k
Navigating Team Friction
lara
177
13k
The Cost Of JavaScript in 2023
addyosmani
13
3.7k
5 minutes of I Can Smell Your CMS
philhawksworth
199
19k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
39
4.3k
The World Runs on Bad Software
bkeepers
PRO
60
6.6k
Embracing the Ebb and Flow
colly
78
4.1k
Transcript
Code review in JavaScript
Who made this cool slide deck??? • Director @ indigo
(hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t
Do u know how to code review?
Do u know how to code review? • It’s not
Do u know how to code review? • It’s not
→ ✅ looks good
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like
Do u know how to code review? • It’s not
→ ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it
An example is probably best https://github.com/indigo-ag/api-interview/pull/1