Upgrade to Pro — share decks privately, control downloads, hide ads and more …
Sign up for free

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
710
0

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
160
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
97
A-Frame and You
Avatar for Adam Conrad acconrad
0
55
UX and Performance
Avatar for Adam Conrad acconrad
0
74
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
78

Other Decks in Programming

See All in Programming
技術的負債を組織課題として解く-増えすぎたマイクロサービスとの戦い-
Avatar for reimaru reimaru
1
2k
GraphRAGのKnowledge Graphを 直接！見る/View-GraphRAG's-KnowledgeGraph-directly!
Avatar for tyumugiko tyumugi1113
1
340
市販E-Readerを乗っ取れ 〜Embedded Swiftで電子ペーパーガジェットを制御する〜
Avatar for Trickart trickart
0
190
Augmenting AI with the Power of Jakarta EE
Avatar for ivargrimstad ivargrimstad
0
200
cdk deploy JawsSonic #MARATHONしながらAWSリソースをデプロイしてみよう
Avatar for アキキー | Akihisa Ikeda akihisaikeda
2
140
wkhtmltopdfの次どうするか問題2026
Avatar for Shinichi Maeshima willnet
2
1.5k
新卒PdEのリアル
Avatar for ryu ryu1013
1
500
海上で動くGoサーバー: goroutineとchannelでさばく航行データストリーム
Avatar for Atsuki Seo atsuki_seo
0
730
Webの地図
Avatar for Yosuke Furukawa yosuke_furukawa
PRO
6
4.6k
AI × TiDD / 2026.09.05 Redmine 大阪
Avatar for tokudiro tokudiro
1
180
Augmenting AI with the Power of Jakarta EE
Avatar for ivargrimstad ivargrimstad
0
210
XP祭りでしか伝わらないフリップネタ #xpjug
Avatar for bayashi murabayashi
0
150

Featured

See All Featured
Building Experiences: Design Systems, User Experience, and Full Site Editing
Avatar for Michelle Schulp Hunt marktimemedia
1
610
BBQ
Avatar for Matthew Crist matthewcrist
89
10k
Building the Perfect Custom Keyboard
Avatar for Naoto Takai takai
2
880
Practical Tips for Bootstrapping Information Extraction Pipelines
Avatar for Matthew Honnibal honnibal
25
2.1k
Building Flexible Design Systems
Avatar for Yesenia Perez-Cruz yeseniaperezcruz
330
41k
ピンチをチャンスに：未来をつくるプロダクトロードマップ #pmconf2020
Avatar for Aki / @LoveIdahoBurger aki_iinuma
128
56k
Getting science done with accelerated Python computing platforms
Avatar for Jacob Tomlinson jacobtomlinson
2
480
The Illustrated Children's Guide to Kubernetes
Avatar for Chris Short chrisshort
51
53k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
Avatar for Tammy Everts tammyeverts
11
1k
Between Models and Reality
Avatar for mayunak mayunak
4
460
Conquering PDFs: document understanding beyond plain text
Avatar for Ines Montani inesmontani
PRO
4
3.1k
Designing for Timeless Needs
Avatar for Cassini Nazir cassininazir
1
480

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1