Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

Avatar for Adam Conrad Adam Conrad
October 03, 2019
Programming
0
680

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Avatar for Adam Conrad

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
Avatar for Adam Conrad acconrad
0
150
The Dos and Don'ts of CBRA
Avatar for Adam Conrad acconrad
0
76
A-Frame and You
Avatar for Adam Conrad acconrad
0
46
UX and Performance
Avatar for Adam Conrad acconrad
0
61
SX - Startup Experience
Avatar for Adam Conrad acconrad
0
73

Other Decks in Programming

See All in Programming
Redox OS でのネームスペース管理と chroot の実現
Avatar for isan isanethen
0
410
The free-lunch guide to idea circularity
Avatar for Holly Cummins hollycummins
0
330
GC言語のWasm化とComponent Modelサポートの実践と課題 - Scalaの場合
Avatar for Rikito Taniguchi tanishiking
0
120
Nostalgia Meets Technology: Super Mario with TypeScript
Avatar for Manfred Steyer manfredsteyer
PRO
0
100
Angular-Apps smarter machen mit Gen AI: Lokal und offlinefähig - Hands-on Workshop!
Avatar for Christian Liebel christianliebel
PRO
0
130
クライアントワークでSREをするということ。あるいは事業会社におけるSREと同じこと・違うこと
Avatar for nnaka2992 nnaka2992
1
360
20260228_JAWS_Beginner_Kansai
Avatar for Takuya Yonezawa takuyay0ne
5
610
DevinとClaude Code、SREの現場で使い倒してみた件
Avatar for karia/Y.Hisamatsu karia
1
1.1k
Codexに役割を持たせる 他のAIエージェントと組み合わせる実務Tips
Avatar for o8n o8n
4
1.4k
Takumiから考えるSecurity_Maturity_Model.pdf
Avatar for gessy0129 gessy0129
1
150
エンジニアの「手元の自動化」を加速するn8n 2026.02.27
Avatar for 西尾義英 symy2co
0
180
PHP 7.4でもOpenTelemetryゼロコード計装がしたい！ / PHPerKaigi 2026
Avatar for Arthur arthur1
1
390

Featured

See All Featured
Tell your own story through comics
Avatar for letsgokoyo letsgokoyo
1
870
Ecommerce SEO: The Keys for Success Now & Beyond - #SERPConf2024
Avatar for Aleyda Solis aleyda
1
1.9k
We Analyzed 250 Million AI Search Results: Here's What I Found
Avatar for Josh Blyskal joshbly
1
1k
CSS Pre-Processors: Stylus, Less & Sass
Avatar for Bermon Painter bermonpainter
360
30k
How to make the Groovebox
Avatar for あそなす asonas
2
2k
Imperfection Machines: The Place of Print at Facebook
Avatar for Scott Boms scottboms
269
14k
Save Time (by Creating Custom Rails Generators)
Avatar for Garrett Dimon garrettdimon
PRO
32
2.5k
Building AI with AI
Avatar for Ines Montani inesmontani
PRO
1
820
Why Mistakes Are the Best Teachers: Turning Failure into a Pathway for Growth
Avatar for Umar Saidu Auna auna
0
93
A better future with KSS
Avatar for Kyle Neath kneath
240
18k
The B2B funnel & how to create a winning content strategy
Avatar for Katarina Dahlin katarinadahlin
PRO
1
310
The Hidden Cost of Media on the Web [PixelPalooza 2025]
Avatar for Tammy Everts tammyeverts
2
250

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1