How to be a great code reviewer with JavaScript code as an example pull request.
Code review in JavaScript
View Slide
Who made this cool slide deck???● Director @ indigo (hiring JS devs)● @theadamconrad on Twitter ● Contributor to deno● Boston JS co-organizer● Writer for SEDaily and host forSoftware Engineering Radio● ???● P r o f i t
Do u know how to code review?
Do u know how to code review?● It’s not
Do u know how to code review?● It’s not→ ✅ looks good
Do u know how to code review?● It’s not→ ✅ looks good● It’s probably more like
Do u know how to code review?● It’s not→ ✅ looks good● It’s probably more like→ ⁉ could we split this code up and test it
An example is probably best https://github.com/indigo-ag/api-interview/pull/1