Code review in JavaScript

43e0fc25bbcc4a1bcf1e6139e424ee35?s=47 Adam Conrad
October 03, 2019
Programming
0
34

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

43e0fc25bbcc4a1bcf1e6139e424ee35?s=128

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
110
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
28
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
21
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
26
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
31

Other Decks in Programming

See All in Programming
5a065e7ea7c56f4b04c2271771688df3?s=48 raykataoka
34
18k
770ede26fb450c104128e35ac37711fd?s=48 musaprg
0
710
3e049ed33195d00a8b745b16c63dce6e?s=48 leew
0
140
C5992092ded9844119ac381eb855873d?s=48 akshaychordiya
1
100
4d78b749c315e21a956053dcbf0508a9?s=48 po3rin
2
480
Faf9deb49f754b79390b64d036725f67?s=48 yuukiyo
1
990
35e08efcf39d692f540047fb756eb4e3?s=48 konifar
1
950
9ae4f3862d4cb0771cfd36e43252f755?s=48 kurotanshi
0
250
1d1580fb0945b0ffadff18e28bead3c5?s=48 adarapata
0
290
Fc96157614ee73039c4a575906167979?s=48 fukumura
0
260
Aae878e0b108379a60ca627ee262befa?s=48 susanpotter
0
180
6e85e396c2fca10e469e67cbede8104e?s=48 yukikimoto
0
130

Featured

See All Featured
1177e050db6bafe62885362edf6e3537?s=48 lauravandoore
8
940
A9179349dd2bdc67f377719f56d85656?s=48 garrettdimon
283
110k
D67fff74178013024d833b3eec6cf27f?s=48 lynnandtonic
265
16k
8081b26e05bb4354f7d65ffc34cbbd67?s=48 chriscoyier
142
19k
20bfe76b3d6105641f879fe45cfc9272?s=48 bkeepers
319
53k
B3ace07412a5178ea778e7eec161fc0a?s=48 jcasabona
6
380
6bb82b13cda86d3b821fa44100335ddf?s=48 thoeni
2
300
Fe6b81005d1553accd6b2a28f6a2bef1?s=48 phodgson
83
3.8k
433acaea1012b25d97ae66da9b998dad?s=48 malarkey
391
60k
E4f5d494ebdc9e7cce1aecf3ce3e8bc1?s=48 shpigford
366
42k
9cde37f47e4a800ea081ea42de8d749a?s=48 dougneiner
55
5.3k
F68cb25ae3e5c2106997454b13b7737d?s=48 brad_frost
154
6.1k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1