Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

Transcript

1. Code review in JavaScript
   
   
   

   View Slide

2. Who made this cool slide deck???
   ● Director @ indigo (hiring JS devs)
   ● @theadamconrad on Twitter
   ● Contributor to deno
   ● Boston JS co-organizer
   ● Writer for SEDaily and host for
   Software Engineering Radio
   ● ???
   ● P r o f i t
   

   View Slide

3. Do u know how to code review?
   

   View Slide

4. Do u know how to code review?
   ● It’s not
   

   View Slide

5. Do u know how to code review?
   ● It’s not
   → ✅ looks good
   

   View Slide

6. Do u know how to code review?
   ● It’s not
   → ✅ looks good
   ● It’s probably more like
   

   View Slide

7. Do u know how to code review?
   ● It’s not
   → ✅ looks good
   ● It’s probably more like
   → ⁉ could we split this code up and test it
   

   View Slide

8. An example is probably best
   https://github.com/indigo-ag/api-interview/pull/1
   

   View Slide