Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review in JavaScript

43e0fc25bbcc4a1bcf1e6139e424ee35?s=47 Adam Conrad
October 03, 2019
Programming
0
270

Code review in JavaScript

How to be a great code reviewer with JavaScript code as an example pull request.

43e0fc25bbcc4a1bcf1e6139e424ee35?s=128

Adam Conrad

October 03, 2019
Tweet

More Decks by Adam Conrad

See All by Adam Conrad
React's Lost Socks: Where Did I Put that Component?
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
130
The Dos and Don'ts of CBRA
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
40
A-Frame and You
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
25
UX and Performance
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
33
SX - Startup Experience
43e0fc25bbcc4a1bcf1e6139e424ee35?s=48 acconrad
0
37

Other Decks in Programming

See All in Programming
Learning DDD輪読会#4 / Learning DDD Book Club #4
E10ba38646a905c8cd2c893c84d5c520?s=48 suzushin54
1
150
Better Reliability through Observability (and Experimentation)
8c73ec710b03be8909e71ad500866934?s=48 ksatirli
PRO
1
350
iOSアプリの技術選択2022
0620564f0125b8b3b7f4fe40c10b8b4e?s=48 tattn
6
2.5k
Jetpack Compose 頑張らないPreviewParameterProvider
785263a3fda3ca9334daeac85c32927f?s=48 horie23
0
110
もしも、 上司に鬼退治を命じられたら~プロジェクト計画編~
Fb0a40e5e7a9dc85520f1646fd41eb44?s=48 higuuu
0
290
実録mruby組み込み体験
5b3338b3676d4f7091a575e584f3a4f4?s=48 coe401_
0
110
職場にPythonistaを増やす方法
86b349524dfba1c635e944f2a9c92e91?s=48 soogie
0
320
プログラミングを勉強したいと言われたら
6dd39716ef7dde18a609703e8e26b7ec?s=48 yuba_4
0
420
A technique to implement DSL in Ruby
110cd4dcaed019b3bd9809e541afdeb6?s=48 okuramasafumi
0
790
LOWYAの信頼性向上とNew Relic
F95bdf0d9003fa506a9f7448335da1af?s=48 kazumax55
4
360
Kotlin KSP - Intro
7589a5a8fec022e8af4e46525150a291?s=48 taehwandev
1
490
「新卒だけ」じゃない！学び直しを支えるミクシィの技術研修を紹介
B16717ef4b7aab0b253d933c3934f280?s=48 mixi_engineers
PRO
0
130

Featured

See All Featured
Bootstrapping a Software Product
A9179349dd2bdc67f377719f56d85656?s=48 garrettdimon
295
110k
Web development in the modern age
465724d73fe3a92c0879fdfb43a3a6f3?s=48 philhawksworth
197
9.3k
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
5b9fe87ec1faa67a4599782930f45ec9?s=48 sstephenson
151
12k
Rails Girls Zürich Keynote
24fc194843a71f10949be18d5a692682?s=48 gr2m
86
12k
GitHub's CSS Performance
64827b31aef81498662e8af4bd6d5157?s=48 jonrohan
1020
410k
Keith and Marios Guide to Fast Websites
E14f55d3f939977cecbf51b64ff6f861?s=48 keithpitt
404
21k
10 Git Anti Patterns You Should be Aware of
Dafc4723e9a1c067796c0fec6f509774?s=48 lemiorhan
638
52k
Atom: Resistance is Futile
7fa6101cd43067653cf4ac6c7ca54305?s=48 akmur
255
20k
Designing Dashboards & Data Visualisations in Web Apps
Fde6c3a50ca518a909ef35c22c0ee0e4?s=48 destraynor
224
49k
5 minutes of I Can Smell Your CMS
465724d73fe3a92c0879fdfb43a3a6f3?s=48 philhawksworth
196
18k
It's Worth the Effort
Ba530e786553390f3fb271848485681c?s=48 3n
172
25k
How GitHub (no longer) Works
78b475797a14c84799063c7cd073962f?s=48 holman
296
140k

Transcript

  1. Code review in JavaScript

  2. Who made this cool slide deck??? • Director @ indigo

    (hiring JS devs) • @theadamconrad on Twitter • Contributor to deno • Boston JS co-organizer • Writer for SEDaily and host for Software Engineering Radio • ??? • P r o f i t

  3. Do u know how to code review?

  4. Do u know how to code review? • It’s not

  5. Do u know how to code review? • It’s not

    → ✅ looks good

  6. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like

  7. Do u know how to code review? • It’s not

    → ✅ looks good • It’s probably more like → ⁉ could we split this code up and test it

  8. An example is probably best https://github.com/indigo-ag/api-interview/pull/1