本当にあった怖いPHPコード7選

今まで仕事で携わってきたPHPでの開発において、可読性、保守性が明らかに低かったコードの例を話し、リファクタリングする場合はどうするかなどを説明します。
例えば、メソッドの引数が7個以上ある。変数名が解読不能。if文のネストが７つ以上あるなどです。

Transcript

1. ླ໦޹೭
   

   View Slide

2. ࣗݾ঺հɾձࣾ঺հ
   ා͍ίʔυͱ͸ʁ
   ຊ౰ʹ͋ͬͨා͍1)1ίʔυબ
   

   View Slide

3. Copyright Re:Build.inc All Rights Reserved.
   ର৅ऀʹ͍ͭͯ
   0
   1)1ͷجૅ஌͕ࣝ͋Δ
   ॳڃऀʙதڃऀ޲͚
   

   View Slide

4. ࣗݾ঺հɾձࣾ঺հ
   

   View Slide

5. Copyright Re:Build.inc All Rights Reserved.
   ࣗݾ঺հ
   1
   ◆໊લ
   
   
   ླ໦ ޹೭(Suzuki Takayuki)
   
   
   ※ಉ੏ಉ໊ଟͯ͘ࠔͬͯ·͢ɻɻɻ
   
   
   ◆ࣗݾ঺հ
   
   
   ɾ1990೥ੜ·Εɻ
   
   
   ɾΤϯδχΞˠϑϦʔϥϯεˠԭೄͰىۀ
   
   
   ɾPHPΧϯϑΝϨϯεԭೄ࣮ߦҕһ௕
   
   
   ◆झຯ
   
   
   ίεϓϨɺԻָϥΠϒɺϚϥιϯେձʹग़Δɺ໺ٿ؍ઓ
   
   
   BDD(Ϗʔνۦಈ։ൃ)
   

   View Slide

6. Copyright Re:Build.inc All Rights Reserved.
   ࣗݾ঺հ
   1
   

   View Slide

7. Copyright Re:Build.inc All Rights Reserved.
   ձࣾ঺հ
   1
   ◆ձ໊ࣾ
   
   
   גࣜձࣾRe:Build
   
   
   ◆ॅॴ
   
   
   ԭೄݝಹ೼ࢢٱໜ஍2-2-2 λΠϜεϏϧ
   
   
   ◆ࣄۀ಺༰
   
   
   ɾࣗࣾWEBαʔϏεͷاըɾ։ൃɻ
   
   
   ɾडୗ։ൃ
   
   
   ɾϓϩάϥϛϯάεΫʔϧ
   
   
   ◆ࣾһ
   
   
   12໊
   
   
   ΤϯδχΞืूͯ͠·͢ʂʂʂ
   
   
   

   View Slide

8. ා͍ίʔυͱ͸ʁ
   

   View Slide

9. Copyright Re:Build.inc All Rights Reserved.
   ͜ͷൃදʹ͓͚Δා͍ίʔυͱ͸ʁ
   - Մಡੑɺอकੑ͕໌Β͔ʹ௿͍ίʔυͳͲΛࢦ͠·͢ɻ
   - ྫ͑͹ɺϝιουͷॲཧ͕෼͔Γʹ͍͘ɻม਺໊͕ղಡෆೳ
   ͳͲͰ͢ɻ
   2
   

   View Slide

10. ຊ౰ʹ͋ͬͨා͍1)1ίʔυબ
    ※࣮ࡍͷίʔυΛΞϨϯδ͠
    ͯɺՍۭͷίʔυΛྫʹग़ͯ͠
    ͍·͢ɻ
    

    View Slide

11. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    3
    ᶃϝιουͷҾ਺͕7ݸҎ্͋Γɺม਺໊͸ΞϧϑΝϕοτΛฒ΂͚ͨͩ
    ൃڰͦ͠͏ʂʂ
    

    View Slide

12. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    3
    ᶃϝιουͷҾ਺͕7ݸҎ্͋Γɺม਺໊͸ΞϧϑΝϕοτΛฒ΂͚ͨͩ
    ݺͼग़͠ݩΛݟͯ΋
    Կͷม਺͔Θ͔Βͳ
    ͍…ɻ
    ม਺໊͸Θ͔Γ΍͢
    ໊͍લʹ͠·͠ΐ͏
    

    View Slide

13. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    ᶄifจͷωετ͕6ݸҎ্͋Δ
    ૣظϦλʔϯΛ͠·
    ͠ΐ͏
    3
    

    View Slide

14. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    ᶅม਺໊͕Θ͔Γʹ͍͘
    ɾҙຯ͕Θ͔Βͳ͍਺ࣈ͸ೖΕͳ͍
    ɾෆཁͳ୯ޠ͸ഉআ͢Δ
    ɾ೔ຊޠΛϩʔϚࣈʹͨ͠ม਺໊͸
    NG
    ɾ഑ྻ΍ίϨΫγϣϯ͸ෳ਺ܗʹ͢
    Δ
    ɾ඼ࢺΛҙࣝ͢Δ
    3
    

    View Slide

15. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    ᶆҰͭͷΞΫγϣϯϝιουʹཪͰ̏ͭΤϯυϙΠϯτ͕ଘࡏ͍ͯ͠Δ
    cinemaͷbladeʹ
    ϨεϙϯεΛฦ͢
    apiͱͯ͠JSONͷ
    ϨεϙϯεΛฦ͢
    eventͷbladeʹ
    ϨεϙϯεΛฦ͢
    ҰͭͷΞΫγϣϯϝιο
    υʹ͸ҰͭͷΤϯυϙΠ
    ϯτʹ͢Δ
    3
    Controller
    Ϋϥε
    /event
    ?mode=apiMode
    ?event=cinema
    ?event=
    

    View Slide

16. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    ᶇίϝϯτΞ΢τ஍ࠈ
    ͍ͭ͜ͷίϝϯτΞ
    ΢τΛ෮׆ͤ͞Δͷ
    ͔ରԠظݶΛܾΊΔ
    3
    

    View Slide

17. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    ᶈϚδοΫφϯόʔ஍ࠈ
    ఆ਺Λఆٛͯ͠ɺ֤਺ࣈ
    ͕ͲͷΑ͏ͳҙຯͳͷ͔
    Θ͔ΔΑ͏ʹ͢Δ
    3
    

    View Slide

18. Copyright Re:Build.inc All Rights Reserved.
    ຊ౰ʹ͋ͬͨා͍PHPίʔυ7બ
    ᶉҰͭͷϑΝΠϧʹ̎ͭΫϥε͕ఆٛ͞Ε͍ͯΔ
    ಛผͳཧ༝͕ͳ͚Ε͹ɺͲ
    ͜ʹΫϥε͕͋Δͷ͔Θ͔
    Γʹ͍͘ͷͰɺ̍ϑΝΠϧ
    ʹ̍Ϋϥεͱ͢Δ
    3
    

    View Slide

19. Copyright Re:Build.inc All Rights Reserved.
    ·ͱΊ
    - Ͳ͏͍͏ίʔυ͕ٕज़తෛ࠴ʹͳΔ͔ཧղͯ͠ɺଞͷਓ͕
    ཧղ͠΍͍͢ίʔυΛॻ͖·͠ΐ͏ʂ
    - ίʔυϨϏϡʔΛೖΕͯଐਓԽ͸ආ͚·͠ΐ͏ɻ
    - ίʔυΛҾ͖ܧ͍ͩਓ͕ٽ͖·͢…
    

    View Slide

20. Copyright Re:Build.inc All Rights Reserved.
    ࢀߟจݙ
    - Ϧʔμϒϧίʔυ
    

    View Slide

21. Copyright Re:Build.inc All Rights Reserved.
    ࠂ஌
    PHPΧϯϑΝϨϯε2022ΛՆࠒʹ։࠵༧ఆͰ͢ʂ
    ※৽ܕίϩφ΢ΠϧεͷӨڹͰ೔ఔ͸લޙ͢ΔՄೳੑ͕͋Γ·͢ɻ
    

    View Slide