Effective Infrastructure Code Review

Once infrastructure becomes code it becomes testable as code (testing is generally considered a pretty good idea). It also becomes reviewable as code. Code review is a powerful complement to testing (and might just be the more effective of the two for finding bugs), spreading knowledge, and improving at the craft of programming

In this talk:
* Be convinced reviewing code review is also a pretty good idea.
* Cover pre and post commit workflows and example tooling to make your day better.
* Lessons from the messy growing pains of growing an organization from virtually no formal code review to reviewing every commit.
* Best practices for being an effective reviewer and reviewee.

Transcript

1. Effective Infrastructure Code Review Chris Burroughs AddThis Chris Burroughs (AddThis) Effective Infrastructure Code Review 1 / 20
2. Chris Burroughs (AddThis) Effective Infrastructure Code Review 2 / 20
3. Chris Burroughs (AddThis) Effective Infrastructure Code Review 3 / 20
4. Diffs/Patches/Revisions Chris Burroughs (AddThis) Effective Infrastructure Code Review 4 / 20
5. Why: Find Bugs Sooner Chris Burroughs (AddThis) Effective Infrastructure Code Review 5 / 20
6. Why: Better than Testing?!? Chris Burroughs (AddThis) Effective Infrastructure Code Review 6 / 20
7. Why: Bus Factor Chris Burroughs (AddThis) Effective Infrastructure Code Review 7 / 20
8. Why: Share Best Practices Chris Burroughs (AddThis) Effective Infrastructure Code Review 8 / 20
9. Why: Reinforce Engineering Culture Chris Burroughs (AddThis) Effective Infrastructure Code Review 9 / 20
10. Example: Never break master Chris Burroughs (AddThis) Effective Infrastructure Code Review 10 / 20
11. Infrastructure as Code Chris Burroughs (AddThis) Effective Infrastructure Code Review 11 / 20
12. Chris Burroughs (AddThis) Effective Infrastructure Code Review 12 / 20
13. When? Pre Post Chris Burroughs (AddThis) Effective Infrastructure Code Review 13 / 20
14. Effective: What? Every commit Chris Burroughs (AddThis) Effective Infrastructure Code Review 14 / 20
15. Effective: Who? Everyone Chris Burroughs (AddThis) Effective Infrastructure Code Review 15 / 20
16. Effective: Review changes not people Empathy is a core engineering value. Chris Burroughs (AddThis) Effective Infrastructure Code Review 16 / 20
17. Effective: Have Computers Lint Chris Burroughs (AddThis) Effective Infrastructure Code Review 17 / 20
18. Effective: Have computers run tests before review Chris Burroughs (AddThis) Effective Infrastructure Code Review 18 / 20
19. Tools Chris Burroughs (AddThis) Effective Infrastructure Code Review 19 / 20
20. Happy Hacking Reviewing! Chris Burroughs (AddThis) Effective Infrastructure Code Review 20 / 20