Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code Reviews: CSS edition

Elea Chang
August 30, 2016
Technology
1
120

Code Reviews: CSS edition

Also known as "decrapifying CSS reviews" or how to do CSS reviews and do them well. As presented at DonutJS.

Elea Chang

August 30, 2016
Tweet

More Decks by Elea Chang

See All by Elea Chang
Unicorns are made, not born
elea
0
150
It doesn't take a unicorn to create rad experiences
elea
1
290

Other Decks in Technology

See All in Technology
ExaDB-D dbaascli で出来ること
oracle4engineer
PRO
0
3.8k
State of Open Source Web Mapping Libraries
dayjournal
0
230
Engineering at LY Corporation
lycorp_recruit_jp
0
590
株式会社島津製作所_研究開発（集団協業と知的生産）の現場を支える、OSS知識基盤システムの導入
akahane92
1
200
組み込みLinuxの時系列
puhitaku
4
1.1k
スクラム成熟度セルフチェックツールを作って得た学びとその活用法
coincheck_recruit
1
110
TanStack Routerに移行するのかい しないのかい、どっちなんだい！ / Are you going to migrate to TanStack Router or not? Which one is it?
kaminashi
0
280
透過型SMTPプロキシによる送信メールの可観測性向上: Update Edition / Improved observability of outgoing emails with transparent smtp proxy: Update edition
linyows
2
200
ドメインの本質を掴む / Get the essence of the domain
sinsoku
2
140
私はこうやってマインドマップでテストすることを出す！
mineo_matsuya
0
300
いざ、BSC討伐の旅
nikinusu
2
730
いろんなものと両立する Kaggleの向き合い方
go5paopao
2
1.1k

Featured

See All Featured
No one is an island. Learnings from fostering a developers community.
thoeni
19
3k
Optimizing for Happiness
mojombo
376
70k
Distributed Sagas: A Protocol for Coordinating Microservices
caitiem20
329
21k
4 Signs Your Business is Dying
shpigford
180
21k
Building Flexible Design Systems
yeseniaperezcruz
327
38k
Navigating Team Friction
lara
183
14k
Understanding Cognitive Biases in Performance Measurement
bluesmoon
26
1.4k
Typedesign – Prime Four
hannesfritz
40
2.4k
JavaScript: Past, Present, and Future - NDC Porto 2020
reverentgeek
47
5k
Embracing the Ebb and Flow
colly
84
4.5k
Designing for humans not robots
tammielis
250
25k
Templates, Plugins, & Blocks: Oh My! Creating the theme that thinks of everything
marktimemedia
26
2.1k

Transcript

  1. /* Code Reviews: CSS edition */ DonutJS elea

  2. ALTERNATE TITLE: Decrapifying CSS reviews

  3. IT’S NOT JUST YOU reviewing CSS is complicated

  4. None

  5. “But what am I even looking for?”

  6. which browsers and platforms do you need it to work

    on? ESTABLISH BASELINES

  7. STANDARDIZE THE THINGS Do you have shared conventions?

  8. CSS STYLE GUIDE? Do you have shared conventions?

  9. CSS STYLE GUIDE? FRAMEWORK? Do you have shared conventions?

  10. FUNCTIONALITY + MAINTAINABILITY

  11. FUNCTIONALITY UI + UX

  12. None

  13. MAINTAINABILITY is this bit of CSS easily understood and reusable?

  14. better CSS reviewing TIPS FOR

  15. What can you offload?

  16. What can you offload? SEMANTICS: THERE’S (PROBABLY) A PLUGIN/ EXTENSION/TOOL

    FOR THAT

  17. What can you offload? SPLIT THE RESPONSIBILITY ROUND 1: PRE-QA

    BY REVIEWEE ROUND 2: BRING IN REVIEWER(S)

  18. Best CSS reviews = collaborative

  19. Best CSS reviews = collaborative

  20. None
  21. None
  22. None

  23. Best CSS reviews = collaborative REVIEWEE: USE YOUR COMMENTS! REVIEWER:

    DON’T ASSUME CONTEXT (RULES OFTEN HAVE EXCEPTIONS)

  24. CONFUSED ABOUT A LINE OF CODE? ASK FOR CLARIFICATION! Best

    CSS reviews = collaborative

  25. (WITH PRACTICE) It’ll all get better! ✨ ✨

  26. /* Thank you DonutJS! */ elea