XXXSerializer#to_json を地道に置き換えている話

Transcript

1. גࣜձࣾλΠϛʔɹShintani Teppei XXXSerializer#to_json Λ ஍ಓʹஔ͖׵͍͑ͯΔ࿩ @euglena1215 ʲΦϑϥΠϯ։࠵ʳomotesando.rb #89
2. ࣗݾ঺հ ৽୩ ఩ฏʢ@euglena1215ʣ • גࣜձࣾλΠϛʔ • όοΫΤϯυΤϯδχΞ • omotesando.rb ࢀՃ2ճ໨Ͱ͢
3. ΞϓϦέʔγϣϯίʔυͰ ͜Μͳ࣮૷ͯ͠·ͤΜ͔ʁ
5. ͜ΕΛ
6. ͜͏௚͍ͯ͠Δ࿩
7. 1 ͳͥ΍͍ͬͯΔͷ͔
8. ͳͥ΍͍ͬͯΔͷ͔ XXXSerializer#to_json Λ࢖ͬͯ JSON ʹγϦΞϥΠζ͢Δͱ
 ࠔΔέʔε͕͋Δ → adapter option Λ൓өͰ͖ͳ͍
9. adapter option ͱ͸ʁ ADAPTER_OPTION_KEYS ʹఆٛ͞Ε͍ͯΔΦϓγϣϯɻ ݸਓతʹҰ൪Α͘࢖͏ͷ͸ key_transform Φϓγϣϯ ݸਓతʹศརͩͱࢥͬͯΔͷ͸ fields Φϓγϣϯ
10. adapter option Λ൓өͰ͖ͳ͍ͱ͸ʁ first_name, last_name Λ field ʹ࣋ͭ UserSerializer ͕ଘࡏ͢ΔͱԾఆɻ key ͕ lower camel ͷ JSON Λग़ྗ͍ͨ͠ɻ firstName: “...”, lastName: “...” ʹ͍ͨ͠ʂ
11. UserSerializer.new ʹΩʔϫʔυҾ਺ͱͯ͠ key_transform Λ༩͑ͯ΋ 
 lower camel ʹ͸ͳΒͳ͍ɻ “lastName”ʹͳͬͯͳ͍... adapter option Λ൓өͰ͖ͳ͍ͱ͸ʁ
12. XXXSerializer.new ͷҾ਺ʹ౉ͨ͠৔߹͸ adapter option ͱͯ͠Ͱ͸ͳ͘ɺ instance option ͱͯ͠ೝࣝ͞ΕΔɻͦͷͨΊɺXXXSerializer#to_json Λ࢖͏ͱ ActiveModelSerializer ͷػೳΛ࢖ͬͯ key Λม׵͢Δ͜ͱ͸Ͱ͖ͳ͍ɻ adapter option Λ൓өͰ͖ͳ͍ͱ͸ʁ
13. ActiveModelSerializer ͸ initializer ͰσϑΥϧτͷ key_transform ΛઃఆͰ͖Δ ͕ɺXXXSerializer#to_json Λ࢖ͬͯ͠·͏ͱ൓ө͞Εͳ͍ͷ΋ࠔΔϙΠϯτͷ1 ͭɻ adapter option Λ൓өͰ͖ͳ͍ͱ͸ʁ
14. Ͳ͏͢Ε͹͍͍ʁ adapter option ͱͯ͠ೝࣝͤ͞ɺkey Λ lower camel ʹม׵͢Δʹ͸ ActiveModelSerializers::SerializableResource.new ͷҾ਺ͱͯ͠౉͢ඞཁ͕͋Δɻ
15. Controller ಺Ͱ͸୹͘ॻ͚ΔΑ͏ʹͳ͍ͬͯΔɻͲͪΒͷॻ͖ํͰ΋OKɻ Ͳ͏͢Ε͹͍͍ʁ
16. Ͳ͏͢Ε͹͍͍ʁ ͦ΋ͦ΋ XXXSerializer#to_json Λ࢖ͬͨ JSON γϦΞϥΠζͷํ๏͸ README ʹهࡌ͞Ε͓ͯΒͣɺREADME ʹ͸ʮγϦΞϥΠζʹ͸ SerializableResource Λ ࢖͍·͠ΐ͏ʯͱॻ͔Ε͍ͯΔɻ
17. READMEʹॻ͍ͯ͋ΔͷͰ READMEΛಡ΋͏ ʙ׬ʙ
18. 2 Ͳ͏΍͍ͬͯΔ͔
19. Ͳ͏΍͍ͬͯΔ͔ ஍ಓʹॻ͖׵͍͔͑ͯ͘͠ͳ͍
20. Ͳ͏΍͍ͬͯΔ͔ Ͳ͏΍ͬͯյͣ͞ʹਐΊ͍͔ͯ͘ ֤ Serializer ʹରԠ͢ΔϚονϟͷத਎Λ༻ҙ͢Δ
21. Ͳ͏΍͍ͬͯΔ͔ request spec ͰϨεϙϯεʹରͯ͠JSONͷߏ଄͕Ұக͢Δ͔Ͳ͏͔Λ֬ೝ͠ɺ յΕ͍ͯͳ͍͜ͱΛશΤϯυϙΠϯτͰνΣοΫ͍ͯ͘͠ɻ APIఆٛ͸ OpenAPI Ͱ؅ཧ͍ͯ͠ΔͷͰ committee-rails Λָ͕Ͱ͖ͦ͏ͳؾ͕ ͭͭ͠ࢼ͍ͤͯͳ͍ͷͰɺར༻ऀΛ੠Λฉ͍ͯΈ͍ͨ 👀
22. ·ͱΊ • XXXSerializer#to_json Ͱ JSON γϦΞϥΠζΛߦ͏ͱ adapter option ͕൓ө͞Εͳ͍ͷͰ README ʹॻ͍ͯ͋Δํ๏ͰγϦΞ ϥΠζ͠Α͏ɻ • committee-rails ࢖ͬͯΔํ͍ͨΒ࢖͍উखΛڭ͍͑ͯͩ͘͞ɻ