Code review beyond code style - DevTalks, Cluj, Romania

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.

Transcript

1. Code reviews @hannesvdvreken @DevTalksRo #devtalks2017
2. Hi, my name is Hannes.
3. !
4. madewithlove.be
5. Code reviews
6. What’s a code review?
7. push commits review commits reply approve
8. push commits review commits reply approve
9. git add -p WHAT MAKES A CODE REVIEW?
11. Why spend time on that?
12. WHY SPEND TIME ON THAT? Why spend time on that? as a submitter:
13. WHY SPEND TIME ON THAT? Why spend time on that? as a reviewer:
14. WHY SPEND TIME ON THAT? Why spend time on that? Management:
15. What should a submitter do?
17. Intermezzo: code style
22. What should a reviewer do? or NOT do?
23. don’ts ❌ WHAT SHOULD A REVIEWER DO?
24. do ✓ WHAT SHOULD A REVIEWER DO?
26. Language
27. OMG I'M A BIG FAN OF UR CODES LANGUAGE
28. LANGUAGE
29. LANGUAGE
30. LANGUAGE
33. Wrapping up
34. Thank you! @hannesvdvreken @DevTalksRo #devtalks2017
35. Time for questions. @hannesvdvreken @DevTalksRo #devtalks2017