Who to blame for long code reviews?

Presentation at the OpenStack Summit, Tokyo (Japan), October 29th 2015. You can watch the video of the presentation.

Transcript

1. Who to blame for long code reviews Jesus M. Gonzalez-Barahona jgb@bitergia.com @jgbarah Bitergia / LibreSoft (URJC) http://bit.ly/openstack-long-reviews OpenStack Summit Tokyo 2015 Tokyo (Japan), October 29th 2015 Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 1 / 26
2. c 2012-2015 Bitergia Some rights reserved. This presentation is distributed under the “Attribution-ShareAlike 4.0” license, by Creative Commons, available at http://creativecommons.org/licenses/by-sa/4.0/ Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 2 / 26
3. I am I, and my circumstance Co-founder of Bitergia: The software development analytics company Dashboards, reports, consultancy... http://bitergia.com Associate Professor at URJC: Understanding free, open source software development Empirical, data analytics approach http://gsyc.es/~jgb Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 3 / 26
4. Let’s find some long reviews... Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 4 / 26
5. All reviews (changesets) for the last two years http://bit.ly/db-openstack-reviews Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 5 / 26
6. Let’s do some magic! Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 6 / 26
7. Reviews more than 10 days old Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 7 / 26
8. But we really don’t know how long reviews in progress will last... Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 8 / 26
9. Reviews more than 10 days old, not still under review Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 9 / 26
10. How long is a long review? Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 10 / 26
11. Reviews more than 50 days old, not still under review Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 11 / 26
12. Let’s double it! Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 12 / 26
13. Reviews more than 100 days old, not still under review Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 13 / 26
14. But... how long are they? How many patchsets? Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 14 / 26
15. Reviews more than 100 days old, not still under review Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 15 / 26
16. Still longer!!! 99% of longer than 100 days reviews are in process for more than 441 days Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 16 / 26
17. Reviews more than 441 days old, not still under review Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 17 / 26
18. How many patchsets? Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 18 / 26
19. Reviews more than 441 days old, not still under review Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 19 / 26
20. But most of these are abandoned reviews Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 20 / 26
21. Reviews more than 100 days old, merged reviews Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 21 / 26
22. How are these long, but finally merged reviews? Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 22 / 26
23. Reviews more than 100 days old, merged reviews Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 23 / 26
24. Details say a lot... Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 24 / 26
25. Reviews more than 100 days old, merged reviews Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 25 / 26
26. So, who to blame? Hardly developers proposing changesets: most of them are accepted after a few patchsets (1-3) Hardly final reviewers accepting them: they are recovering contributions from the far past But there are projects with less long reviews than others For abandoned changesets, probably abandon earlier (but some are still useful after very long periods!) For merged changesets, what about a policy ensuring review in less than x days? Jesus Gonzalez-Barahona (Bitergia) Who to blame for long code reviews OpenStack Summit Tokyo 2015 26 / 26