Flux + Repositoryへリアーキテクチャ後にテストを書き始めて1ヶ月経った話

Transcript

1. Flux + Repository ʹϦΞʔΩςΫνϟޙ ςετΛॻ͖࢝Ί͔ͯΒϲ݄ܦͬͨ࿩
2. ࣗݾ঺հ  ҆ᜊ༞لʢ͋Μ͍͟Ώ͏͖ʣ Twitter: @off2white connpass: tonyu 株式会社 ディー・エヌ・エー - 次世代タクシー配⾞サービス「MOV」 - Androidアプリ開発担当 - プロジェクト管理とコーディングの割合 = 50:50 (気持ちは) 最近困っていること Kotlin-festのLTに採択されたはいいものの いまだに運営さんが⼈を間違えていないか⼼配 Twitter connpass
3. ໨࣍  ςετΛॻ͖࢝Ί͖͔͚ͨͬ ϲ݄લͷ͓ؾ࣋ͪ ϲ݄ޙͷ͓ؾ࣋ͪ   ࣍ͷνϟϨϯδ  
4. ςετΛॻ͖࢝Ί͖͔͚ͨͬ 
5.  ػೳ௥ՃʹΑΓ૿͑ଓ͚Δ2"޻਺
6.  ݱঢ়ϓϩδΣΫτʹςετίʔυ͕ ͕ͬͭΓ͋ΔΘ͚Ͱ͸ͳ͍
7.  $PEF
   XJUIPVU
   UFTUT
   JT
   CBE
   DPEF
8.  TDD 5PEBO r ESJWFO
   r EFWFMPQNFOU
9. ϦΞʔΩςΫνϟͷ࿩ʢͬ͘͟Γʣ 
10. ϦΞʔΩςΫνϟͷ࿩ʢͬ͘͟Γʣ λΫγʔ഑ं .07ͷ৐຿һ޲͚ΞϓϦͷอक͕͠ΜͲ͘ͳ͖ͬͯͨ ˠϦΞʔΩςΫνϟΛ࣮ࢪ ʢ͜͜Βลͷৄ͍͠࿩͸·ͨ୭͔ผͷਓ͕΍ͬͯ͘ΕΔ͸ͣʣ ͬ͘͟Γ΍ͬͨ͜ͱ - γϯάϧϞδϡʔϧ ˠ
    ϚϧνϞδϡʔϧ - ετϦʔϜεύήοςΟ ˠ ίϧʔνϯ
    3Y - ΞʔΩςΫνϟ ˠ 'MVY 
11. ΞʔΩςΫνϟʢ'MVY
    
    3FQPTJUPSZ
    
    4UBUF
    .BDIJOF  'SBHNFOU "DUJPO $SFBUPS %JTQBUDIFS 4UPSF 3FQPTJUPS Z "1* %# 1SFG "DUJPO "DUJPO 4UBUF .BDIJOF "DUJPO "DUJWJUZ /BWJHBUJPO (MPCBM
    "DUJPO '$. .FUFS ֎෦ 3Y
12. ϲ݄લͷ͓ؾ࣋ͪද໌ 
13. ϲ݄લͷ͓ؾ࣋ͪද໌ • 6OJU
    5FTUT
    • +6OJU • *OUFHSBUJPO
    5FTUT • 4QFLͰهࡌ • ࢓༷Λग़ྗ͍ͨ͠ͳ͊ • &F
    5FTUT
    • มΘΒͳͦ͏ͳͱ͜Ζ͚࣮ͩ૷ • ۀ຿༻ΞϓϦͳͷͰෳ਺σΟεϓϨΠαΠζΛߟྀ͢Δඞཁ͕ͳ͍ͷͰ΍Γ΍ͦ͢͏ɻ ಉ࣌ʹεϓϦϯτຖʹ2"νʔϜʹखಈςετΛ͓ئ͍͍ͯ͘͠ӡ༻  ։ൃऴ͔ྃ࣌ΒϦϦʔε·ͰͷظؒΛͳΔ΂͘ݮΒ͢໨త  https://codelabs.developers.google.com/codelabs/android-testing/#2
14. ΞʔΩςΫνϟʢ'MVY
    
    3FQPTJUPSZ
    
    4UBUF
    .BDIJOF  'SBHNFOU "DUJPO $SFBUPS %JTQBUDIFS 4UPSF 3FQPTJUPS Z "1* %# 1SFG "DUJPO "DUJPO 4UBUF .BDIJOF "DUJPO "DUJWJUZ /BWJHBUJPO (MPCBM
    "DUJPO '$. .FUFS ֎෦ 3Y Unit Tests Integration Tests
15. ࡞ઓɿલఏ • ϚϧνϞδϡʔϧԽ͸͢ͰʹࡁΜͰ͍Δঢ়ଶ • #JUSJTF
    $JSDMF$*
    %FQMPZ(BUFͷ$*؀ڥ͸੔͍ͬͯΔ 
16. ୈҰϑΣʔζ • ։ൃϝϯόʔ͕๲Ε্͕Δ૝ఆͩͬͨͨΊɺ࠷ॳͷ͓ؾ͚࣋ͪͩڞ ༗ͯ͠΋ςετͷཻ౓΍ॻ͖ํ͕όϥόϥʹͳ͍ͬͯ͘ͱ༧૝ɻ • Ұ୴ҰਓͰαϯϓϧͱͳΔςετΛॻ͍͍ͯͬͯɺ֤ϞδϡʔϧͲ Μͳ෩ʹॻ͘΂͖͔ڞ༗͢Δ 
17. ୈೋϑΣʔζ • ֤ίʔυमਖ਼࣌ʹ͸ςετίʔυؚ͕·ΕΔΑ͏ʹ͢Δ • ঃʑʹ6*
    5FTUTΛಋೖ͍ͯ͘͠ • ৽نػೳͷ࢓༷͕ݟΕ͹෼͔Δঢ়ଶʢՄೳͰ͋Ε͹υΩϡϝϯτΛ ग़ྗ͍ͨ͠ʣ 
18. ϲ݄ܦͪ·ͨ͠ 
19. ϲ݄ޙͷ͓ؾ࣋ͪ • 6OJU
    5FTUT
    • +6OJU • *OUFHSBUJPO
    5FTUT • 'MVYपΓ͚ͩ4QFLͰهࡌ • ࢓༷Λग़ྗ͍ͨ͠ • &F
    5FTUT
    • 6*͕೔࣍ͰมΘ͍ͬͯ͘ͷͰແཧʢ஌ͬͯͨʣ • มΘΒͳͦ͏ͳͱ͜Ζ͚࣮ͩ૷ • ۀ຿༻ΞϓϦͳͷͰෳ਺σΟεϓϨΠαΠζΛߟྀ͢Δඞཁ͕ͳ͍ͷͰ΍Γ΍ͦ͢͏ɻ ಉ࣌ʹεϓϦϯτຖʹ2"νʔϜʹखಈςετΛ͓ئ͍͍ͯ͘͠ӡ༻  ։ൃऴ͔ྃ࣌ΒϦϦʔε·ͰͷظؒΛͳΔ΂͘ݮΒ͢໨త  https://codelabs.developers.google.com/codelabs/android-testing/#2
20. 6OJU
    5FTUT 
21. 6OJU
    5FTUT • ֤Ϟδϡʔϧ͝ͱʹ6OJU
    5FTUTΛ୶ʑͱ࣮૷͍ͯ͘͠ • *O
    .FNPSZͰͷ3PPNςετ • 3FTQPOTF
    UP
    &OUJUZ
    ͷϚοϐϯάςετ ͳͲ • ϚϧνϞδϡʔϧԽʹΑΓ៉ྷʹґଘؔ܎͕੾Γ཭͞Ε͍ͯΔͨΊ ଞϞδϡʔϧ͕ࢀরͰ͖ͳ͍ɻ֤ςετͷཻ౓͕ἧ͍΍ͯ͘͢ͱͯ ΋ྑ͍ײ͡ɻ 
22.  JOGSBSFQPTJUPSZ JOGSBSFQPTJUPSZ*NQM JOGSBEC JOGSBECJNQM JOGSBBQJ JOGSBBQJJNQM *OGSBSFQPTJUPSZJNQMϞδϡʔϧ͸ *OGSBBQJJNQMͷґଘؔ܎Λ͍࣋ͬͯͳ͍ͷͰ BQJΛؚΊͨ݁߹ςετΛॻ͘͜ͱ͕Ͱ͖ͳ͍
23. 6OJU
    UFTUͰॻ͔ͳ͔ͬͨͱ͜Ζ
    3FQPTJUPSZ  Fragment Action Creator Dis patcher Store Repository API DB Pref Action Action State Machine (App Store) Action Activity Navigation (Global Action) verify(exactly = 0) { apiA.request (… verify(exactly = 0) { apiB.request (… coVerify(exactly = 1) { database.save(… 書いてはみたものの 「mockメソッドが 順番通り呼ばれているか」 くらいの確認しかできなかったので 実りが少なそう → Integration Testsで担保する
24. 6OJU
    UFTUͰॻ͔ͳ͔ͬͨͱ͜Ζ
    "DUJPO$SFBUPS
    4UPSF  'SBHNFOU "DUJPO $SFBUPS %JTQBUDIFS 4UPSF 3FQPTJUPSZ "1* %# 1SFG Action $PNQMFUFE "DUJPO 4UBUF .BDIJOF "QQ
    4UPSF Action "DUJWJUZ Navigation (Global Action) Read only ActionCreatorがActionを発⾏しているかどうか 確認するためにdispatcherを監視する必要があり ならもういっそIntegration Testsで良いかな、 という気持ち val store: Store by memoized { Store(dispatcher) } val statusObserver: Observer<Status> by memoized { // テスト対象 val actionCreator: ActionCreator by memoized { // Given store.status.observeForever(statusObserver)
25. *OUFHSBUJPO
    5FTUT 'MVY 
26.  object Test : Spek({ applyTestTaskExecutor() applyTestCoroutineDispather( Feature(”XXXΛঝ୚͢Δ“) { // Flux val dispatcher = Dispatcher(Schedulers.trampoline()) val store: Store by memoized {Store(dispatcher) } val statusObserver: Observer<Status> by memoized { spyk () } // ςετର৅ val actionCreator: ActionCreator by memoized { DispatchOrderActionCreator( dispatcher = dispatcher, aRepository = mockk(relaxed = true) )
27.  Scenario(”XXXϘλϯ͕ԡ͞Εͨ৔߹ɺXXX͕௨஌͞ΕΔ“) { Given(”εςʔλεΛ؂ࢹ͢Δ“) { store.status.observeForever(statusObserver) } When(”XXXϘλϯ͕ԡ͞Εͨ“) { runBlocking { actionCreator.consentCarRequest() } } Then(“XXX͕௨஌͞ΕΔ") { verifySequence { statusObserver.onChanged(DispatchOrderStatus.InProgress) statusObserver.onChanged(DispatchOrderStatus.OnCompleted) } }
28. 5FTUॻ͖΍͍͢ • DSFBUF"DUJPOͨ݁͠Ռɺ4UBUFʹԿ͕ྲྀΕ͖͔ͯͨΛ֬ೝ͢Δͱ͍͏ϑϩʔʹ౷Ұ Ͱ͖Δ • ଟਓ਺Ͱςετॻ͘৔߹ʹςετهࡌͷϒϨ͕গͳͯ͘ྑͦ͞͏ 
29. *OUFHSBUJPO
    5FTUT 3FQPTJUPSZ 
30.  JOGSBSFQPTJUPSZ JOGSBSFQPTJUPSZ*NQM JOGSBEC JOGSBECJNQM JOGSBBQJ JOGSBBQJJNQM ͜ΜͳςετΛॻ͘
31.  3FQPTJUPSZ*NQMΛ5FTUͰ ΠϯελϯεԽ
32.  *OUFSOBM DMBTT
    3FQPTJUPSZ*NQM
33.  ៉ྷʹґଘੑ͕੾Γ཭͞Ε͍ͯΔ ʢζϧ͸͢Δͳͬͯ ʣ
34. *OGSBSFQPTJUPSZJNQM 3FQPTJUPSZ$PNQPOFOU 3FQPTJUPSZ$PNQPOFOU.PEVMF  *OUFSOBM 3FQPTJUPSZ.PEVMF 3FQPTJUPSZ*NQM *OGSBECJNQM %#$PNQPOFOU %#$PNQPOFOU.PEVMF *OUFSOBM %BHHFS.PEVMF EC*NQM BQQ %BHHFS$PNQPOFOU ֤ϞδϡʔϧͰ͸ $PNQPOFOUͱ $PNQPOFOU.PEVMFͷΈ ެ։͍ͯ͠Δ
35.  %C.PEVMF %C$PNQPOFOU %C$PNQPOFOU.PEVMF @Module(includes = [DbModule.Providers::class]) internal abstract class DbModule { @Binds abstract fun requestDatabase(impl: requestDatabaseImpl): RequestDatabase @Module internal object Providers { @JvmStatic @Provides fun requestDao(db: requestRoomDb): RequestDao { return db.requestDao() }
36.  %C.PEVMF %C$PNQPOFOU %C$PNQPOFOU.PEVMF @Singleton @Component( modules = [ DbModule::class ] ) interface DbComponent { fun requestDatabase(): RequestDatabase
37.  %C.PEVMF %C$PNQPOFOU %C$PNQPOFOU.PEVMF @Module object DbComponentModule { @JvmStatic @Provides @AppScope fun provideRequestDatabase( component: DbComponent ): RequestDatabase { return component.requestDatabase() } @JvmStatic @Provides @AppScope fun provideDbComponent( context: Context, gson: Gson ): DbComponent {
38. *OGSBSFQPTJUPSZJNQM 3FQPTJUPSZ$PNQPOFOU 3FQPTJUPSZ$PNQPOFOU.PEVMF  *OUFSOBM 3FQPTJUPSZ.PEVMF 3FQPTJUPSZ*NQM *OGSBECJNQM %#$PNQPOFOU %#$PNQPOFOU.PEVMF *OUFSOBM %BHHFS.PEVMF EC*NQM BQQ %BHHFS$PNQPOFOU BQQϞδϡʔϧͰ͸ ֤Ϟδϡʔϧͷ $PNQPOFOU.PEVMFΛ .PEVMFͱͯ͠ઃఆ͠ ґଘੑΛղܾ͍ͯ͠Δ
39.  Ϟδϡʔϧ֎ʹެ։͞Ε͍ͯΔͷ͸ $PNQPOFOUͱ$PNQPOFOU.PEVMFͷΈ
40.  $PNQPOFOUͷ#VJMEFS͔ΒΠϯελϯε Λੜ੒ interface RepositoryComponent { fun RequestRepository(): RequestRepository @Component.Builder interface Builder { @BindsInstance fun api(api: Api): Builder @BindsInstance fun gson(gson: Gson): Builder fun build(): RepositoryComponent } companion object { fun builder(): Builder = RepositoryComponent.builder() } }
41.  ͜ΕͰ*NQM͕औಘͰ͖Δʂ @Before fun setup() { repository = MovApiRepositoryComponent.builder() .api(mockk(relaxed = true)) .gson(mockk(relaxed = true)) .requestDatabase(mockk(relaxed = true)) .movApiRequestDatabase(mockk(relaxed = true)) .taxiBusinessRepository(mockk(relaxed = true)) .build() .MovCarRequestRepository() } 3FQPTJUPSZͷ*NQM͕ੜ੒Ͱ͖ͨʂ
42.  શ෦NPDLͳΒ 6OJU
    UFTUTͰ͔͠ͳ͍ͷͰ %#ΛJOKFDU͍ͨ͠
43.  ͱ͸͍͑UFTU*NQMFNFOUBUJPO Ͱ3PPNͷґ ଘؔ܎Λ௥Ճ͢Δͷ΋ͳ͊ͱ͍͏ؾ࣋ͪ
44.  Ͱ͖Ε͹.PEVMFଆͰ5FTU࣌ͩͬͨΒ JO.FNPSZͷΠϯελϯεΛฦͯ͘͠ΕΔํ͕ྑ͍
45.  @Component.Builder interface Builder { @BindsInstance fun context(context: Context): Builder @BindsInstance fun coroutineContext(coroutineContext: CoroutineContext): Builder @BindsInstance fun gson(gson: Gson): Builder @BindsInstance fun testFlag(isTest: Boolean = false): Builder // BuilderʹtestFlagΛ࡞੒ fun build(): DbComponent } %C$PNQPOFOULU
46.  @Module internal object Providers { @Singleton @JvmStatic @Provides fun requestRoomDb( context: Context, isTest: Boolean ): requestRoomDb { // ϑϥάʹΑͬͯ෼ذ return if (isTest) { Room.inMemoryDatabaseBuilder(context, RequestRoomDb::class.java).build() } else { Room.databaseBuilder( context, RequestRoomDb::class.java, "request.db" ).build() } %C.PEVMFLU
47.  W[ @Before fun setup() { val context = ApplicationProvider.getApplicationContext<Context>() component = DbComponent.builder() .context(context) .coroutineContext(Dispatchers.IO) .gson(mockk(relaxed = true)) .testFlag(true) .build() repository = MovApiRepositoryComponent.builder() .api(mockk(relaxed = true)) .gson(mockk(relaxed = true)) .requestDatabase(component.movCarRequestDatabase()) .build() .requestRepository() } 3FQPTJUPSZ5FTULU
48.  ͋ͱ͸"1*ΛJOKFDU͍ͨ͠
49.  JOGSBSFQPTJUPSZ*NQM JOGSBEC JOGSBECJNQM JOGSBBQJ JOGSBBQJJNQM JOGSBBQJEFCVH JOGSBBQJEFCVHJNQM
50.  internal class DebugMovApiImpl @Inject constructor( private val movApi: MovApi ) : DebugMovApi { override fun getXXXRequest( id: Long ): Single<XXXRequestResponse> = if (useMockResponse) { Single.just(XXXRequestResponse()) } else { movApi.getXXXRequest(id) } } %FCVH"QJ*NQMLU
51.  ςετ༻ͷϨεϙϯεσʔλ͕ฦͤΔʂ val movApi = DebugApiComponent.builder() .movApi(mockk(relaxed = true)) .build() .debugApi() .apply { useMockResponse = true } 3FQPTJUPSZ5FTULU ςετ༻ͷϨεϙϯεσʔλ͕ฦͤΔʂ
52. ͨͩ͋Μ·Γྑ͘ͳͦ͞͏ • ςετଆͰ੾Γ཭͞ΕͨϨεϙϯεͷ಺༰Λͳ͔ͥ஌͍ͬͯΔ͜ͱ ʹͳΔ
    ࡉ͔͍Ϩεϙϯεͷ৘ใΛࢦఆͰ͖ͳ͍ • ֎෦͔ΒϨεϙϯε৘ใΛࢦఆͰ͖ΔΑ͏ʹमਖ਼த 
53. ࣍ͷνϟϨϯδ 
54. ࣍ͷνϟϨϯδ • 'MVYͷςετʹؔͯ͠͸'SBHNFOU͔ΒςετͰ͖ͨΒྑͦ͞͏ • 4QFLΛར༻͢Δ͔Ͳ͏͔೰Ήʜ • ͋Δఔ౓ςετ࣮૷ํ๏͕ݻ·͖ͬͯͨͷͰɺϓϩδΣΫτϝϯόʔͰڞ༗ • ͪΒ΄ΒΞʔΩςΫνϟʹԊ͍ͬͯͳ͍࣮૷͕ग़͖͍ͯͯΔͷͰɺςετ͕ॻ͚ͳ͍࣮ ૷ʹͳ͍ͬͯͨΒ௚ͯ͠΋Β͏ • εϓϦϯτ2"࣌ͷෆ۩߹݅਺ͷ௿ԼΛ௥ͬͯΈΔ • 2"޻਺࡟ݮΛૂͬͯΑΓεϐʔυͷ͋Δ։ൃΛ໨ࢦ͢ • ը໘͕ݻ·͖ͬͯͨΒ6*ςετΛ໨ࢦ͢ • ·ͩఘΊͯͳ͍ • ಛʹύλʔϯʹΑͬͯ6*͕੾ΓସΘΔͱ͜Ζ͋ͨΓॻ͖͍ͨ