Fukuoka.go#13+Okayama.go #fukuokago https://fukuokago.connpass.com/event/112073/
- ϓϩδΣΫτ Go modules -ࡾ༔հ / Pepabo R&D Institute, GMO Pepabo, Inc.2019.02.12 Fukuoka.go#13+Okayama.godragon-importsͰരgoimportsੜ׆
View Slide
ϓϦϯγύϧΤϯδχΞࡾ༔հ!NPOPDISPNFHBOF(.0ϖύϘגࣜձࣾϖύϘݚڀॴIUUQTCMPHNPOPDISPNFHBOFDPN
1. Motivation2. Problem of goimports3. Approach by dragon-imports4. Evalution5. Discussion about Go modules3࣍
1.Motivation
͓·͑ࠓ·ͰΠϯϙʔτͨ͠ίʔυͷΛ͓΅͍͑ͯΔͷ͔ʁ
• goimportsimportߦͷߋ৽ΛࣗಈͰߦͬͯ͘ΕΔͨΊඇৗʹศར• goimports։ൃதɼԿ࣮ߦ͞ΕΔ• ୳ࡧରͷύοέʔδ͕૿͑Δͱ࣮ߦ͕͘ͳΓੜ࢈ੑ͕Լ͕Δ• ಛʹghq+pecoͰϩʔΧϧϦϙδτϦΛ౷Ұཧ͍ͯ͠Δ߹ʹݦஶ• ͦ͜Ͱ୳ࡧରͷύοέʔδ͕૿࣮͑ͯߦ͕มΘΒͳ͍άϨʔτͳgoimports͕ٻΊΒΕΔ6goimportsͷԽΛղܾ͍ͨ͠
2.Problem of goimports
• ରͷίʔυΛASTʹม͠importߦΛߋ৽ɼՃɼআɽͦͷޙɼϑΥʔϚοτࡁΈίʔυΛग़ྗ͢Δ• ୳ࡧରͷύοέʔδʹඪ४ϥΠϒϥϦͱ֎෦ύοέʔδ͕͋Δ• $GOPATH/src, $GOPATH/pkg/mod• ରͷೖྗதͷύοέʔδ໊ɼγϯϘϧ໊ͷΈ߹ΘͤΛશͯຬͨ͢ΠϯϙʔτύεΛղܾ͢Δ• math/rand (import path), rand (package name), Int (symbol)8goimportsͷجຊ
9goimportsͷ࣮ߦྫ$ cat imp.txtpackage impfunc hoge() {fmt.Println("hello.")kaburaya.Recorder}$ goimports imp.txtpackage impimport ("fmt""github.com/monochromegane/kaburaya")func hoge() {fmt.Println("hello.")kaburaya.Recorder}
• ΑΓਖ਼͘͠୳ࡧରͱͳΔʮ֎෦ʯύοέʔδ͕૿Ճͨ͠߹ʹ͘ͳΔ• ΫϥΠΞϯτڥ࣌ؒܦաʹΑͬͯ֎෦ύοέʔδҰཡมԽ͢Δ͜ͱ͔Βɼ୳ࡧରͷσΟϨΫτϦ୳ࡧɼߏจղੳɼϦϑΝϨϯεͷநग़Λߦ͏ඞཁ͕͋ΔͨΊɽ• ରʹɼύοέʔδҰཡ͕ڥʹΑͬͯมԽ͠ͳ͍ඪ४ύοέʔδΠϯϙʔτύεɼύοέʔδ໊ɼγϯϘϧͷϦετΛࣄલʹղੳ͞Ε͍ͯΔ10ͳͥgoimports͕͘ͳΔͷ͔
goimportsඪ४ύοέʔδ11package importsvar stdlib = map[string]map[string]bool{"archive/tar": map[string]bool{"ErrFieldTooLong": true,"ErrHeader": true,"ErrWriteAfterClose": true,"ErrWriteTooLong": true,$GOROOT/api/go1.*txtgolang.org/x/tools/imports/mkstdlib.gogolang.org/x/tools/imports/zstdlib.gogolang.org/x/tools/cmd/goimports.go#maingolang.org/x/tools/imports/imports.go#Processgolang.org/x/tools/imports/fix.go#addStdlibCandidatespkg crypto/rsa, method (*PrivateKey) Size() intpkg crypto/rsa, method (*PublicKey) Size() int
• First pass (Πϯϙʔτ͕ඞཁ͔ௐΔ)• ରͷϦϑΝϨϯεҰཡͱimportߦ͕߹க͢Δ͔֬ೝ• Second pass (ඪ४ύοέʔδ·ͨطimportߦ͔Βղܾ)• var stdlib·ͨଞϑΝΠϧͰimportࡁΈͷߦΛީิͱͯ͠߹க͢Δ͔֬ೝ• Third pass (֎෦ύοέʔδ͔Βղܾ)• $GOPATH/src͘͠$GOPATH/pkg/mod͔ΒϦϑΝϨϯεʹࣅͨσΟϨΫτϦΛߜΓࠐΈɼީิϑΝΠϧΛղੳͯ֬͠ೝ12goimportsͷߴԽͷ
13ஈ֊͝ͱͷ࣮ߦTUQBTT ЖT OEQBTT ЖT SEQBTT ЖTΠϯϙʔτෆཁ ඪ४ϥΠϒϥϦͷΤΫεϙʔτΛࢀর ଞϑΝΠϧͷΠϯϙʔτΛࢀর ֎෦ύοέʔδͷΤΫεϙʔτΛࢀর $ tree!"" imp.txt!"" other.go#"" other2.go$ find . -type d | wc -l120840Original goimports
3.Approachby dragon-imports
• ΫϥΠΞϯτڥ͝ͱʹ୳ࡧରͷύοέʔδҰཡਓؒ࣌ؒͰ͔͠มԽ͠ͳ͍• ࣄલղੳͷ݁Ռ͕ݱঢ়ʹԊΘͳ͚Εશ୳ࡧΛߦ͏ϑΥʔϧόοΫ͕Մೳ• ͞ΒʹΠϯϙʔτߦʹޡΓ͕͋ͬͯϏϧυͰࣦഊ͢Δ• ͜ΕΒͷલఏ͔Β֤ΫϥΠΞϯτڥ͝ͱʹ୳ࡧରͷύοέʔδΛҙͷλΠϛϯάͰࣄલղੳ͓ͯ͘͜͠ͱͰgoimportsͷߴԽ͕Մೳ15ఏҊख๏ͷண؟
• monochromegane/dragon-imports• A tool for speedup go imports command • https://github.com/monochromegane/dragon-imports• ඪ४ύοέʔδͱ$GOPATH/srcΛղੳ͠ɼzstdlib.goΛ࠶ੜɼgoimportsͷ࠶Πϯετʔϧ·Ͱߦ͏• zstdlib.go(=var stdlib)ͷͷߴ͞ʹΑΓैੑ൚༻ੑ͕ߴ·Δ16ఏҊख๏ͷ࣮$ go get github.com/monochromegane/dragon-imports/...$ dragon-imports
dragon-imports 17package importsvar stdlib = map[string]map[string]bool{"archive/tar": map[string]bool{"ErrFieldTooLong": true,"ErrHeader": true,"ErrWriteAfterClose": true,"ErrWriteTooLong": true,$GOROOT/api/go1.*txtdragon-imports golang.org/x/tools/imports/zstdlib.gogolang.org/x/tools/cmd/goimports.go#maingolang.org/x/tools/imports/imports.go#Processgolang.org/x/tools/imports/fix.go#addStdlibCandidates$GOPATH/**/*.go
4.Evalution
19࣮ߦ࣌ؒͷൺֱTUQBTT ЖT OEQBTT ЖT SEQBTT ЖTΠϯϙʔτෆཁ ඪ४ϥΠϒϥϦͷΤΫεϙʔτΛࢀর ଞϑΝΠϧͷΠϯϙʔτΛࢀর ֎෦ύοέʔδͷΤΫεϙʔτΛࢀর Original goimportsTUQBTT ЖT OEQBTT ЖT SEQBTT ЖTΠϯϙʔτෆཁ ඪ४ϥΠϒϥϦͷΤΫεϙʔτΛࢀর ଞϑΝΠϧͷΠϯϙʔτΛࢀর ֎෦ύοέʔδͷΤΫεϙʔτΛࢀর Dragonize goimports
5.Discussionabout Go modules
• Go modulesΛ༗ޮʹ͢Δͱ$GOPATH/srcͰͳ͘$GOPATH/pkg/modԼͷόʔδϣχϯάཧ͞Εͨύοέʔδ͕ར༻͞ΕΔ• goimportsͰ୳ࡧରΛಉ͡Α͏ʹΓସ͍͑ͯΔ• ֎෦ύοέʔδʹόʔδϣχϯάͷ֓೦͕ಋೖ͞ΕΔͨΊɼಉҰΠϯϙʔτύεͰ͋ͬͯγϯϘϧϦετ͕ҟͳΔՄೳੑ͕͋Δʢͨͩ͠ϝδϟʔόʔδϣϯ͕ҟͳΔͱ/v2ͷΑ͏ʹผͱͯ͠ѻ͑Δʣ• ඪ४ύοέʔδόʔδϣχϯάͷ֓೦͕·ͩͳ͍ͨΊzstdlib.goෳόʔδϣϯͷγϯϘϧΛѻ͏ߏʹͳ͍ͬͯͳ͍21Go modulesΛͲ͏ѻ͏͔
• Go modulesཧͷ֎෦ύοέʔδΛࣄલղੳ͢Δ• ΦϓγϣϯʹΑͬͯղੳରΛGOPATH/pkg/modʹมߋ͢ΔɽGO111MODULES=autoͷڍಈաظͰ͋Δ͜ͱɼzstdlib.goWorkingDirΛΕͳ͍͜ͱ͔ΒରԠ͠ͳ͍• ֎෦ύοέʔδ֤ϝδϟʔόʔδϣϯͷ࠷৽ͷΈΛࣄલղੳ͢Δ• ϚΠφʔόʔδϣϯҎԼͷෳόʔδϣϯ͕ଘࡏ͢Δ߹ɼbreaking changeͳ͍લఏͰඪ४ύοέʔδͱಉ༷ʹ࠷৽ͷΈରԠɽsemverະରԠͳ֎෦ύοέʔδʹ͓͍ͯຊํʹΑͬͯޡఆࢭɼ࠷৽Խͷಈػ͚ͱ͢Δ• vendoringࣄલղੳ͠ͳ͍• ͦͦڞ௨Խ͞Εͨύοέʔδ܈͕૿େ͢Δ͜ͱͰҾ͖ى͜͞ΕΔԆͰ͋ΓɼϓϩδΣΫτ͝ͱͷ࠷খͷύοέʔδ୳ࡧʹΑΔԆߟ͑ʹ͍ͨ͘Ί 22Go modulesΛͲ͏ѻ͏͔
23dragon-imports $ go get -u github.com/monochromegane/dragon-imports/...$ dragon-imports --gomodules• gomodulesΦϓγϣϯΛ࣮ݧతʹఏڙ• Go1.12ͷਖ਼ࣜαϙʔτͷঢ়گΛݟͯΦϓγϣϯॳظΛtrueͱ͢Δ༧ఆ• ܅ࠓ͙͢go get -u !!!
• Go modulesͰv2Ҏ߱ͷϝδϟʔόʔδϣϯ͝ͱʹΠϯϙʔτύε͕ҟͳΔ• ͔͠͠ύοέʔδύεϝδϟʔόʔδϣϯΛؚ·ͳ͍24v2ͱ͍͏٬$ tree!"" hellomod$ #"" [email protected]#"" [email protected]package mainimport "github.com/donvito/hellomod/v2"func main() {hellomod.SayHello("Melvin")}• ඪ४ϥΠϒϥϦόʔδϣϯΛߟྀ͠ͳ͍ͨΊ “v2”ͱ“hellomod”Λൺֱ͞Εͯ͠·͍ɼ֎෦ύοέʔδ୳ࡧ͕࢝·ͬͯ͠·͏……………………………!!!
R.I.P.
• dragon-importsͷΈΛհͨ͠• UsefulͳΕͲGo modules࣌ʹશରԠݫͦ͠͏• ७ਮʹύοέʔδ͚ͩͷσΟϨΫτϦͱͳΔͷͰԆൃੜ͠ͳ͍ͱࢥΘΕΔɽ͠Β͘ӡ༻ͯ͠ࠔͬͨΒdragon-import.v2Λߟ͑Δɽ• Go modules࣌ͷศརπʔϧ࡞͍ͬͯ͜͏• ͱΓ͋͑ͣGo modulesʹدͤΔʹͨͬͯҰཡΛऔಘ͢ΔͨΊͷ ’mole(ཽ)’Λ࡞ͬͯΔ https://github.com/monochromegane/mole26·ͱΊ
monochromegane
suzukihoge
hschwentner
mrasu
tomokusaba
efbmzwyk999
ari_mharada
gmvalentino8
daipresents
jrsaruo
nozaki
zachklipp
ogiwarat
keavy
jakevdp
edds
jacobian
sachag
hursman
tmm1
garrettdimon
palkan
mza
eileencodes
michaelherold