What a hard work to make the recipe sharing service available on Ruby 1.9.3!

๭ϨγϐαΠτͷ Ruby 1.9.3 ରԠͰۤ࿑͠·ͨ͠
mrkn
Kenta Murata
What a hard work to make the recipe
sharing service available on Ruby 1.9.3!
2013.03.16 #odrk03
1

View Slide

Kenta Murata (mrkn)
DevInfra Engineer
at COOKPAD Inc.
Ruby committer
http://www.flickr.com/photos/kakutani/8526732201/
2

View Slide

3

View Slide

Kenta Murata (mrkn)
DevInfra Engineer
at COOKPAD Inc.
Ruby committer
4

View Slide

Kenta Murata (mrkn)
DevInfra Engineer
at COOKPAD Inc.
Ruby committer
BATMAN
4

View Slide

5

View Slide

Run on 1.9.3-p392 since 26 Feb 2013
5

View Slide

Run on 1.9.3-p392 since 26 Feb 2013
We’ll move to 2.0.0-p0 next month !!!
5

View Slide

REE 1.9.3 2.0.0
809
576
497
REE 1.9.3 2.0.0
1773
1305
1166
ฏۉϨεϙϯελΠϜ [ms] 90% Line [ms]
6

View Slide

http://info.cookpad.com/
7

View Slide

8

View Slide

http://bit.ly/cookpad_jobs
8

View Slide

1.9.3 ҠߦͰ
ۤ࿑ͨ͠ࣄ
9

View Slide

Ϛδίϝ
then/do ͷ୅ΘΓͷ :
Πϯελϯεม਺ΛϒϩοΫύϥϝʔλʹ࢖͏ͳ
Temp le ͷΦʔϓϯϞʔυ͸ ‘w+’
Hash ͷॱং໰୊
Array#to_s ͱ Hash#to_s
(time .. time).include? time
Date#step with ActiveSupport::Duration
enum_with_index
lambda ͷҾ਺Ϛονϯά
next Ͱ͸ϝιου͔Βൈ͚ΒΕͳ͍Α
ଟॏ୅ೖ
Symbol#to_int ͷͪΐͬͱྑ͍࿩
ਖ਼نදݱͷඇޓ׵ੑ
nkf, kconv, jcode, iconv
ΦϦδφϧ String#blank?
ActiveRecord ͱ nil.id
ϝʔϧ
10

View Slide

# coding: utf-8
11

View Slide

౰࣌͸ΈΜͳॻ͍ͯ͘Εͳ͔ͬͨ
12

View Slide

script/insert_magic_comment
13

View Slide

#! /usr/bin/env ruby
# coding: utf-8
def has_magic_comment?(content)
if content.lines.first =~ /\A#!/
first_line = content.lines.take(2).last
else
first_line = content.lines.first
end
comment = first_line.sub(
/(?:\"(?:[^"]|\\\")*\"|\'(?:[^']|\\\')*\'|[^#]*)#/, '').strip
comment =~ /\b(?:en)?coding\s*:\s*(?:utf|UTF)-?8\b/
end
def insert_magic_comment(path)
content = open(path, 'rb') {|io| io.read } rescue $!
return if Exception === content || content.empty?
content.force_encoding('BINARY') if content.respond_to?(:force_encoding)
unless has_magic_comment?(content)
if content =~ /[^\x00-\x7E]/m
$stderr.puts "inserting magic comment to #{path}"
open(path, 'wb') do |io|
io.puts "# coding: utf-8"
io.write content
end
end
end
end
if ARGV[0] == '--pre-commit'
open("|git diff --cached --name-only HEAD") do |io|
while path = io.gets
path.strip!
next unless path =~ /\.rb$/
insert_magic_comment(path)
end
end
else
require 'find'
Find.find(Dir.pwd) do |path|
next unless path =~ /\.rb$/
insert_magic_comment(path)
end
end
14

View Slide

https://gist.github.com/
mrkn/5173137
15

View Slide

if condition:
when condition:
while condition:
16

View Slide

items.each do |@item|
17

View Slide

view template ಺Ͱࢄݟ
18

View Slide

name
description
...

19

View Slide

ϨϯμϦϯά͞ΕΔ·Ͱ
syntax error ͕஗Ԇ͢Δ
20

View Slide

Ͳͷ partial view ͔
Βࢀর͞ΕͯΔ͔ௐ΂
Δͷ͕େมͳͷͰ୯७
ʹ @ ΛऔΔͱࢮ͵
21

View Slide

શͯෛ࠴Ͱஔ͖׵͑ͨ
22

View Slide

name
description
...

23

View Slide

Tempfile ͷΦʔϓϯ
Ϟʔυ͕ ‘w+’ ݻఆ໰୊
24

View Slide

default_external ͸ UTF-8
25

View Slide

ςϯϙϥϦϑΝΠϧʹ
JPEG Λॻ͖ࠐΊͳ͍
26

View Slide

͓ྉཧͷࣸਅΛอଘ
Ͱ͖ͳ͍ʼʻ
27

View Slide

tf.set_encoding(‘BINARY’) \
! if tf.respond_to? :set_encoding
28

View Slide

Hash ͷॱং໰୊
29

View Slide

# ruby-1.8.7 ͷ৔߹
{:a => 1, :b => 2}.to_a
#=> [[:b, 2], [:a, 1]]
# ruby-1.9.3 ͷ৔߹
{:a => 1, :b => 2}.to_a
#=> [[:a, 1], [:b, 2]]
30

View Slide

Hash ͷ map ʹΑΔ݁
ՌΛݕূ͢Δςετͱ͔
31

View Slide

to_s ͷڍಈͷมԽ
32

View Slide

Array#to_s ͕
join(“”) ૬౰ͩͬͨ
33

View Slide

# ruby-1.8.7 ͷ৔߹
%w(a b c).to_s #=> “abc”
# ruby-1.9.3 ͷ৔߹
p %w(a b c).to_s #=> "[\"a\", \"b\", \"c\"]"
34

View Slide

# ruby-1.8.7 ͷ৔߹
[:foo].to_s #=> “foo”
[:foo].first.to_s #=> “foo”
# ruby-1.9.3 ͷ৔߹
[:foo].to_s #=> “[:foo]”
[:foo].first.to_s #=> “foo”
35

View Slide

໌࣏తʹ to_s ΛݺΜ
ͰΔίʔυͳΜͯͦ
Μͳʹͳ͍
36

View Slide

# ruby-1.8.7 ͷ৔߹
“#{[:foo]}” #=> “foo”
“#{[:foo].first}” #=> “foo”
# ruby-1.9.3 ͷ৔߹
“#{[:foo]}” #=> “[:foo]”
“#{[:foo].first}” #=> “foo”
37

View Slide

Hash#to_s ͕
to_a.join(“”) ૬౰ͩͬͨ
38

View Slide

# ruby-1.8.7 ͷ৔߹
p({:a => 1, :b => 2}.to_s)
#=> “b2a1”
# ruby-1.9.3 ͷ৔߹
p({:a => 1, :b => 2}.to_s)
#=> "{:a=>1, :b=>2}"
39

View Slide

(time .. time).include? time
40

View Slide

class Range
def include_with_warn?(obj)
if Time === self.begin
caller.tap do |callstack|
repository_root = File.expand_path(
'../../../../../../../', __FILE__) + '/'
offending_line = callstack.find {|line|
File.expand_path(line.split(':').first).
start_with?(repository_root)
} || callstack.first
$stderr.puts "[WARN] can't iterate from Time
since 1.9 at #{offending_line}"
end
end
include_without_warn?(obj)
end
alias include_without_warn? include?
alias include? include_with_warn?
end
41

View Slide

Date#step ͕
ActiveSupport::Duration Λ
ڋઈͩ͢͠
42

View Slide

# Ruby 1.9.3 Ͱಈ͔ͳ͘ͳͬͨίʔυ
begin_date = Date.parse(“2013/03/01”)
end_date = Date.parse(“2013/06/30”)
begin_date.step(end_date, 1.week) do |date|
...
end
43

View Slide

require 'date'
class Date
def step_with_warn(*args, &block)
unless Numeric === args[1] || args[1].nil?
$stderr.puts "\n[WARN] non-Numeric object is
given for the 2nd argument of step at #{caller[0]}"
$stderr.flush
end
step_without_warn(*args, &block)
end
alias step_without_warn step
alias step step_with_warn
end
44

View Slide

enum_with_index
45

View Slide

each_with_index
46

View Slide

lambda ͷҾ਺Ϛονϯά
47

View Slide

# ApplicationHelper ͷத
def init_handler(foo)
Hash.new {|h, k|
h[k] = lambda {}
}.merge(foo)
end
# ΞϓϦέʔγϣϯίʔυ಺
init_handler(@handlers)
...
@handlers[:foo].call(model)
48

View Slide

wrong number of
arguments (1 for 0)
49

View Slide

Hash.new {|h, k|
h[k] = lambda {|*args| }
}.merge(foo)
end
...
50

View Slide

Hash.new {|h, k|
h[k] = proc {}
}.merge(foo)
end
...
51

View Slide

ࢿྉ࡞ͬͯͯࢥͬͨ
52

View Slide

# null_proc.rb
module NullProc
class << self
def call(*args); end
alias [] call
end
end
require ‘null_proc’
Hash.new {|h, k|
h[k] = NullProc
}.merge(foo)
end
53

View Slide

next Ͱϝιου͔Β
ൈ͚Εͳ͘ͳͬͨ
54

View Slide

class FooController
def show
...
next if params[:bar].blank?
...
end
end
55

View Slide

࣮૷Λ Chanko ͔Β
ίϯτϩʔϥຊମ΁Ҡ
ಈ͢Δͱ͖ʹى͖Δ
56

View Slide

Chanko ͸ Rails Ξ
ϓϦέʔγϣϯΛ؆
୯ʹ֦ு͢Δ࢓૊Έ
57

View Slide

֦ுػೳ͸ϒϩοΫ
Ͱ࣮૷͢Δ
58

View Slide

Chanko ͷதͰ࣮૷͞
ΕͯΔؒ͸ɺ֦ுػೳ
ͷத͔Β୤ग़͢Δͱ͖
͸ next Λ࢖͏
59

View Slide

࣮૷Λ Chanko ͔Β
ίϯτϩʔϥຊମ΁Ҡ
ಈ͢Δͱ͖ʹ return
ʹஔ׵͠๨ΕΔ
60

View Slide

ଟॏ୅ೖ
61

View Slide

# Ruby 1.8.7
lambda {|*a| b = *a }.call(1)
#=> 1
# Ruby 1.9.3
lambda {|*a| b = *a }.call(1)
#=> [1]
62

View Slide

ΧϯϚΛ෇͚Ε͹ྑ͍
63

View Slide

# Ruby 1.8.7
lambda {|*a| b, = *a; b }.call(1)
#=> 1 ↑
# Ruby 1.9.3
lambda {|*a| b, = *a; b }.call(1)
#=> 1 ↑
64

View Slide

Symbol#to_int
65

View Slide

# Ruby 1.8.7
{:foo => “hello world”}[:foo][:bar]
#=> nil
# Ruby 1.9.3
{:foo => “hello world”}[:foo][:bar]
#=> can't convert Symbol into Integer (TypeError)
66

View Slide

Ruby 1.9 Ͱ
Symbol#to_int ͕ফ
͓͔͑ͨ͛Ͱόά͕
໌Β͔ʹʂʂ̍
67

View Slide

ྑ͍࿩
68

View Slide

ਖ਼نදݱͷඇޓ׵
69

View Slide

\s ͷҙຯ (ޙड़)
70

View Slide

\w ͱ \W ͱ
\p{Word}
71

View Slide

\w ͕ US-ASCII ͷൣ
ғʹมΘͬͨ
72

View Slide

\p{Word} ͸ 1.8 Ͱਖ਼
نදݱίϯύΠϧΤ
ϥʔʹͳΔ
73

View Slide

\w → \p{Word}
\W →ɹ ???? ɹ
74

View Slide

if RUBY_VERSION >= ‘1.9’
word = ‘\p{Word}’
re = /(?!#{word})./
else
re = /\W/
end
75

View Slide

ಠࣗͷ
String#blank?
76

View Slide

class String
def blank?
self =~ /\A[\sɹ]*\z/m
end
end
↑ IDEOGRAPHIC SPACE
77

View Slide

໰୊͸ IDEOGRAPHIC SPACE
ͷํ͡Όͳͯ͘ \s ʹ͋Δ
78

View Slide

# for 1.8
class String
UTF8_WHITESPACE_CHAR_PATTERN =
/(?:\s|\xE3\x80\x80)/.freeze
UTF8_BLANK_PATTERN =
/\A(?:#{UTF8_WHITESPACE_CHAR_PATTERN})*\z/.freeze
end
# for 1.9.3
class String
NON_BLANK_SPACE_CHARACTERS =
"\u00A0\u1680\u180E\u2000-\u200B\u202F\u205F".freeze
private_constant :NON_BLANK_SPACE_CHARACTERS
UTF8_WHITESPACE_CHAR_PATTERN =
/(?:(?![#{NON_BLANK_SPACE_CHARACTERS}])\p{Space})/.freeze
UTF8_BLANK_PATTERN =
/\A(?:#{UTF8_WHITESPACE_CHAR_PATTERN})*\z/.freeze
end
79

View Slide

จࣈΤϯίʔσΟϯάม׵ܥ
80

View Slide

NKF ޓ׵ϝιου
81

View Slide

# Ruby 1.8.7
class String
def to_win31j_from_utf8
NKF.nkf(‘-W -s -m0 -x’, self)
end
end
# Ruby 1.9.3
class String
def to_win31j_from_utf8
encode('Windows-31J', 'UTF-8',
invalid: :replace,
undef: :replace,
replace: '')
end
end
82

View Slide

kconv ͷϝιουͰ
ܯࠂΛग़͢
83

View Slide

# Ruby 1.8.7
class String
def tosjis_with_warn
$stderr.puts “[WARN] ... #{caller[0]}”
tosjis_without_warn
end
alias tosjis_without_warn tosjis
alias tosjis tosjis_with_warn
end
# Ruby 1.9.3
class String
def tosjis
$stderr.puts “[WARN] ... #{caller[0]}”
encode(‘Windows-31J’,
invalid: :replace,
undef: :replace,
replace: '')
end
end
84

View Slide

ܯࠂΛग़͢Α͏ʹͯ͠
͓͘ࣄͰɺαʔϏε
։ൃΤϯδχΞ͕ؾ
෇͍ͯमਖ਼ͯ͘͠ΕΔ
85

View Slide

ActiveRecord ͱ
nil.id
86

View Slide

1.8 Ͱ͸ nil.id ͕ 4 Λ
ฦ͢ͷͰྫ֎͕ग़ͳ͍
87

View Slide

if Rails.application.config.whiny_nils
require 'active_support/whiny_nil'
end
if RUBY_VERSION < '1.9'
class NilClass
def id_with_warn(*args)
return 4 unless File.expand_path(caller[0]).
starts_with?(Rails.root)
message = "nil.id was called at #{caller[0]}"
if defined? Logger
Logger.error.post('nil.id', message)
else
$stderr.puts message
end
4
end
alias id_without_warn id
alias id id_with_warn
end
end
88

View Slide

ϝʔϧؔ܎
89

View Slide

ଧ౗ tmail
90

View Slide

tmail → mail.gem
91

View Slide

ۤߦ
92

View Slide

tmail ͷόάʹґଘ
ͨ͠ίʔυ͕͋ͬͨ
93

View Slide

·ͩઓ͍͸ऴΘͬͯ
ͳ͍ɾɾɾ
94

View Slide

ײ૝
95

View Slide

ྑ͘ͳ͍ίʔυΛېࢭ
͢Δඇޓ׵ੑ͸େ׻ܴ
96

View Slide

items.each do |@item|
97

View Slide

ศརͩͬͨࣄ͕Ͱ͖
ͳ͘ͳΔͱ൵͍͠
98

View Slide

# Ruby 1.9.3 Ͱಈ͔ͳ͘ͳͬͨίʔυ
begin_date = Date.parse(“2013/03/01”)
end_date = Date.parse(“2013/06/30”)
begin_date.step(end_date, 1.week) do |date|
...
end
99

View Slide

Ҡߦ TIPS
100

View Slide

Ruby ͷόʔδϣϯผ
ʹϞϯΩʔύονΛ
੔ཧ
101

View Slide

lib/
monkey_patches/
ruby/
1.8/
array/
object/
string/
blank.rb
conversion.rb
encoding.rb
multibyte.rb
1.9/
array/
object/
string/
blank.rb
conversion.rb
encoding.rb
multibyte.rb
2.0/
common/
102

View Slide

# config/initializers/000_load_libs.rb
FileUtils.chdir(‘../../../lib’, __FILE__) do
# load monkey patches for ruby first
Dir[‘monkey_patches/ruby/**/*.rb’].sort.each do |fn|
version = fn.split(‘/’)[2]
case
when version == ‘common’
# do nothing
when RUBY_VERSION < ‘1.9’
next unless version == ‘1.8’
next unless version == ‘1.9’
next unless (‘1.9’...‘2.1’).cover? version
else
next unless version >= ‘2.1’
end
require fn
end
end
103

View Slide

৽͍͠όʔδϣϯͰ
૿͑Δϝιου͸
ύονͰಋೖ͢Δ
104

View Slide

Object#singleton_c
lass
105

View Slide

# for 1.8
class Object
def singleton_class
class << self
self
end
end
end
106

View Slide

String#bytesize
107

View Slide

# for 1.8
class String
alias bytesize size
end
108

View Slide

String#b
109

View Slide

# for 1.8
class String
def b
self
end
end
# for 1.9
class String
def b
dup.force_encoding(‘ASCII-8BIT’)
end
end
110

View Slide

String#force_enco
ding
111

View Slide

# for 1.8
class String
def force_encoding(enc)
self
end
end
112

View Slide

࣮͸͜ΕͰ͸ବ໨
113

View Slide

respond_to?
(:force_encoding) Ͱ 1.9
͔Ͳ͏͔൑அͯ͠ΔϥΠϒ
ϥϦ͕͍͔ͭ͘ଘࡏ͢Δ
114

View Slide

# for 1.8
class String
def method_missing_with_force_encoding(name, *args, &block)
if name == :force_encoding
self
else
method_missing_without_force_encoding(
name, *args, &block)
end
end
alias method_missing_without_force_encoding method_missing
alias method_missing method_missing_with_force_encoding
end
115

View Slide

ΤϯίʔσΟϯάม
׵
116

View Slide

from ͱ to ͷΤϯ
ίʔσΟϯάΛݶఆ
͢Δͱಋೖ͠΍͍͢
117

View Slide

ͨͬͨ͜Ε͚ͩͰΞϓ
Ϧέʔγϣϯίʔυ͔
Β RUBY_VERSION Λ
ݮΒͤΔ
118

View Slide

͓·͚
119

View Slide

irb(main):005:0> keys = (:a .. :d).to_a
=> [:a, :b, :c, :d]
irb(main):006:0> values = (1 .. 4).to_a
=> [1, 2, 3, 4]
irb(main):007:0> Hash[keys.zip(values)]
=> {:a=>1, :b=>2, :c=>3, :d=>4}
120

View Slide

Time.now Λ্ॻ͖͢Δ
ͷ͸ࢭΊΑ͏ ʼʻ
121

View Slide

·ͱΊ
122

View Slide

REE 1.9.3 2.0.0
809
576
497
REE 1.9.3 2.0.0
1773
1305
1166
ฏۉϨεϙϯελΠϜ [ms] 90% Line [ms]
Use Ruby 2.0.0 !!!
123

View Slide

124

View Slide

125

View Slide

What a hard work to make the recipe sharing service available on Ruby 1.9.3!

What a hard work to make the recipe sharing service available on Ruby 1.9.3!

Kenta Murata

More Decks by Kenta Murata

Other Decks in Technology

Featured

Transcript