今日から書けるリーダブルコード

Transcript

1. Ϧʔμϒϧίʔυ ΑΓྑ͍ίʔυΛॻͨ͘Ίͷ࣮ફతͳςΫχοΫ
3. ࠓ೔ͷΰʔϧ ɾϦʔμϒϧίʔυͬͯͳʹʁ ɾͳΜͰϦʔμϒϧίʔυΛॻ͘ͷʁ ɾͲ͏΍ͬͯϦʔμϒϧίʔυΛॻ͘ͷʁ
4. Ϧʔμϒϧίʔυͬͯͳʹʁ 
5. Ϧʔμϒϧίʔυ
   ˜
   SFBEBCMF
   DPEF
   ˜
   ಡΈ΍͍͢ίʔυ
6. ಡΈ΍͍͢ίʔυͬͯ
   ͲΜͳίʔυͩͱࢥ͍·͔͢ʁ
7. ݟͨ໨͕੔͍ͬͯΕ͹ಡΈ΍͍͢ʁ function isNull($array) { foreach($array as $v) { if (is_null($v)) { return false; } } return true; } Πϯσϯτ͕͖Ε͍ͳίʔυ CSSͰ΋͍͍͔΋ function isNull($array) { foreach ($array as $v) { if (is_null($v)) { return false; } } return true; }
8. Ϧʔμϒϧίʔυͱ͸ ଞͷਓ͕࠷୹࣌ؒͰ
   ཧղͰ͖Δίʔυ
9. Ϧʔμϒϧίʔυͱ͸ ଞͷਓ͕࠷୹࣌ؒͰ
   ཧղͰ͖Δίʔυ
10. Ϧʔμϒϧίʔυͱ͸ ଞͷਓ͕࠷୹࣌ؒͰ
    ཧղͰ͖Δίʔυ
11. ୹͍͚Ͳɺ͙͢ʹ͸ཧղͰ͖ͳ͍ if (split(':', $line)[0] === 'root') { // }
12. ௕͘ͳ͍͍͔ͬͯΒӅͯ͠͠·͏ if (split(':', $line)[0] === 'root') { // } $username = split(':', $line)[0]; if ($username === 'root') { // } ˜
13. if (split(':', $line)[0] === 'root') { // } ˜ // ίϩϯͷࠨଆΛநग़͢Δ $username = split(':', $line)[0]; if ($username === root) { // } ඞཁͳΒίϝϯτ΋
14. ͳΜͰϦʔμϒϧίʔυΛॻ͘ͷʁ 
15. ͳΜͰಡΈ΍͍͢ίʔυΛ
    ॻ͍ͨ΄͏͕͍͍ͱࢥ͍·͔͢ʁ
16. Ϧʔμϒϧίʔυͱ͸ ଞͷਓ͕࠷୹࣌ؒͰ
    ཧղͰ͖Δίʔυ
17. ։ൃ͕εϜʔζʹਐΉ ಡΈ΍͍͢ίʔυͳΒʜ
    ɾղऍʹ໎Θͳ͍ɺޡղ͕ੜ·Εͳ͍
    ɾಈ࡞ͷཧղ͕ૣ͘ͳΔ
    ɾҾ͖ܧָ͕͗
    ɾಥવϓϩδΣΫτʹΞαΠϯ͞Εͯ΋େৎ෉ ಡΈʹ͍͘ίʔυͩͱʜ
    ɾೝ͕͍͕ࣝͪ͘͏ɺޡղ͕ੜ͡Δ
    ɾಡΈͨ͘ͳ͘ͳΔ
    ɾετϨεΛײ͡Δ
    ɾͪΐͬͱͨ͠ػೳ௥Ճʹ΋͕͔͔࣌ؒΔ
18. ։ൃ͕εϜʔζʹਐΉ ಡΈ΍͍͢ίʔυͳΒʜ
    ɾղऍʹ໎Θͳ͍ɺޡղ͕ੜ·Εͳ͍
    ɾಈ࡞ͷཧղ͕ૣ͘ͳΔ
    ɾҾ͖ܧָ͕͗
    ɾಥવϓϩδΣΫτʹΞαΠϯ͞Εͯ΋େৎ෉ ಡΈʹ͍͘ίʔυͩͱʜ
    ɾೝ͕͍͕ࣝͪ͘͏ɺޡղ͕ੜ͡Δ
    ɾಡΈͨ͘ͳ͘ͳΔ
    ɾετϨεΛײ͡Δ
    ɾͪΐͬͱͨ͠ػೳ௥Ճʹ΋͕͔͔࣌ؒΔ ಡΈ΍͍͢ίʔυΛॻ͜͏ʂ
19. Ϧʔμϒϧίʔυͬͯ
    Ͳ͏΍ͬͯॻ͘ͷʁ 
20. ͜͜·Ͱͷ෮श ಡΈ΍͍͢ίʔυͬͯͳʹʁ
    ˠ
    ଞͷਓ͕࠷୹࣌ؒͰཧղͰ͖Δίʔυ ͳΜͰಡΈ΍͍͢ίʔυΛॻ͘ͷʁ
    ˠ
    ։ൃ͕εϜʔζʹͳΔ͔Β
    ɹ
    ։ൃָ͕ʹͳΔ͔Β
21. Ͱɺ۩ମతʹͲ͏΍ͬͯॻ͘ͷʁ
22.  
    ૣ͘SFUVSO͢Δ ⁞
    ม਺໊ΛΧϥϑϧʹ͢Δ ⁠
    JGจΛ෼ׂ͢Δ ͙͢ʹਅࣅͰ͖ΔͭͷςΫχοΫ
23. ⁞
    ໊લΛΧϥϑϧʹ͢Δ
24. ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    CFGPSF ͳΜͰ΋ಉ͡ಈࢺʹ͕ͪ͠
    ɾHFU'JMF
    ɾHFU+TPO
    ɾHFU)UNM
    ɾHFU%BUB
    ɾHFU1BHF
    ɾHFU6TFS/BNF
    ɾHFU1BSBNT
    ɾHFU4FBSDI2VFSZ
    
25. ͍ΖΜͳ୯ޠ͕͋Γ·͢
    HFU ͍ۙͱ͜Ζ͔Βऔͬͯ͘Δ
    GFUDI ԕ͍ͱ͜Ζ͔Βऔͬͯ͘Δ
    NBLF ൺֱతখ͞ͳ΋ͷΛ࡞Δ
    ࡐྉΛՃ޻͢Δ
    CVJME ൺֱతେ͖ͳ΋ͷΛ࡞Δ
    ૊ΈཱͯΔ
    HFOFSBUF Կ͔Λม׵ͯ͠࡞Γग़͢
    DSFBUF Կ΋ͳ͍ͱ͜Ζʹ৽͘͠࡞Δ
26. ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    BGUFS HFU)UNM QPTU 
    ɹ%#ʹอଘ͞Ε͍ͯΔ)5.-Λऔͬͯ͘Δ
    GFUDI)UNM VSM 
    ɹࢦఆͨ͠63-͔Β)5.-Λऔͬͯ͘Δ
    HFOFSBUF)UNM UFNQMBUF 
    ɹςϯϓϨʔτ͔Β)5.-Λੜ੒͢Δ
    CVJME)UNM QBSUT 
    ɹ෦඼Λ૊Έ߹Θͤͯ)5.-Λੜ੒͢Δ
27.  
    ૣ͘SFUVSO͢Δ
28.  
    ૣ͘SFUVSO͢Δ
    CFGPSF if (auth(‘admin’)->check() || (auth()->check() && auth()->user()->isPurchased($item) ) ) { if ($item->raw()—>exists()) { return Storage::download($item->raw); } } return redirect()->back(); ݖݶνΣοΫ ϑΝΠϧͷଘࡏ֬ೝ
29.  
    ૣ͘SFUVSO͢Δ
    CFGPSF if (auth(‘admin’)->check() || (auth()->check() && auth()->user()->isPurchased($item) ) ) { if ($item->raw()—>exists()) { return Storage::download($item->raw); } } return redirect()->back(); JGจ͕ωετ͍ͯ͠Δ
30.  
    ૣ͘SFUVSO͢Δ
    BGUFS if ($item->raw()—>doesNotExists()) { return redirect()->back(); } if (auth(‘admin’)->check() || (auth()->check() && auth()->user()->isPurchased($item) ) ) { return Storage::download($item->raw); } return redirect()->back();
31.  
    ૣ͘SFUVSO͢Δ
    BGUFS if ($item->raw()—>doesNotExists()) { return redirect()->back(); } if (auth(‘admin’)->check() || (auth()->check() && auth()->user()->isPurchased($item) ) ) { return Storage::download($item->raw); } return redirect()->back(); ϑΝΠϧͷଘࡏ֬ೝ ݖݶνΣοΫ ϑΝΠϧ͕ͳ͍࣌఺ͰSFUVSO͢Ε͹ɼ
    ݖݶνΣοΫͰϑΝΠϧͷ͜ͱΛؾʹ͠ͳ͍͍ͯ͘
32. ⁠
    JGจΛ෼ׂ͢Δ
33. ⁠
    JGจΛ෼ׂ͢Δ
    BGUFS if ($item->raw()—>doesNotExists()) { return redirect()->back(); } if (auth(‘admin’)->check() || (auth()->check() && auth()->user()->isPurchased($item)) ) { return Storage::download($item->raw); } return redirect()->back(); BENJOͱVTFSΛҰ౓ʹνΣοΫ͠Α͏ͱ
    ͢Δ͔Βͪ͝Όͪ͝Όͯ͠͠·͏
34. ⁠
    JGจΛ෼ׂ͢Δ
    BGUFS if ($item->raw()—>doesNotExists()) { return redirect()->back(); } if (auth(‘admin’)->check()) { return Storage::download($item->raw); } if (auth()->check() && auth()->user()->isPurchased($item)) { return Storage::download($item->raw); } return redirect()->back(); BENJOͷݖݶνΣοΫ VTFSͷݖݶνΣοΫ
35. ⁠
    JGจΛ෼ׂ͢Δ
    BGUFS if ($item->raw()—>doesNotExists()) { return redirect()->back(); } if (auth(‘admin’)->check()) { return Storage::download($item->raw); } if (auth()->check() && auth()->user()->isPurchased($item)) { return Storage::download($item->raw); } return redirect()->back(); ϑΝΠϧͷଘࡏ֬ೝ BENJOͷݖݶνΣοΫ VTFSͷݖݶνΣοΫ
36. ࠓ೔ͷ·ͱΊ ಡΈ΍͍͢ίʔυͬͯͳʹʁ
    ˠ
    ଞͷਓ͕࠷୹࣌ؒͰཧղͰ͖Δίʔυ ͳΜͰಡΈ΍͍͢ίʔυΛॻ͘ͷʁ
    ˠ
    ։ൃ͕εϜʔζʹͳΔ͔Β Ͳ͏΍ͬͯಡΈ΍͍͢ίʔυΛॻ͘ͷʁ
    ˠ
    ͍ΖΜͳςΫχοΫ͕͋ͬͯɺ
    ɹʰϦʔμϒϧίʔυʱͰͨ͘͞Μ঺հ͞Εͯ
    ɹ
    ͍Δ
37. ͓·͚
    ϘπҊ
    ͔ͤͬ͘ͳͷͰ෇͚ͱ͖·͢
38. ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    CFGPSF %#ͷΧϥϜ໊Λྫʹ ෺ཧ໊ ࿦ཧ໊ OFXTEFUBJM ͓஌Βͤ಺༰ BVUIPSTEFUBJM ஶऀʹ͍ͭͯ TFSJFTEFTDSJQUJPO ֓ཁ DMJFOUTEFTDSJQUJPO උߟ
39. %#ͷΧϥϜ໊Λྫʹ ෺ཧ໊ ࿦ཧ໊ OFXTEFUBJM ͓஌Βͤ಺༰ BVUIPSTEFUBJM ஶऀʹ͍ͭͯ TFSJFTEFTDSJQUJPO ֓ཁ DMJFOUTEFTDSJQUJPO උߟ EFUBJM
    ৄࡉɺEFTDSJQUJPO
    આ໌ ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    CFGPSF
40. %#ͷΧϥϜ໊Λྫʹ ෺ཧ໊ ࿦ཧ໊ OFXTEFUBJM ͓஌Βͤ಺༰ BVUIPSTEFUBJM ஶऀʹ͍ͭͯ TFSJFTEFTDSJQUJPO ֓ཁ DMJFOUTEFTDSJQUJPO උߟ ࿦ཧ໊͕ҧ͏ͷʹ෺ཧ໊͸ಉ͡ ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    CFGPSF
41. %#ͷΧϥϜ໊Λྫʹ ෺ཧ໊ ࿦ཧ໊ OFXTEFUBJM ͓஌Βͤ಺༰ BVUIPSTEFUBJM ஶऀʹ͍ͭͯ TFSJFTEFTDSJQUJPO ֓ཁ DMJFOUTEFTDSJQUJPO උߟ ࿦ཧ໊͕ҧ͏ͷʹ෺ཧ໊͸ಉ͡ ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    CFGPSF
42. %#ͷΧϥϜ໊Λྫʹ ෺ཧ໊ ࿦ཧ໊ OFXTEFUBJM ͓஌Βͤ಺༰ BVUIPSTEFUBJM ஶऀʹ͍ͭͯ TFSJFTEFTDSJQUJPO ֓ཁ DMJFOUTEFTDSJQUJPO උߟ ύοͱݟ͚ͨͩͰ͸Θ͔Βͳ͍ ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    CFGPSF
43. ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    BGUFS ӳ୯ޠͷόϦΤʔγϣϯΛ૿΍ͯ͠ΈΔ ෺ཧ໊ ࿦ཧ໊ OFXTCPEZ ͓஌Βͤ಺༰ BVUIPSTEFUBJM ஶऀʹ͍ͭͯ
    ৄࡉ BVUIPSTEFTDSJQUJPO ஶऀʹ͍ͭͯ
    આ໌ TFSJFTPWFSWJFX ֓ཁ DMJFOUTSFNBSL උߟ
44. ӳ୯ޠͷόϦΤʔγϣϯΛ૿΍ͯ͠ΈΔ ෺ཧ໊ ࿦ཧ໊ OFXTCPEZ ͓஌Βͤ಺༰ BVUIPSTEFUBJM ஶऀʹ͍ͭͯ
    ৄࡉ BVUIPSTEFTDSJQUJPO ஶऀʹ͍ͭͯ
    આ໌ TFSJFTPWFSWJFX ֓ཁ DMJFOUTSFNBSL උߟ ӳ୯ޠΛ஌͓ͬͯ͘ ඞཁ͕͋Δ͚Ͳɺ
    ෺ཧ໊Λݟ͚ͨͩͰ ஋Λ૝૾Ͱ͖Δ ⁞
    ໊લΛΧϥϑϧʹ͢Δ
    BGUFS