Upgrade to Pro — share decks privately, control downloads, hide ads and more …

WordCamp SG: Contributing to WordPress Core

Peter Wilson
September 06, 2016

WordCamp SG: Contributing to WordPress Core

Almost everyone will have heard the phrase “don’t hack WordPress core” before, what’s less known is that it’s only the start of the saying. Don’t hack WordPress core, without contributing the hacks back.

Contributing to WordPress core is like riding a bike, it takes a little effort to get started but once you learn it’s a skill you’ll never forget.

You will be given a jump start on contributing, from how to use the bug tracker all the way to contributing a patch and getting your first props.

Peter Wilson

September 06, 2016
Tweet

More Decks by Peter Wilson

Other Decks in Technology

Transcript

  1. Dr. Mirko Junge / Wikimedia Commons (CC)

    View Slide

  2. Public domain

    View Slide

  3. Brooklyn Museum / Wikimedia Commons

    View Slide

  4. Brooklyn Museum / Wikimedia Commons

    View Slide

  5. Christophe Finot / Wikimedia Commons (CC)

    View Slide

  6. Contributing to WordPress Core
    Peter Wilson • peterwilson.cc • @pwcc

    View Slide

  7. Contributing to WordPress
    Peter Wilson • peterwilson.cc • @pwcc

    View Slide

  8. Contributing to WordPress Core
    Peter Wilson • peterwilson.cc • @pwcc

    View Slide

  9. View Slide

  10. } else {
    $classes[] = 'page-template-default';
    Index: /trunk/wp-includes/post-template.php
    =================================================================
    --- /trunk/wp-includes/post-template.php (revision 18411)
    +++ /trunk/wp-includes/post-template.php (revision 18412)
    @@ -490,4 +490,6 @@
    $classes[] = 'page-template';
    $classes[] = 'page-template-' . sanitize_html_class( str_repla
    + } else {
    + $classes[] = 'page-template-default';
    }
    } elseif ( is_search() ) {

    View Slide

  11. Sites using WordPress
    Jan 2011 onward (%)
    5.0%
    10.0%
    15.0%
    20.0%
    25.0%
    30.0%
    1 Jan 2011 1 Jan 2012 1 Jan 2013 1 Jan 2014 1 Jan 2015 1 Jan 2016 30 Jul 2016
    w3techs.com, July 2016

    View Slide

  12. View Slide

  13. View Slide

  14. wordpress.org/about/philosophy/

    View Slide

  15. WordPress Core Trac
    core.trac.wordpress.org

    View Slide

  16. View Slide

  17. core.trac.wordpress.org

    View Slide

  18. core.trac.wordpress.org/browser

    View Slide

  19. make.wordpress.org/core/reports/

    View Slide

  20. core.trac.wordpress.org/my-comments

    View Slide

  21. core.trac.wordpress.org/tickets/major

    View Slide

  22. Boring

    View Slide

  23. Sites using WordPress
    5.0%
    10.0%
    15.0%
    20.0%
    25.0%
    30.0%
    1 Jan 2011 1 Jan 2012 1 Jan 2013 1 Jan 2014 1 Jan 2015 1 Jan 2016 30 Jul 2016
    Boring

    View Slide

  24. Checkout WordPress Core
    A version control love story.

    View Slide

  25. Checkout WordPress via SVN
    wordpress-develop
    https://develop.svn.wordpress.org/trunk/ ↩
    svn checkout ↩

    View Slide

  26. Checkout WordPress Core
    A version control love story.

    View Slide

  27. Clone WordPress via Git
    wordpress-develop
    git://develop.git.wordpress.org ↩
    git clone ↩

    View Slide

  28. Contribute with
    SVN or Git

    View Slide

  29. Public domain

    View Slide

  30. Public domain

    View Slide

  31. View Slide

  32. View Slide

  33. View Slide

  34. View Slide

  35. View Slide

  36. View Slide

  37. View Slide

  38. View Slide

  39. Contributing within
    five minutes

    View Slide

  40. localhost/phpmyadmin

    View Slide

  41. localhost/phpmyadmin

    View Slide

  42. localhost

    View Slide

  43. View Slide

  44. View Slide

  45. View Slide

  46. View Slide

  47. core.trac.wordpress.org/tickets/good-first-bugs

    View Slide

  48. View Slide

  49. View Slide

  50. Creating a patch

    View Slide

  51. ~$ git pull
    Updating 470a9fa..e7a6afc
    Fast-forward
    src/wp-includes/js/swfupload/swfupload.js|2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
    ~$

    View Slide

  52. View Slide

  53. WordCamp Easter Egg
    // Inside get_body_class()
    $title = get_the_title($post_id);
    if ($title == "WordCamp Singapore")
    $classes[] = "September, 2016";

    View Slide

  54. WordCamp Easter Egg

    View Slide

  55. WordCamp Easter Egg


    View Slide

  56. WordCamp Easter Egg
    // Inside get_body_class()
    $title = get_the_title($post_id);
    if ($title == "WordCamp Singapore")
    $classes[] = sanitize_html_class("September, 2016");

    View Slide


  57. WordCamp Easter Egg

    View Slide



  58. WordCamp Easter Egg

    View Slide

  59. Public domain

    View Slide

  60. Malcolm Best (CC)

    View Slide

  61. View Slide

  62. View Slide

  63. View Slide

  64. This is what happens in a world
    without standards.

    View Slide

  65. Saroar Zubair (CC), flic.kr/p/a1ePPd

    View Slide

  66. WordPress Coding Standards
    // Inside get_body_class()
    $title = get_the_title($post_id);
    if ($title == "WordCamp Singapore")
    $classes[] = sanitize_html_class("September, 2016");

    View Slide

  67. WordPress Coding Standards
    // Inside get_body_class()
    $title = get_the_title($post_id);
    if ($title == "WordCamp Singapore")
    $classes[] = sanitize_html_class("September, 2016");

    View Slide

  68. Spaces
    // Inside get_body_class()
    $title = get_the_title( $post_id );
    if ( $title == "WordCamp Singapore" )
    $classes[] = sanitize_html_class( "September, 2016" );

    View Slide

  69. No inline control structures
    // Inside get_body_class()
    $title = get_the_title( $post_id );
    if ( $title == "WordCamp Singapore" ) {
    $classes[] = sanitize_html_class( "September, 2016" );
    }

    View Slide

  70. No inline control structures
    // Inside get_body_class()
    $title = get_the_title( $post_id );
    if ( $title == "WordCamp Singapore" ) {
    $classes[] = sanitize_html_class( "September, 2016" );
    $classes[] = sanitize_html_class( "all-welcome" );
    }

    View Slide

  71. No inline control structures
    // Inside get_body_class()
    $title = get_the_title( $post_id );
    if ( $title == "WordCamp Singapore" ) {
    $classes[] = sanitize_html_class( "September, 2016" );
    }

    View Slide

  72. Single quotes preferred
    // Inside get_body_class()
    $title = get_the_title( $post_id );
    if ( $title == 'WordCamp Singapore' ) {
    $classes[] = sanitize_html_class( 'September, 2016' );
    }

    View Slide

  73. Yoda Conditions
    // Inside get_body_class()
    $title = get_the_title( $post_id );
    if ( 'WordCamp Singapore' == $title ) {
    $classes[] = sanitize_html_class( 'September, 2016' );
    }

    View Slide

  74. === != ==
    // Inside get_body_class()
    $title = get_the_title( $post_id );
    if ( 'WordCamp Singapore' === $title ) {
    $classes[] = sanitize_html_class( 'September, 2016' );
    }

    View Slide

  75. Uploading a patch

    View Slide

  76. WordCamp Easter Egg
    }
    }
    $title = get_the_title( $post_id );
    if ( 'WordCamp Singapore' === $title ) {
    $classes[] = sanitize_html_class( 'September, 2016' );
    }
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);

    View Slide

  77. WordCamp Easter Egg
    }
    }
    $title = get_the_title( $post_id );
    if ( 'WordCamp Singapore' === $title ) {
    $classes[] = sanitize_html_class( 'September, 2016' );
    }
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);
    src/wp-includes/post-template.php

    View Slide

  78. WordCamp Easter Egg
    git diff

    View Slide

  79. WordCamp Easter Egg
    diff --git a/src/wp-includes/post-template.php b/src/wp-includes/post-template.php
    index 7994f89..f1a0cad 100644
    --- a/src/wp-includes/post-template.php
    +++ b/src/wp-includes/post-template.php
    @@ -614,6 +614,11 @@ function get_body_class( $class = '' ) {
    }
    }
    + $title = get_the_title( $post_id );
    + if ( 'WordCamp Singapore' === $title ) {
    + $classes[] = sanitize_html_class( 'September, 2016' );
    + }
    +
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);
    $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/'...

    View Slide

  80. WordCamp Easter Egg
    diff --git a/src/wp-includes/post-template.php b/src/wp-includes/post-template.php
    index 7994f89..f1a0cad 100644
    --- a/src/wp-includes/post-template.php
    +++ b/src/wp-includes/post-template.php
    @@ -614,6 +614,11 @@ function get_body_class( $class = '' ) {
    }
    }
    + $title = get_the_title( $post_id );
    + if ( 'WordCamp Singapore' === $title ) {
    + $classes[] = sanitize_html_class( 'September, 2016' );
    + }
    +
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);
    $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/'...

    View Slide

  81. WordCamp Easter Egg
    diff --git a/src/wp-includes/post-template.php b/src/wp-includes/post-template.php
    index 7994f89..f1a0cad 100644
    --- a/src/wp-includes/post-template.php
    +++ b/src/wp-includes/post-template.php
    @@ -614,6 +614,11 @@ function get_body_class( $class = '' ) {
    }
    }
    + $title = get_the_title( $post_id );
    + if ( 'WordCamp Singapore' === $title ) {
    + $classes[] = sanitize_html_class( 'September, 2016' );
    + }
    +
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);
    $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/'...

    View Slide

  82. WordCamp Easter Egg
    diff --git a/src/wp-includes/post-template.php b/src/wp-includes/post-template.php
    index 7994f89..f1a0cad 100644
    --- a/src/wp-includes/post-template.php
    +++ b/src/wp-includes/post-template.php
    @@ -614,6 +614,11 @@ function get_body_class( $class = '' ) {
    }
    }
    + $title = get_the_title( $post_id );
    + if ( 'WordCamp Singapore' === $title ) {
    + $classes[] = sanitize_html_class( 'September, 2016' );
    + }
    +
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);
    $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/'...

    View Slide

  83. WordCamp Easter Egg
    diff --git a/src/wp-includes/post-template.php b/src/wp-includes/post-template.php
    index 7994f89..f1a0cad 100644
    --- a/src/wp-includes/post-template.php
    +++ b/src/wp-includes/post-template.php
    @@ -614,6 +614,11 @@ function get_body_class( $class = '' ) {
    }
    }
    + $title = get_the_title( $post_id );
    + if ( 'WordCamp Singapore' === $title ) {
    + $classes[] = sanitize_html_class( 'September, 2016' );
    + }
    +
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);
    $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/'...

    View Slide

  84. WordCamp Easter Egg
    diff --git a/src/wp-includes/post-template.php b/src/wp-includes/post-template.php
    index 7994f89..f1a0cad 100644
    --- a/src/wp-includes/post-template.php
    +++ b/src/wp-includes/post-template.php
    @@ -614,6 +614,11 @@ function get_body_class( $class = '' ) {
    }
    }
    + $title = get_the_title( $post_id );
    + if ( 'WordCamp Singapore' === $title ) {
    + $classes[] = sanitize_html_class( 'September, 2016' );
    + }
    +
    if ( is_attachment() ) {
    $mime_type = get_post_mime_type($post_id);
    $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/'...

    View Slide

  85. Generating a patch
    > ~/Downloads/37941.diff
    git diff

    View Slide

  86. git diff
    Generating a patch
    > ~/Downloads/37941.diff

    View Slide

  87. View Slide

  88. View Slide

  89. You retain the copyright.
    You license your code to WordPress

    View Slide

  90. View Slide

  91. View Slide

  92. View Slide

  93. Let the code reviews begin

    View Slide

  94. View Slide

  95. flic.kr/p/y35dEE (CC)

    View Slide

  96. Hack WordPress core,
    contribute code back.

    View Slide

  97. Hack WordPress docs,
    contribute docs back.

    View Slide

  98. Translate WordPress,
    help spread the word.

    View Slide

  99. Contribute however you can,
    however you feel comfortable.

    View Slide

  100. Thank you
    Peter Wilson • peterwilson.cc • @pwcc

    View Slide