Cells refactroing

Transcript

1. Refactoring cells
2. Example
3. Example
4. Example
5. What's the matter?
6. Example
7. Example
8. Example ?
9. Compare
10. Example
11. Compare
12. Compare
13. Compare
14. Compare
15. What we can do?
16. Change templates • Change template for ResumeViewer • Remove template for ResumeViewerVacancy
17. Extended cells
18. What is next?
21. What we can do more?
22. What we can do more?
23. Architectural error
26. What we can do more?
27. What we can do more?
28. Property?
29. Property
31. Next cell
32. What we can do?
33. What is it?
34. What is it?
36. What we can do more?
37. What we can do more?
38. What we can do more? if !a.nil? a else b end a || b
39. What we can do more? if !a.nil? a else b end a || b
40. Danger!!!
42. What we can do more?
43. What we can do more? Property
44. What we can do more? Property
47. Next cell
48. What we can do?
49. What we can do?
50. What we can do more?
51. Without ‘each’ on cells?
52. Create Item::Cell
53. Create Item::Cell
54. Create Item::Cell
55. Create Item::Cell
56. What we can do more?
58. What we can do more?
59. What we can do more? Property
60. Property
61. What we can do more?
63. Use ‘present?’
64. What we can do more?
65. What we can do more?
66. Use ‘delegate’ http://apidock.com/rails/Module/delegate
67. Use ‘delegate’
68. Use ‘delegate’ with ‘allow_nil’ http://apidock.com/rails/Module/delegate
69. Use ‘delegate’ with ‘allow_nil’ http://apidock.com/rails/Module/delegate
71. Next cell
72. What we can do?
73. Refactoring
74. Refactoring
75. Use ‘map’
76. What next?
77. Remove ‘each’
78. Remove ‘each’
79. Create Item::Cell
80. Create Item::Cell
81. What next?
82. What next?
83. Remove ‘item’
84. What do with ‘projects’?
85. Use ‘map’
86. Use ‘map’
87. Create Item::Project::Cell
88. Create Item::Project::Cell
89. Refactor Item::Project::Cell like Item::Cell
90. Refactor Item::Project::Cell like Item::Cell
91. What next?
92. What next?
93. Use ‘map’ and ‘join’?
94. Use ‘map’ and ‘join’?
95. Before refactoring
96. After refactoring
97. Summary
98. Summary • Don’t use ‘each’ on views, use for it nested cell
99. Summary • Don’t use ‘each’ on views, use for it nested cell • Use ‘property’
100. Summary • Don’t use ‘each’ on views, use for it nested cell • Use ‘property’ • Use ‘delegate’
101. Summary • Don’t use ‘each’ on views, use for it nested cell • Use ‘property’ • Use ‘delegate’ • Extend cells instead of code duplication
102. Summary • Don’t use ‘each’ on views, use for it nested cell • Use ‘property’ • Use ‘delegate’ • Extend cells instead of code duplication
103. About extending
104. On evetab
105. Compare
106. Compare
107. Compare
108. WTF???
109. Problems on using cells
110. Problems on using cells
111. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments
112. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments • many logic on templates • don’t use ‘strftime’
113. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments • many logic on templates • don’t use ‘strftime’
114. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments • many logic on templates • don’t use ‘strftime’
115. Use Rails Internationalisation API http://guides.rubyonrails.org/i18n.html#adding-date-time- formats
116. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments • many logic on templates • don’t use ‘strftime’
117. Don’t use object’s interfaces on templates • Use delegates
118. Don’t use object’s interfaces on templates • Use delegates = model.field property :field = field Property
119. Don’t use object’s interfaces on templates • Use delegates = model.field property :field = field Property Delegates = object.field delegate :field, to: :object, prefix: true = object_field
120. Don’t use object’s interfaces on templates • Use delegates • Use decorators methods
121. Don’t use object’s interfaces on templates • Use delegates • Use decorators methods = I18n.l created_at, format: :long def created_at_long_date I18n.l created_at, format: :long end = created_at_long_date
122. Don’t use object’s interfaces on templates • Use delegates • Use decorators methods
123. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments • many logic on templates • don’t use ‘strftime’
124. Logic on templates • Use decorators methods
125. Logic on templates • Use decorators methods
126. Logic on templates • Use decorators methods
127. Logic on templates • Use decorators methods • Don’t use iterators on rendering
128. Logic on templates • Use decorators methods • Don’t use iterators on rendering
129. Logic on templates • Use decorators methods • Don’t use iterators on rendering • Don’t use big condition statements, hide it on another templates, cells to methods
130. Logic on templates • … • Don’t use big condition statements, hide it on another templates, cells to methods
131. Logic on templates • … • Don’t use big condition statements, hide it on another templates, cells to methods
132. Logic on templates • … • Don’t use big condition statements, hide it on another templates, cells to methods If statements have a lot of logic, make sense to create cell for it
133. Logic on templates • … • Don’t use big condition statements, hide it on another templates, cells to methods Good idea hide statement on another template and render it on main template
134. Logic on templates • Use decorators methods • Don’t use iterators on rendering • Don’t use big condition statements, hide it on another templates, cells to methods • Don’t use many condition statements or blocks, hide it on templates
135. Logic on templates • … • Don’t use many condition statements or blocks, hide it on templates
136. Logic on templates • … • Don’t use many condition statements or blocks, hide it on templates
137. Logic on templates • Use decorators methods • Don’t use iterators on rendering • Don’t use big condition statements, hide it on another templates, cells to methods • Don’t use many condition statements or blocks, hide it on templates • If having some nesting levels, use templates
138. Logic on templates • … • If having some nesting levels, use templates
139. Logic on templates • … • If having some nesting levels, use templates
140. Logic on templates • Use decorators methods • Don’t use iterators on rendering • Don’t use big condition statements, hide it on another templates, cells to methods • Don’t use many condition statements or blocks, hide it on templates • If having some nesting levels, use templates • Cells only rendering something, don’t calculate results
141. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments • many logic on templates • don’t use ‘strftime’
142. Cell’s structure problem
143. Cell’s structure problem Dev.by
144. Cell’s structure problem Dev.by
145. Cell’s structure problem Dev.by
146. Cell’s structure problem Dev.by
147. Cell’s structure problem Dev.by
148. Cell’s structure problem Dev.by
149. Cell’s structure problem Dev.by
150. Cell’s structure problem Dev.by
151. Cell’s structure problem Dev.by
152. Cell’s structure problem Dev.by + show
153. Cell’s structure problem Dev.by
154. Cell’s structure problem Dev.by
155. Cell’s structure problem Dev.by
156. Cell’s structure problem Dev.by ???
157. Cell’s structure problem Dev.by main_page
158. Cell’s structure problem Dev.by
159. Cell’s structure problem Dev.by Profile pages
160. Cell’s structure problem Rules:
161. Cell’s structure problem Rules: ?
162. Problems on using cells • don’t use object’s interfaces on templates • cell’s structure • large number of arguments • many logic on templates • don’t use ‘strftime’
163. Summary • Use delegates • Use decorators methods • Don’t use ‘strftime’ • Don’t use iterators on rendering • Don’t use big condition statements, hide it on another templates, cells to methods
164. • Don’t use many condition statements or blocks, hide it on templates • If having some nesting levels, use templates • Cells only rendering something, don’t calculate results