Paris.rb Oct 2014: Be more productive and confident with PullReview

Paris.rb Oct 2014: Be more productive and confident with PullReview

Presentation of PullReview:
- When it's useful
- 2 use cases: assist daily development and drive ad hoc refactoring

https://pullreview.com

3f8fcddf7ab5d1bd90b0a0a9adfd6527?s=128

Christophe Philemotte

October 07, 2014
Tweet

Transcript

  1. None
  2. _toch toch Hi, I'm Christophe

  3. Belgium

  4. Belgium

  5. Co-founder of

  6. A typical Development Day

  7. class Projects::TeamMembersController < Projects::ApplicationController # Authorize before_filter :authorize_admin_project!, except: :leave

    layout "project_settings" def index @group = @project.group @project_members = @project.project_members.order('access_level DESC') end def new @user_project_relation = project.project_members.new end def create users = User.where(id: params[:user_ids].split(',')) @project.team << [users, params[:access_level]] if params[:redirect_to] redirect_to params[:redirect_to] else redirect_to project_team_index_path(@project) end end # … end
  8. $ rake test ....................... Finished in 0.61848 seconds (files took

    1.18 seconds to load) 23 examples, 0 failures
  9. $ git add files $ git commit $ git push

    origin master
  10. But ...

  11. But Alone

  12. None
  13. Nobody Reads Your Code

  14. But Clock is ticking

  15. None
  16. Too few Reviews of Your Code

  17. But Big Team

  18. None
  19. Too Many Code to Review

  20. None
  21. Still, You have to Ship.

  22. $ git push heroku master # or $ cap production

    deploy
  23. Tests Catch Only Expectations

  24. None
  25. Because you're Worried

  26. We're Human

  27. We make mistakes

  28. None
  29. None
  30. None
  31. What if you have ...

  32. None
  33. https://pullreview.com

  34. None
  35. Refactor && Develop

  36. None
  37. None
  38. $ git checkout -b feature/local-asset

  39. None
  40. $ git commit -a $ git push -u origin feature/local-asset

  41. None
  42. None
  43. None
  44. None
  45. $ git commit -a # Fix some style issue *

    remove trailing blank (assets.rb) * remove extra blank line at body end (add_impress_js.rb, document.rb) * favor if for single line body condition (presentation.rb) * missing space between { and | in block (add_reveal_js.rb, presentation.rb, processor_helpers.rb) * space missing after comma (add_reveal_js.rb, presentation.rb, processor_helpers.rb) * space missing before } of block (add_reveal_js.rb, processors_helpers.rb, assets.rb) * space missing to the left of { block (add_reveal_js.rb, assets.rb) * prefer ' (add_reveal_js.rb, add_impress_js.rb) * use new Hash syntax (presentation.rb) Thanks to PullReview.com/Ruby Style Guide
  46. None
  47. None
  48. None
  49. None
  50. None
  51. None
  52. Drive Refactoring

  53. None
  54. None
  55. None
  56. None
  57. None
  58. None
  59. None
  60. None
  61. None
  62. None
  63. None
  64. None
  65. None
  66. None
  67. None
  68. None
  69. None
  70. None
  71. Dev, Spot, Fix, Ship

  72. None
  73. ? https://pullreview.com/ _toch toch pullreview