Paris.rb Oct 2014: Be more productive and confident with PullReview

Presentation of PullReview:
- When it's useful
- 2 use cases: assist daily development and drive ad hoc refactoring

https://pullreview.com

Transcript

2. _toch toch Hi, I'm Christophe
3. Belgium
4. Belgium
5. Co-founder of
6. A typical Development Day
7. class Projects::TeamMembersController < Projects::ApplicationController # Authorize before_filter :authorize_admin_project!, except: :leave layout "project_settings" def index @group = @project.group @project_members = @project.project_members.order('access_level DESC') end def new @user_project_relation = project.project_members.new end def create users = User.where(id: params[:user_ids].split(',')) @project.team << [users, params[:access_level]] if params[:redirect_to] redirect_to params[:redirect_to] else redirect_to project_team_index_path(@project) end end # … end
8. $ rake test ....................... Finished in 0.61848 seconds (files took 1.18 seconds to load) 23 examples, 0 failures
9. $ git add files $ git commit $ git push origin master
10. But ...
11. But Alone
13. Nobody Reads Your Code
14. But Clock is ticking
16. Too few Reviews of Your Code
17. But Big Team
19. Too Many Code to Review
21. Still, You have to Ship.
22. $ git push heroku master # or $ cap production deploy
23. Tests Catch Only Expectations
25. Because you're Worried
26. We're Human
27. We make mistakes
31. What if you have ...
33. https://pullreview.com
35. Refactor && Develop
38. $ git checkout -b feature/local-asset
40. $ git commit -a $ git push -u origin feature/local-asset
45. $ git commit -a # Fix some style issue * remove trailing blank (assets.rb) * remove extra blank line at body end (add_impress_js.rb, document.rb) * favor if for single line body condition (presentation.rb) * missing space between { and | in block (add_reveal_js.rb, presentation.rb, processor_helpers.rb) * space missing after comma (add_reveal_js.rb, presentation.rb, processor_helpers.rb) * space missing before } of block (add_reveal_js.rb, processors_helpers.rb, assets.rb) * space missing to the left of { block (add_reveal_js.rb, assets.rb) * prefer ' (add_reveal_js.rb, add_impress_js.rb) * use new Hash syntax (presentation.rb) Thanks to PullReview.com/Ruby Style Guide
52. Drive Refactoring
71. Dev, Spot, Fix, Ship
73. ? https://pullreview.com/ _toch toch pullreview