Querlyで始めるコードレビューの自動化

コード改善meetup #3

Transcript

1. 2VFSMZͰ࢝ΊΔ
   ίʔυϨϏϡʔͷࣗಈԽ
   ίʔυվળNFFUVQ
   !XBUB
   

   View Slide

2. !XBUB
   w ,B[VNB8BUBOBCF
   w &OHJOFFSBU"DUDBU *OD
   w 4JEF$*ͱ͍͏4BB4ͷ։ൃΛ͠
   ͍ͯ·͢
   w ࢓ࣄͰ͸ओʹ3VCZΛॻ͖·͢
   

   View Slide

3. ίʔυվળʁ
   

   View Slide

4. ৭ʑ͋Γ·͕͢
   ίʔυϨϏϡʔͷ࿩Λ͠·͢
   

   View Slide

5. ίʔυϨϏϡʔ
   w ͦ΋ͦ΋͢Δ΂͖ͳͷ͔
   w ίʔυϨϏϡʔ͓͡͞Μ໰୊
   w ͕࣌ؒऔΒΕ͗͢Δ⏳
   w ͜Μͳʹۤ࿑ͯ͠·Ͱ͢Δඞཁ͋Δʁʁʁ
   w ։ൃʹ࣌ؒΛճͨ͠΄͏͕ɺ݁Ռͱͯ͠ίʔυվળ
   ʹܨ͕ΔͷͰ͸ͳ͍͔
   

   View Slide

6. ίʔυϨϏϡʔΛ͠ͳ͍ੈք
   w ਓ͸ඞͣԿ͔Λࣦ೦͢Δ
   w ͦΕ͕σʔλϕʔεपΓͩͱ൵ࢂ
   w ࣅͨϝιου͕ͦ͜Βதʹੜ͑ͯΔ
   w ʮࢲ͸ͦͷ։ൃʹؔΘ͍ͬͯͳ͍ͷͰ஌Γ·ͤΜʯ
   

   View Slide

7. Ͱ͸Ͳ͏͢Δͷ͔
   w ٽ͖ͳ͕ΒϨϏϡʔ͢Δ
   w ׂͱͲ͏͠Α͏΋ແ͍ͷͰؾ࣋ͪͰղܾ͞Ε͕ͪ
   w ࢓૊ΈԽ͓ͯ͠͡͞ΜԽΛ๷͙
   w 13ʹରͯࣗ͠ಈͰΞαΠϯ͢Δ#PUͱ͔
   w Ұ෦ΛࣗಈԽ͢Δ
   

   View Slide

8. Ͱ͸Ͳ͏͢Δͷ͔
   w ٽ͖ͳ͕ΒϨϏϡʔ͢Δ
   w ׂͱͲ͏͠Α͏΋ແ͍ͷͰؾ࣋ͪͰղܾ͞Ε͕ͪ
   w ࢓૊ΈԽ͓ͯ͠͡͞ΜԽΛ๷͙
   w 13ʹରͯࣗ͠ಈͰΞαΠϯ͢Δ#PUͱ͔
   w Ұ෦ΛࣗಈԽ͢Δ
   

   View Slide

9. ϨϏϡʔͷ͢͢Ί͔ͨ
   w ࣗ෼ͳΒͲ͏ॻ͔͘ʁΛߟ͑ͳ͕ΒݟΔ
   w ࣗಈԽͰ͖Δ෦෼͕͋Γͦ͏
   w ཁٻΛຬ͍ͨͯ͠Δ͔֬ೝ͢Δ
   w Τοδέʔεͷ࿙Ε͕ແ͍͔֬ೝ͢Δ
   

   View Slide

10. ίʔυϨϏϡʔͷ
    ࣗಈԽͰίʔυΛվળ͢Δ
    

    View Slide

11. View Slide

12. 2VFSMZ
    w 1BUUFSO#BTFE$IFDLJOH5PPMGPS3VCZ
    w :".-Ͱࢦఠ͍ͨ͠ίʔυͷύλʔϯͱɺͦΕʹର
    ͢ΔϝοηʔδΛهड़
    w $*Ͱ૸ΒͤΕ͹ɺίʔυϨϏϡʔͷࣗಈԽʹ
    

    View Slide

13. ࣄྫඇਪ঑ͷม਺
    w ৭ʑͳ৔ॴͰ࢖͍ͬͯΔΠϯελϯεม਺ΛॳظԽ
    ͢ΔϝιουʹύϑΥʔϚϯε্ͷ໰୊͕͋Δ
    w Ұؾʹফ͢ͷ͸೉͍͠ͷͰɺ୅༻ϝιουΛ࡞Δ
    w ֘౰ͷΠϯελϯεม਺Λ࢖͏ίʔυ͕͋ͬͨΒϨ
    ϏϡʔͰ஄͖͍ͨ
    

    View Slide

14. View Slide

15. Πϯελϯεม਺͕
    ग़͖ͯͨΒౖΔ
    

    View Slide

16. ࣄྫOVMMBCMFDPMVNO
    w 3BJMTͷϚΠάϨʔγϣϯͰ
    OVMMGBMTFΛࢦఆ͠ͳ͍ͱσϑΥ
    ϧτͰ/6--ڐՄ
    w ඞͣσʔλΛೖΕΔ࣮૷ʹͳͬ
    ͍ͯΔͳΒ͹ɺ/6--ڐՄʹ
    ͳ͍ͬͯΔͱࢥΘ͵όάͷݩ
    ʹͳΔ
    

    View Slide

17. View Slide

18. @TUSJOH TZNCPM OVMM@
    
    

    View Slide

19. @TUSJOH TZNCPM OVMM@
    
    
    UTUSJOHdͷΑ͏ͳهड़
    ʢz@z͸೚ҙͷࣜʣ
    

    View Slide

20. @TUSJOH TZNCPM OVMM@
    
    
    ೚ҙͷγϯϘϧ
    

    View Slide

21. @TUSJOH TZNCPM OVMM@
    
    ͦͷଞͷҾ਺
    

    View Slide

22. @TUSJOH TZNCPM OVMM@
    
    ΩʔϫʔυOVMMΛؚ·ͳ͍
    

    View Slide

23. ͏·͍ͬͯ͘Δʁ
    w ·͊·͊
    w ࡶʹ๨Ε͕ͪͳ͜ͱͱ͔Λ௥ՃͰ͖ΔʢDPVOU
    TJ[F MFOHUIͷ࢖͍෼͚ͱ͔ʣ
    w ࣗಈԽͯ͠ϊ΢ϋ΢Λ஝ੵ͍͖ͯ͠·͠ΐ͏
    

    View Slide