Upgrade to Pro — share decks privately, control downloads, hide ads and more …

RESCUE SQUAD: Rails Edition - Ancient City Ruby 2015

RESCUE SQUAD: Rails Edition - Ancient City Ruby 2015

Ben Lovell

March 28, 2015
Tweet

More Decks by Ben Lovell

Other Decks in Programming

Transcript

  1. RESCUE SQUAD
    RAILS EDITION
    Ancient City Ruby 2015

    View Slide

  2. I ❤ 'ancient' city

    View Slide

  3. ben.lovell.720p.S01_E02.mkv

    View Slide

  4. View Slide

  5. View Slide

  6. View Slide

  7. london

    View Slide

  8. england

    View Slide

  9. london

    View Slide

  10. not yoga, drunk

    View Slide

  11. View Slide

  12. psa: don't stare into the eclipse

    View Slide

  13. View Slide

  14. View Slide

  15. View Slide

  16. View Slide

  17. View Slide

  18. ben lovell ltd ™ © ®
    giving no fucks since 2014

    View Slide


  19. View Slide

  20. rails
    sucks

    View Slide

  21. $ rails new life_is_good

    View Slide

  22. View Slide

  23. View Slide

  24. View Slide

  25. View Slide

  26. View Slide

  27. View Slide

  28. View Slide

  29. View Slide

  30. @benlovell
    twitter/github/irc

    View Slide

  31. I really
    suck!

    View Slide

  32. Here’s some commits
    I made just the other day

    View Slide

  33. View Slide

  34. View Slide

  35. ! "

    View Slide

  36. Programming is like
    skipping merrily between
    car crashes

    View Slide

  37. WHY!!!!?
    !

    View Slide

  38. Ephemeral
    Teams

    View Slide

  39. Make it work
    Make it right
    Make it fast

    View Slide

  40. Make it work
    Make it right
    Make it fast

    View Slide

  41. Is it done yet?
    Is it done yet?
    Is it done yet?

    View Slide

  42. !!!

    View Slide

  43. Rails
    Derailed

    View Slide

  44. View Slide

  45. View Slide

  46. View Slide

  47. View Slide

  48. three hard problems
    in computer science

    View Slide

  49. 1. cache invalidation

    View Slide

  50. 2. naming things

    View Slide

  51. DHH

    View Slide

  52. View Slide

  53. Changing
    requirements

    View Slide

  54. sorry
    Your project is
    not a special ❄

    View Slide

  55. guess what?
    software changes

    View Slide

  56. Quit whining!

    View Slide

  57. No. 1
    best job?

    View Slide

  58. View Slide

  59. $ git clone ...

    View Slide

  60. Huge pile of shit?

    View Slide

  61. View Slide

  62. View Slide

  63. !"
    GTFO?

    View Slide

  64. 5
    Steps

    View Slide

  65. 1
    Step

    View Slide

  66. Perception
    change it!

    View Slide

  67. I see
    dead
    people

    View Slide

  68. Being a
    positive
    influence

    View Slide

  69. Opinions as
    pull requests

    View Slide

  70. Broken windows

    View Slide

  71. Always leave the camp
    cleaner than you found it

    View Slide

  72. It’s better to
    seek forgiveness
    than ask permission

    View Slide

  73. 2
    step

    View Slide

  74. Metrics

    View Slide

  75. CI

    View Slide

  76. View Slide

  77. !

    View Slide

  78. Effect a
    consistent style

    View Slide

  79. Make it
    approachable

    View Slide

  80. Rubocop

    View Slide

  81. 2nd most stylish rubyist

    View Slide

  82. $ gem install rubocop
    ~/code/frontend % rubocop
    Inspecting 313 files
    .....................................................C
    ......................................................
    ......................................................
    ......................................................
    ......................................................
    ...........................................
    Offenses:
    app/helpers/profile_helper.rb:2:1: C: Extra empty line detected at body beginning.
    313 files inspected, 1 offense detected

    View Slide

  83. Auto correction?

    View Slide

  84. ~/code/frontend % rubocop -a
    Inspecting 313 files
    .....................................................C
    Offenses:
    app/helpers/profile_helper.rb:2:1: C: [Corrected] Extra
    empty line detected at body beginning.
    313 files inspected, 1 offense detected, 1 offense corrected

    View Slide

  85. Sorcery!

    View Slide

  86. View Slide

  87. Test Coverage

    View Slide

  88. $ gem install SimpleCov

    View Slide

  89. View Slide

  90. You're sitting on a
    throne of lies

    View Slide

  91. Cyclomatic Complexity

    View Slide

  92. $ gem install metric_fu-Saikuro

    View Slide

  93. Coverage + Cyclomatic Complexity
    Inform your tests

    View Slide

  94. Duplication
    Duplication
    Duplication
    Duplication

    View Slide

  95. $ gem install flay
    ~/code/frontend % flay app/**/*.rb -f
    Total score (lower is better) = 256
    1) Similar code found in :call (mass = 148)
    app/controllers/styleguide_controller.rb:63
    app/controllers/styleguide_controller.rb:221
    2) Similar code found in :defn (mass = 108)
    app/helpers/application_helper.rb:2
    app/helpers/application_helper.rb:9
    app/helpers/application_helper.rb:16
    app/helpers/application_helper.rb:23
    app/helpers/application_helper.rb:30
    app/helpers/application_helper.rb:37

    View Slide

  96. Not all
    duplication

    View Slide

  97. Good DRY
    Bad DRY

    View Slide

  98. single
    unambiguous
    authoritative
    representation

    View Slide

  99. Churn

    View Slide

  100. $ gem install churn
    ~/code/blog % churn
    Files
    +----------------------------------------------------------+---------------+
    | file_path | times_changed |
    +----------------------------------------------------------+---------------+
    | Gemfile | 20 |
    | app/helpers/application_helper.rb | 14 |
    | app/models/article.rb | 11 |
    | spec/models/text_filter_spec.rb | 11 |
    | spec/controllers/articles_controller_spec.rb | 11 |
    | spec/controllers/setup_controller_spec.rb | 11 |
    | spec/rails_helper.rb | 10 |
    | app/models/blog.rb | 10 |
    | spec/models/article_spec.rb | 10 |
    | spec/controllers/admin/content_controller_spec.rb | 10 |
    | spec/helpers/application_helper_spec.rb | 10 |
    +----------------------------------------------------------+---------------+

    View Slide

  101. All the metrics!
    $ gem install metric_fu
    cane, churn, flog, flay, reek
    roodi, saikuro, code statistics
    rails best practices

    View Slide

  102. code climate?

    View Slide

  103. Metric
    Overflow!

    View Slide

  104. Only capture that
    you plan to action

    View Slide

  105. Make it
    known

    View Slide

  106. Dashboard

    View Slide

  107. Gamify

    View Slide

  108. 3
    step

    View Slide

  109. Tests

    View Slide

  110. % tree spec/models
    spec/models
    ├── authentication_token_spec.rb
    ├── challenge_spec.rb
    ├── entry_spec.rb
    ├── facebook_token_spec.rb
    ├── follow_spec.rb
    ├── followed_list_spec.rb
    ├── item_spec.rb
    ├── list_fulfilment_criterion_spec.rb
    ├── list_spec.rb
    ├── prize_spec.rb
    ├── rating_spec.rb
    └── user_spec.rb
    0 directories, 12 files

    View Slide

  111. require 'test_helper'
    class UserTest < ActiveSupport::TestCase
    # test "the truth" do
    # assert true
    # end
    end

    View Slide

  112. View Slide

  113. All kinds of
    bad

    View Slide

  114. No tests
    Slow tests
    Low quality tests

    View Slide

  115. Tests are not
    sacred artifacts

    View Slide

  116. Tests can be
    transient

    View Slide

  117. zero coverage?
    this might not be so bad

    View Slide

  118. Feature specs
    go full stack or go home

    View Slide

  119. Poor or slow units?
    wrong time, wrong place

    View Slide

  120. Repeat after me:
    Tests are not
    sacred artifacts

    View Slide

  121. kill them with fire

    View Slide

  122. 4
    step

    View Slide

  123. Seek
    and
    destroy

    View Slide

  124. Reduce the
    surface
    area

    View Slide

  125. Always be merciless

    View Slide

  126. Metrics

    View Slide

  127. Low hanging fruit
    Targets or goals which are
    easily achievable but do
    not require lots of effort

    View Slide

  128. Improve
    Incrementally

    View Slide

  129. View Slide

  130. versioning rails
    stay on target, stay on target

    View Slide

  131. 5
    step

    View Slide

  132. Keep it full unicorn

    View Slide

  133. Fail the build

    View Slide

  134. Always be
    improving

    View Slide

  135. Perception
    Metrics
    Tests
    Reduce & Improve
    Stay Full Unicorn

    View Slide

  136. View Slide

  137. View Slide

  138. View Slide

  139. View Slide

  140. meet hot single sharks in your area

    View Slide

  141. View Slide

  142. View Slide

  143. View Slide

  144. View Slide

  145. Thanks!
    @benlovell

    View Slide

  146. View Slide