Rescue Squad: Rails Edition - Rails Israel 2014

Transcript

1. RESCUE SQUAD RAILS EDITION Rails Israel 2014
2. @benlovell twitter/github/irc
4. ❤
5. rails sucks
6. $ rails new life_is_good
15. I really suck!
16. Here’s some commits I made just the other day
19. ! "
20. Programming is like skipping merrily between car crashes
21. ME!
22. WHY!!!!? !
23. Team Transience
24. Make it work Make it right Make it fast
25. Make it work Make it right Make it fast
26. Is it done yet? Is it done yet? Is it done yet?
27. !!!
28. Rails Derailed
30. Changing requirements
31. sorry Your project is not a special ❄
32. Quit whining!
33. No. 1 best job?
35. $ git clone ...
36. Huge pile of shit?
38. !" GTFO?
39. 5 Steps
40. 1 Step
41. Perception change it!
42. I see dead people
43. Being a positive influence
44. Opinions as pull requests
45. Broken windows
46. Strategise
47. Always leave the camp cleaner than you found it
48. It’s better to seek forgiveness than ask permission
49. Docs
50. 2 step
51. Metrics
52. CI
54. !
55. Effect a style guide
56. Make it approachable
57. Rubocop
58. $ gem install rubocop ~/code/frontend % rubocop Inspecting 313 files .....................................................C ...................................................... ...................................................... ...................................................... ...................................................... ........................................... Offenses: app/helpers/profile_helper.rb:2:1: C: Extra empty line detected at body beginning. 313 files inspected, 1 offense detected
59. Autocorrect?
60. ~/code/frontend % rubocop -a Inspecting 313 files .....................................................C Offenses: app/helpers/profile_helper.rb:2:1: C: [Corrected] Extra empty line detected at body beginning. 313 files inspected, 1 offense detected, 1 offense corrected
61. Sorcery!
63. Test Coverage
64. $ gem install SimpleCov
66. You're sitting on a throne of lies
67. Cyclomatic Complexity
68. $ gem install metric_fu-Saikuro
69. Coverage + Cyclomatic Complexity Inform your tests
70. Duplication Duplication Duplication Duplication
71. $ gem install flay ~/code/frontend % flay app/**/*.rb -f Total score (lower is better) = 256 1) Similar code found in :call (mass = 148) app/controllers/styleguide_controller.rb:63 app/controllers/styleguide_controller.rb:221 2) Similar code found in :defn (mass = 108) app/helpers/application_helper.rb:2 app/helpers/application_helper.rb:9 app/helpers/application_helper.rb:16 app/helpers/application_helper.rb:23 app/helpers/application_helper.rb:30 app/helpers/application_helper.rb:37
72. Not all duplication
73. Good DRY Bad DRY
74. single unambiguous authoritative representation
75. Churn
76. $ gem install churn ~/code/blog % churn Files +----------------------------------------------------------+---------------+ | file_path | times_changed | +----------------------------------------------------------+---------------+ | Gemfile | 20 | | app/helpers/application_helper.rb | 14 | | app/models/article.rb | 11 | | spec/models/text_filter_spec.rb | 11 | | spec/controllers/articles_controller_spec.rb | 11 | | spec/controllers/setup_controller_spec.rb | 11 | | spec/rails_helper.rb | 10 | | app/models/blog.rb | 10 | | spec/models/article_spec.rb | 10 | | spec/controllers/admin/content_controller_spec.rb | 10 | | spec/helpers/application_helper_spec.rb | 10 | +----------------------------------------------------------+---------------+
77. Lines of Code
78. $ rake stats +----------------------+-------+-------+---------+---------+-----+-------+ | Name | Lines | LOC | Classes | Methods | M/C | LOC/M | +----------------------+-------+-------+---------+---------+-----+-------+ | Controllers | 1995 | 1613 | 34 | 179 | 5 | 7 | | Helpers | 485 | 401 | 0 | 67 | 0 | 3 | | Models | 2793 | 2196 | 45 | 352 | 7 | 4 | | Mailers | 37 | 31 | 1 | 5 | 5 | 4 | | Javascripts | 31894 | 17140 | 0 | 1553 | 0 | 9 | | Libraries | 2455 | 1878 | 85 | 233 | 2 | 6 | | Controller specs | 3468 | 2801 | 0 | 16 | 0 | 173 | | Helper specs | 264 | 213 | 1 | 3 | 3 | 69 | | Lib specs | 247 | 195 | 0 | 0 | 0 | 0 | | Model specs | 3970 | 3241 | 1 | 21 | 21 | 152 | | Routing specs | 109 | 89 | 0 | 0 | 0 | 0 | | Service specs | 125 | 103 | 0 | 0 | 0 | 0 | | Uploader specs | 9 | 8 | 0 | 0 | 0 | 0 | | View specs | 975 | 788 | 0 | 20 | 0 | 37 | +----------------------+-------+-------+---------+---------+-----+-------+ | Total | 48826 | 30697 | 167 | 2449 | 14 | 10 | +----------------------+-------+-------+---------+---------+-----+-------+ Code LOC: 23259 Test LOC: 7438 Code to Test Ratio: 1:0.3
79. All the metrics! $ gem install metric_fu cane, churn, flog, flay, reek roodi, saikuro, code statistics rails best practices
80. Metric Overflow!
81. Only capture that you plan to action
82. Make it known
83. Dashboard
84. Gamify
85. 3 step
86. Tests
87. % tree spec/models spec/models ├── authentication_token_spec.rb ├── challenge_spec.rb ├── entry_spec.rb ├── facebook_token_spec.rb ├── follow_spec.rb ├── followed_list_spec.rb ├── item_spec.rb ├── list_fulfilment_criterion_spec.rb ├── list_spec.rb ├── prize_spec.rb ├── rating_spec.rb └── user_spec.rb 0 directories, 12 files
88. require 'test_helper' class UserTest < ActiveSupport::TestCase # test "the truth" do # assert true # end end
90. All kinds of bad
91. No tests Slow tests Low quality tests
92. Tests are not sacred artifacts
93. Tests can be transient
94. zero coverage? this might not be so bad
95. Feature specs go full stack or go home
96. Poor or slow units? wrong time, wrong place
97. Repeat after me: Tests are not sacred artifacts
98. kill them with fire
99. 4 step
100. Seek and destroy
101. Reduce the surface area
102. Always be merciless
103. Metrics
104. Low hanging fruit Targets or goals which are easily achievable but do not require lots of effort
105. Improve Incrementally
107. Katrina Owen @kytrinyx
108. If you're especially brave...
109. $ bundle outdated
110. 5 step
111. Keep it full unicorn
112. Fail the build
113. Always be improving
114. Perception Metrics Tests Reduce or Improve Stay Full Unicorn
116. Thanks! @benlovell