Rails: The Good Parts

https://www.youtube.com/watch?v=LUJiEA88a3U

Developers nowadays tend to blame Rails and DHH because they encourage bad practices that lead to a bad code. This is true but there are many good things in Rails we rarely use that help us to write good maintainable code. I’ll show bad examples in popular opensource projects and show you features of Rails that can be used to avoid their mistakes.

Transcript

1. Rails The Good Parts with ❤ from datarockets
2. Criticism • ActiveRecord: validations, callbacks, and more • ActionView: global helpers, views, rails-ujs • ActionMailer and class methods • Lack of abstractions for business logic • Many-many more…
3. Good Parts • ActiveRecord associations and queries DSL • Database migrations • Form helpers • Security
4. Code Organization
5. Models 
 ❤
6. Flat Models Structure Diaspora 44 files Discourse 176 files GitLab 136 files
7. 176?
8. Flat Models Structure post_action_type.rb
 post_action.rb
 post_analyzer.rb
 post_custom_fields.rb
 post_detail.rb
 post_mover.rb
 post_reply.rb
 post_revision.rb
 post_search_data.rb
 post_stat.rb
 post_timing.rb
 post_upload.rb
 post.rb
9. Flat Models Structure post_action_type.rb
 post_action.rb
 post_analyzer.rb
 post_custom_fields.rb
 post_detail.rb
 post_mover.rb
 post_reply.rb
 post_revision.rb
 post_search_data.rb
 post_stat.rb
 post_timing.rb
 post_upload.rb
 post.rb class Post < ActiveRecord::Base
 has_many :post_uploads
 has_many :uploads, through: :post_ has_many :post_details
 has_many :post_revisions
 # ...
 end
 

10. Flat Models Structure post_action_type.rb
 post_action.rb
 post_analyzer.rb
 post_custom_fields.rb
 post_detail.rb
 post_mover.rb
 post_reply.rb
 post_revision.rb
 post_search_data.rb
 post_stat.rb
 post_timing.rb
 post_upload.rb
 post.rb class Post < ActiveRecord::Base
 has_many :post_uploads
 has_many :uploads, through: :post_ has_many :post_details
 has_many :post_revisions
 # ...
 end
 
 
 post.post_details
 
 post.post_revisions
11. Namespace Your Models class Post::Upload # post/upload.rb
 belongs_to :post
 belongs_to :upload, class_name: "::Upload"
 end
 
 class Post::Detail # post/detail.rb
 belongs_to :post
 end
 
 class Post
 has_many :uploads, class_name: "Post::Upload"
 has_many :details
 end
12. Namespace Your Models post_action_type.rb
 post_action.rb
 post_analyzer.rb
 post_custom_fields.rb
 post_detail.rb
 post_mover.rb
 post_reply.rb
 post_revision.rb
 post_search_data.rb
 post_stat.rb
 post_timing.rb
 post_upload.rb
 post.rb post/
 action/
 type.rb
 action.rb
 analyzer.rb
 custom_fields.rb
 detail.rb
 mover.rb
 reply.rb
 revision.rb
 search_data.rb
 stat.rb
 timing.rb
 upload.rb
 post.rb
13. Namespace Your Models post/
 post.rb
14. Controllers 
 ❤
15. Custom Actions $ cat app/controllers/users_controller.rb | wc -l 1097
16. 1097?
17. Custom Actions resources :users do
 put "suspend"
 put "unsuspend"
 
 put "grant_moderation"
 put "revoke_moderation"
 
 # ...
 end

18. Resourceful Routes resources :users do
 put "suspend"
 put "unsuspend"
 end resources :users do
 resource :suspension, 
 only: [:create, :destroy]
 end
19. Resourceful Routes resources :users do
 put "suspend"
 put "unsuspend"
 end resources :users do
 resource :suspension, 
 only: [:create, :destroy]
 end DELETE /users/:user_id/suspension suspensions#destroy
 POST /users/:user_id/suspension suspensions#create
20. Resourceful Routes resources :users do
 put "suspend"
 put "unsuspend"
 end resources :users do
 resource :suspension, 
 only: [:create, :destroy]
 end DELETE /users/:user_id/suspension suspensions#destroy
 POST /users/:user_id/suspension suspensions#create app/controllers/
 users_controller.rb
 suspensions_controller.rb
21. Resourceful Routes resources :users do
 put "suspend"
 put "unsuspend"
 end resources :users do
 resource :suspension, 
 only: [:create, :destroy]
 end DELETE /users/:user_id/suspension suspensions#destroy
 POST /users/:user_id/suspension suspensions#create app/controllers/
 users_controller.rb
 suspensions_controller.rb
22. Resourceful Routes resources :users do
 scope module: :users do
 resource :suspension, only: [:create, :destroy]
 resource :moderation_permission, only: [:create, :destroy] end
 end
 
 app/controllers/
 users/
 suspensions_controller.rb
 moderator_permissions_controller.rb
 users_controller.rb
23. Service Objects 
 ❤
24. More ❤ • ActiveRecord Querying • HTTP2 support • Logging
25. Thank you pivohug! with ❤ from datarockets twitter.com/dzhlobo
 
 fb.com/dima.zhlobo
 
 vk.com/datarockets