scales eg, the time cost and the documentation benefit accrue immediately eg, the preservation of ideas benefit and the opportunity cost accrue over very long time scales
ideas in the code, or some of them legitimizes the code; distinguishes it from competitors refereed citations for your software work situates the software in an appropriate scientific context
software systems in addition to the papers about them. I don’t like the statistical editor comments on data analysis papers submitted to the AAS Journals.
no refereeing headaches either citation of the software is direct citation of the relevant work the ASCL and ADS and GitHub have made all this very easy
are (currently) unrefereed (and less respected, perhaps) uncertain long-term value of citations; preservation issues hard to distinguish your software system from competitors
legion (though sometimes a bit intangible) both pure software publications and papers with a software component are very valuable the (new) direct cite-ability of software does not much diminish these benefits