$30 off During Our Annual Pro Sale. View Details »

May the Code Review be with you [Russian]

May the Code Review be with you [Russian]

Code review is often mistaken for a silver bullet that solves all the developer problems. In reality it's not exactly like that, and this process has its requirements and constraints, just like everything else. We'll talk about what teams can benefit from code review and how to approach this process. We'll get into the details of process, measure the time it takes and learn to assess its usefulness.

Also the main rules of conducting a code review will be shown: both technical and ethical ones that can have positive impact not only on product quality but also on the team making it.

Egor Tolstoy

April 21, 2017
Tweet

More Decks by Egor Tolstoy

Other Decks in Technology

Transcript

  1. 2

  2. 3

  3. 4

  4. 5

  5. 13

  6. 15

  7. 16

  8. 17

  9. 19

  10. 20

  11. 21

  12. 22

  13. 25

  14. 26

  15. 28

  16. 30

  17. 31

  18. 32 #1: Коллективное владение кодом #2: Переиспользование кода #3: Обмен

    знаниями #4: Обнаружение ошибок #5: Единообразие проекта
  19. 37

  20. 40

  21. 45

  22. 50

  23. 55

  24. 61

  25. 62

  26. 64

  27. строки кода 67 0 50 100 150 200 0 500

    1000 1500 2000 комментарии чем больше изменений, тем меньше комментариев
  28. 69

  29. 71

  30. 73

  31. 76

  32. 79

  33. 80

  34. 88 #1: Коллективное владение кодом #2: Переиспользование кода #3: Обмен

    знаниями #4: Обнаружение ошибок #5: Единообразие проекта
  35. 94 Inspection rate = LoC / hour Defect rate =

    problems / hour Defect density = problems / LoC
  36. 95

  37. 97

  38. 98

  39. 99 Inspection rate = 2.1 / 0.56 = 3.75 Defect

    rate = 4 / 0.56 = 7.1 Defect density = 4 / 2.1 = 1.9
  40. 100 Inspection rate = 2.1 / 0.08 = 26.25 Defect

    rate = 1 / 0.08 = 12.5 Defect density = 1 / 2.1 = 0.48
  41. 105

  42. 106

  43. 108

  44. 109

  45. 111

  46. 112

  47. 113 Можно ставить смайлики Крутой Code Ownership Шаблоны для PR

    Интеграции с инструментами Доступен из коробки
  48. 114

  49. 116

  50. 119

  51. 121

  52. 122