Upgrade to Pro — share decks privately, control downloads, hide ads and more …

May the Code Review be with you [English]

Egor Tolstoy
September 22, 2017

May the Code Review be with you [English]

Code review is often mistaken for a silver bullet that solves all the developer problems. In reality it's not exactly like that, and this process has its requirements and constraints, just like everything else. We'll talk about what teams can benefit from code review and how to approach this process. We'll get into the details of process, measure the time it takes and learn to assess its usefulness.

Also the main rules of conducting a code review will be shown: both technical and ethical ones that can have positive impact not only on product quality but also on the team making it.

Egor Tolstoy

September 22, 2017
Tweet

More Decks by Egor Tolstoy

Other Decks in Technology

Transcript

  1. 2

  2. 3

  3. 4

  4. 5

  5. 6

  6. 11

  7. 12

  8. 13

  9. 14

  10. 19 #1: Shared Code Ownership #2: Code reuse #3: Knowledge

    sharing in a team #4: Error diagnosis #5: Project consistency
  11. 22 Questions Are we using shared libraries in the code?

    Did we extract all visual styles? What is a level of code duplication?
  12. 29

  13. 32

  14. 37

  15. 41

  16. 44

  17. 47

  18. lines of code 0 50 100 150 200 0 500

    1000 1500 2000 comments the more lines of code, the fewer comments
  19. 57

  20. 58

  21. 61

  22. 62

  23. 66

  24. 76

  25. 77