〇〇を切り出したいときに / Extract something from big rails app

Transcript

1. ʓʓΛ੾Γग़͍ͨ͠ͱ͖ʹ
   
   ͓͓͖ΊͷϦϑΝΫλΛ΍Δ
   PO
   3BJMTʢʁʣ TokyuRubyKaigi #12 !J[VNJO 2018.7.29 -

2. izumin5210 Engineer at Wantedly, Inc. Wantedly People ‣ Web Application

   Engineer - Profile Data Strategy Group ‣ Interests in developer productivity on microservices Gopher, Rubyist, JavaScripter and Androider

3. ˓˓Λ੾Γग़͍ͨ͠ɾҠߦ͍ͨ͠ ࢖͍·Θͤͦ͏ͳ࣮૷
   %#
   .PEFM
   ػೳ
   γεςϜͷҰ෦
   

4.  ςετΛॻ͜͏
    ϩάΛͱΖ͏ ͍͞͠ΐʹߟ͑Δ͜ͱ

5.  ςετΛॻ͜͏
    ͦ΋ͦ΋ςετ͸ϦϑΝΫλϦϯάͷͨΊʹ͋Δʢۃ࿦ʣ
    ίʔυ͕յΕΔͱςετ͕མͪͯؾ͚ͮͯศར
    ͳ͔ͬͨΒ
   ؤுͬͯॻ͘ʢن໛ʹΑͬͯ͸ఘΊ΋؊৺ʣ
    ϩάΛͱΖ͏

   ͍͞͠ΐʹߟ͑Δ͜ͱ

6.  ςετΛॻ͜͏
    ϩάΛͱΖ͏
    Ͳ͏͍͏ܦ࿏Ͱར༻͞ΕΔ͔ɼͲΕ͘Β͍ར༻͞ΕΔ͔
    ͦ΋ͦ΋
   ESPQ
   Ͱ͖ͳ͍͔
   
    յΕͦ͏ͳͱ͜ΖͷςετΛॏ఺తʹॻ͚Δ

   ͍͞͠ΐʹߟ͑Δ͜ͱ

7.  DBMMFS
   Λه࿥͢Δ
    ࡶʹϩάΛཷΊࠐΊΔπʔϧɾαʔϏεΛ࢖͏ ƁŞƄŪž
   UJQT

8.  DBMMFS
   Λه࿥͢Δ
   
   ͡
    `Thread.current[:controller] = controller_name`
   ͠ͱ͘ͱศར
    ͋͘·ͰҰ࣌తͳϩάऩूͳͷͰɼਖ਼͠͞
   
   खܰ͞ɾརศੑ
   

    ࡶʹϩάΛཷΊࠐΊΔπʔϧɾαʔϏεΛ࢖͏ ƁŞƄŪž
   UJQT caller.find do |c| !c.to_s.start_with?(Bundler.bundle_path.to_s) && c.to_s.start_with?(Rails.root.to_s) end

9.  DBMMFS
   Λه࿥͢Δ
    ࡶʹϩάΛཷΊࠐΊΔπʔϧɾαʔϏεΛ࢖͏
    ʮϨεϙϯεʹӨڹΛ༩͑ͳ͍ʯ͸ॏཁ
    ͍͍ײ͡ʹ
   CVGGFSJOH
   ͨ͠ΓඇಉظͰσʔλૹͬͯ͘ΕΔ܅Λ͔ͭ͏
    fluent-logger-ruby

   
   td-logger-ruby
   FUD
    Ұ࣌తͳϩάऩूͳͷͰɼਖ਼͠͞
   
   खܰ͞ɾརศੑ
   
   େ੾ͳ͜ͱͳͷͰʢ͈́ ƁŞƄŪž
   UJQT

10.  DBMMFS
    Λه࿥͢Δ
     ࡶʹϩάΛཷΊࠐΊΔπʔϧɾαʔϏεΛ࢖͏
     ʮϨεϙϯεʹӨڹΛ༩͑ͳ͍ʯ͸ॏཁ
     ͍͍ײ͡ʹ
    CVGGFSJOH
    ͨ͠ΓඇಉظͰσʔλૹͬͯ͘ΕΔ܅Λ͔ͭ͏
     qVFOUMPHHFSSVCZ

    
    UEMPHHFSSVCZ
    FUD
     Ұ࣌తͳϩάऩूͳͷͰɼਖ਼͠͞
    
    खܰ͞ɾརศੑ
    
    େ੾ͳ͜ͱͳͷͰʢ͈́ ƁŞƄŪž
    UJQT caller_app = caller.find do |c| !c.to_s.start_with?(Bundler.bundle_path.to_s) && c.to_s.start_with?(Rails.root.to_s) end TD.event.post("hoge_log", { caller_app: caller_app, request_controller: Tread.current[:request_controller], request_action: Tread.current[:request_action], # sinp. }) Կ΋ߟ͑ͣʢUFTUBCJMJUZ
    ʹӨڹΛ༩͑ͣʣɼࡶʹϩά౤͛ΒΕΔͷ͸
    3VCZ
    ͔ͩΒͦ͜

11.  DBMMFS
    Λه࿥͢Δ
     ࡶʹϩάΛཷΊࠐΊΔπʔϧɾαʔϏεΛ࢖͏
     ʮϨεϙϯεʹӨڹΛ༩͑ͳ͍ʯ͸ॏཁ
     ͍͍ײ͡ʹ
    CVGGFSJOH
    ͨ͠ΓඇಉظͰσʔλૹͬͯ͘ΕΔ܅Λ͔ͭ͏
     qVFOUMPHHFSSVCZ

    
    UEMPHHFSSVCZ
    FUD
     Ұ࣌తͳϩάऩूͳͷͰɼਖ਼͠͞
    
    खܰ͞ɾརศੑ
    
    େ੾ͳ͜ͱͳͷͰʢ͈́ ƁŞƄŪž
    UJQT class ActiveRecrod::Relation def eager_loading? super.tap do |loading| if loading # send logs end end end 3VCZ
    ͳͷͰܭଌ༻ίʔυ͸Ͳ͜ʹͰ΋࢓ࠐΊΔ
    ʢ˞
    ༻͕ࡁΜͩΒফ͠·͠ΐ͏ʣ

12.  ίʔυͷมߋൣғΛ࠷খʹཹΊΔ
     Ϛϝʹຊ൪ʹग़͢
     ෳࡶͳͱ͜Ζ͸࡟Εͳ͍͔ৄ͍͠ਓʹฉ͘ Ͳ͏΍ͬͯ͢͢ΊΔʁ

13.  ίʔυͷมߋൣғΛ࠷খʹཹΊΔ
     ΞϓϦ͕σΧ͘ͳΔͱ໢ཏతʹมߋ͢Δͷ͸େม
     FH
    %#
    ෼ׂͰ
    AProfileA
    ͕
    AProfileDb::ProfileA
    ʹͳΓ·͢
    ͱ͔มߋྔଟ͗ͯ͢ແཧ
     ϕʔεΫϥεΛม͑ΔʢAApplicationRecordA
    
    AProfileRecordAʣͱ͔ͳΒ·ͩΘ͔Δ
     ӨڹൣғΛࡶʹ೺Ѳ͢ΔͷʹΫϥεਤॻ͘ͱศར
    

     Ϛϝʹຊ൪ʹग़͢
     ෳࡶͳͱ͜Ζ͸࡟Εͳ͍͔ৄ͍͠ਓʹฉ͘ Ͳ͏΍ͬͯ͢͢ΊΔʁ

14.  ίʔυͷมߋൣғΛ࠷খʹཹΊΔ
     ΞϓϦ͕σΧ͘ͳΔͱ໢ཏతʹมߋ͢Δͷ͸େม
     FH
    %#
    ෼ׂͰ
    AProfileA
    ͕
    AProfileDb::ProfileA
    ʹͳΓ·͢
    ͱ͔มߋྔଟ͗ͯ͢ແཧ
     ϕʔεΫϥεΛม͑ΔʢAApplicationRecordA
    
    AProfileRecordAʣͱ͔ͳΒ·ͩΘ͔Δ
     ӨڹൣғΛࡶʹ೺Ѳ͢ΔͷʹΫϥεਤॻ͘ͱศར
    

     Ϛϝʹຊ൪ʹग़͢
     ෳࡶͳͱ͜Ζ͸࡟Εͳ͍͔ৄ͍͠ਓʹฉ͘ Ͳ͏΍ͬͯ͢͢ΊΔʁ ػցతʹੜ੒Ͱ͖Δؾ΋͢Δ͕ɼͲΕ͘Β͍
    3VCZ
    ͷຐज़Λ࢖ͬͯΔ͔ʹґଘ͢Δ
    ˢͷΫϥεਤ͸໨
    HSFQ
    
    

15.  ίʔυͷมߋൣғΛ࠷খʹཹΊΔ
     Ϛϝʹຊ൪ʹग़͢
     Ұؾʹ΍ΔͱյΕͨͱ͖ʹݪҼڀ໌͕େม
     ෳࡶͳͱ͜Ζ͸࡟Εͳ͍͔ৄ͍͠ਓʹฉ͘ Ͳ͏΍ͬͯ͢͢ΊΔʁ

16.  ίʔυͷมߋൣғΛ࠷খʹཹΊΔ
     Ϛϝʹຊ൪ʹग़͢
     ෳࡶͳͱ͜Ζ͸࡟Εͳ͍͔ৄ͍͠ਓʹฉ͘
     ͨ·ʔʹʮ͜ΜͳΜઈରແཧ΍Ζ͆ʯΈ͍ͨͳͷ͕͋Δ
     ΊͬͪΌ
    "SFM
    ͝ʹΐ͝ʹΐͯ͠Δͱ͔ɼΞϓϦͷίΞʹΊͬͪΌґଘͯ͠Δͱ͔
    

     ͦ͏͍͏ͷ͸ͦ΋ͦ΋࢓༷Λ࡟Εͳ͍͔ɾଞͷ࣮૷͕ͳ͍͔ߟ͑Δ
     υϝΠϯʹৄ͍͠ਓʹ΍ͬͯ΋Β͏ͷ͕٢ Ͳ͏΍ͬͯ͢͢ΊΔʁ

17. ͍ͪ͹ΜॏཁͳϙΠϯτ ʢݸਓతʹʣ

18. ੎͍ͱے೑Ͱԡ͠੾Δ ௕ظઓʹͳΔͱ৺͕ંΕͦ͏ʹͳΔ ˞͜ͷͱ͖ʢ%#෼ׂʣ͸਺೔Ͱڧߦಥഁͨ͠ͷͰ͔͢ΓইͰࡁΜͩ

19. ࣮ࡍʹͦͦ͜͜Ͱ͔͍ΞϓϦͰ΍ͬͨࣄྫ

20. ࣮ࡍʹͦͦ͜͜Ͱ͔͍ΞϓϦͰ΍ͬͨࣄྫ ͜͜ʹه͢ʹ͸༨ന͕ڱ͗͢Δ

21. None

22. ͖ͭͮ͸ Ͱʂ