Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
[社内LT]AndroidプロジェクトにDangerを導入してみた
Search
きりみん
October 16, 2017
Programming
140
0
Share
[社内LT]AndroidプロジェクトにDangerを導入してみた
社内LT
きりみん
October 16, 2017
More Decks by きりみん
See All by きりみん
AndroidエンジニアがRailsにチャレンジしてる理由
kirimin
1
1.6k
What are AtCoder and competitive programming
kirimin
0
10k
バーチャル男声幼女プログラマーとして活動した1年間の振り返り
kirimin
0
1.1k
アプリエンジニアでも神絵師になりたい!
kirimin
4
5.5k
Watashi ni Kotlin ga maiorita
kirimin
0
600
NEMのAPIとモザイクであそぼう
kirimin
0
420
はじめようきれいなコード
kirimin
8
3.2k
Material Components for Android触ってみる
kirimin
7
2.1k
[社内LT]あたらしいMaterial Design
kirimin
1
1.8k
Other Decks in Programming
See All in Programming
(Re)make Regexp in Ruby: Democratizing internals for the JIT
makenowjust
3
1k
過去のレビュー知見をSkillsで資産化した話
pkshadeck
PRO
1
1.8k
Surviving Black Friday: 329 billion requests with Falcon!
ioquatix
0
3k
20年以上続くプロダクトでも使い続けられる静的解析ツールを求めて
matsuo_atsushi
0
150
ふにゃっとしない名前の付け方 〜哲学で茹で上げる、コシのあるソフトウェア設計〜
shimomura
0
120
書籍「ユーザーストーリーマッピング」が私のバイブル
asumikam
4
490
Road to RubyKaigi: Play Hard(ware)
makicamel
1
560
Explore CoroutineScope
tomoeng11
0
180
Cache-moi si tu peux : patterns et pièges du cache en production - Devoxx France 2026 - Conférence
slecache
0
350
Symfony AI in Action - SymfonyLive Berlin 2026
chr_hertel
1
140
t *testing.T は どこからやってくるの?
otakakot
1
930
Augmenting AI with the Power of Jakarta EE
ivargrimstad
0
340
Featured
See All Featured
YesSQL, Process and Tooling at Scale
rocio
174
15k
Evolution of real-time – Irina Nazarova, EuRuKo, 2024
irinanazarova
9
1.3k
Utilizing Notion as your number one productivity tool
mfonobong
4
300
10 Git Anti Patterns You Should be Aware of
lemiorhan
PRO
659
62k
We Are The Robots
honzajavorek
0
230
Data-driven link building: lessons from a $708K investment (BrightonSEO talk)
szymonslowik
1
1k
Distributed Sagas: A Protocol for Coordinating Microservices
caitiem20
333
22k
Building an army of robots
kneath
306
46k
Have SEOs Ruined the Internet? - User Awareness of SEO in 2025
akashhashmi
0
340
More Than Pixels: Becoming A User Experience Designer
marktimemedia
3
400
Taking LLMs out of the black box: A practical guide to human-in-the-loop distillation
inesmontani
PRO
3
2.2k
Accessibility Awareness
sabderemane
1
110
Transcript
AndroidϓϩδΣΫτʹ DangerΛಋೖͯ͠Έͨ @kirimin
Dangerʁ • PRͷࣗಈνΣοΫπʔϧ • ਓྗͰΔඞཁͷͳ͍ϨϏϡʔΛࣗಈԽ͢Δ • ϨϏϡʔݮɺਓؒʹ͔͠ग़དྷͳ͍Ϩ Ϗϡʔʹूத͢Δ
͍ํ • ϓϩδΣΫτԼʹgemfileͱDangerfileΛ Ճ͢Δɻ • DangerfileʹεΫϦϓτΛॻ͘ɻ • CI͔ΒίϚϯυΛୟ͍࣮ͯߦ͢Δɻ bundle install
bundle exec danger
Dangerfile? • ͨͩͷruby script • ҎԼͷΑ͏ʹॻ͘ͱࣗಈͰPRʹίϝϯτͯ͠ ͘ΕΔ message('Αͦ͞͏') warn('ͦ͏') fail('ͩΊͦ͏')
Dangerfile? • PRʹؔ͢ΔใΛgem͔ΒऔಘͰ͖Δ • ͍Ζ͍ΖPlugin͋Δ if github.pr_title.include? '[WIP]' warn('WIPͩΑ') end
࣮ࡍʹͬͨ͜ͱ • Ϛʔδઌ͕masterͳΒΞϥʔτ • λΠτϧʹIssue൪߸ؚ͕·Ε͍ͯͳ͚ΕΞϥʔτ • λΠτϧʹWIPؚ͕·Ε͍ͯͨΒΞϥʔτ • ࣗಈͰؔ࿈IssueΛclose͢Δه๏͕ॻ͔Ε͍ͯͳ͚ΕΞϥʔτ •
assignee͕ઃఆ͞Ε͍ͯͳ͚ΕΞϥʔτ • PR͕࡞͞ΕͨΒSlackʹϝϯγϣϯΛඈ͢
Α͏͢
࣮ࡍͷεΫϦϓτ
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • Reviewerʹؚ·Ε͍ͯΔਓʹͷΈϝϯγϣϯ Λඈ͢ ɹ→ReviewerͷҰཡ͕danger͔ΒऔಘͰ͖ͳ ͍ɻGitHub্ͰAPI͕͔Ε͓ͯΓखಈͰऔಘ͢Δ ͷͪΐͬͱ໘
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • AndroidLintΛΒͤࣗಈͰίʔυʹࢦఠίϝ ϯτΛຒΊࠐΉ ɹ→AndroidLint͕ͦͦKotlinʹରԠ͍ͯ͠ͳ͍ Β͍͠ͷͰอཹ
͓ΘΓ • ࠓޙػೳ֦ு͍͖͍ͯͨ͠ॴଘ