Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
[社内LT]AndroidプロジェクトにDangerを導入してみた
Search
Sponsored
·
Your Podcast. Everywhere. Effortlessly.
Share. Educate. Inspire. Entertain. You do you. We'll handle the rest.
→
きりみん
October 16, 2017
Programming
0
140
[社内LT]AndroidプロジェクトにDangerを導入してみた
社内LT
きりみん
October 16, 2017
Tweet
Share
More Decks by きりみん
See All by きりみん
AndroidエンジニアがRailsにチャレンジしてる理由
kirimin
1
1.6k
What are AtCoder and competitive programming
kirimin
0
10k
バーチャル男声幼女プログラマーとして活動した1年間の振り返り
kirimin
0
1.1k
アプリエンジニアでも神絵師になりたい!
kirimin
4
5.5k
Watashi ni Kotlin ga maiorita
kirimin
0
590
NEMのAPIとモザイクであそぼう
kirimin
0
410
はじめようきれいなコード
kirimin
8
3.1k
Material Components for Android触ってみる
kirimin
7
2.1k
[社内LT]あたらしいMaterial Design
kirimin
1
1.8k
Other Decks in Programming
See All in Programming
Understanding Apache Lucene - More than just full-text search
spinscale
0
140
Rで始めるML・LLM活用入門
wakamatsu_takumu
0
200
DevinとClaude Code、SREの現場で使い倒してみた件
karia
1
1.1k
社内規程RAGの精度を73.3% → 100%に改善した話
oharu121
13
8.3k
Laravel Nightwatchの裏側 - Laravel公式Observabilityツールを支える設計と実装
avosalmon
1
140
Redox OS でのネームスペース管理と chroot の実現
isanethen
0
420
Fundamentals of Software Engineering In the Age of AI
therealdanvega
2
290
The Past, Present, and Future of Enterprise Java
ivargrimstad
0
950
How to stabilize UI tests using XCTest
akkeylab
0
140
[SF Ruby Feb'26] The Silicon Heel
palkan
0
120
maplibre-gl-layers - 地図に移動体たくさん表示したい
kekyo
PRO
0
420
GoのDB アクセスにおける 「型安全」と「柔軟性」の両立 - Bob という選択肢
tak848
0
270
Featured
See All Featured
Reality Check: Gamification 10 Years Later
codingconduct
0
2.1k
Abbi's Birthday
coloredviolet
2
5.6k
WENDY [Excerpt]
tessaabrams
9
37k
AI Search: Implications for SEO and How to Move Forward - #ShenzhenSEOConference
aleyda
1
1.2k
Heart Work Chapter 1 - Part 1
lfama
PRO
5
35k
Six Lessons from altMBA
skipperchong
29
4.2k
Impact Scores and Hybrid Strategies: The future of link building
tamaranovitovic
0
240
AI in Enterprises - Java and Open Source to the Rescue
ivargrimstad
0
1.2k
YesSQL, Process and Tooling at Scale
rocio
174
15k
Understanding Cognitive Biases in Performance Measurement
bluesmoon
32
2.8k
Sharpening the Axe: The Primacy of Toolmaking
bcantrill
46
2.7k
The Impact of AI in SEO - AI Overviews June 2024 Edition
aleyda
5
770
Transcript
AndroidϓϩδΣΫτʹ DangerΛಋೖͯ͠Έͨ @kirimin
Dangerʁ • PRͷࣗಈνΣοΫπʔϧ • ਓྗͰΔඞཁͷͳ͍ϨϏϡʔΛࣗಈԽ͢Δ • ϨϏϡʔݮɺਓؒʹ͔͠ग़དྷͳ͍Ϩ Ϗϡʔʹूத͢Δ
͍ํ • ϓϩδΣΫτԼʹgemfileͱDangerfileΛ Ճ͢Δɻ • DangerfileʹεΫϦϓτΛॻ͘ɻ • CI͔ΒίϚϯυΛୟ͍࣮ͯߦ͢Δɻ bundle install
bundle exec danger
Dangerfile? • ͨͩͷruby script • ҎԼͷΑ͏ʹॻ͘ͱࣗಈͰPRʹίϝϯτͯ͠ ͘ΕΔ message('Αͦ͞͏') warn('ͦ͏') fail('ͩΊͦ͏')
Dangerfile? • PRʹؔ͢ΔใΛgem͔ΒऔಘͰ͖Δ • ͍Ζ͍ΖPlugin͋Δ if github.pr_title.include? '[WIP]' warn('WIPͩΑ') end
࣮ࡍʹͬͨ͜ͱ • Ϛʔδઌ͕masterͳΒΞϥʔτ • λΠτϧʹIssue൪߸ؚ͕·Ε͍ͯͳ͚ΕΞϥʔτ • λΠτϧʹWIPؚ͕·Ε͍ͯͨΒΞϥʔτ • ࣗಈͰؔ࿈IssueΛclose͢Δه๏͕ॻ͔Ε͍ͯͳ͚ΕΞϥʔτ •
assignee͕ઃఆ͞Ε͍ͯͳ͚ΕΞϥʔτ • PR͕࡞͞ΕͨΒSlackʹϝϯγϣϯΛඈ͢
Α͏͢
࣮ࡍͷεΫϦϓτ
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • Reviewerʹؚ·Ε͍ͯΔਓʹͷΈϝϯγϣϯ Λඈ͢ ɹ→ReviewerͷҰཡ͕danger͔ΒऔಘͰ͖ͳ ͍ɻGitHub্ͰAPI͕͔Ε͓ͯΓखಈͰऔಘ͢Δ ͷͪΐͬͱ໘
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • AndroidLintΛΒͤࣗಈͰίʔυʹࢦఠίϝ ϯτΛຒΊࠐΉ ɹ→AndroidLint͕ͦͦKotlinʹରԠ͍ͯ͠ͳ͍ Β͍͠ͷͰอཹ
͓ΘΓ • ࠓޙػೳ֦ு͍͖͍ͯͨ͠ॴଘ