Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
[社内LT]AndroidプロジェクトにDangerを導入してみた
Search
Sponsored
·
Your Podcast. Everywhere. Effortlessly.
Share. Educate. Inspire. Entertain. You do you. We'll handle the rest.
→
きりみん
October 16, 2017
Programming
140
0
Share
Embed
Copy iframe code
Copy JS code
Copy link
Start on current slide
[社内LT]AndroidプロジェクトにDangerを導入してみた
社内LT
きりみん
October 16, 2017
More Decks by きりみん
See All by きりみん
AndroidエンジニアがRailsにチャレンジしてる理由
kirimin
1
1.6k
What are AtCoder and competitive programming
kirimin
0
10k
バーチャル男声幼女プログラマーとして活動した1年間の振り返り
kirimin
0
1.1k
アプリエンジニアでも神絵師になりたい!
kirimin
4
5.5k
Watashi ni Kotlin ga maiorita
kirimin
0
610
NEMのAPIとモザイクであそぼう
kirimin
0
420
はじめようきれいなコード
kirimin
8
3.2k
Material Components for Android触ってみる
kirimin
7
2.1k
[社内LT]あたらしいMaterial Design
kirimin
1
1.8k
Other Decks in Programming
See All in Programming
はてなアカウント基盤 State of the Union
cockscomb
0
610
Oxlintのカスタムルールの現況
syumai
6
1.1k
dRuby over BLE
makicamel
2
390
Inside Stream API
skrb
1
770
依存関係から依存物へ―Dependencyという言葉の歴史をひも解く
j_lee
0
130
代数的データ型って何が嬉しいの? #frontend_phpcon_do
kajitack
8
3.8k
フロントエンドとバックエンドで「1文字」を揃えよう
youkidearitai
PRO
0
740
AIを活用したE2Eテスト実装効率化のあゆみ / ebisu-mobile-14-kotetu
kotetuco
0
130
[2026年度第1回ORセミナー] 計画最適化ベンチャーと競技プログラミング人材
terryu16
0
270
A2UI という光を覗いてみる
satohjohn
1
150
Vite+ Unified Toolchain for the Web
naokihaba
0
340
Javaの型とAI時代に型が大事な理由 / java types and type in AI era
kishida
2
150
Featured
See All Featured
Dealing with People You Can't Stand - Big Design 2015
cassininazir
367
27k
Between Models and Reality
mayunak
4
350
We Have a Design System, Now What?
morganepeng
55
8.2k
What Being in a Rock Band Can Teach Us About Real World SEO
427marketing
0
1k
Visual Storytelling: How to be a Superhuman Communicator
reverentgeek
2
560
Git: the NoSQL Database
bkeepers
PRO
432
67k
Leadership Guide Workshop - DevTernity 2021
reverentgeek
1
310
Visualizing Your Data: Incorporating Mongo into Loggly Infrastructure
mongodb
49
10k
How to Get Subject Matter Experts Bought In and Actively Contributing to SEO & PR Initiatives.
livdayseo
0
140
What's in a price? How to price your products and services
michaelherold
247
13k
We Analyzed 250 Million AI Search Results: Here's What I Found
joshbly
1
1.4k
Efficient Content Optimization with Google Search Console & Apps Script
katarinadahlin
PRO
1
630
Transcript
AndroidϓϩδΣΫτʹ DangerΛಋೖͯ͠Έͨ @kirimin
Dangerʁ • PRͷࣗಈνΣοΫπʔϧ • ਓྗͰΔඞཁͷͳ͍ϨϏϡʔΛࣗಈԽ͢Δ • ϨϏϡʔݮɺਓؒʹ͔͠ग़དྷͳ͍Ϩ Ϗϡʔʹूத͢Δ
͍ํ • ϓϩδΣΫτԼʹgemfileͱDangerfileΛ Ճ͢Δɻ • DangerfileʹεΫϦϓτΛॻ͘ɻ • CI͔ΒίϚϯυΛୟ͍࣮ͯߦ͢Δɻ bundle install
bundle exec danger
Dangerfile? • ͨͩͷruby script • ҎԼͷΑ͏ʹॻ͘ͱࣗಈͰPRʹίϝϯτͯ͠ ͘ΕΔ message('Αͦ͞͏') warn('ͦ͏') fail('ͩΊͦ͏')
Dangerfile? • PRʹؔ͢ΔใΛgem͔ΒऔಘͰ͖Δ • ͍Ζ͍ΖPlugin͋Δ if github.pr_title.include? '[WIP]' warn('WIPͩΑ') end
࣮ࡍʹͬͨ͜ͱ • Ϛʔδઌ͕masterͳΒΞϥʔτ • λΠτϧʹIssue൪߸ؚ͕·Ε͍ͯͳ͚ΕΞϥʔτ • λΠτϧʹWIPؚ͕·Ε͍ͯͨΒΞϥʔτ • ࣗಈͰؔ࿈IssueΛclose͢Δه๏͕ॻ͔Ε͍ͯͳ͚ΕΞϥʔτ •
assignee͕ઃఆ͞Ε͍ͯͳ͚ΕΞϥʔτ • PR͕࡞͞ΕͨΒSlackʹϝϯγϣϯΛඈ͢
Α͏͢
࣮ࡍͷεΫϦϓτ
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • Reviewerʹؚ·Ε͍ͯΔਓʹͷΈϝϯγϣϯ Λඈ͢ ɹ→ReviewerͷҰཡ͕danger͔ΒऔಘͰ͖ͳ ͍ɻGitHub্ͰAPI͕͔Ε͓ͯΓखಈͰऔಘ͢Δ ͷͪΐͬͱ໘
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • AndroidLintΛΒͤࣗಈͰίʔυʹࢦఠίϝ ϯτΛຒΊࠐΉ ɹ→AndroidLint͕ͦͦKotlinʹରԠ͍ͯ͠ͳ͍ Β͍͠ͷͰอཹ
͓ΘΓ • ࠓޙػೳ֦ு͍͖͍ͯͨ͠ॴଘ