Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
[社内LT]AndroidプロジェクトにDangerを導入してみた
Search
きりみん
October 16, 2017
Programming
140
0
Share
[社内LT]AndroidプロジェクトにDangerを導入してみた
社内LT
きりみん
October 16, 2017
More Decks by きりみん
See All by きりみん
AndroidエンジニアがRailsにチャレンジしてる理由
kirimin
1
1.6k
What are AtCoder and competitive programming
kirimin
0
10k
バーチャル男声幼女プログラマーとして活動した1年間の振り返り
kirimin
0
1.1k
アプリエンジニアでも神絵師になりたい!
kirimin
4
5.5k
Watashi ni Kotlin ga maiorita
kirimin
0
600
NEMのAPIとモザイクであそぼう
kirimin
0
420
はじめようきれいなコード
kirimin
8
3.2k
Material Components for Android触ってみる
kirimin
7
2.1k
[社内LT]あたらしいMaterial Design
kirimin
1
1.8k
Other Decks in Programming
See All in Programming
CSC307 Lecture 17
javiergs
PRO
0
310
今さら聞けないCancellationToken
htkym
0
210
New "Type" system on PicoRuby
pocke
1
400
ユニットテストの先へ:テスト技法で要求・仕様を整理するJava開発実践 / Beyond_Unit_Testing_Practical_Java_Development_Techniques_for_Organizing_Requirements_and_Specifications
shimashima35
0
310
Spec-Driven Development with AI-Agents: From High-Level Requirements to Working Software
antonarhipov
2
410
RTSPクライアントを自作してみた話
simotin13
0
400
Lemonade + Foundry Toolkit でお手軽アプリ開発
seosoft
1
250
JavaDoc 再入門
nagise
0
230
RailsTokyo 2026#4: AI様があれば、 Hotwireの弱点は消えるか?
naofumi
5
1k
[KCD Czech] eBPF Meets the GPU: Future of AI Infra Observability
doniacld
0
130
ReactとSvelteのその先、Ripple-TS / Beyond React and Svelte: Ripple-TS
ssssota
3
1.9k
密結合なバックエンドから TypeScript のコードを生成する
kemuridama
1
420
Featured
See All Featured
コードの90%をAIが書く世界で何が待っているのか / What awaits us in a world where 90% of the code is written by AI
rkaga
61
44k
Connecting the Dots Between Site Speed, User Experience & Your Business [WebExpo 2025]
tammyeverts
11
930
Designing Dashboards & Data Visualisations in Web Apps
destraynor
231
55k
GraphQLの誤解/rethinking-graphql
sonatard
75
12k
ReactJS: Keep Simple. Everything can be a component!
pedronauck
666
130k
SEOcharity - Dark patterns in SEO and UX: How to avoid them and build a more ethical web
sarafernandez
0
190
So, you think you're a good person
axbom
PRO
2
2k
[RailsConf 2023 Opening Keynote] The Magic of Rails
eileencodes
31
10k
It's Worth the Effort
3n
188
29k
Thoughts on Productivity
jonyablonski
76
5.2k
Lightning Talk: Beautiful Slides for Beginners
inesmontani
PRO
2
560
Building Applications with DynamoDB
mza
96
7.1k
Transcript
AndroidϓϩδΣΫτʹ DangerΛಋೖͯ͠Έͨ @kirimin
Dangerʁ • PRͷࣗಈνΣοΫπʔϧ • ਓྗͰΔඞཁͷͳ͍ϨϏϡʔΛࣗಈԽ͢Δ • ϨϏϡʔݮɺਓؒʹ͔͠ग़དྷͳ͍Ϩ Ϗϡʔʹूத͢Δ
͍ํ • ϓϩδΣΫτԼʹgemfileͱDangerfileΛ Ճ͢Δɻ • DangerfileʹεΫϦϓτΛॻ͘ɻ • CI͔ΒίϚϯυΛୟ͍࣮ͯߦ͢Δɻ bundle install
bundle exec danger
Dangerfile? • ͨͩͷruby script • ҎԼͷΑ͏ʹॻ͘ͱࣗಈͰPRʹίϝϯτͯ͠ ͘ΕΔ message('Αͦ͞͏') warn('ͦ͏') fail('ͩΊͦ͏')
Dangerfile? • PRʹؔ͢ΔใΛgem͔ΒऔಘͰ͖Δ • ͍Ζ͍ΖPlugin͋Δ if github.pr_title.include? '[WIP]' warn('WIPͩΑ') end
࣮ࡍʹͬͨ͜ͱ • Ϛʔδઌ͕masterͳΒΞϥʔτ • λΠτϧʹIssue൪߸ؚ͕·Ε͍ͯͳ͚ΕΞϥʔτ • λΠτϧʹWIPؚ͕·Ε͍ͯͨΒΞϥʔτ • ࣗಈͰؔ࿈IssueΛclose͢Δه๏͕ॻ͔Ε͍ͯͳ͚ΕΞϥʔτ •
assignee͕ઃఆ͞Ε͍ͯͳ͚ΕΞϥʔτ • PR͕࡞͞ΕͨΒSlackʹϝϯγϣϯΛඈ͢
Α͏͢
࣮ࡍͷεΫϦϓτ
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • Reviewerʹؚ·Ε͍ͯΔਓʹͷΈϝϯγϣϯ Λඈ͢ ɹ→ReviewerͷҰཡ͕danger͔ΒऔಘͰ͖ͳ ͍ɻGitHub্ͰAPI͕͔Ε͓ͯΓखಈͰऔಘ͢Δ ͷͪΐͬͱ໘
Γ͍͚ͨͲग़དྷͯͳ͍͜ͱ • AndroidLintΛΒͤࣗಈͰίʔυʹࢦఠίϝ ϯτΛຒΊࠐΉ ɹ→AndroidLint͕ͦͦKotlinʹରԠ͍ͯ͠ͳ͍ Β͍͠ͷͰอཹ
͓ΘΓ • ࠓޙػೳ֦ு͍͖͍ͯͨ͠ॴଘ