Upgrade to Pro — share decks privately, control downloads, hide ads and more …

コードレビュー座学 / About code reviews

コードレビュー座学 / About code reviews

GMOペパボの2019年エンジニア研修で利用した資料です

Kōhei Yamamoto

May 30, 2019
Tweet

More Decks by Kōhei Yamamoto

Other Decks in Programming

Transcript

  1. !LZNNU
    ίʔυϨϏϡʔ࠲ֶ

    View full-size slide

  2. &$ࣄۀ෦
    ࢁຊߒฏ!LZNNU
    LZNNUDPN

    View full-size slide

  3. ίʔυϨϏϡʔͱ͸

    View full-size slide

  4. ʮϨϏϡʔ࣮ફݚमʯ
    CZ!KVOF

    View full-size slide

  5. ʮϨϏϡʔ࣮ફݚमʯ

    Λಡ΋͏ʂʂʂʂʂʂʂʂʂʂʂʂʂ

    Ҏ্ʂʂʂʂʂʂʂʂʂʂʂʂʂʂʂ

    View full-size slide

  6. ίʔυϨϏϡʔͷศརࢿྉ͸͍Ζ͍Ζ͋Δ
    w8%#13&447PMʮϨϏϡʔ࣮ફݚमʯ
    w!IJTBJDIJ͞Μͷࢿྉ
    wଞ͍Ζ͍Ζ

    View full-size slide

  7. ͡Ό͋ɺ͜ͷ࣌ؒ͸Ͳ͏͢Δ͔ʁ

    View full-size slide

  8. ίʔυϨϏϡʔͷ༷ࢠΛ࣮ࡍʹ
    ݟͳ͕ΒɺΈΜͳͰ͋Ε͜Εݴ͏࣌ؒ
    ʹ͠·͢

    View full-size slide

  9. ίʔυϨϏϡʔ͢ΔͷͰ

    αϯϓϧϦϙδτϦΛݟΔ

    View full-size slide

  10. 8FCαʔϏεʹ͓͚ΔϦϙδτϦ
    w8FCαʔϏε͕׎͍͑ͨϏδωε্ͷཁٻΛຬͨ͢
    ιϑτ΢ΣΞͷஔ͖৔
    wνʔϜͰڞ༗͢Δίʔυͷू߹ମ

    View full-size slide

  11. QVMMSFRVFTUΛݟΔ

    View full-size slide

  12. QVMMSFRVFTUΛϨϏϡʔΛ͢Δཧ༝
    wࣗ෼ͷ੒Ռ෺ΛνʔϜϝϯόʔʹݟͯ΋ΒͬͯɺҎԼ
    Λ֬ೝ͍͔ͨ͠Β
    wαʔϏε͕׎͍͑ͨϏδωε্ͷཁٻΛຬͨ͢ಈ࡞
    Λ͢Δͷ͔
    wࠓޙνʔϜͰڞ༗͢Δίʔυͱͯ͠΍͍͚ͬͯͦ͏
    ͔

    View full-size slide

  13. 'JMFTDIBOHFEΛݟΔ

    View full-size slide

  14. ϨϏϡΞʔ͸Կ͔Β࢝ΊΔͷ͔
    wٙ໰ʹࢥ͏͜ͱɺΘ͔Βͳ͍͜ͱΛݟ͚ͭΔ
    wίϛοτ͝ͱʹݟΔ
    wHJUDIFDLPVUͯ͠खݩͷΤσΟλͰݟΔ

    View full-size slide

  15. $PNNJUTΛݟ͍ͯ͘

    View full-size slide

  16. ϨϏϡΠʔͷ४උ͕ॏཁ
    wιϑτ΢ΣΞ։ൃ͸ίϥϘϨʔγϣϯ
    w13͸ϨϏϡʔ͠΍͍͢ঢ়ଶʹ͓ͯ͘͠ͱΑ͍
    wHJUTIPX΍HJUMPHQͰಡΈฦ͢
    w(JU)VC্Ͱઆ໌Λॻ͘

    View full-size slide

  17. ͞Βʹ$PNNJUTΛݟ͍ͯ͘

    View full-size slide

  18. ࿦ཧతʹνΣοΫͰ͖Δࣄ߲
    wͦ΋ͦ΋ͷ࢓༷ͱͷࠩҟ
    w෼ذͷ৚݅
    wҙ֎ʹ΋ҙਤͱٯʹͳͬͯͨΓ͢Δ

    View full-size slide

  19. ίʔσΟϯάελΠϧ໰୊
    wۭന͕ଟ͍ɺ͚ͩ͜͜൒֯ʹͳͬͯΔɺͳͲʜ
    wػցతʹमਖ਼Ͱ͖Δ
    w3VCP$PQ 1SFUUJFS HPGNU ʜ

    View full-size slide

  20. ίʔσΟϯάελΠϧ໰୊
    w͔͠͠ɺʮεϖʔε͕ద੾Ͱ͋Δ͔Ͳ͏͔͕ؾʹͳͬ
    ͯ࢓ํͷͳ͍ਓʹͳͬͯ΄͍͠ʯ
    w IUUQTTQFBLFSEFDLDPNOBZNPYJFGBMTFSBJMTYJOSFOZBOYJV
    GBMTFLPEPSFCJZVLPNFOUPXPGFOYJTJUFNJNBTJUB TMJEF

    View full-size slide

  21. ؾʹͳΔ఺͕ग़͖ͯͨͷͰ
    ίϝϯτΛॻ͍͍ͯ͘

    View full-size slide

  22. ϨϏϡʔͰ։ൃΛՃ଎͢ΔͨΊʹ
    w8FCαʔϏεΛ։ൃ͢Δͷ͸Ϗδωε্ͷཁٻΛ࣮
    ݱ͢ΔͨΊ
    wΑΓૣ͘Ϗδωε্ͷཁٻΛ࣮ݱ͢ΔͨΊʹ͸13͕
    ΑΓૣ͘ϚʔδͰ͖ΔͱΑ͍
    wϨϏϡʔͰ஌ܙΛग़͠߹͏

    View full-size slide

  23. ͦ΋ͦ΋࿦ʹͳΔͱ͖
    wJTTVF΍ΦϑϥΠϯͷٞ࿦Λ΍͓ͬͯ͘
    wΤϯδχΞɺσβΠφʔɺϓϩμΫτϚωʔδϟͱ
    wલఏͱͳΔ࢓༷΍ઃܭ
    wϗϫΠτϘʔυΛ࢖͏

    View full-size slide

  24. ΦϯϥΠϯͱΦϑϥΠϯ
    wΦϯϥΠϯͷ(JU)VCͩͱ
    wඇಉظʹϨϏϡʔͰ͖Δ
    w͋ͱ͔Β։ൃ౰࣌ͷࣄ৘ΛݟฦͤΔ
    wࠐΈೖͬͨϨϏϡʔͩͱจষ࡞੒ʹ͕͔͔࣌ؒΔ͜
    ͱ΋͋Δ

    View full-size slide

  25. ΦϯϥΠϯͱΦϑϥΠϯ
    wΦϑϥΠϯͷର໘ϨϏϡʔͩͱ
    wχϡΞϯεΛ఻͑΍͍͢
    w࣮࣭ϛʔςΟϯάͳͷͰ߆ଋ͕࣌ؒൃੜ͢Δ
    wͪΌΜͱϝϞͯ͠13ʹॻ͍͓ͯ͘

    View full-size slide

  26. ίϝϯτΛ΋ΒͬͨͷͰ

    QVMMSFRVFTUΛվળ͍ͯ͘͠

    View full-size slide

  27. ϨϏϡΠʔͱͯ͠ͷଶ౓
    wݴΘΕΔ͕··ʹมߋ͢ΔΑΓɺࣗ෼Ͱೲಘ͢Δ·Ͱ
    ཧ༝Λߟ͑Δ
    wΑΓΑ͍ํ๏͕͋ΔͳΒɺͦͷํ๏Ͱ΍Δ
    wࣗ෼ͷݴ༿ͰίϛοτϩάΛॻ͘
    wIUUQTKVOFKQZPVSPXODPNNJUNFTTBHF

    View full-size slide

  28. ΋͏Ұ౓ϨϏϡʔͯ͠΋Β͏

    View full-size slide

  29. BQQSPWFͩ
    w-(5.
    wPL@XPNBO
    wBQQSPWFԿ݅ͰNBTUFS΁Ϛʔδ͢Δ͔͸νʔϜ࣍ୈ
    w΋͠BQQSPWF͕݅Ͱ͍͍৔߹Ͱ΋ɺෳ਺ਓʹ
    BQQSPWFΛ΋Β͍͍ͨͳΒ͓ئ͍ͪ͠ΌͬͯΑ͍

    View full-size slide