コードレビュー座学 / About code reviews

1604058c93731a1f795ce62d37d19fd5?s=47 Kōhei Yamamoto
May 30, 2019
Programming
0
4.2k

コードレビュー座学 / About code reviews

GMOペパボの2019年エンジニア研修で利用した資料です

1604058c93731a1f795ce62d37d19fd5?s=128

Kōhei Yamamoto

May 30, 2019
Tweet

Want more?

1604058c93731a1f795ce62d37d19fd5?s=48 kymmt90
2
370
1604058c93731a1f795ce62d37d19fd5?s=48 kymmt90
3
2.9k
1604058c93731a1f795ce62d37d19fd5?s=48 kymmt90
1
1.2k
3ab1249be442027903e1180025340b3f?s=48 reverentgeek
13
790
A9a491b0fcbe0fbce3d64063a37add99?s=48 rmw
4
430
766b9746b59e6f09e280cd33cf4ed419?s=48 skipperchong
0
270
61857dafbd287b3027c4dcea9008ad3c?s=48 carmenhchung
8
560
06f8b41980eb4c577fa40c41d5030c19?s=48 keathley
9
310
C0390e8b11079f8761c0cd3274ed61cb?s=48 productmarketing
3
350
C35e01544a0dd94a2cf1619ee8a42ebb?s=48 clairelew
4
830
6bb82b13cda86d3b821fa44100335ddf?s=48 thoeni
1
220
B3ace07412a5178ea778e7eec161fc0a?s=48 jcasabona
4
290

Transcript

  1. 1.

    !LZNNU ίʔυϨϏϡʔ࠲ֶ

  2. 2.

    &$ࣄۀ෦ ࢁຊߒฏ!LZNNU LZNNUDPN

  3. 3.

    ίʔυϨϏϡʔͱ͸

  4. 4.

    ʮϨϏϡʔ࣮ફݚमʯ CZ!KVOF

  5. 5.

    ʮϨϏϡʔ࣮ફݚमʯ
 Λಡ΋͏ʂʂʂʂʂʂʂʂʂʂʂʂʂ
 Ҏ্ʂʂʂʂʂʂʂʂʂʂʂʂʂʂʂ

  6. 6.
    None
  7. 7.

    ίʔυϨϏϡʔͷศརࢿྉ͸͍Ζ͍Ζ͋Δ w8&# %#13&447PMʮϨϏϡʔ࣮ફݚमʯ w!IJTBJDIJ͞Μͷࢿྉ wଞ͍Ζ͍Ζ

  8. 8.

    ͡Ό͋ɺ͜ͷ࣌ؒ͸Ͳ͏͢Δ͔ʁ

  9. 9.

    ίʔυϨϏϡʔͷ༷ࢠΛ࣮ࡍʹ ݟͳ͕ΒɺΈΜͳͰ͋Ε͜Εݴ͏࣌ؒ ʹ͠·͢

  10. 10.

    ίʔυϨϏϡʔ͢ΔͷͰ
 αϯϓϧϦϙδτϦΛݟΔ

  11. 11.

    8FCαʔϏεʹ͓͚ΔϦϙδτϦ w8FCαʔϏε͕׎͍͑ͨϏδωε্ͷཁٻΛຬͨ͢ ιϑτ΢ΣΞͷஔ͖৔ wνʔϜͰڞ༗͢Δίʔυͷू߹ମ

  12. 12.

    QVMMSFRVFTUΛݟΔ

  13. 13.

    QVMMSFRVFTUΛϨϏϡʔΛ͢Δཧ༝ wࣗ෼ͷ੒Ռ෺ΛνʔϜϝϯόʔʹݟͯ΋ΒͬͯɺҎԼ Λ֬ೝ͍͔ͨ͠Β wαʔϏε͕׎͍͑ͨϏδωε্ͷཁٻΛຬͨ͢ಈ࡞ Λ͢Δͷ͔ wࠓޙνʔϜͰڞ༗͢Δίʔυͱͯ͠΍͍͚ͬͯͦ͏ ͔

  14. 14.

    'JMFTDIBOHFEΛݟΔ

  15. 15.

    ϨϏϡΞʔ͸Կ͔Β࢝ΊΔͷ͔ wٙ໰ʹࢥ͏͜ͱɺΘ͔Βͳ͍͜ͱΛݟ͚ͭΔ wίϛοτ͝ͱʹݟΔ wHJUDIFDLPVUͯ͠खݩͷΤσΟλͰݟΔ

  16. 16.

    $PNNJUTΛݟ͍ͯ͘

  17. 17.

    ϨϏϡΠʔͷ४උ͕ॏཁ wιϑτ΢ΣΞ։ൃ͸ίϥϘϨʔγϣϯ w13͸ϨϏϡʔ͠΍͍͢ঢ়ଶʹ͓ͯ͘͠ͱΑ͍ wHJUTIPX΍HJUMPHQͰಡΈฦ͢ w(JU)VC্Ͱઆ໌Λॻ͘

  18. 18.

    ͞Βʹ$PNNJUTΛݟ͍ͯ͘

  19. 19.

    ࿦ཧతʹνΣοΫͰ͖Δࣄ߲ wͦ΋ͦ΋ͷ࢓༷ͱͷࠩҟ w෼ذͷ৚݅ wҙ֎ʹ΋ҙਤͱٯʹͳͬͯͨΓ͢Δ

  20. 20.

    ίʔσΟϯάελΠϧ໰୊ wۭന͕ଟ͍ɺ͚ͩ͜͜൒֯ʹͳͬͯΔɺͳͲʜ wػցతʹमਖ਼Ͱ͖Δ w3VCP$PQ 1SFUUJFS HPGNU ʜ

  21. 21.

    ίʔσΟϯάελΠϧ໰୊ w͔͠͠ɺʮεϖʔε͕ద੾Ͱ͋Δ͔Ͳ͏͔͕ؾʹͳͬ ͯ࢓ํͷͳ͍ਓʹͳͬͯ΄͍͠ʯ w IUUQTTQFBLFSEFDLDPNOBZNPYJFGBMTFSBJMTYJOSFOZBOYJV GBMTFLPEPSFCJZVLPNFOUPXPGFOYJTJUFNJNBTJUB TMJEF

  22. 22.

    ؾʹͳΔ఺͕ग़͖ͯͨͷͰ ίϝϯτΛॻ͍͍ͯ͘

  23. 23.

    ϨϏϡʔͰ։ൃΛՃ଎͢ΔͨΊʹ w8FCαʔϏεΛ։ൃ͢Δͷ͸Ϗδωε্ͷཁٻΛ࣮ ݱ͢ΔͨΊ wΑΓૣ͘Ϗδωε্ͷཁٻΛ࣮ݱ͢ΔͨΊʹ͸13͕ ΑΓૣ͘ϚʔδͰ͖ΔͱΑ͍ wϨϏϡʔͰ஌ܙΛग़͠߹͏

  24. 24.

    ͦ΋ͦ΋࿦ʹͳΔͱ͖ wJTTVF΍ΦϑϥΠϯͷٞ࿦Λ΍͓ͬͯ͘ wΤϯδχΞɺσβΠφʔɺϓϩμΫτϚωʔδϟͱ wલఏͱͳΔ࢓༷΍ઃܭ wϗϫΠτϘʔυΛ࢖͏

  25. 25.

    ΦϯϥΠϯͱΦϑϥΠϯ wΦϯϥΠϯͷ(JU)VCͩͱ wඇಉظʹϨϏϡʔͰ͖Δ w͋ͱ͔Β։ൃ౰࣌ͷࣄ৘ΛݟฦͤΔ wࠐΈೖͬͨϨϏϡʔͩͱจষ࡞੒ʹ͕͔͔࣌ؒΔ͜ ͱ΋͋Δ

  26. 26.

    ΦϯϥΠϯͱΦϑϥΠϯ wΦϑϥΠϯͷର໘ϨϏϡʔͩͱ wχϡΞϯεΛ఻͑΍͍͢ w࣮࣭ϛʔςΟϯάͳͷͰ߆ଋ͕࣌ؒൃੜ͢Δ wͪΌΜͱϝϞͯ͠13ʹॻ͍͓ͯ͘

  27. 27.

    ίϝϯτΛ΋ΒͬͨͷͰ
 QVMMSFRVFTUΛվળ͍ͯ͘͠

  28. 28.

    ϨϏϡΠʔͱͯ͠ͷଶ౓ wݴΘΕΔ͕··ʹมߋ͢ΔΑΓɺࣗ෼Ͱೲಘ͢Δ·Ͱ ཧ༝Λߟ͑Δ wΑΓΑ͍ํ๏͕͋ΔͳΒɺͦͷํ๏Ͱ΍Δ wࣗ෼ͷݴ༿ͰίϛοτϩάΛॻ͘ wIUUQTKVOFKQZPVSPXODPNNJUNFTTBHF

  29. 29.

    ΋͏Ұ౓ϨϏϡʔͯ͠΋Β͏

  30. 30.

    BQQSPWFͩ w-(5. wPL@XPNBO wBQQSPWFԿ݅ͰNBTUFS΁Ϛʔδ͢Δ͔͸νʔϜ࣍ୈ w΋͠BQQSPWF͕݅Ͱ͍͍৔߹Ͱ΋ɺෳ਺ਓʹ BQQSPWFΛ΋Β͍͍ͨͳΒ͓ئ͍ͪ͠ΌͬͯΑ͍

  31. 31.

    Ϛʔδͩʂ

  32. 32.

    ʙ׬ʙ