コードレビュー座学 / About code reviews

GMOペパボの2019年エンジニア研修で利用した資料です

Transcript

1. !LZNNU
   ίʔυϨϏϡʔ࠲ֶ
   

   View Slide

2. &$ࣄۀ෦
   ࢁຊߒฏ!LZNNU
   LZNNUDPN
   

   View Slide

3. ίʔυϨϏϡʔͱ͸
   

   View Slide

4. ʮϨϏϡʔ࣮ફݚमʯ
   CZ!KVOF
   

   View Slide

5. ʮϨϏϡʔ࣮ફݚमʯ

   Λಡ΋͏ʂʂʂʂʂʂʂʂʂʂʂʂʂ

   Ҏ্ʂʂʂʂʂʂʂʂʂʂʂʂʂʂʂ
   

   View Slide

6. View Slide

7. ίʔυϨϏϡʔͷศརࢿྉ͸͍Ζ͍Ζ͋Δ
   w8%#13&447PMʮϨϏϡʔ࣮ફݚमʯ
   w!IJTBJDIJ͞Μͷࢿྉ
   wଞ͍Ζ͍Ζ
   

   View Slide

8. ͡Ό͋ɺ͜ͷ࣌ؒ͸Ͳ͏͢Δ͔ʁ
   

   View Slide

9. ίʔυϨϏϡʔͷ༷ࢠΛ࣮ࡍʹ
   ݟͳ͕ΒɺΈΜͳͰ͋Ε͜Εݴ͏࣌ؒ
   ʹ͠·͢
   

   View Slide

10. ίʔυϨϏϡʔ͢ΔͷͰ

    αϯϓϧϦϙδτϦΛݟΔ
    

    View Slide

11. 8FCαʔϏεʹ͓͚ΔϦϙδτϦ
    w8FCαʔϏε͕׎͍͑ͨϏδωε্ͷཁٻΛຬͨ͢
    ιϑτ΢ΣΞͷஔ͖৔
    wνʔϜͰڞ༗͢Δίʔυͷू߹ମ
    

    View Slide

12. QVMMSFRVFTUΛݟΔ
    

    View Slide

13. QVMMSFRVFTUΛϨϏϡʔΛ͢Δཧ༝
    wࣗ෼ͷ੒Ռ෺ΛνʔϜϝϯόʔʹݟͯ΋ΒͬͯɺҎԼ
    Λ֬ೝ͍͔ͨ͠Β
    wαʔϏε͕׎͍͑ͨϏδωε্ͷཁٻΛຬͨ͢ಈ࡞
    Λ͢Δͷ͔
    wࠓޙνʔϜͰڞ༗͢Δίʔυͱͯ͠΍͍͚ͬͯͦ͏
    ͔
    

    View Slide

14. 'JMFTDIBOHFEΛݟΔ
    

    View Slide

15. ϨϏϡΞʔ͸Կ͔Β࢝ΊΔͷ͔
    wٙ໰ʹࢥ͏͜ͱɺΘ͔Βͳ͍͜ͱΛݟ͚ͭΔ
    wίϛοτ͝ͱʹݟΔ
    wHJUDIFDLPVUͯ͠खݩͷΤσΟλͰݟΔ
    

    View Slide

16. $PNNJUTΛݟ͍ͯ͘
    

    View Slide

17. ϨϏϡΠʔͷ४උ͕ॏཁ
    wιϑτ΢ΣΞ։ൃ͸ίϥϘϨʔγϣϯ
    w13͸ϨϏϡʔ͠΍͍͢ঢ়ଶʹ͓ͯ͘͠ͱΑ͍
    wHJUTIPX΍HJUMPHQͰಡΈฦ͢
    w(JU)VC্Ͱઆ໌Λॻ͘
    

    View Slide

18. ͞Βʹ$PNNJUTΛݟ͍ͯ͘
    

    View Slide

19. ࿦ཧతʹνΣοΫͰ͖Δࣄ߲
    wͦ΋ͦ΋ͷ࢓༷ͱͷࠩҟ
    w෼ذͷ৚݅
    wҙ֎ʹ΋ҙਤͱٯʹͳͬͯͨΓ͢Δ
    

    View Slide

20. ίʔσΟϯάελΠϧ໰୊
    wۭന͕ଟ͍ɺ͚ͩ͜͜൒֯ʹͳͬͯΔɺͳͲʜ
    wػցతʹमਖ਼Ͱ͖Δ
    w3VCP$PQ 1SFUUJFS HPGNU ʜ
    

    View Slide

21. ίʔσΟϯάελΠϧ໰୊
    w͔͠͠ɺʮεϖʔε͕ద੾Ͱ͋Δ͔Ͳ͏͔͕ؾʹͳͬ
    ͯ࢓ํͷͳ͍ਓʹͳͬͯ΄͍͠ʯ
    w IUUQTTQFBLFSEFDLDPNOBZNPYJFGBMTFSBJMTYJOSFOZBOYJV
    GBMTFLPEPSFCJZVLPNFOUPXPGFOYJTJUFNJNBTJUB TMJEF
    

    View Slide

22. ؾʹͳΔ఺͕ग़͖ͯͨͷͰ
    ίϝϯτΛॻ͍͍ͯ͘
    

    View Slide

23. ϨϏϡʔͰ։ൃΛՃ଎͢ΔͨΊʹ
    w8FCαʔϏεΛ։ൃ͢Δͷ͸Ϗδωε্ͷཁٻΛ࣮
    ݱ͢ΔͨΊ
    wΑΓૣ͘Ϗδωε্ͷཁٻΛ࣮ݱ͢ΔͨΊʹ͸13͕
    ΑΓૣ͘ϚʔδͰ͖ΔͱΑ͍
    wϨϏϡʔͰ஌ܙΛग़͠߹͏
    

    View Slide

24. ͦ΋ͦ΋࿦ʹͳΔͱ͖
    wJTTVF΍ΦϑϥΠϯͷٞ࿦Λ΍͓ͬͯ͘
    wΤϯδχΞɺσβΠφʔɺϓϩμΫτϚωʔδϟͱ
    wલఏͱͳΔ࢓༷΍ઃܭ
    wϗϫΠτϘʔυΛ࢖͏
    

    View Slide

25. ΦϯϥΠϯͱΦϑϥΠϯ
    wΦϯϥΠϯͷ(JU)VCͩͱ
    wඇಉظʹϨϏϡʔͰ͖Δ
    w͋ͱ͔Β։ൃ౰࣌ͷࣄ৘ΛݟฦͤΔ
    wࠐΈೖͬͨϨϏϡʔͩͱจষ࡞੒ʹ͕͔͔࣌ؒΔ͜
    ͱ΋͋Δ
    

    View Slide

26. ΦϯϥΠϯͱΦϑϥΠϯ
    wΦϑϥΠϯͷର໘ϨϏϡʔͩͱ
    wχϡΞϯεΛ఻͑΍͍͢
    w࣮࣭ϛʔςΟϯάͳͷͰ߆ଋ͕࣌ؒൃੜ͢Δ
    wͪΌΜͱϝϞͯ͠13ʹॻ͍͓ͯ͘
    

    View Slide

27. ίϝϯτΛ΋ΒͬͨͷͰ

    QVMMSFRVFTUΛվળ͍ͯ͘͠
    

    View Slide

28. ϨϏϡΠʔͱͯ͠ͷଶ౓
    wݴΘΕΔ͕··ʹมߋ͢ΔΑΓɺࣗ෼Ͱೲಘ͢Δ·Ͱ
    ཧ༝Λߟ͑Δ
    wΑΓΑ͍ํ๏͕͋ΔͳΒɺͦͷํ๏Ͱ΍Δ
    wࣗ෼ͷݴ༿ͰίϛοτϩάΛॻ͘
    wIUUQTKVOFKQZPVSPXODPNNJUNFTTBHF
    

    View Slide

29. ΋͏Ұ౓ϨϏϡʔͯ͠΋Β͏
    

    View Slide

30. BQQSPWFͩ
    w-(5.
    wPL@XPNBO
    wBQQSPWFԿ݅ͰNBTUFS΁Ϛʔδ͢Δ͔͸νʔϜ࣍ୈ
    w΋͠BQQSPWF͕݅Ͱ͍͍৔߹Ͱ΋ɺෳ਺ਓʹ
    BQQSPWFΛ΋Β͍͍ͨͳΒ͓ئ͍ͪ͠ΌͬͯΑ͍
    

    View Slide

31. Ϛʔδͩʂ
    

    View Slide

32. ʙ׬ʙ
    

    View Slide