DangerでスムーズなPRレビューを

2017/09/12 iOS社内勉強会 @OHAKO.inc にて公開したスライドです

Transcript

1. DangerͰ εϜʔζͳPRϨϏϡʔΛ 2017/09/12 iOSࣾ಺ษڧձ @OHAKO.inc Masakazu Sano (@kz56cd)
2. Dangerʁ
4. You can use Danger to codify your teams norms, leaving humans to think about harder problems.
5. Dangerͱ͸ νʔϜ։ൃͰ͸ࡉ͔ͳϧʔϧ͕ଘࡏ͢Δ
6. Dangerͱ͸ νʔϜ։ൃͰ͸ࡉ͔ͳϧʔϧ͕ଘࡏ͢Δ • WIP͕͍ͭͨ··ϨϏϡʔʹճ͞ͳ͍Ͱʂ • ίʔυมߋͨ͠ΒCHANGELOGs΋ߋ৽ͯ͠ʂ • PRͷ࡞ۀऀΛઃఆͯ͠ʂ • ಛघͳϑΝΠϧ͕ߋ৽͞Ε͍ͯΔͳΒࣄલʹڭ͑ͯ΄͍͠... etc...
7. ͜ΕΒΛʢਓؒͷ୅ΘΓʹʣ ࣄલνΣοΫͯ͘͠ΕΔͷ͕ Danger
8. Danger ͷछྨ
10. Danger ͷछྨ • ݱࡏ js൛ͱruby൛͕͋Δ • ࠷ۙ swift൛ʢ·ͩβͬΆ͍ʣ͕௥Ճ͞Εͨ! • iOS 11 / swift 4 ʹͯಈ࡞ • https://github.com/danger/danger-swift ※ ࠓճ͸ruby൛Ͱ࿩ΛਐΊ·͢
11. ಋೖํ๏
12. ಋೖํ๏ ༻ҙ͢Δ΋ͷ • Bundler • ԿΒ͔ͷCI (CircleCI , Bitrize ...) • Danger௨஌༻ͷ bot • organization / private repoͷࡍ͸ඞཁʹͳΔ
13. ಋೖํ๏ ͓͓·͔ͳྲྀΕ 1. ϩʔΧϧ؀ڥʹDangerΛೖΕΔ 2. GithubʹbotΛઃఆ͢Δ 3. CI্ͰDangerFileΛධՁͰ͖ΔΑ͏ʹηοτ͢Δ
14. ಋೖํ๏ 1. ϩʔΧϧ؀ڥʹDangerΛೖΕΔ
15. ಋೖํ๏ 1. ϩʔΧϧ؀ڥʹDangerΛೖΕΔ • ϓϩδΣΫτԼʹ࣮ͯߦ $ bundle init
16. ಋೖํ๏ 1. ϩʔΧϧ؀ڥʹDangerΛೖΕΔ • ੜ੒͞ΕͨGemFileʹ gem "danger" Λ௥ه $ bundle install ʢ࣮ߦ࣌ɺର࿩ܗࣜʹͯηοτΞοϓΛߦ͑Δ͕ɺͱΓ͋͑ͣ Enter࿈ଧͯ͠΋Α͍ʣ ➡ Πϯετʔϧ੒ޭ͢ΔͱDangerFile͕ੜ੒͞ΕΔ
17. ಋೖํ๏ 1. ϩʔΧϧ؀ڥʹDangerΛೖΕΔ • ϓϩδΣΫτ্ෆཁͳϑΝΠϧ͸.gitignoreʹ௥ه͓ͯ͘͠ ## danger(use bundler) .bundle/ vendor/
18. ಋೖํ๏ 2. GithubʹbotΛઃఆ͢Δ
19. ಋೖํ๏ 2. GithubʹbotΛઃఆ͢Δ
20. ಋೖํ๏ 2. GithubʹbotΛઃఆ͢Δ ʢOSSͷ৔߹͸͜ͷखॱ͸ল͍ͯΑ͍Ͱ͢!ʣ • Githubͷ৔߹͸machine userΛ༻ҙ͢Δ
21. ಋೖํ๏ 2. GithubʹbotΛઃఆ͢Δ • ن໿্ɺmachine user ͸1ͭͷ organization ʹ͖ͭ1ମͷΈ ͱͳ͍ͬͯΔͷͰ஫ҙ • https://developer.github.com/v3/guides/managing- deploy-keys/#machine-users • machine userͷ௥Ճํ๏ • http://www.wikihow.com/Use-Deploy-Keys-on- Github#CreatingaMachineUsersub
22. ಋೖํ๏ 2. GithubʹbotΛઃఆ͢Δ ʢOSSͷ৔߹͸͜ͷखॱ͸ল͍ͯΑ͍Ͱ͢!ʣ • ௥Ճ͍ͨ͠private repoʹcollaboratorͱͯ͠ɺbotΛ௥Ճ͢ Δ
23. ಋೖํ๏ 2. GithubʹbotΛઃఆ͢Δ ʢOSSͷ৔߹͸ࣗ਎ͷΞΧ΢ϯτͷtokenΛ࡞Γ·͠ΐ͏!ʣ • botʹDanger༻ͷprivate access tokenΛ௥Ճ͢Δ • botͰϩάΠϯ • Setting -> Personal access tokens -> ʮGenerate new tokenʯԡԼ • ͦͷࡍɺtokenͷݖݶ͸ repos શͯʹνΣοΫ͢Δ͜ͱ
24. ಋೖํ๏ 3. CI্ͰDangerFileΛධՁͰ͖ΔΑ ͏ʹηοτ͢Δ
25. ಋೖํ๏ 3. CI্ͰDangerFileΛධՁ Ͱ͖ΔΑ͏ʹηοτ͢Δ • bitriseͷ৔߹ • ֘౰ϓϩδΣΫτͷworkflow editorΛ։͘ • ೚ҙͷҐஔʹʮScriptʯstepΛ৽ ن௥Ճ • Script content ʹهड़ɿ
26. ಋೖํ๏ 3. CI্ͰDangerFileΛධՁ Ͱ͖ΔΑ͏ʹηοτ͢Δ • ઌʹ༻ҙͨ͠bot (OSSͷ৔߹͸ࣗ਎ ͷ) ͷ private access token Λη οτ͢Δ • workflow editor಺ͷʮEnv Varsʯ λϒԡԼ • ʮAdd newʯԡԼ͠ɺ ʮDANGERGITHUBAPI_TOKENʯ ͱ͍͏໊শͰtokenొ࿥
27. ͋ͱ͸ɺpull requestΛ࡞੒ͯ͠ Dangerͷ௨஌͕ग़Ε͹OKͰ͢ʂ
29. DangerFileΛΧελϚ Πζ͢Δ
31. DangerFileΛΧελϚΠζ͢Δ • message / warn / fail ͷࡾछͰϢʔβʔʹνΣοΫ಺༰Λप ஌Ͱ͖Δ • markdownͰͷهड़΋Մɿ • markdown("## ࡞ۀதͰ͢") • ಛఆͷίʔυͷdiffΛදࣔ͢Δ͜ͱ΋Ͱ͖Δ
32. DangerFileΛΧελϚΠζ͢Δ ڞ௨Ͱ࢖͑ͦ͏ͳνΣοΫɿ # ϚΠϧετʔϯͷνΣοΫ message("ϚΠϧετʔϯ͕ະઃఆͰ͢") unless has_milestone # ࡞ۀऀͷνΣοΫ warn("࡞ۀऀΛΞαΠϯ͠·͠ΐ͏", sticky: false) unless has_assignee # ϚʔδઌͷνΣοΫ warn("ϚʔδઌΛdevelopʹઃఆ͠·͠ΐ͏") if !github.branch_for_base == "develop" # ߦ਺νΣοΫ warn("500ߦ௒͑ͯ·͢ɻ෼ׂͰ͖ΔͱϕλʔͰ͢Ͷ") if git.lines_of_code > 500
33. DangerFileΛΧελϚΠζ͢Δ iOS։ൃ༻్ͷνΣοΫɿ # App.xcodeproj/project.pbxproj ͷมߋνΣοΫ message ("`App.xcodeproj/project.pbxproj` ͕มߋ͞Ε͍ͯ·͢") if git.modified_files.include? "App.xcodeproj/project.pbxproj" # Cartfile ͷมߋνΣοΫ message ("`Cartfile` ͕มߋ͞Ε͍ͯ·͢") if git.modified_files.include? "Cartfile" message ("`Cartfile.resolved` ͕มߋ͞Ε͍ͯ·͢") if git.modified_files.include? "Cartfile.resolved" # Podfile ͷมߋνΣοΫ message ("`Podfile` ͕มߋ͞Ε͍ͯ·͢") if git.modified_files.include? "Podfile" message ("`Podfile.lock` ͕มߋ͞Ε͍ͯ·͢") if git.modified_files.include? "Podfile.lock"
34. DangerFileΛΧελϚΠζ͢Δ LGTMɿ # add lgtm pic lgtm.check_lgtm • ʮwarn / failͰͻ͔͔ͬΒͳ͍࣌ͷΈʯLGTM͞ΕΔ • ͻͱ໨ͰϨϏϡʔՄೳ͔൑Δʂ! • GemFileʹ௥ه͕ඞཁɿ gem "danger-lgtm"
35. DangerFileΛΧελϚΠζ͢Δ ʴα • ެࣜυΩϡϝϯτɺʮSHOW ME SOME DANGERFILESʯʹ ෳ਺ྫ͋Γɿ • http://danger.systems/ruby/
36. Danger Pluginͷಋೖ
37. Danger Pluginͷಋೖ • ઌͷʮdanger-lgtmʯ΋ϓϥάΠϯ • Gemfileʹهड़ͯ͠Πϯετʔϧ͢Ε͹OK • ެࣜαΠτͰଟ਺঺հ͞ΕͯΔ • ʮPLUGINSʯͷ߲Λࢀরɿ • http://danger.systems/ruby/
38. ྑͦ͞͏ͳDanger Plugin clorox • file header(ॺ໊)ͷܗࣜνΣοΫ • https://github.com/barbosa/danger-clorox todoist • TODO/FIXMEͷهड़ʹର͠ࡉ͔ͳ௨஌͕Ͱ͖Δ • https://github.com/hanneskaeufler/danger-todoist
39. slather • ίʔυΧόϨοδͷՄࢹԽ • https://github.com/BrunoMazzo/Danger-Slather Rubocop • rubocopʹ४ڌͨ͠lintνΣοΫ • https://github.com/ashfurrow/danger-rubocop
40. DUPLICATELOCALIZABLESTRINGS • Localizable.strings ͷkeyॏෳνΣοΫ • https://github.com/AirHelp/danger- duplicatelocalizablestrings LGTM • https://github.com/leonhartX/danger-lgtm
41. ! Ҏ্ !
42. ref • http://danger.systems/ • http://sssslide.com/speakerdeck.com/jp_pancake/ dangerwoshi-tuteprwozi-dong-de-nitietukusuru • https://www.slideshare.net/ShunsukeMaeda/dangerpull- request • http://qiita.com/toshiya/items/589834d9b09c0dbe4c56