Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review, do you speak it?
Search
Michal Ostruszka
October 17, 2013
Programming
0
530
Code review, do you speak it?
Slides from my Agile By Example 2013 talk.
Michal Ostruszka
October 17, 2013
Tweet
Share
More Decks by Michal Ostruszka
See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
mostr
2
430
Building modern web applications. Single Responsibility Principle applied
mostr
4
160
You don't need Rails
mostr
3
180
JSON API - standards please
mostr
2
270
Backendless frontend development
mostr
2
320
Things you probably should know about JavaScript that you may not have been told before
mostr
6
680
Other Decks in Programming
See All in Programming
もうちょっといいRubyプロファイラを作りたい (2025)
osyoyu
0
330
MLH State of the League: 2026 Season
theycallmeswift
0
230
AIを活用し、今後に備えるための技術知識 / Basic Knowledge to Utilize AI
kishida
20
5.1k
Laravel Boost 超入門
fire_arlo
2
210
AI時代のUIはどこへ行く?
yusukebe
16
8.3k
Kiroで始めるAI-DLC
kaonash
2
560
開発チーム・開発組織の設計改善スキルの向上
masuda220
PRO
18
9.9k
GitHubとGitLabとAWS CodePipelineでCI/CDを組み比べてみた
satoshi256kbyte
3
130
go test -json そして testing.T.Attr / Kyoto.go #63
utgwkk
3
260
個人軟體時代
ethanhuang13
0
310
実用的なGOCACHEPROG実装をするために / golang.tokyo #40
mazrean
1
230
時間軸から考えるTerraformを使う理由と留意点
fufuhu
14
4.4k
Featured
See All Featured
Navigating Team Friction
lara
189
15k
StorybookのUI Testing Handbookを読んだ
zakiyama
31
6.1k
Making Projects Easy
brettharned
117
6.4k
Rebuilding a faster, lazier Slack
samanthasiow
83
9.2k
Art, The Web, and Tiny UX
lynnandtonic
302
21k
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
eileencodes
36
2.5k
The Art of Delivering Value - GDevCon NA Keynote
reverentgeek
15
1.6k
How to train your dragon (web standard)
notwaldorf
96
6.2k
Into the Great Unknown - MozCon
thekraken
40
2k
Testing 201, or: Great Expectations
jmmastey
45
7.6k
Measuring & Analyzing Core Web Vitals
bluesmoon
9
580
Balancing Empowerment & Direction
lara
3
610
Transcript
CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS