Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review, do you speak it?
Search
Michal Ostruszka
October 17, 2013
Programming
570
0
Share
Embed
Copy iframe code
Copy JS code
Copy link
Start on current slide
Code review, do you speak it?
Slides from my Agile By Example 2013 talk.
Michal Ostruszka
October 17, 2013
More Decks by Michal Ostruszka
See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
mostr
2
440
Building modern web applications. Single Responsibility Principle applied
mostr
4
170
You don't need Rails
mostr
3
180
JSON API - standards please
mostr
2
280
Backendless frontend development
mostr
2
320
Things you probably should know about JavaScript that you may not have been told before
mostr
6
720
Other Decks in Programming
See All in Programming
ITヒヤリハットを整理してみた ~ライフサイクルと原因から考える再発防止策~
koukimiura
1
110
5分で問診!Composer セキュリティ健康診断
codmoninc
0
360
えっ!!コードを読まずに開発を!?
hananouchi
0
220
act2-costs.pdf
sumedhbala
0
120
Haskell/Servantを通してWebミドルウェアを捉え直す
pizzacat83
1
590
琵琶湖の水は止められてもNet--HTTPのリトライは止められない / You might be able to stop the water flow of Lake Biwa but you can't stop Net::HTTP retries
luccafort
PRO
0
400
symfony/aiとlaravel/boost
77web
0
130
PHP初心者セッション2026 〜生成AIでは見えない裏側を知る:今だからLAMPを通して仕組みを学ぶ〜
kashioka
0
530
コーディングルールの鮮度を保ちたい for SRE NEXT 2026 / keep-fresh-go-internal-conventions-sre-next-2026
handlename
0
140
はてなアカウント基盤 State of the Union
cockscomb
1
1.3k
任せる範囲はこう広がった / How the Scope of AI Delegation Has Expanded
nrslib
1
260
【やさしく解説 設計編・中級 #6】良いアーキテクチャとは ~ 一本の登り道の、行き先 ~
panda728
PRO
0
170
Featured
See All Featured
[RailsConf 2023] Rails as a piece of cake
palkan
59
6.8k
Site-Speed That Sticks
csswizardry
13
1.3k
How GitHub (no longer) Works
holman
316
150k
Max Prin - Stacking Signals: How International SEO Comes Together (And Falls Apart)
techseoconnect
PRO
0
200
Balancing Empowerment & Direction
lara
6
1.2k
XXLCSS - How to scale CSS and keep your sanity
sugarenia
249
1.3M
The Curse of the Amulet
leimatthew05
2
13k
The Limits of Empathy - UXLibs8
cassininazir
1
510
Amusing Abliteration
ianozsvald
1
230
The Web Performance Landscape in 2024 [PerfNow 2024]
tammyeverts
12
1.2k
StorybookのUI Testing Handbookを読んだ
zakiyama
31
6.8k
Leveraging Curiosity to Care for An Aging Population
cassininazir
1
400
Transcript
CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS