Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review, do you speak it?

Avatar for Michal Ostruszka Michal Ostruszka
October 17, 2013
Programming
0
530

Code review, do you speak it?

Slides from my Agile By Example 2013 talk.

Avatar for Michal Ostruszka

Michal Ostruszka

October 17, 2013
Tweet

More Decks by Michal Ostruszka

See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
Avatar for Michal Ostruszka mostr
2
430
Building modern web applications. Single Responsibility Principle applied
Avatar for Michal Ostruszka mostr
4
160
You don't need Rails
Avatar for Michal Ostruszka mostr
3
180
JSON API - standards please
Avatar for Michal Ostruszka mostr
2
270
Backendless frontend development
Avatar for Michal Ostruszka mostr
2
320
Things you probably should know about JavaScript that you may not have been told before
Avatar for Michal Ostruszka mostr
6
680

Other Decks in Programming

See All in Programming
(Extension DC 2025) Actor境界を越える技術
Avatar for Himeshi teamhimeh
1
240
Flutterで分数(Fraction)を表示する方法
Avatar for kouki.miura koukimiura
0
120
アメ車でサンノゼを走ってきたよ！
Avatar for Shigure Shimotori s_shimotori
0
210
CSC509 Lecture 03
Avatar for Javier Gonzalez-Sanchez javiergs
PRO
0
330
ポスターセッション: 「まっすぐ行って、右！」って言ってラズパイカーを動かしたい 〜生成AI × Raspberry Pi Pico × Gradioの試作メモ〜
Avatar for komo_fr komofr
0
1.2k
Go言語の特性を活かした公式MCP SDKの設計
Avatar for hond hond0413
1
200
ソフトウェア設計の実践的な考え方
Avatar for 増田 亨 masuda220
PRO
3
520
CSC305 Lecture 06
Avatar for Javier Gonzalez-Sanchez javiergs
PRO
0
210
あなたの知らない「動画広告」の世界 - iOSDC Japan 2025
Avatar for ukitaka ukitaka
0
450
CI_CD「健康診断」のススメ。現場でのボトルネック特定から、健康診断を通じた組織的な改善手法
Avatar for teamLab teamlab
PRO
0
200
monorepo の Go テストをはやくした〜い！~最小の依存解決への道のり~ / faster-testing-of-monorepos
Avatar for convto convto
2
450
XP, Testing and ninja testing ZOZ5
Avatar for seki at druby.org m_seki
3
520

Featured

See All Featured
Sharpening the Axe: The Primacy of Toolmaking
Avatar for Bryan Cantrill bcantrill
45
2.5k
Facilitating Awesome Meetings
Avatar for Lara Hogan lara
56
6.6k
The Pragmatic Product Professional
Avatar for Laura Van Doore lauravandoore
36
6.9k
Unsuck your backbone
Avatar for Amy Palamountain ammeep
671
58k
How GitHub (no longer) Works
Avatar for Zach Holman holman
315
140k
Distributed Sagas: A Protocol for Coordinating Microservices
Avatar for Caitie McCaffrey caitiem20
333
22k
How to Create Impact in a Changing Tech Landscape [PerfNow 2023]
Avatar for Tammy Everts tammyeverts
54
3k
Rails Girls Zürich Keynote
Avatar for Gregor Martynus gr2m
95
14k
Cheating the UX When There Is Nothing More to Optimize - PixelPioneers
Avatar for Stéphanie Walter stephaniewalter
285
14k
Bash Introduction
Avatar for André Augusto Costa Santos 62gerente
615
210k
Stop Working from a Prison Cell
Avatar for Chris Michel hatefulcrawdad
271
21k
Optimising Largest Contentful Paint
Avatar for Harry Roberts csswizardry
37
3.4k

Transcript

  1. CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL

  2. what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE

    REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD

  3. who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST

  4. why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING

  5. if it is so good WHY NOT ALL DEVELOPERS DO

    IT

  6. why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO

    EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED

  7. checkpoint BLOCKING FLOW NON-BLOCKING

  8. toolbox BARE-HANDS TOOL-ASSISTED

  9. doing code review is difficult FOR BOTH SIDES

  10. dive into CODE AUTHOR'S MIND

  11. as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO

    DO RECEIVING FEEDBACK

  12. now step into REVIEWER'S SHOES

  13. as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL

    RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK

  14. we are TERRIBLE AT FEEDBACK STUFF

  15. how to MAKE GOOD REVIEW TO SUCK LESS

  16. ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK

  17. codebrag LIKES: 86 COMMENTS: 877

  18. play with it IT'S NOT SET IN STONE

  19. experiment 1 MONTH KEEP IT OR DROP IT

  20. thank you ENJOY YOUR CODE REVIEWS