Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review, do you speak it?
Search
Sponsored
·
SiteGround - Reliable hosting with speed, security, and support you can count on.
→
Michal Ostruszka
October 17, 2013
Programming
580
0
Share
Embed
Copy iframe code
Copy JS code
Copy link
Start on current slide
Code review, do you speak it?
Slides from my Agile By Example 2013 talk.
Michal Ostruszka
October 17, 2013
More Decks by Michal Ostruszka
See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
mostr
2
440
Building modern web applications. Single Responsibility Principle applied
mostr
4
170
You don't need Rails
mostr
3
180
JSON API - standards please
mostr
2
280
Backendless frontend development
mostr
2
330
Things you probably should know about JavaScript that you may not have been told before
mostr
6
730
Other Decks in Programming
See All in Programming
ハーネス設計入門 〜プロンプト、コンテキストの次〜
kinopeee
43
27k
AI駆動開発にグラフDBを重ねてみた
satoshi256kbyte
2
420
言葉の格闘技のススメ~紙とペンと言葉から始める、キャリアの描き方~
progresscicada
2
190
AIと壁打ちしながら進めるコスト管理
fufuhu
2
1.8k
Pythonの実行はどこまで賢くなったのか? CPythonとPyPyから見る最適化のしくみ
curekoshimizu
4
2.3k
Hello, Hiroshima Geospatial Data! — Exploring DoboX with Python
ra0kley
0
120
Oxlintはいいぞ(続)
yug1224
1
490
Dockerfile CMD for Node.js
grazie1999
0
150
[PyCon KR 2026] More Variants, More Diversity for AI Accelerators
achimnol
0
120
楽しそうなつよつよエンジニアと目が死んでる僕/A brilliant engineer having a blast, and dead-eyed me.
3l4l5
2
260
Flow は今どうなっているか
mizdra
PRO
0
770
仕様駆動開発の消費期限
watany
20
9.1k
Featured
See All Featured
Chrome DevTools: State of the Union 2024 - Debugging React & Beyond
addyosmani
10
1.3k
Documentation Writing (for coders)
carmenintech
77
5.5k
Unlocking the hidden potential of vector embeddings in international SEO
frankvandijk
0
910
Fantastic passwords and where to find them - at NoRuKo
philnash
52
3.8k
Bootstrapping a Software Product
garrettdimon
PRO
306
120k
The Invisible Side of Design
smashingmag
301
52k
How STYLIGHT went responsive
nonsquared
100
6.3k
エンジニアに許された特別な時間の終わり
watany
108
250k
Abbi's Birthday
coloredviolet
3
9.6k
Speed Design
sergeychernyshev
33
2k
Navigating the moral maze — ethical principles for Al-driven product design
skipperchong
2
500
VelocityConf: Rendering Performance Case Studies
addyosmani
331
25k
Transcript
CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS