Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review, do you speak it?
Search
Michal Ostruszka
October 17, 2013
Programming
0
530
Code review, do you speak it?
Slides from my Agile By Example 2013 talk.
Michal Ostruszka
October 17, 2013
Tweet
Share
More Decks by Michal Ostruszka
See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
mostr
2
430
Building modern web applications. Single Responsibility Principle applied
mostr
4
160
You don't need Rails
mostr
3
180
JSON API - standards please
mostr
2
270
Backendless frontend development
mostr
2
320
Things you probably should know about JavaScript that you may not have been told before
mostr
6
680
Other Decks in Programming
See All in Programming
CSC305 Lecture 08
javiergs
PRO
0
280
三者三様 宣言的UI
kkagurazaka
0
290
Amazon ECS Managed Instances が リリースされた!キャッチアップしよう!! / Let's catch up Amazon ECS Managed Instances
cocoeyes02
0
110
Temporal Knowledge Graphで作る! 時間変化するナレッジを扱うAI Agentの世界
po3rin
5
1k
釣り地図SNSにおける有料機能の実装
nokonoko1203
0
200
One Enishi After Another
snoozer05
PRO
0
170
AIと人間の共創開発!OSSで試行錯誤した開発スタイル
mae616
2
830
組込みだけじゃない!TinyGo で始める無料クラウド開発入門
otakakot
2
380
Google Opalで使える37のライブラリ
mickey_kubo
3
160
登壇は dynamic! な営みである / speech is dynamic
da1chi
0
390
スキーマ駆動で、Zod OpenAPI Honoによる、API開発するために、Hono Takibiというライブラリを作っている
nakita628
0
330
コードとあなたと私の距離 / The Distance Between Code, You, and I
hiro_y
0
210
Featured
See All Featured
Put a Button on it: Removing Barriers to Going Fast.
kastner
60
4k
Fashionably flexible responsive web design (full day workshop)
malarkey
407
66k
Building Applications with DynamoDB
mza
96
6.7k
[Rails World 2023 - Day 1 Closing Keynote] - The Magic of Rails
eileencodes
37
2.6k
Measuring & Analyzing Core Web Vitals
bluesmoon
9
640
Become a Pro
speakerdeck
PRO
29
5.6k
Producing Creativity
orderedlist
PRO
348
40k
Thoughts on Productivity
jonyablonski
71
4.9k
Keith and Marios Guide to Fast Websites
keithpitt
411
23k
Learning to Love Humans: Emotional Interface Design
aarron
274
41k
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
34
2.5k
Improving Core Web Vitals using Speculation Rules API
sergeychernyshev
21
1.2k
Transcript
CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS