Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review, do you speak it?

Sponsored · Your Podcast. Everywhere. Effortlessly. Share. Educate. Inspire. Entertain. You do you. We'll handle the rest. →
Avatar for Michal Ostruszka Michal Ostruszka
October 17, 2013
Programming
560
0

Code review, do you speak it?

Slides from my Agile By Example 2013 talk.

Avatar for Michal Ostruszka

Michal Ostruszka

October 17, 2013

More Decks by Michal Ostruszka

See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
Avatar for Michal Ostruszka mostr
2
430
Building modern web applications. Single Responsibility Principle applied
Avatar for Michal Ostruszka mostr
4
160
You don't need Rails
Avatar for Michal Ostruszka mostr
3
180
JSON API - standards please
Avatar for Michal Ostruszka mostr
2
270
Backendless frontend development
Avatar for Michal Ostruszka mostr
2
320
Things you probably should know about JavaScript that you may not have been told before
Avatar for Michal Ostruszka mostr
6
710

Other Decks in Programming

See All in Programming
ローカルで稼働する AI エージェントを超えて / beyond-local-ai-agents
Avatar for geeawa gawa
3
280
年間50登壇、単著出版、雑誌寄稿、Podcast出演、YouTube、CM、カンファレンス主催……全部やってみたので面白さ等を比較してみよう / I’ve tried them all, so let’s compare how interesting they are.
Avatar for nrs nrslib
4
800
10 Tips of AWS ～Gen AI on AWS～
Avatar for matsukada licux
5
430
tRPCの概要と少しだけパフォーマンス
Avatar for Keigo Ebihara misoton665
2
220
Cache-moi si tu peux : patterns et pièges du cache en production - Devoxx France 2026 - Conférence
Avatar for Sébastien LECACHEUR slecache
0
280
PicoRuby for IoT: Connecting to the Cloud with MQTT
Avatar for Y_uuu yuuu
2
630
アクセシビリティ試験の"その後"を仕組み化する
Avatar for yuuumin yuuumiravy
1
170
ドメインイベントでビジネスロジックを解きほぐす #phpcon_odawara
Avatar for Takuma Kajikawa kajitack
3
790
🦞OpenClaw works with AWS
Avatar for matsukada licux
1
180
Terraform言語の静的解析 / static analysis of Terraform language
Avatar for Kazuma Watanabe wata727
1
110
의존성 주입과 모듈화
Avatar for Sungyong An fornewid
0
150
Oxlintとeslint-plugin-react-hooks 明日から始められそう？
Avatar for t6adev t6adev
0
280

Featured

See All Featured
世界の人気アプリ100個を分析して見えたペイウォール設計の心得
Avatar for Akihiro Kokubo akihiro_kokubo
PRO
69
39k
Faster Mobile Websites
Avatar for Dean Hume deanohume
310
31k
Reality Check: Gamification 10 Years Later
Avatar for Sebastian Deterding codingconduct
0
2.1k
More Than Pixels: Becoming A User Experience Designer
Avatar for Michelle Schulp Hunt marktimemedia
3
380
Navigating Team Friction
Avatar for Lara Hogan lara
192
16k
Build your cross-platform service in a week with App Engine
Avatar for Jose L jlugia
234
18k
Information Architects: The Missing Link in Design Systems
Avatar for Michelle Chin soysaucechin
0
890
Building Applications with DynamoDB
Avatar for Matt Wood mza
96
7k
HU Berlin: Industrial-Strength Natural Language Processing with spaCy and Prodigy
Avatar for Ines Montani inesmontani
PRO
0
320
The SEO Collaboration Effect
Avatar for Kristina Bergwall kristinabergwall1
1
430
Raft: Consensus for Rubyists
Avatar for Patrick Van Stee vanstee
141
7.4k
Improving Core Web Vitals using Speculation Rules API
Avatar for Sergey Chernyshev sergeychernyshev
21
1.4k

Transcript

  1. CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL

  2. what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE

    REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD

  3. who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST

  4. why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING

  5. if it is so good WHY NOT ALL DEVELOPERS DO

    IT

  6. why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO

    EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED

  7. checkpoint BLOCKING FLOW NON-BLOCKING

  8. toolbox BARE-HANDS TOOL-ASSISTED

  9. doing code review is difficult FOR BOTH SIDES

  10. dive into CODE AUTHOR'S MIND

  11. as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO

    DO RECEIVING FEEDBACK

  12. now step into REVIEWER'S SHOES

  13. as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL

    RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK

  14. we are TERRIBLE AT FEEDBACK STUFF

  15. how to MAKE GOOD REVIEW TO SUCK LESS

  16. ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK

  17. codebrag LIKES: 86 COMMENTS: 877

  18. play with it IT'S NOT SET IN STONE

  19. experiment 1 MONTH KEEP IT OR DROP IT

  20. thank you ENJOY YOUR CODE REVIEWS