Code review, do you speak it?

Slides from my Agile By Example 2013 talk.

Michal Ostruszka

October 17, 2013

More Decks by Michal Ostruszka

See All by Michal Ostruszka

Building modern web applications. Single Responsibility Principle applied

2

450

Building modern web applications. Single Responsibility Principle applied

4

170

You don't need Rails

3

190

JSON API - standards please

2

280

Backendless frontend development

2

330

Things you probably should know about JavaScript that you may not have been told before

6

730

Other Decks in Programming

See All in Programming

Web Framework Benchmark Battle 2026, Any%

3

3.2k

flutter_test のその先へ — Flutter アプリの LLM 機能に「評価」という品質保証を

0

200

私なりのハーネスエンジニアリング～独自の言語処理系の開発を通して～

0

180

TS 7.0 で baseUrl が使えなくなった今、パスエイリアスをどうするか

2

560

Goコンパイラを作ってGoをもっと理解する / Build a Go compiler to better understand Go

0

130

Enforcing Your Architecture with Unit Tests in the AI Era (Swift Connection X)

PRO

1

150

Long Living Tokens, Die, Die, Die! (or: The One Ring is Banned in Modern)

0

410

動画プレイヤーはなぜカクつくのか〜Flutterのレンダリングとネイティブの境界を解剖する〜

0

330

作れるエンジニアから、価値を届けるエンジニアへ

1

240

AmebaブログはKMPから卒業します

0

330

AI時代のシニアエンジニアとは

yosuke_furukawa

PRO

15

11k

AI時代のFlutter品質設計 — アプリ品質を守るQuality Layers

0

360

Featured

See All Featured

From π to Pie charts

1

440

ラッコキーワードサービス紹介資料

5

5.7M

The Mindset for Success: Future Career Progression

PRO

0

560

How to Align SEO within the Product Triangle To Get  Buy-In & Support - #RIMC

2

1.9k

Measuring Dark Social's Impact On Conversion and Attribution

2

320

Un-Boring Meetings

0

490

SEOcharity - Dark patterns in SEO and UX: How to avoid them and build a more ethical web

0

320

Jess Joyce - The Pitfalls of Following Frameworks

PRO

1

470

A brief & incomplete history of  UX Design for the World Wide Web: 1989–2019

2

560

Fantastic passwords and where to find them - at NoRuKo

53

4k

The Success of Rails: Ensuring Growth for the Next 100 Years

47

8.4k

How to Grow Your eCommerce with AI & Automation

PRO

2

350

Transcript

CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS