Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Code review, do you speak it?

Avatar for Michal Ostruszka Michal Ostruszka
October 17, 2013
Programming
0
500

Code review, do you speak it?

Slides from my Agile By Example 2013 talk.
Avatar for Michal Ostruszka

Michal Ostruszka

October 17, 2013
Tweet

More Decks by Michal Ostruszka

See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
Avatar for Michal Ostruszka mostr
2
430
Building modern web applications. Single Responsibility Principle applied
Avatar for Michal Ostruszka mostr
4
160
You don't need Rails
Avatar for Michal Ostruszka mostr
3
180
JSON API - standards please
Avatar for Michal Ostruszka mostr
2
260
Backendless frontend development
Avatar for Michal Ostruszka mostr
2
310
Things you probably should know about JavaScript that you may not have been told before
Avatar for Michal Ostruszka mostr
6
680

Other Decks in Programming

See All in Programming
関数型まつりレポート for JuliaTokai #22
Avatar for GOTOH Shunsuke antimon2
0
130
Julia という言語について （FP in Julia « SIDE: F »） for 関数型まつり2025
Avatar for GOTOH Shunsuke antimon2
3
970
XP, Testing and ninja testing
Avatar for seki at druby.org m_seki
2
110
赤裸々に公開。 TSKaigiのオフシーズン
Avatar for Yoshiteru Takeshita takezoux2
0
140
イベントストーミングから始めるドメイン駆動設計
Avatar for おだかとしゆき jgeem
4
870
Webからモバイルへ Vue.js × Capacitor 活用事例
Avatar for Naoki Haba naokihaba
0
740
Cline指示通りに動かない？ AI小説エージェントで学ぶ指示書の書き方と自動アップデートの仕組み
Avatar for 葦沢かもめ kamomeashizawa
1
560
レガシーシステムの機能調査・開発におけるAI利活用
Avatar for takuya ohtonari takuya_ohtonari
0
610
Elixir で IoT 開発、 Nerves なら簡単にできる！？
Avatar for pojiro pojiro
1
150
アンドパッドの Go 勉強会「 gopher 会」とその内容の紹介
Avatar for ANDPAD inc andpad
0
250
データの民主化を支える、透明性のあるデータ利活用への挑戦 2025-06-25 Database Engineering Meetup#7
Avatar for Kentaro Yoshida y_ken
0
280
第9回 情シス転職ミートアップ 株式会社IVRy（アイブリー）の紹介
Avatar for 株式会社IVRy（社員登壇資料） ivry_presentationmaterials
1
190

Featured

See All Featured
Exploring the Power of Turbo Streams & Action Cable | RailsConf2023
Avatar for Kevin Liebholz kevinliebholz
32
5.9k
Building Adaptive Systems
Avatar for Chris Keathley keathley
43
2.6k
The Psychology of Web Performance [Beyond Tellerrand 2023]
Avatar for Tammy Everts tammyeverts
48
2.8k
Visualization
Avatar for Eitan Lees eitanlees
146
16k
GraphQLの誤解/rethinking-graphql
Avatar for sonatard sonatard
71
11k
"I'm Feeling Lucky" - Building Great Search Experiences for Today's Users (#IAC19)
Avatar for Dan Newman danielanewman
228
22k
Fireside Chat
Avatar for paigeccino paigeccino
37
3.5k
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
Avatar for Sam Stephenson sstephenson
161
15k
YesSQL, Process and Tooling at Scale
Avatar for Rocio Delgado rocio
173
14k
A Tale of Four Properties
Avatar for Chris Coyier chriscoyier
159
23k
Large-scale JavaScript Application Architecture
Avatar for Addy Osmani addyosmani
512
110k
How To Stay Up To Date on Web Technology
Avatar for Chris Coyier chriscoyier
790
250k

Transcript

  1. CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL

  2. what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE

    REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD

  3. who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST

  4. why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING

  5. if it is so good WHY NOT ALL DEVELOPERS DO

    IT

  6. why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO

    EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED

  7. checkpoint BLOCKING FLOW NON-BLOCKING

  8. toolbox BARE-HANDS TOOL-ASSISTED

  9. doing code review is difficult FOR BOTH SIDES

  10. dive into CODE AUTHOR'S MIND

  11. as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO

    DO RECEIVING FEEDBACK

  12. now step into REVIEWER'S SHOES

  13. as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL

    RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK

  14. we are TERRIBLE AT FEEDBACK STUFF

  15. how to MAKE GOOD REVIEW TO SUCK LESS

  16. ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK

  17. codebrag LIKES: 86 COMMENTS: 877

  18. play with it IT'S NOT SET IN STONE

  19. experiment 1 MONTH KEEP IT OR DROP IT

  20. thank you ENJOY YOUR CODE REVIEWS