Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review, do you speak it?
Search
Sponsored
·
Ship Features Fearlessly
Turn features on and off without deploys. Used by thousands of Ruby developers.
→
Michal Ostruszka
October 17, 2013
Programming
0
550
Code review, do you speak it?
Slides from my Agile By Example 2013 talk.
Michal Ostruszka
October 17, 2013
Tweet
Share
More Decks by Michal Ostruszka
See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
mostr
2
430
Building modern web applications. Single Responsibility Principle applied
mostr
4
160
You don't need Rails
mostr
3
180
JSON API - standards please
mostr
2
270
Backendless frontend development
mostr
2
320
Things you probably should know about JavaScript that you may not have been told before
mostr
6
700
Other Decks in Programming
See All in Programming
CSC307 Lecture 15
javiergs
PRO
0
240
RAGでハマりがちな"Excelの罠"を、データの構造化で突破する
harumiweb
9
2.8k
API Platformを活用したPHPによる本格的なWeb API開発 / api-platform-book-intro
ttskch
1
130
Swift ConcurrencyでよりSwiftyに
yuukiw00w
0
260
AIコードレビューの導入・運用と AI駆動開発における「AI4QA」の取り組みについて
hagevvashi
0
420
AI駆動開発の本音 〜Claude Code並列開発で見えたエンジニアの新しい役割〜
hisuzuya
4
500
CSC307 Lecture 14
javiergs
PRO
0
470
Codexに役割を持たせる 他のAIエージェントと組み合わせる実務Tips
o8n
4
1.3k
Windows on Ryzen and I
seosoft
0
250
最初からAWS CDKで技術検証してもいいんじゃない?
akihisaikeda
4
130
20260313 - Grafana & Friends Taipei #1 - Kubernetes v1.36 的開發雜記:那些困在 Alpha 加護病房太久的 Metrics
tico88612
0
150
オブザーバビリティ駆動開発って実際どうなの?
yohfee
3
820
Featured
See All Featured
Crafting Experiences
bethany
1
81
CoffeeScript is Beautiful & I Never Want to Write Plain JavaScript Again
sstephenson
162
16k
Leo the Paperboy
mayatellez
4
1.5k
Designing Dashboards & Data Visualisations in Web Apps
destraynor
231
54k
Building Experiences: Design Systems, User Experience, and Full Site Editing
marktimemedia
0
440
Building Adaptive Systems
keathley
44
3k
コードの90%をAIが書く世界で何が待っているのか / What awaits us in a world where 90% of the code is written by AI
rkaga
60
42k
How to Ace a Technical Interview
jacobian
281
24k
The AI Search Optimization Roadmap by Aleyda Solis
aleyda
1
5.4k
Code Review Best Practice
trishagee
74
20k
Between Models and Reality
mayunak
2
230
Self-Hosted WebAssembly Runtime for Runtime-Neutral Checkpoint/Restore in Edge–Cloud Continuum
chikuwait
0
390
Transcript
CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS