Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Sign up for free
Menu
Search
Features
All features
Private URLs
Password Protection
Custom URLS
Scheduled publishing
Remove Branding
Restrict embedding
Deck Collections
Notes
Features
All features
Private URLs
Password Protection
Custom URLS
Scheduled publishing
Remove Branding
Restrict embedding
Deck Collections
Notes
Explore
Featured decks
Featured speakers
Programming
Technology
Storyboards
Explore
Featured decks
Featured speakers
Programming
Technology
Storyboards
Pricing
Search
Sign in
Sign up for free
Code review, do you speak it?
Search
Sponsored
·
Ship Features Fearlessly
Turn features on and off without deploys. Used by thousands of Ruby developers.
→
Michal Ostruszka
October 17, 2013
Programming
600
0
Share
Embed
Copy iframe code
Copy JS code
Copy link
Start on current slide
Code review, do you speak it?
Slides from my Agile By Example 2013 talk.
Michal Ostruszka
October 17, 2013
More Decks by Michal Ostruszka
See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
mostr
2
450
Building modern web applications. Single Responsibility Principle applied
mostr
4
170
You don't need Rails
mostr
3
190
JSON API - standards please
mostr
2
280
Backendless frontend development
mostr
2
330
Things you probably should know about JavaScript that you may not have been told before
mostr
6
730
Other Decks in Programming
See All in Programming
新卒PdEのリアル
ryu1013
1
520
アクセシビリティから考える情報設計
high_g_engineer
0
420
速習iPhone Duo対応
yuukiw00w
2
840
Ghostty + Neovimで作る 透明でカッコ良い開発環境
j341nono
0
130
Turning Architecture into Unit Tests in the AI Era (NSSpain XIV)
steliosf
PRO
1
110
Omarchy Tokyo やると聞いて UMPC 買ってセットアップしてきた
mtsmfm
0
170
モデルのリファクタリングが難しいと思ったら、そもそも複雑だったのはビジネス仕様だった ? / is-the-business-domain-the-real-complexity
hatsu38
0
410
JAWS-UG 東京支部が始める、JAWS-UG支部コラボ / JAWS-UG lunchtime LT Collaboration
y0hgi
0
160
カツオ、ご期待ください
suneo3476
0
110
wkhtmltopdfの次どうするか問題2026
willnet
2
1.8k
AGENTS.md Is Not Enough:Build Skills, Don't Download Them
lx_t
0
130
MCP Appsでつくるチャット駆動な地図アプリ
nakamori1024
0
110
Featured
See All Featured
Become a Pro
speakerdeck
PRO
31
6.3k
Understanding Cognitive Biases in Performance Measurement
bluesmoon
32
3k
Leveraging Curiosity to Care for An Aging Population
cassininazir
1
520
The Anti-SEO Checklist Checklist. Pubcon Cyber Week
ryanjones
0
250
I Don’t Have Time: Getting Over the Fear to Launch Your Podcast
jcasabona
35
2.9k
Taking LLMs out of the black box: A practical guide to human-in-the-loop distillation
inesmontani
PRO
3
2.4k
[SF Ruby Conf 2025] Rails X
palkan
3
1.4k
Thoughts on Productivity
jonyablonski
76
5.4k
Building a Modern Day E-commerce SEO Strategy
aleyda
45
9.2k
Practical Orchestrator
shlominoach
192
12k
Accessibility Awareness
sabderemane
1
220
The #1 spot is gone: here's how to win anyway
tamaranovitovic
4
1.2k
Transcript
CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS