Upgrade to Pro
— share decks privately, control downloads, hide ads and more …
Speaker Deck
Features
Speaker Deck
PRO
Sign in
Sign up for free
Search
Search
Code review, do you speak it?
Search
Sponsored
·
Ship Features Fearlessly
Turn features on and off without deploys. Used by thousands of Ruby developers.
→
Michal Ostruszka
October 17, 2013
Programming
0
550
Code review, do you speak it?
Slides from my Agile By Example 2013 talk.
Michal Ostruszka
October 17, 2013
Tweet
Share
More Decks by Michal Ostruszka
See All by Michal Ostruszka
Building modern web applications. Single Responsibility Principle applied
mostr
2
430
Building modern web applications. Single Responsibility Principle applied
mostr
4
160
You don't need Rails
mostr
3
180
JSON API - standards please
mostr
2
270
Backendless frontend development
mostr
2
320
Things you probably should know about JavaScript that you may not have been told before
mostr
6
690
Other Decks in Programming
See All in Programming
Best-Practices-for-Cortex-Analyst-and-AI-Agent
ryotaroikeda
1
110
izumin5210のプロポーザルのネタ探し #tskaigi_msup
izumin5210
1
120
AWS re:Invent 2025参加 直前 Seattle-Tacoma Airport(SEA)におけるハードウェア紛失インシデントLT
tetutetu214
2
110
Fluid Templating in TYPO3 14
s2b
0
130
そのAIレビュー、レビューしてますか? / Are you reviewing those AI reviews?
rkaga
6
4.6k
ぼくの開発環境2026
yuzneri
0
220
humanlayerのブログから学ぶ、良いCLAUDE.mdの書き方
tsukamoto1783
0
190
CSC307 Lecture 01
javiergs
PRO
0
690
AIによる高速開発をどう制御するか? ガードレール設置で開発速度と品質を両立させたチームの事例
tonkotsuboy_com
7
2.3k
Unicodeどうしてる? PHPから見たUnicode対応と他言語での対応についてのお伺い
youkidearitai
PRO
1
2.5k
Implementation Patterns
denyspoltorak
0
290
AI時代の認知負荷との向き合い方
optfit
0
160
Featured
See All Featured
What Being in a Rock Band Can Teach Us About Real World SEO
427marketing
0
170
The #1 spot is gone: here's how to win anyway
tamaranovitovic
2
940
Groundhog Day: Seeking Process in Gaming for Health
codingconduct
0
92
My Coaching Mixtape
mlcsv
0
48
Hiding What from Whom? A Critical Review of the History of Programming languages for Music
tomoyanonymous
2
420
Lightning Talk: Beautiful Slides for Beginners
inesmontani
PRO
1
440
Being A Developer After 40
akosma
91
590k
Building an army of robots
kneath
306
46k
Rails Girls Zürich Keynote
gr2m
96
14k
技術選定の審美眼(2025年版) / Understanding the Spiral of Technologies 2025 edition
twada
PRO
117
110k
The Illustrated Children's Guide to Kubernetes
chrisshort
51
51k
CSS Pre-Processors: Stylus, Less & Sass
bermonpainter
359
30k
Transcript
CODE REVIEW DO YOU SPEAK IT? @MOSTRUSZKA | SOFTWAREMILL
what WHY REVIEW CODE FIND YOUR REVIEW STYLE GOOD CODE
REVIEW IS NOT EASY MAKE IT RIGHT & ENJOY IT TIPS FROM THE FIELD
who's zed SOFTWARE WIZARD BOTH-ENDS DEVELOPER AGILE ENTHUSIAST
why TRUCK FACTOR CODE REUSE CHEAP BUG FIXES ASYNCHRONOUS PAIRING
if it is so good WHY NOT ALL DEVELOPERS DO
IT
why TIME, DEADLINES, SCHEDULES WE USED TO SHIP ANYWAY NO
EXPERIENCE IN REVIEW NO PUSH FROM DEVELOPERS TRIED & DROPPED
checkpoint BLOCKING FLOW NON-BLOCKING
toolbox BARE-HANDS TOOL-ASSISTED
doing code review is difficult FOR BOTH SIDES
dive into CODE AUTHOR'S MIND
as a code author EMOTIONS PERSONAL RELATIONS MORE WORK TO
DO RECEIVING FEEDBACK
now step into REVIEWER'S SHOES
as a reviewer ADDITIONAL WORK TO DO CURRENT MOOD PERSONAL
RELATIONS TOXIC CODE OWNERSHIP GIVING FEEDBACK
we are TERRIBLE AT FEEDBACK STUFF
how to MAKE GOOD REVIEW TO SUCK LESS
ideas REVIEW CODE, NOT AUTHOR PRAISE GOOD STUFF BALANCE FEEDBACK
codebrag LIKES: 86 COMMENTS: 877
play with it IT'S NOT SET IN STONE
experiment 1 MONTH KEEP IT OR DROP IT
thank you ENJOY YOUR CODE REVIEWS