コメントの書き方から見る 良いコードについての考察

Transcript

1. ίϝϯτͷॻ͖ํ͔ΒݟΔ
   ྑ͍ίʔυʹ͍ͭͯͷߟ࡯
   Re:Build.inc
   TETSU
   (Twitter: @kaoru6strings)
   2020೥1݄10೔ʢ೔ʣ
   WebφΠτٶ࡚ Vol.8ɹʙͯ͛ྑ͍ίʔυॻ͖͍ͨʙ
   https://mokumoku-naha.connpass.com/event/154703/
   

   View Slide

2. • ͳ·͑ɿͯͭ
   • גࣜձࣾϦϏϧυॴଐ
   • ϦϞʔτϫʔΫͯ͠·͢
   • ࠷ۙ͸ϚʔέςΟϯάษڧத
   • Twitter -> @kaoru6strings
   Information
   

   View Slide

3. Skill sets
   Ͱ͖Δ ͪΐͬͱͰ͖Δ
   GSPOUFOE
   +4
   7VFKT
   /VYUKT
   K2VFSZ
   #BDLFOE -BSBWFM
   3VCZPOSBJMT
   1ZUIPO
   *OGSBTUSVDUVSF
   %PDLFS
   -JOVY
   "84
   .BDLFSFM
   7JSUVBM#PY
   7BHSBOU
   ($1
   

   View Slide

4. ࣗࣾαʔϏεͷ͝঺հ
   

   View Slide

5. લఏ
   • ͜Ε͔Β࿩͢͜ͱ͸த੢ݸਓͷݟղͰ͢ɻ͞·͟·ͳਓͷҙݟΛ
   ෳ߹ͯࣗ͠෼ͷ౴͑Λݟ͚͍ͭͯͩ͘͞
   • ຊࢿྉ಺ʹొ৔͢Δίʔυ͸શͯμϛʔͷίʔυͰ͢ɻΠϝʔδ
   Λ௫Ή͜ͱʹͷΈར༻͍ͯͩ͘͠͞ɻ
   

   View Slide

6. ྑ͍ίʔυͱ͸…
   

   View Slide

7. ద੾ʹίϝϯτ͕هड़͞ΕͨίʔυͰ͋Δ
   

   View Slide

8. ద੾ʹίϝϯτ͕هड़͞ΕͨίʔυͰ͋Δ
   ※ॾઆ͋Γ
   

   View Slide

9. ຊLT಺Ͱ໨ࢦ͢ʮྑ͍ίʔυʯͷఆٛ
   • ࣍ͷਓ͕ಡΈ΍͍͢ίʔυͰ͋Δ
   • ࣍ͷਓ͕มߋΛՃ͑΍͍͢ίʔυͰ͋Δ
   

   View Slide

10. ίϯτϩʔϥʔ
    

    View Slide

11. Α͘ݟΔײ͡ͷίϯτϩʔϥʔ
    

    View Slide

12. ॲཧ͕3ͭͷ
    ϒϩοΫʹ
    Θ͔Εͯͦ͏
    Α͘ݟΔײ͡ͷίϯτϩʔϥʔ
    

    View Slide

13. Α͘ݟΔײ͡ͷίϯτϩʔϥʔ
    

    View Slide

14. վળҊ
    → ίϝϯτΛফ͢
    → ϓϥΠϕʔτϝιουʹ෼͚Δ
    fetchSpecialPages()
    → ϓϥΠϕʔτϝιουʹ෼͚Δ
    fetchProductsForTopPage()
    ༨༟͕͋Ε͹ServiceΫϥεͷར༻Λݕ౼
    

    View Slide

15. ݸਓతʹίϝϯτͰิͬͯ͘ΕΔͱخ͍͠৔໘
    • ཧ༝͕͋ͬͯσϑΝΫτελϯμʔτͰͳ͍ίʔυΛॻ͍ͨͱ͖
    ྫʣߴ଎ͳίʔυΛॻ͘ඞཁ͕͋ͬͨͨΊORMΛ࢖༻ͤͣDB͔ΒσʔλΛऔಘͨ͠ͱ͖
    • ࣌ؒతͳ੒໿͕͋ͬͨɾௐࢠ͕ѱ͔ͬͨͳͲɺվળͷ༨஍͕͋Δ
    ίʔυΛ͔͍ͯ͠·ͬͨͱ͖
    ※Ͱ͖Ε͹ίʔυϨϏϡʔͰରԠ͢Δ͔ɺνέοτͰ؅ཧͯ͠΄͕͋͠͞Δ
    

    View Slide

16. ؔ਺
    

    View Slide

17. ؔ਺࡞੒ͷجຊϧʔϧ
    ؔ਺ͷ1ߦ໨Ͱػೳ͕༧ଌͰ͖ΔΑ͏ʹ͢Δ
    

    View Slide

18. ؔ਺ͷྫɿBad…
    ࢖ͬͨઌͰͳΜͷؔ਺͔Θ͔Βͳ͍…
    

    View Slide

19. ؔ਺ͷྫɿGood!
    

    View Slide

20. ม਺
    

    View Slide

21. ม਺એݴ࣌ͷجຊϧʔϧ
    ͪΐͬͱ͘Β͍௕͘ͳͬͯ΋͍͍͔Β
    ม਺ͷத਎͕ͳΜͳͷ͔Θ͔ΔΑ͏ʹ͔͘
    

    View Slide

22. ม਺ͷྫ
    

    View Slide

23. ࢀߟॻ੶ɾ͓͢͢Ίॻ੶
    

    View Slide

24. ࢀߟॻ੶ɾ͓͢͢Ίॻ੶
    

    View Slide

25. ࠂ஌
    

    View Slide

26. Information
    

    View Slide

27. ͝ਗ਼ௌ͋Γ͕ͱ͏͍͟͝·ͨ͠
    

    View Slide

28. ͓·͚
    

    View Slide

29. ݱ࣮ੈքʹྫ͑ΔͱΘ͔Γ΍͍͢Α
    ※ॾઆ͋Γ
    

    View Slide

30. ݱ࣮ੈքͰLaravelΛߟ͑ͯΈΔ
    

    View Slide

31. େاۀʹ͓٬͞Μ͕དྷͨ
    ड෇ Ӧۀ෦
    ͓٬͞Μ ސ٬৘ใ
    

    View Slide

32. Laravelͷ໾ׂͰ໊લΛ͚ͭΔͱ͜Μͳײ͡
    $POUSPMMFS 4FSWJDF
    $MBTT
    )5513FRVFTU &MPRVFOU
    

    View Slide