Upgrade to Pro — share decks privately, control downloads, hide ads and more …

【IMO】コードレビューって難しいよね.pdf

 【IMO】コードレビューって難しいよね.pdf

https://fortee.jp/phpcon-2021/proposal/5d39aa6d-aef2-4bed-8747-60b6d2f6adfe

PHPカンファレンス2021の登壇スライドです

AkitoTsukahara

October 02, 2021
Tweet

More Decks by AkitoTsukahara

Other Decks in Technology

Transcript

  1. Copyright© M&A
    IMO
    PHP 2021 Akito.Tsukahara

    View full-size slide

  2. Copyright© M&A 2
    AkitoTsukahara
    M&A
    AkitoTsukahara

    View full-size slide

  3. Copyright© M&A 3

    View full-size slide

  4. Copyright© M&A 4

    View full-size slide

  5. Copyright© M&A 5

    View full-size slide

  6. Copyright© M&A 6

    View full-size slide

  7. Copyright© M&A 7

    View full-size slide

  8. Copyright© M&A 8

    View full-size slide

  9. Copyright© M&A 9

    View full-size slide

  10. Copyright© M&A 10
    IMO

    View full-size slide

  11. Copyright© M&A
    IMO
    11

    View full-size slide

  12. Copyright© M&A 12
    IMO

    View full-size slide

  13. Copyright© M&A

    13
    IMO

    View full-size slide

  14. Copyright© M&A 14

    View full-size slide

  15. Copyright© M&A 15

    View full-size slide

  16. Copyright© M&A 16

    View full-size slide

  17. Copyright© M&A 17

    View full-size slide

  18. Copyright© M&A 18
    2

    View full-size slide

  19. Copyright© M&A 19

    View full-size slide

  20. Copyright© M&A 20

    View full-size slide

  21. Copyright© M&A 21

    View full-size slide

  22. Copyright© M&A 22

    View full-size slide

  23. Copyright© M&A 23

    View full-size slide

  24. Copyright© M&A 24

    View full-size slide

  25. Copyright© M&A 25

    View full-size slide

  26. Copyright© M&A 26
    PR ~500 1

    View full-size slide

  27. Copyright© M&A 27
    PR

    View full-size slide

  28. Copyright© M&A 28
    PR

    View full-size slide

  29. Copyright© M&A 29
    L G T M

    View full-size slide

  30. Copyright© M&A 30

    View full-size slide

  31. Copyright© M&A 31
    PR PR

    View full-size slide

  32. Copyright© M&A 32
    PR PR

    View full-size slide

  33. Copyright© M&A 33
    100%

    View full-size slide

  34. Copyright© M&A 34
    https://tech.macloud.jp/entry/2021/06/17/190827

    View full-size slide

  35. Copyright© M&A 35

    View full-size slide

  36. Copyright© M&A 36
    PR
    Slack
    GitHub Scheduled reminders
    Pull Panda
    etc
    新人さんには先にレ
    ビューさせて
    あげるのもGood

    View full-size slide

  37. Copyright© M&A 37
    なんとかリリースま
    で辿り着かないと!

    View full-size slide

  38. Copyright© M&A 38

    View full-size slide

  39. Copyright© M&A 39

    View full-size slide

  40. Copyright© M&A 40

    View full-size slide

  41. Copyright© M&A 41

    View full-size slide

  42. Copyright© M&A 42
    PR PR
    PR
    KISS DRY YAGNI ... etc

    View full-size slide

  43. Copyright© M&A 43
    PR PR
    DRY

    View full-size slide

  44. Copyright© M&A 44
    PR PR
    SRP

    View full-size slide

  45. Copyright© M&A 45
    PR PR
    YAGNI

    View full-size slide

  46. Copyright© M&A 46
    PR PR
    PIE

    View full-size slide

  47. Copyright© M&A 47

    View full-size slide

  48. Copyright© M&A 48

    View full-size slide

  49. Copyright© M&A 49
    PR
    PR 400

    View full-size slide

  50. Copyright© M&A 50
    PR
    PR
    PR
    https://tech.macloud.jp/entry/2020/06/29/103604

    View full-size slide

  51. Copyright© M&A 51
    PR 400
    400
    PR
    PR
    Best Practices for Code
    Review

    View full-size slide

  52. Copyright© M&A 52
    OK
    OK

    View full-size slide

  53. Copyright© M&A 53
    Best Practices for Code Review
    SmartBear Best Practices for Code Review
    https://smartbear.com/learn/code-review/best-practices-for-peer-code-review/
    10 Tips
    .1 400
    . 500 /
    .1 60

    View full-size slide

  54. Copyright© M&A 54
    Best Practices for Code Review
    10 Tips
    .1 60
    .
    .
    .

    View full-size slide

  55. Copyright© M&A 55
    Best Practices for Code Review
    10 Tips
    .
    .
    .
    10.

    View full-size slide

  56. Copyright© M&A 56

    View full-size slide

  57. Copyright© M&A 57

    View full-size slide

  58. Copyright© M&A 58

    View full-size slide

  59. Copyright© M&A 59

    View full-size slide

  60. Copyright© M&A 60
    Best Practices for Code Review
    https://smartbear.com/learn/code-review/
    https://qiita.com/awakia/items/8344ba751426e386e0f5
    https://postd.cc/code-review-best-practices/
    https://qiita.com/teradonburi/items/2fa475c860d0fb16c0eb
    10
    https://yutokyokutyo.hatenablog.com/entry/20161213/1481590322

    View full-size slide

  61. Copyright© M&A 61

    View full-size slide

  62. Copyright© M&A 62
    M&A
    M&A
    M&A
    M&A
    M&A
    M&A
    1. 2.
    M&A

    View full-size slide

  63. Copyright© M&A 63
    M&A
    PMI

    View full-size slide

  64. Copyright© M&A
    WE ARE HIRING!
    M&A
    https://www.wantedly.com/companies/macloud

    View full-size slide

  65. Copyright© M&A 65

    View full-size slide