【IMO】コードレビューって難しいよね.pdf

https://fortee.jp/phpcon-2021/proposal/5d39aa6d-aef2-4bed-8747-60b6d2f6adfe

PHPカンファレンス2021の登壇スライドです

Transcript

1. Copyright© M&A
   IMO
   PHP 2021 Akito.Tsukahara
   

   View Slide

2. Copyright© M&A 2
   AkitoTsukahara
   M&A
   AkitoTsukahara
   

   View Slide

3. Copyright© M&A 3
   

   View Slide

4. Copyright© M&A 4
   

   View Slide

5. Copyright© M&A 5
   

   View Slide

6. Copyright© M&A 6
   

   View Slide

7. Copyright© M&A 7
   

   View Slide

8. Copyright© M&A 8
   

   View Slide

9. Copyright© M&A 9
   

   View Slide

10. Copyright© M&A 10
    IMO
    

    View Slide

11. Copyright© M&A
    IMO
    11
    

    View Slide

12. Copyright© M&A 12
    IMO
    

    View Slide

13. Copyright© M&A
    責
    13
    IMO
    

    View Slide

14. Copyright© M&A 14
    

    View Slide

15. Copyright© M&A 15
    

    View Slide

16. Copyright© M&A 16
    

    View Slide

17. Copyright© M&A 17
    

    View Slide

18. Copyright© M&A 18
    2
    

    View Slide

19. Copyright© M&A 19
    

    View Slide

20. Copyright© M&A 20
    

    View Slide

21. Copyright© M&A 21
    

    View Slide

22. Copyright© M&A 22
    

    View Slide

23. Copyright© M&A 23
    

    View Slide

24. Copyright© M&A 24
    

    View Slide

25. Copyright© M&A 25
    

    View Slide

26. Copyright© M&A 26
    PR ~500 1
    

    View Slide

27. Copyright© M&A 27
    PR
    

    View Slide

28. Copyright© M&A 28
    PR
    

    View Slide

29. Copyright© M&A 29
    L G T M
    

    View Slide

30. Copyright© M&A 30
    

    View Slide

31. Copyright© M&A 31
    PR PR
    

    View Slide

32. Copyright© M&A 32
    PR PR
    

    View Slide

33. Copyright© M&A 33
    100%
    

    View Slide

34. Copyright© M&A 34
    https://tech.macloud.jp/entry/2021/06/17/190827
    

    View Slide

35. Copyright© M&A 35
    

    View Slide

36. Copyright© M&A 36
    PR
    Slack
    GitHub Scheduled reminders
    Pull Panda
    etc
    新人さんには先にレ
    ビューさせて
    あげるのもGood
    

    View Slide

37. Copyright© M&A 37
    なんとかリリースま
    で辿り着かないと！
    

    View Slide

38. Copyright© M&A 38
    

    View Slide

39. Copyright© M&A 39
    

    View Slide

40. Copyright© M&A 40
    

    View Slide

41. Copyright© M&A 41
    

    View Slide

42. Copyright© M&A 42
    PR PR
    PR
    KISS DRY YAGNI ... etc
    

    View Slide

43. Copyright© M&A 43
    PR PR
    DRY
    

    View Slide

44. Copyright© M&A 44
    PR PR
    SRP
    

    View Slide

45. Copyright© M&A 45
    PR PR
    YAGNI
    

    View Slide

46. Copyright© M&A 46
    PR PR
    PIE
    

    View Slide

47. Copyright© M&A 47
    

    View Slide

48. Copyright© M&A 48
    

    View Slide

49. Copyright© M&A 49
    PR
    PR 400
    

    View Slide

50. Copyright© M&A 50
    PR
    PR
    PR
    https://tech.macloud.jp/entry/2020/06/29/103604
    

    View Slide

51. Copyright© M&A 51
    PR 400
    400
    PR
    PR
    Best Practices for Code
    Review
    

    View Slide

52. Copyright© M&A 52
    OK
    OK
    

    View Slide

53. Copyright© M&A 53
    Best Practices for Code Review
    SmartBear Best Practices for Code Review
    https://smartbear.com/learn/code-review/best-practices-for-peer-code-review/
    10 Tips
    .1 400
    . 500 /
    .1 60
    

    View Slide

54. Copyright© M&A 54
    Best Practices for Code Review
    10 Tips
    .1 60
    .
    .
    .
    

    View Slide

55. Copyright© M&A 55
    Best Practices for Code Review
    10 Tips
    .
    .
    .
    10.
    

    View Slide

56. Copyright© M&A 56
    

    View Slide

57. Copyright© M&A 57
    

    View Slide

58. Copyright© M&A 58
    

    View Slide

59. Copyright© M&A 59
    

    View Slide

60. Copyright© M&A 60
    Best Practices for Code Review
    https://smartbear.com/learn/code-review/
    https://qiita.com/awakia/items/8344ba751426e386e0f5
    https://postd.cc/code-review-best-practices/
    https://qiita.com/teradonburi/items/2fa475c860d0fb16c0eb
    10
    https://yutokyokutyo.hatenablog.com/entry/20161213/1481590322
    

    View Slide

61. Copyright© M&A 61
    

    View Slide

62. Copyright© M&A 62
    M&A
    M&A
    M&A
    M&A
    M&A
    M&A
    1. 2.
    M&A
    

    View Slide

63. Copyright© M&A 63
    M&A
    PMI
    

    View Slide

64. Copyright© M&A
    WE ARE HIRING!
    M&A
    https://www.wantedly.com/companies/macloud
    

    View Slide

65. Copyright© M&A 65
    

    View Slide