one or several humans check a program mainly by viewing and reading parts of its source code. What is Code Review? Done right it is also a valuable tool for growing skills and knowledge amongst the team. Not just here for the quality of today’s code, but also to improve tomorrow’s
on one. For fans of xSports, you could say that pair programming is extreme code review It can be a group activity where the entire team gets together reviewing all or just some of the teams code It can be performed remotely - OSS projects, distributed teams, cross company
our last point by looking at the what not the why. Normally DPs are a choice they have trade offs. Does it really need to be a singleton or is that just personal preference? Focus on the facts, especially in a position of authority.
was ok! If we ﬁx this method, our life will be better Developers are people. They feel protective of their code. They can get defensive if they feel attacked. They may shut down and stop listening, certainly not learn well. Not everyone has same understanding of code base or features. Develop not destroy. Especially more junior ppl
Not everything *must* be ﬂagged up, changed or ﬁxed. Pick up on the most important things. If it really makes a difference then ﬁx it. Bonus point. Don’t say “While you are at it ﬁx X” in code that wasn’t changed. Raise another issue for it.
matters little Craig’s boss Craig’s boss gave the craigslist founder some advice that Craig shared in a Business Insider interview. When it matters a lot--when there's something on the line; when it's going to affect something important at the company; --of course let someone know. But when it doesn't really matter, don't tell people what they're doing wrong. Let them be.