Share
Embed
`Wrap(err)` in production
Presented on "Go(Un)Conference(Goあんこ)LT大会 4kg"
https://gounconference.connpass.com/event/99487/
- https://github.com/srvc/fail
- https://github.com/srvc/wraperr
- https://github.com/izumin5210/grapi
izumin5210
October 19, 2018
Transcript
31 slides
-
Go(Un)Conference 4kg - @izumin5210 `Wra p ( e r r
)` i n pro du ction -
izumin5210 ‣ Wantedly People ‣ Web Engineer (serverside & frontend)
‣ Gopher & Rubyist -
func TestErrors_noWrapStdError(t *testing.T) { err := err1() if err !=
nil { printError(t, err) } } func err1() error { return stderr() } func stderr() error { return stderrors.New("error!") } -
func TestErrors_noWrapStdError(t *testing.T) { err := err1() if err !=
nil { printError(t, err) } } func err1() error { return stderr() } func stderr() error { return stderrors.New("error!") } === RUN TestErrors_noWrapStdError --- PASS: TestErrors_noWrapStdError (0.00s) main.go:16: *** %#v ****************************************** main.go:17: &errors.errorString{s:"error!"} main.go:18: *** %+v ****************************************** main.go:19: error! main.go:20: *** stacktrace *********************************** main.go:20: /go/src/sandbox/main.go:16: main.TestErrors_noWrap main.go:20: /usr/local/go/src/testing/testing.go:777: testing. main.go:20: /usr/local/go/src/runtime/asm_amd64p32.s:968: runt PASS -
func TestErrors_noWrapStdError(t *testing.T) { err := err1() if err !=
nil { printError(t, err) } } func err1() error { return stderr() } func stderr() error { return stderrors.New("error!") } === RUN TestErrors_noWrapStdError --- PASS: TestErrors_noWrapStdError (0.00s) main.go:16: *** %#v ****************************************** main.go:17: &errors.errorString{s:"error!"} main.go:18: *** %+v ****************************************** main.go:19: error! main.go:20: *** stacktrace *********************************** main.go:20: /go/src/sandbox/main.go:16: main.TestErrors_noWrap main.go:20: /usr/local/go/src/testing/testing.go:777: testing. main.go:20: /usr/local/go/src/runtime/asm_amd64p32.s:968: runt PASS -
func TestErrors_noWrapStdError(t *testing.T) { err := err1() if err !=
nil { printError(t, err) } } func err1() error { return stderr() } func stderr() error { return stderrors.New("error!") } === RUN TestErrors_noWrapStdError --- PASS: TestErrors_noWrapStdError (0.00s) main.go:16: *** %#v ****************************************** main.go:17: &errors.errorString{s:"error!"} main.go:18: *** %+v ****************************************** main.go:19: error! main.go:20: *** stacktrace *********************************** main.go:20: /go/src/sandbox/main.go:16: main.TestErrors_noWrap main.go:20: /usr/local/go/src/testing/testing.go:777: testing. main.go:20: /usr/local/go/src/runtime/asm_amd64p32.s:968: runt PASS ΤϥʔΛฦͨؔ͠ͷଆͷελοΫτϨʔε͕ͱΕͳ͍ -
func TestErrors_Wrap(t *testing.T) { err := err2() if err !=
nil { printError(t, err) } } func err2() error { err := stderr() return pkgerrors.Wrap(err, "wrapped") } func pkgerr() error { return pkgerrors.New("error!") } -
func TestErrors_Wrap(t *testing.T) { err := err2() if err !=
nil { printError(t, err) } } func err2() error { err := stderr() return pkgerrors.Wrap(err, "wrapped") } func pkgerr() error { return pkgerrors.New("error!") } === RUN TestErrors_Wrap --- PASS: TestErrors_Wrap (0.00s) main.go:47: *** %#v **************************************** main.go:48: wrapped: error! main.go:49: *** %+v **************************************** main.go:50: error! wrapped main.err2 /go/src/sandbox/main.go:30 main.TestErrors_Wrap /go/src/sandbox/main.go:21 testing.tRunner /usr/local/go/src/testing/testing.go:777 runtime.goexit /usr/local/go/src/runtime/asm_amd64p32.s:968 main.go:51: *** stacktrace ********************************* main.go:51: /go/src/sandbox/main.go:24: main.TestErrors_Wrap main.go:51: /usr/local/go/src/testing/testing.go:777: testin main.go:51: /usr/local/go/src/runtime/asm_amd64p32.s:968: ru PASS -
func TestErrors_Wrap(t *testing.T) { err := err2() if err !=
nil { printError(t, err) } } func err2() error { err := stderr() return pkgerrors.Wrap(err, "wrapped") } func pkgerr() error { return pkgerrors.New("error!") } === RUN TestErrors_Wrap --- PASS: TestErrors_Wrap (0.00s) main.go:47: *** %#v **************************************** main.go:48: wrapped: error! main.go:49: *** %+v **************************************** main.go:50: error! wrapped main.err2 /go/src/sandbox/main.go:30 main.TestErrors_Wrap /go/src/sandbox/main.go:21 testing.tRunner /usr/local/go/src/testing/testing.go:777 runtime.goexit /usr/local/go/src/runtime/asm_amd64p32.s:968 main.go:51: *** stacktrace ********************************* main.go:51: /go/src/sandbox/main.go:24: main.TestErrors_Wrap main.go:51: /usr/local/go/src/testing/testing.go:777: testin main.go:51: /usr/local/go/src/runtime/asm_amd64p32.s:968: ru PASS -
func TestErrors_Wrap(t *testing.T) { err := err2() if err !=
nil { printError(t, err) } } func err2() error { err := stderr() return pkgerrors.Wrap(err, "wrapped") } func pkgerr() error { return pkgerrors.New("error!") } === RUN TestErrors_Wrap --- PASS: TestErrors_Wrap (0.00s) main.go:47: *** %#v **************************************** main.go:48: wrapped: error! main.go:49: *** %+v **************************************** main.go:50: error! wrapped main.err2 /go/src/sandbox/main.go:30 main.TestErrors_Wrap /go/src/sandbox/main.go:21 testing.tRunner /usr/local/go/src/testing/testing.go:777 runtime.goexit /usr/local/go/src/runtime/asm_amd64p32.s:968 main.go:51: *** stacktrace ********************************* main.go:51: /go/src/sandbox/main.go:24: main.TestErrors_Wrap main.go:51: /usr/local/go/src/testing/testing.go:777: testin main.go:51: /usr/local/go/src/runtime/asm_amd64p32.s:968: ru PASS ࠷ॳʹ8SBQͨ͠ͱ͜Ζ͔ΒͷτϨʔε͕औΓग़ͤΔ -
func main() { err := auth() if err != nil
{ fmt.Fprintln(os.Stderr, errors.Wrap(err, "failed to authorization")) } } func auth() error { _, err := getUser() if err != nil { return errors.Wrap(err, "failed to get user") } return nil } func getUser() (*User, error) { return nil, errors.New("not found error") } -
func main() { err := auth() if err != nil
{ fmt.Fprintln(os.Stderr, errors.Wrap(err, "failed to authorization")) } } func auth() error { _, err := getUser() if err != nil { return errors.Wrap(err, "failed to get user") } return nil } func getUser() (*User, error) { return nil, errors.New("not found error") } failed to authorization: failed to get user: not found error -
func main() { err := auth() if err != nil
{ fmt.Fprintln(os.Stderr, errors.Wrap(err, "failed to authorization")) } } func auth() error { _, err := getUser() if err != nil { return errors.Wrap(err, "failed to get user") } return nil } func getUser() (*User, error) { return nil, errors.New("not found error") } failed to authorization: failed to get user: not found error ΤϥʔϝοηʔδͲΜͲΜBOOPUBUFͰ͖Δ ˠͲ͏͍͏ίϯςΩετͰΤϥʔ͕ى͖ͯΔ͔͕Θ͔Γ͍͢ʂ -
‣ A8SBQ FSS A͢Δ͜ͱͰʜ ελοΫτϨʔεΛΤϥʔͷൃੜݯ·ͰḪΔ͜ͱ͕Ͱ͖Δ ΤϥʔࣗମʹͲΜͲΜใΛՃͰ͖ΔͷͰɼݪҼΛ͏ͷʹ׆༻Ͱ͖Δ ‣ ৄ͘͠(P$POGFSFODF4QSJOHͷ,FZOPUFΛݟ·͠ΐ͏
IUUQTEBWFDIFOFZOFUQBTUFHPDPOTQSJOHQEG -
‣ A8SBQ FSS A͢Δ͜ͱͰʜ ελοΫτϨʔεΛΤϥʔͷൃੜݯ·ͰḪΔ͜ͱ͕Ͱ͖Δ ΤϥʔࣗମʹͲΜͲΜใΛՃͰ͖ΔͷͰɼݪҼΛ͏ͷʹ׆༻Ͱ͖Δ ‣ ৄ͘͠(P$POGFSFODF4QSJOHͷ,FZOPUFΛݟ·͠ΐ͏
IUUQTEBWFDIFOFZOFUQBTUFHPDPOTQSJOHQEG ΄Μͱʹ͜Ε͚ͩͰ͍͍ͷ͔ʁ -
‣ ͜ͷͱ͖ͷεςʔλείʔυʁ %#͕ࢮΜͰͨΒ*OUFSOBM ଘࡏ͠ͳ͍VTFSͳΒ/PU'PVOE FUD func (s
*server) GetUser(ctx context.Context, req *Get user, err := s.userRepo.GetUser(ctx, req.GetUserID() if err != nil { return nil, errors.Wrap(err, "failed to get user") } // snip } -
‣ Ͳ͏ͬͯΤϥʔΛผ͢Δ͔ ఆԽʢ4FOUJOFMFSSPST 5ZQFʹ͢Δ &SSPSUZQFTUZQFBTTFSUJPO ‣
ਖ਼͍͔͠͠Εͳ͍͕ɼຖճఆٛ͢Δͷ ਖ਼ΊΜͲ͍͘͞ʜ switch errors.Cause(err).(type) { case *user.NotFoundError: return nil, status.Error(codes.NotFound, "user not f } if errors.Cause(err) == user.ErrNotFound { return nil, status.Error(codes.NotFound, "user not f } -
‣ ͜ͷΤϥʔ&SSPSSFQPSUFSʹ͛Δ͖ʁ ࡶͳΞΫηεͰ/PU'PVOEͳΒແࢹ͍ͨ͠ ֤ʑͷϞδϡʔϧ͕উखʹSFQPSUͪ͠Ό͏ͱ Τϥʔ͕ॏෳ͢Δ͔ ‣ લड़ͷFSSPSUZQFTʹʮSFQPSU͖͢ʯϑϥάΛ ͨͤΔͷ͔ʜʁ
func (s *server) GetUser(ctx context.Context, req *Get user, err := s.userRepo.GetUser(ctx, req.GetUserID() if err != nil { return nil, errors.Wrap(err, "failed to get user") } // snip } -
Go(Un)Conference 4kg - @izumin5210 `Wra p ( e r r
)` i n p rod uct ion -
‣ *OPVSQSPEVDUJPO AHJUIVCDPNTSWDGBJMAΛར༻͍ͯ͠Δ QLHFSSPSTʹ͍͔ͭ͘ͷNFUBEBUBΛ Ճͨ͠ͷ AGBJM8SBQAʹBOOPUBUPSΛ͢͜ͱͰ ΤϥʔʹϚʔΩϯάͰ͖Δ
func (r *repo) GetUser(ctx context.Context, id uint64) (*User, user, err := r.db.GetContext(ctx, &user, "...", id) if err == sql.ErrNoRows { return nil, fail.Wrap( err, fail.WithCode(appx.NotFound), fail.WithIgnorable(), ) } if err != nil { return nil, fail.Wrap(err, fail.WithCode(appx.Internal)) } // snip. } -
‣ AGBJM8JUI$PEF DPEF A εςʔλείʔυΛ͢ AG&SS$PEFAͷܗͰऔΓग़ͤΔ func (r
*repo) GetUser(ctx context.Context, id uint64) (*User, user, err := r.db.GetContext(ctx, &user, "...", id) if err == sql.ErrNoRows { return nil, fail.Wrap( err, fail.WithCode(appx.NotFound), fail.WithIgnorable(), ) } if err != nil { return nil, fail.Wrap(err, fail.WithCode(appx.Internal)) } // snip. } 1FSTJTUFODFMBZFSʹIUUQH31$ͷࣝΛೖΕͨ͘ͳ͔ͬͨͨΊʢ࣮ଶH31$ͷADPEFT$PEFAͱಉҰʣ -
‣ AGBJM8JUI$PEF DPEF A εςʔλείʔυΛ͢ AG&SS$PEFAͷܗͰऔΓग़ͤΔ ‣ *OPVSQSPEVDUJPO
ABQQY AࣾͰಠࣗఆٛ ͨ͠$PEFܕ JOUFSDFQUPSͰ͍͍ײ͡ʹH31$ͷDPEFʹ Ϛοϐϯά͞ΕΔ func (r *repo) GetUser(ctx context.Context, id uint64) (*User, user, err := r.db.GetContext(ctx, &user, "...", id) if err == sql.ErrNoRows { return nil, fail.Wrap( err, fail.WithCode(appx.NotFound), fail.WithIgnorable(), ) } if err != nil { return nil, fail.Wrap(err, fail.WithCode(appx.Internal)) } // snip. } 1FSTJTUFODFMBZFSʹIUUQH31$ͷࣝΛೖΕͨ͘ͳ͔ͬͨͨΊʢ࣮ଶH31$ͷADPEFT$PEFAͱಉҰʣ -
func (r *repo) GetUser(ctx context.Context, id uint64) (*User, user, err
:= r.db.GetContext(ctx, &user, "...", id) if err == sql.ErrNoRows { return nil, fail.Wrap( err, fail.WithCode(appx.NotFound), fail.WithIgnorable(), ) } if err != nil { return nil, fail.Wrap(err, fail.WithCode(appx.Internal)) } // snip. } ‣ AGBJM8JUI*HOPSBCMF A ʮ͜Εେͨ͜͠ͱͳ͍ΑʔʯϚʔΫ ʮ͚ͭΕͯΤϥʔʹؾ͚ͮͳ͍ʯ ةݥͳͷͰɼGBMTFQPTJUJWFʹ͍ͯ͠Δ -
func (r *repo) GetUser(ctx context.Context, id uint64) (*User, user, err
:= r.db.GetContext(ctx, &user, "...", id) if err == sql.ErrNoRows { return nil, fail.Wrap( err, fail.WithCode(appx.NotFound), fail.WithIgnorable(), ) } if err != nil { return nil, fail.Wrap(err, fail.WithCode(appx.Internal)) } // snip. } ‣ AGBJM8JUI*HOPSBCMF A ʮ͜Εେͨ͜͠ͱͳ͍ΑʔʯϚʔΫ ʮ͚ͭΕͯΤϥʔʹؾ͚ͮͳ͍ʯ ةݥͳͷͰɼGBMTFQPTJUJWFʹ͍ͯ͠Δ ‣ *OPVSQSPEVDUJPO ͜Ε͕AUSVFAͳΤϥʔʹ͍ͭͯɼ JOUFSDFQUPSͰউखʹSFQPSU͞ΕΔ 8SBQΕͯSFQPSU͞ΕΔ -
‣ AGBJM8JUI*HOPSBCMF A ʮ͜Εେͨ͜͠ͱͳ͍ΑʔʯϚʔΫ ʮ͚ͭΕͯΤϥʔʹؾ͚ͮͳ͍ʯ ةݥͳͷͰɼGBMTFQPTJUJWFʹ͍ͯ͠Δ ‣ *OPVSQSPEVDUJPO
͜Ε͕AUSVFAͳΤϥʔʹ͍ͭͯɼ JOUFSDFQUPSͰউखʹSFQPSU͞ΕΔ 8SBQΕͯSFQPSU͞ΕΔ func (r *repo) GetUser(ctx context.Context, id uint64) (*User, user, err := r.db.GetContext(ctx, &user, "...", id) if err == sql.ErrNoRows { return nil, fail.Wrap( err, fail.WithCode(appx.NotFound), fail.WithIgnorable(), ) } if err != nil { return nil, fail.Wrap(err, fail.WithCode(appx.Internal)) } // snip. } ͜ΕJOUFSDFQUPSͰSFQPSU͞ΕΔ -
‣ 0UIFSBOOPUBUPSTA8JUI5BHTA A8JUI1BSBNTA FUD ‣ AHJUIVCDPNTSWDHSQDFSSPSTA H31$ͷJOUFSDFQUPSͰGBJM&SSPSΛ͍͍ײ͡ʹϋϯυϧ͢Δ࣮ ‣ ࣾڞ௨ϥΠϒϥϦATFSWJDFYA
͜͜ͰAHSQDFSSPSTAΛ͍͍ײ͡ʹηοτͯ͠ɼ͍͍ײ͡ʹFSSPSSFQPSU͢ΔΈΛ࡞͍ͬͯΔ AHSBQJA ͷ0QUJPOΛఏڙ͍ͯͯ͠ɼߦه ڥมΛೖΕΔ͚ͩͰ͕ͯ͢༗ޮԽ͞ΕΔ HJUIVCDPNJ[VNJOHSBQJH31$ HSQDHBUFXBZΛར༻ͨ͠8FCGSBNFXPSLDPEFHFOFSBUPS -
‣ 8SBQΕͯSFQPSU͞ΕΔͱ͍͑ʜ SFQPSU͞ΕΔϝλσʔλ͕ݮΔͷࠔΔ ͔ͩΒͱ͍ͬͯຖճϨϏϡʔͰࢦఠ͢Δͷʜʁ ‣ *OPVSQSPEVDUJPO AHJUIVCDPNTSWDXSBQFSSAͱ͍͏ɼ
8SBQΕݕग़πʔϧΛ࡞ͬͨ ASFWJFXEPHAͱҰॹʹಈ͔͍ͯ͠Δ -
‣ A8SBQ FSS AΤϥʔͷίϯςΩετΛൖͤ͞Δͷʹॏཁ 4UBDLUSBDFͳͲؚΉ *OPVSQSPEVDUJPO ‣ AHJUIVCDPNTSWDGBJMA
ͪΐͬͱϦονͳA8SBQ FSS AͰɼ͍ΖΜͳՃใΛΤϥʔʹ͍ͤͯΔ ڞ௨ϥΠϒϥϦͷJOUFSDFQUPSͰɼXSBQQFEFSSPSͷՃใ͔ΒFSSPSSFQPSUΛ͍ͯ͠Δ ‣ AHJUIVCDPNTSWDXSBQFSSA A8SBQ FSS AΛΕΛݕ͢ΔπʔϧΛͬͯɼ1VMM3FRVFTUͰࣗಈϨϏϡʔ͍ͯ͠Δ