Upgrade to Pro — share decks privately, control downloads, hide ads and more …

CSE564 Lecture 19

B546a9b97d993392e4b22b74b99b91fe?s=47 Javier Gonzalez
September 19, 2020
Programming
0
210

CSE564 Lecture 19

Software Design
Design Smells
(202011)

B546a9b97d993392e4b22b74b99b91fe?s=128

Javier Gonzalez

September 19, 2020
Tweet

More Decks by Javier Gonzalez

See All by Javier Gonzalez
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
520
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
360
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
330
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
340
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
260
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
130
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
190
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
480
B546a9b97d993392e4b22b74b99b91fe?s=48 javiergs
0
320

Other Decks in Programming

See All in Programming
A7c0e931e8189d7a709eaebb44ed69d4?s=48 rince
3
240
471605f6e94a32caa4b0101524f80429?s=48 kimyan
3
290
75cf8176bf14811428f77d8fe737f0d5?s=48 konstantin_diener
0
130
20ddbe9b7cfdde5e2dfeb8d8714d5de8?s=48 tarugoconf
1
1.6k
C11bce314c53f6d9e3096f121d96d7f9?s=48 neripark
3
670
270b0c7883545117a9a618dc7ca7cc83?s=48 xrdnk
0
130
B1196c22fd3ca181eec43e1b67823d3f?s=48 aftiopk
0
120
Dcbf2269af2483cabf43128ad1718c11?s=48 grapecity_dev
0
180
14c9795d267f5b85abb98ca5e8780646?s=48 ntaro
0
170
Dcbf2269af2483cabf43128ad1718c11?s=48 grapecity_dev
0
190
8434e5fcdb11033234455d4b2bfb6bb3?s=48 voyage_tech
0
110
15934fa2aa7b2ce21f091e9b7cffa856?s=48 manfredsteyer
PRO
0
130

Featured

See All Featured
64827b31aef81498662e8af4bd6d5157?s=48 jonrohan
1021
380k
7653c7c449918ff6542880a8c284f5e7?s=48 jponch
103
5.1k
Ded01cdab114abe4ec13511e4c25b9bb?s=48 andyhume
63
3.7k
433acaea1012b25d97ae66da9b998dad?s=48 malarkey
193
8.6k
20bfe76b3d6105641f879fe45cfc9272?s=48 bkeepers
52
4.2k
9375a9529679f1b42b567a640d775e7d?s=48 schacon
145
6.6k
282d599b414022eba5096510f675b6e2?s=48 chrislema
231
16k
Eb8975af8e49e19e3dd6b6b84a542e26?s=48 qrush
285
19k
027d1ebf66cc039a0bd3b55eeadbe75d?s=48 sachag
446
36k
1f74b13f1e5c6c69cb5d7fbaabb1e2cb?s=48 sferik
610
55k
96270e4c3e5e9806cf7245475c00b275?s=48 addyosmani
1346
190k
Bfd6b681ec6e8c9bef82ff0521c364f7?s=48 kastner
54
1.9k

Transcript

  1. jgs CSE 564 Software Design Lecture 19: Design Smells Dr.

    Javier Gonzalez-Sanchez javiergs@asu.edu javiergs.engineering.asu.edu | javiergs.com PERALTA 230U Office Hours: By appointment

  2. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 2 jgs

    Definition § Design smells are structures in the design that indicate violation of fundamental design principles and negatively impact design quality § The origin of the term design smell can be traced to the term code smell which was featured in the book “Refactoring: Improving the Design of Existing Code” by Martin Fowler.

  3. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 3 jgs

    Design smells § Abstraction: Missing or Obsession § Encapsulation: Deficient or Excessive § Modularization: Insufficient, Excessive, or Broken (not make sense) § Hierarchical relationships: unnecessary duplication, broken hierarchies. § Circular dependency: careful with loops

  4. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 4 jgs

    General Rules 1. It is about You. Showcase what is yours (your classes) 2. KISS Design. Include one level of hierarchical relationships (do not showcase Java API unless it is needed) 3. DRY Design. If it looks complicated, it smells 4. Semantic. Apply the symbols correctly 5. Be sure diagram and code match

  5. jgs Scenarios

  6. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 6 jgs

    Case 01

  7. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 7 jgs

    Case 01

  8. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 8 jgs

    Case 01 • UIComponent vs JPanel or JButton • Observer and Singleton in a GUI element • Decorator (pattern?) • Stereotype <<Java Class>>

  9. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 9 jgs

    Case 02

  10. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 10 jgs

    Case 02

  11. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 11 jgs

    Case 02 • Looks good but Add methods and attributes • Is NeuralNetwork a singleton, if so, missing the constructor • Careful with strong dependencies

  12. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 12 jgs

    Case 03

  13. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 13 jgs

    Case 03

  14. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 14 jgs

    Case 03 • Smells • Everything is association • Using a JPanel ?! • Search the main and go top-down

  15. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 15 jgs

    Case 04

  16. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 16 jgs

    Case 04 • Smells • We know the system and it is not so big. • There are so many lines going in or out in several places (a red light)

  17. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 17 jgs

    Case 05

  18. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 18 jgs

    Case 05 • Smells • It is not about showcasing the Java API. Be careful. • Methods and variables

  19. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 19 jgs

    Case 06

  20. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 20 jgs

    Case 06

  21. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 21 jgs

    Case 06 • Smells • Multiplicity • Factory for Panels • Could main() be added in a child of JFrame ?

  22. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 22 jgs

    Case 07

  23. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 23 jgs

    Case 07

  24. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 24 jgs

    Case 07 • Logger vs Logger Factory • Logger is singleton so, why the aggregation • Variables and Methods

  25. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 25 jgs

    Case 08

  26. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 26 jgs

    Case 08

  27. Javier Gonzalez-Sanchez | CSE564 | Fall 2020 | 27 jgs

    Case 08 • It is about make it easy to implement • Do not reinvent the wheel • What we get adding Observer to a Listener

  28. jgs Test Yourselves

  29. jgs CSE 564 Computer Systems Fundamentals Javier Gonzalez-Sanchez javiergs@asu.edu Fall

    2020 Disclaimer. These slides can only be used as study material for the class CSE564 at ASU. They cannot be distributed or used for another purpose.