Upgrade to Pro — share decks privately, control downloads, hide ads and more …

Hate The Code

Ian Asaff
November 14, 2012

Hate The Code

A brief commentary on how to change your engineering team's attitude about the code it writes.

Ian Asaff

November 14, 2012
Tweet

Other Decks in Programming

Transcript

  1. • Awkward teenage phase of engineering team growth • Modest

    technical debt • Coding decisions based on legacy issues • Staying the course doesn't scale Where we are
  2. • Encourages individual ownership • Discourages collective ownership • No

    feedback means easier to go off the "rails" (heh) Silo coding is bad
  3. • It's ok. • Really. • Code needs to get

    beaten up. • Tough love. Let's talk trash about our code
  4. • Every developer has something to contribute • "Hey, junior

    dev. Does this make sense to you?" • "Hey, senior dev. Would you have done it this way?" The takeaway is...
  5. Seek out criticism and feedback • “I know this isn’t

    great. What can I improve about it?” • "Am I better today than I was yesterday?"
  6. Don’t ignore pain. Dive into it. Setting up dev environment

    sucks. Ruby script for installation? Test data is irreplaceable. DB dump after migrations are run? Let's make things suck less
  7. “This code is fragile and mission critical. Don’t touch it.”

    VS “This code is fragile and mission critical. Let’s refactor so it’s easy to understand and debug.” What's better?
  8. • “That’s X’s code. Ask X how it works.” “X

    is out until Monday…” • Low bus factor • “Just this one time…” • “We need to ship this…” Technical debt is expensive
  9. • “I think it basically works this way… Let’s dig

    in a bit.” • Higher bus factor • Frequent discussion about the code Let's move toward...