Learning from performance improvements on GraphQL Ruby

https://www.meetup.com/graphql-tokyo/events/295606838/

Meetup #21 Guest talk and lightning talks

Transcript

1. @mtsmfm Learning from performance improvements on GraphQL Ruby
2. Fumiaki Matsushima GitHub, Twitter @mtsmfm
3. https://www.meetup.com/ja-JP/GraphQL-Tokyo/
4. https://autify.com/
5. https://autify.com/careers
6. https://www.youtube.com/watch?v=dvip2PXi52Y&t=1875s
9. Summary of my last talk - GraphQL Ruby 2.0.13 (the latest version at that time) is twice slower than 1.5.15
10. Since 2.0.13, there have been 17 releases! https://rubygems.org/gems/graphql/versions
11. Benchmark target type Article { field0: String! field1: String! ... fieldN: String! } type Query { articles: [Article!]! } query { articles { field0, field1, ..., fieldN } }
12. Benchmark target type Article { field0: String! field1: String! ... fieldN: String! } type Query { articles: [Article!]! } query { articles { field0, field1, ..., fieldN } } Num of articles = 1000 Num of fields = 100
13. Run benchmark on GitHub Actions https://github.com/mtsmfm/graphql-ruby-benchmark/pull/4
14. Run benchmark on GitHub Actions https://github.com/mtsmfm/graphql-ruby-benchmark/pull/4
15. Run benchmark on GitHub Actions https://github.com/mtsmfm/graphql-ruby-benchmark/pull/4
16. Benchmark env - GitHub Actions (ubuntu-latest) - Ruby 3.2.2 - https://github.com/mtsmfm/graphql-ruby-benchmark
19. Many performance improvements https://github.com/rmosolgo/graphql-ruby/blob/904e8c595637450 40b6d05c5ecb22a73a320c7b5/CHANGELOG.md
22. PR #4399 https://github.com/rmosolgo/graphql-ruby/pull/4399
23. PR #4399 https://github.com/rmosolgo/graphql-ruby/pull/4399
24. PR #4399 https://github.com/rmosolgo/graphql-ruby/pull/4399
25. PR #4399 https://github.com/rmosolgo/graphql-ruby/pull/4399
26. PR #4399 1. Introduces CurrentState class to store runtime state 2. Removes unnecessary context lookup
27. PR #4399 1. Introduces CurrentState class to store runtime state 2. Removes unnecessary context lookup
28. Previous code
29. Previous code
30. PR #4399 https://github.com/rmosolgo/graphql-ruby/pull/4399
31. Referring context takes time?!
32. Context#[] https://github.com/rmosolgo/graphql-ruby/blob/904e8c59563745040b6d05c5ec b22a73a320c7b5/lib/graphql/query/context.rb#L124-L141
33. Context#[] https://github.com/rmosolgo/graphql-ruby/blob/904e8c59563745040b6d05c5ec b22a73a320c7b5/lib/graphql/query/context.rb#L124-L141 Hash like Hash Set
34. Looks fast enough 🤔
35. Benchmark target type Article { field0: String! field1: String! ... fieldN: String! } type Query { articles: [Article!]! } query { articles { field0, field1, ..., fieldN } } Num of articles = 1000 Num of fields = 100
36. Benchmark target type Article { field0: String! field1: String! ... fieldN: String! } type Query { articles: [Article!]! } query { articles { field0, field1, ..., fieldN } } Num of articles = 1000 Num of fields = 100 = 100,000 fields!
37. Learning from PR #4399 1. Field related code can be a hotspot a. Even context lookup
38. Context#[] https://github.com/rmosolgo/graphql-ruby/blob/904e8c59563745040b6d05c5ec b22a73a320c7b5/lib/graphql/query/context.rb#L124-L141
39. It changes [key] to public_send(key) https://github.com/rmosolgo/graphql-ruby/pull/4399/files#diff-2c8869b38ea62e6 9d0aa4fc7e571e6dc3b8c9f05fba9c25bc79fc17cfee2a335
40. require 'bundler/inline' gemfile do source 'https://rubygems.org' gem 'benchmark-ips', require: 'benchmark/ips' gem 'graphql' end state = GraphQL::Execution::Interpreter::Runtime::CurrentState.new Benchmark.ips do |x| x.report('send') do state.public_send(:current_arguments) end x.report('direct') do state.current_arguments end x.compare! end
41. public_send is 2 times slower $ ruby foo.rb Warming up -------------------------------------- send 889.676k i/100ms direct 2.157M i/100ms Calculating ------------------------------------- send 8.757M (± 7.4%) i/s - 43.594M in 5.008124s direct 20.391M (± 7.0%) i/s - 103.546M in 5.105176s Comparison: direct: 20391490.9 i/s send: 8756908.0 i/s - 2.33x slower
42. 2% improvements https://github.com/rmosolgo/graphql-ruby/pull/4631
43. Conclusion 1. GraphQL Ruby is twice faster than last year! 2. Consider total number of fields a. Especially if you’re going to add some codes which affect all fields 3. Enjoy Talk Driven Development